t of no use with macros here, as the figures are not used
anywhere else, but whatever.
With s-o-b fixed:
Acked-by: Sam Ravnborg
> ---
> drivers/gpu/drm/kmb/kmb_drv.c | 8
> drivers/gpu/drm/kmb/kmb_drv.h | 5 +
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
>
^ add space
> + * from the Myriadx tests
>*/
> out_format |= LCD_OUTF_FORMAT_RGB888;
>
> @@ -526,6 +532,11 @@ struct kmb_plane *kmb_plane_init(struct drm_device *drm)
> plane->id = i;
> }
>
> + /* Disable pipeline AXI read transactions for the DMA
> + * prior to setting graphics layers
> + */
> + kmb_clr_bitmask_lcd(kmb, LCD_CONTROL, LCD_CTRL_PIPELINE_DMA);
> +
> return primary;
> cleanup:
> drmm_kfree(drm, plane);
With the two nits fixed:
Acked-by: Sam Ravnborg
On Mon, Jul 26, 2021 at 09:44:57PM +0200, Marek Vasut wrote:
> In case there is a bridge connected to the LCDIF, use bus_format
> from the bridge, otherwise behave as before and use bus_format
> from the connector. This way, even if there are multiple bridges
> in the display pipeline, the LCDIF
Hi Thomas,
On Tue, Jul 27, 2021 at 08:27:07PM +0200, Thomas Zimmermann wrote:
> DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move
> the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux
> IRQ interfaces.
>
> DRM provides IRQ helpers for setting up, receiving and
Hi Chenyang,
I browsed the code on lore and noticed a few things and thought it
better to bring it to your attention now.
The general structure of the drivers seems good and coding style is
fine. The feedback is mostly stuff we have decided to do different over
time, so likely because you based
Hi Geert,
On Tue, Jul 27, 2021 at 03:47:25PM +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series optimizes console operations on ssd1307fb, after the
> customary fixes and cleanups.
>
> Currently, each screen update triggers an I2C transfer of all screen
> data, up to 1 KiB of
- Make the backlight .set_brightness() turn the backlight
> off completely if blank.
> - Fix some dev_err_probe() use cases along the way.
Very nice cleanup - thanks.
One issue below, with that fixed:
Reviewed-by: Sam Ravnborg
I assume you will apply the patch yourself.
Sam
>
Hi Nicolas,
On Tue, Jul 27, 2021 at 09:45:21AM +0800, Nicolas Boichat wrote:
> Many of the DSI flags have names opposite to their actual effects,
> e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually
> be disabled. Fix this by including _NO_ in the flag names, e.g.
>
Hi Nikita,
On Mon, Jul 26, 2021 at 04:59:52PM +0300, Nikita Shubin wrote:
> From: Alexander Sverdlin
>
> Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
> to Common Clock Framework.
>
> Signed-off-by: Alexander Sverdlin
> Signed-off-by: Nikita Shubin
Thanks,
cit, add log messages to
> drm_framebuffer_remove (Daniel)
>
> Signed-off-by: Simon Ser
> Cc: Daniel Vetter
Looks like some very useful debugging logging.
Acked-by: Sam Ravnborg
Hi Paul,
On Mon, Jul 26, 2021 at 10:02:08AM +0100, Paul Cercueil wrote:
> Hi Artjom,
>
> Le lun., juil. 26 2021 at 01:15:27 +0300, Artjom Vejsel
> a écrit :
> > The Gopher 2b LCD panel is used in Gopher 2b handhelds.
> > It's simple panel with NewVision NV3047 driver, but SPI lines are not
> >
Hi Björn,
On Mon, Jul 26, 2021 at 10:32:59AM -0700, Bjorn Andersson wrote:
> Add bindings for the two AUO panels B133HAN05 and B140HAN06, both
> 1920x1080 panels with 16.7M colors, first being 13.3" and the latter
> 14.0".
>
> Signed-off-by: Bjorn Andersson
Thanks, both patches applied to
Hi Zheyu,
On Mon, Jul 26, 2021 at 10:03:52AM +, Zheyu Ma wrote:
> Zheyu Ma (3):
> video: fbdev: asiliantfb: Error out if 'pixclock' equals zero
> video: fbdev: kyro: Error out if 'pixclock' equals zero
> video: fbdev: riva: Error out if 'pixclock' equals zero
Thanks for the quick
Hi,
On Mon, Jul 26, 2021 at 11:32:37AM +, tcs_kernel(腾讯云内核开发者) wrote:
> yres and vyres can be controlled by user mode paramaters, and cause p->vrows
> to become a negative value. While this value be passed to real_y function,
> the ypos will be out of screen range.
> This is an out-of-bounds
Hi Nicolas,
On Mon, Jul 26, 2021 at 08:38:18AM +0800, Nicolas Boichat wrote:
> On Sun, Jul 25, 2021 at 9:31 PM Sam Ravnborg wrote:
> >
> > On Tue, Jun 29, 2021 at 07:47:21AM +0800, Nicolas Boichat wrote:
> > > Many of the DSI flags have names opposite to their a
On Sat, Jul 24, 2021 at 01:33:58PM +0300, Artjom Vejsel wrote:
> The Gopher 2b LCD panel is used in Gopher 2b handhelds.
> It's simple panel with NewVision NV3047 driver, but SPI lines are not
> connected.
> It has no specific name, since it's unique to that handhelds.
> lot name at AliExpress:
Hi Artjom,
On Sat, Jul 24, 2021 at 01:33:56PM +0300, Artjom Vejsel wrote:
> Add vendor prefix for Shenzhen QiShenglong Industrialist Co., Ltd.
> QiShenglong is a Chinese manufacturer of handheld gaming consoles, most of
> which run (very old) versions of Linux.
> QiShenglong is known as Hamy.
>
>
Hi Zheyu,
On Sun, Jul 25, 2021 at 02:10:51AM +, Zheyu Ma wrote:
> Zheyu Ma (3):
> video: fbdev: kyro: add a check against divide error
> video: fbdev: riva: add a check against divide error
> video: fbdev: asiliantfb: add a check against divide error
I would prefer something a bit more
Hi Jagan,
On Sun, Jul 25, 2021 at 11:17:37PM +0530, Jagan Teki wrote:
> ytc700tlag_05_201c panel support 8 bpc not 6 bpc as per
> recent testing in i.MX8MM platform.
>
> Fix it.
>
> Fixes: 7a1f4fa4a629 ("drm/panel: simple: Add YTC700TLAG-05-201C")
> Signed-off-by: Jagan Teki
Thanks, applied to
l only supports single-plane formats.
>
> No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> Acked-by: Noralf Trønnes
Acked-by: Sam Ravnborg
> ---
> drivers/gpu/drm/gud/gud_pipe.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
m_writeback_job. Introduce the new type
> struct vkms_writeback_job, which holds the output mappings addresses
> while the writeback job is active.
>
> The patchset also cleans up some internal casting an setup of the
> output addresses. No functional changes.
>
> Signed-off-
erform unmap operations of certain BOs by themselfes.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_fram
; functional changes.
>
> v2:
> * using [static N] for array parameters enables compile-time checks
> * include for DRM_FORMAT_MAX_PLANES (kernel
> test robot)
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
ude for DRM_FORMAT_MAX_PLANES
>
> Signed-off-by: Thomas Zimmermann
One nit below.
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 19 +++
> include/drm/drm_fourcc.h | 13 +
> include/drm/drm_framebuff
Hi Jagan,
On Sun, Jul 04, 2021 at 02:32:30PM +0530, Jagan Teki wrote:
> Fixing up the mode flags are required in order to correlate
> the correct sync flags in i.MX8MM eLCDIF.
>
> So, handle the mode flags via bridge, mode_fixup.
Please do this in atomic_check.
Check rcar-du for a way to get
Hi Jagan,
On Sun, Jul 04, 2021 at 02:32:29PM +0530, Jagan Teki wrote:
> PMS_P offset value in existing driver is not compatible
> with i.MX8MM.
>
> However the i.MX8M Mini Application Reference manual shows
> the PMS_P offset is the same in the driver, but the i.MX8MM
> downstream driver uses a
On Sun, Jul 04, 2021 at 02:32:19PM +0530, Jagan Teki wrote:
> Exynos DSI driver is actually a Samsung MIPI DSIM bridge
> IP which is also used in i.MX8MM platforms.
>
> Right now the existing driver has some exynos drm specific
> code bases like te_irq, crtc and component_ops.
>
> In order to
Hi Jagan,
On Sun, Jul 04, 2021 at 02:32:18PM +0530, Jagan Teki wrote:
> Now the exynos dsi driver is fully aware of bridge
> handling, so get the display mode from bridge, mode_set
> API instead of legacy encoder crtc.
>
> This makes bridge usage more efficient instead of relying
> on encoder
tach function call.
>
> Signed-off-by: Jagan Teki
Acked-by: Sam Ravnborg
Hi Jagan,
See a few comments below.
Sam
On Sun, Jul 04, 2021 at 02:32:14PM +0530, Jagan Teki wrote:
> DRM bridge drivers have built-in handling of treating
> all display pipeline components as bridges.
>
> Convert exynos_drm_dsi to a bridge driver with built-in
> encoder support for
Hi Jagan,
On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote:
> This series supports common bridge support for Samsung MIPI DSIM
> which is used in Exynos and i.MX8MM SoC's.
>
> The final bridge supports both the Exynos and i.MX8MM DSI devices.
>
> Right now bridge offers two sets of
Hi Alexey,
On Sun, Jul 25, 2021 at 05:03:38PM +0300, Alexey Minnekhanov wrote:
> Samsung S6E3FA2 panel is amoled 1080x1920 command mode DSI
> panel used in Samsung Galaxy S5 phone. There are 2 known
> variations of panel that were shipped in this phone, and
> this driver handles both of them.
>
gt; +required:
> + - compatible
reg?
> + - reset-gpios
> + - iovdd-supply
> + - vddr-supply
> +
> +unevaluatedProperties: false
As I do not see the DT node pull in additional preperties from another
binding the more strict:
additionalProperties: false seems to be the right ch
On Tue, Jun 29, 2021 at 07:47:21AM +0800, Nicolas Boichat wrote:
> Many of the DSI flags have names opposite to their actual effects,
> e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually
> be disabled. Fix this by including _NO_ in the flag names, e.g.
>
Hi Geert,
On Wed, Jul 14, 2021 at 04:51:22PM +0200, Geert Uytterhoeven wrote:
> Convert the Solomon SSD1307 Framebuffer Device Tree binding
> documentation to json-schema.
>
> Fix the spelling of the "pwms" property.
> Document default values.
> Make properties with default values not required.
>
Hi Oleksij,
On Wed, Jul 14, 2021 at 06:53:46AM +0200, Oleksij Rempel wrote:
> Add Logictechno and Multi-Inno panels:
> - Logic Technologies LTTD800x480 L2RT 7" 800x480 TFT Resistive Touch Module
> - Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch
> Module
> - Multi-Inno
Hi Marek,
On Wed, Jul 21, 2021 at 07:12:56PM +0200, Marek Vasut wrote:
> Fix the warning message "missing connector type" by adding connector_type
> for EDT ETM0700G0BDH6 panel.
>
> Signed-off-by: Marek Vasut
> Cc: Biju Das
> Cc: Sam Ravnborg
> ---
> driver
On Fri, Jul 23, 2021 at 10:57:56AM +0200, Daniel Vetter wrote:
> On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote:
> > From: Chenyang Li
> >
> > This patch adds an initial DRM driver for the Loongson LS7A1000
> > bridge chip(LS7A). The LS7A bridge chip contains two display
> >
drm_bridge_new_crtc_state() will be used by bridge drivers to provide
easy access to the mode from the drm_bridge_funcs operations.
The helper will be useful in the atomic operations of
struct drm_bridge_funcs.
Signed-off-by: Sam Ravnborg
Suggested-by: Laurent Pinchart
Cc: Laurent Pinchart
Cc
- deprecated callbacks in drm_bridge_funcs
- move connector creation to display drivers
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
---
Documentation/gpu/todo.rst | 47
uld see this call was included in the original
version of the driver so there was no help there to find out why it was
added in the first place. But a lot has changed since the initial driver
were added and is seems safe to remove the call now.
Signed-off-by: Sam Ravnborg
Cc: Chun-Kuang Hu
The atomic variants of enable/disable in drm_bridge_funcs are the
preferred operations - introduce these.
Use of mode_set is deprecated - merge the functionality with
atomic_enable()
Signed-off-by: Sam Ravnborg
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc
There are no users left and we do not want to have this function
available.
drm_atomic_bridge_check() is used to call the mode_fixup() operation for
the chained bridges and there is no need for drm_atomic_bridge_check().
Drop it.
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc: Maarten
The drm_bridge_chain_{pre_enable,enable,disable,post_disable} has no
users left and we have atomic variants that should be used.
Drop them so they do not gain new users.
Adjust a few comments to avoid references to the dropped functions.
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc
The atomic variants of enable/disable in drm_bridge_funcs are the
preferred operations - introduce these.
The ps8640 driver used the non-atomic variants of the drm_bridge chain
functions - convert these to the atomic variants.
Signed-off-by: Sam Ravnborg
Cc: Andrzej Hajda
Cc: Neil Armstrong
to use the atomic variants
of drm_bridge_funcs operations. The easy ones are the drivers wihtout
mode_set or mode_fixup.
I have something typed up already, but wanted feedback on this patchset before
sending out additional patches.
Sam
Sam Ravnborg (7):
drm/bridge: ps8640: Use atomic
Hi Dillon,
On Wed, Jul 21, 2021 at 03:41:28PM +0800, dillon.min...@gmail.com wrote:
> From: Dillon Min
>
> This driver combine tiny/ili9341.c mipi_dbi_interface driver
> with mipi_dpi_interface driver, can support ili9341 with serial
> mode or parallel rgb interface mode by register
Hi Linus,
On Wed, Jul 21, 2021 at 04:00:35PM +0200, Linus Walleij wrote:
> On Wed, Jul 21, 2021 at 9:41 AM wrote:
>
> > From: Dillon Min
> >
> > Add documentation for "ilitek,ili9341" panel.
> >
> > Cc: Linus Walleij
> > Signed-off-by: Dillon Min
> > Reviewed-by: Rob Herring
>
>
On Wed, Jul 21, 2021 at 04:03:41PM +0200, Maxime Ripard wrote:
> The corpro,gm7123 was in use in a DT but was never properly documented,
> let's add it.
>
> Cc: dri-devel@lists.freedesktop.org
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Maxime Ripard
Acked-by: Sam Ravnborg
ent all of them, and that the binding will create an
> error if we add one that isn't.
>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Laurent Pinchart
> Cc: Sam Ravnborg
> Cc: Thierry Reding
> Signed-off-by: Maxime Ripard
> ---
> .../bindings/display/panel/lvds.yaml
Hi Zheyu,
On Wed, Jul 21, 2021 at 12:43:44PM +, Zheyu Ma wrote:
> The userspace program could pass any values to the driver through
> ioctl() interface. If the driver doesn't check the value of 'pixclock',
> it may cause divide error because of the 'PICOS2KHZ' macro.
>
> Fix this by checking
Hi Colin,
On Wed, Jul 21, 2021 at 11:26:08AM +0100, Colin King wrote:
> From: Colin Ian King
>
> The variable err is being initialized with a value that is never
> read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
>
On Tue, Jul 20, 2021 at 03:45:21PM +0200, Maxime Ripard wrote:
> Now that we have additional attach and detach hooks for panels, make
> sure that the panel bridge driver calls them when relevant.
Combine this with the previous patch as this is again a partial revert of
the same patch.
On Tue, Jul 20, 2021 at 03:45:20PM +0200, Maxime Ripard wrote:
> In order to make the probe order expectation more consistent between
> bridges, let's create attach and detach hooks for the panels as well to
> match what is there for bridges.
This is a partally revert of:
87154ff86bf6 ("drm:
are/separate/
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Sam Ravnborg
> ---
> Documentation/gpu/drm-kms-helpers.rst | 6 ++
> drivers/gpu/drm/drm_bridge.c | 14 +-
> 2 files changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/Docume
- to avoid
mixing things.
But thats just nitpicking, so:
Reviewed-by: Sam Ravnborg
Hi Maxime,
On Tue, Jul 20, 2021 at 03:45:17PM +0200, Maxime Ripard wrote:
> Display drivers so far need to have a lot of boilerplate to first
> retrieve either the panel or bridge that they are connected to using
> drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Sam Ravnborg
I did a quick audit (as using grep mostly) to see if other panels had
the same bug, but did not find others.
This patch should be applied to drm-misc-fixes independent of the rest of
the patches.
Sam
> ---
> drivers/gpu/dr
Hi Geert,
On Tue, Jul 20, 2021 at 09:33:11AM +0200, Geert Uytterhoeven wrote:
> Hi Sam,
>
> On Mon, Jul 19, 2021 at 9:23 PM Sam Ravnborg wrote:
> > On Wed, Jul 14, 2021 at 04:57:59PM +0200, Geert Uytterhoeven wrote:
> > > This patch series optimizes console operat
Hi Geert,
On Tue, Jul 20, 2021 at 09:43:22AM +0200, Geert Uytterhoeven wrote:
> Hi Sam,
>
> On Mon, Jul 19, 2021 at 9:05 PM Sam Ravnborg wrote:
> > On Wed, Jul 14, 2021 at 04:58:01PM +0200, Geert Uytterhoeven wrote:
> > > Simplify the nested loops to handle conversion
On Tue, Jul 20, 2021 at 11:16:27AM +0200, Geert Uytterhoeven wrote:
> Hi Sam,
>
> On Tue, Jul 20, 2021 at 9:56 AM Geert Uytterhoeven
> wrote:
> > On Mon, Jul 19, 2021 at 9:21 PM Sam Ravnborg wrote:
> > > On Wed, Jul 14, 2021 at 04:58:03PM +0200, Geert Uytterhoev
Hi Xiyu, Xin,
On Mon, Jul 19, 2021 at 01:59:45PM +0800, Xiyu Yang wrote:
> refcount_t type and corresponding API can protect refcounters from
> accidental underflow and overflow and further use-after-free situations.
>
> Signed-off-by: Xiyu Yang
> Signed-off-by: Xin Tan
Looks like a nice
.
>
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Rob Clark
> Cc: Sean Paul
> Cc: Marek Vasut
> Cc: Krishna Manikandan
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Rob Herring
Acked-by: Sam Ravnborg
gt; ssd1307fb_update_display()
> video: fbdev: ssd1307fb: Simplify ssd1307fb_update_display()
> video: fbdev: ssd1307fb: Extract ssd1307fb_set_address_range()
> video: fbdev: ssd1307fb: Optimize screen updates
> video: fbdev: ssd1307fb: Cache address ranges
A few comments left for a coupl
Hi Geert,
On Wed, Jul 14, 2021 at 04:58:03PM +0200, Geert Uytterhoeven wrote:
> Currently, each screen update triggers an I2C transfer of all screen
> data, up to 1 KiB of data for a 128x64 display, which takes at least 20
> ms in Fast mode.
>
> Reduce the amount of transferred data by only
+{
Bikeshedding, but I think a dedicated function for col_range and another
for page_range had been simpler to read.
With or wihout this change:
Acked-by: Sam Ravnborg
Sam
> + u8 col_end = col_start + cols - 1;
> + u8 page_end = page_start + pages - 1;
> + int ret;
Hi Geert,
On Wed, Jul 14, 2021 at 04:58:01PM +0200, Geert Uytterhoeven wrote:
> Simplify the nested loops to handle conversion from linear frame buffer
> to ssd1307 page layout:
> 1. Move last page handling one level up, as the value of "m" is the
> same inside a page,
> 2. array->data[]
Hi Zheyu,
On Wed, Jul 14, 2021 at 04:09:22AM +, Zheyu Ma wrote:
> The user can pass in any value to the driver through the 'ioctl'
> interface. The driver dost not check, which may cause DoS bugs.
>
> The following log reveals it:
>
> divide error: [#1] PREEMPT SMP KASAN PTI
> RIP:
Hi Oleksij,
On Wed, Jul 14, 2021 at 06:53:49AM +0200, Oleksij Rempel wrote:
> From: Sam Ravnborg
The real author one these dts files are Juergen Borleis IIRC.
I made some internal refactoring / renaming which is why I thing git
says otherwise.
So onless Juergen says otherwise we should give
Hi Dan,
On Thu, Jul 15, 2021 at 09:55:09PM +, dan.sned...@microchip.com wrote:
> I tested this patch set on the 9x60ek board and unfortunately it causes
> errors. The vbltest returns -1 and I also see the display get out of
> sync while testing with a gui application.
Thanks a lot for the
Hi Alex,
On Wed, Jul 14, 2021 at 06:08:58PM -0400, Alex Deucher wrote:
> Hi Dave, Daniel,
>
> Fixes for 5.14. The big change here is unifying the SMU13 code. This was
> new code added in 5.14 to support Yellow Carp, but we've since cleaned it
> up and removed a lot of duplication, so better to
Hi Geert,
On Wed, Jul 14, 2021 at 04:57:59PM +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series optimizes console operations on ssd1307fb, after the
> customary fixes and cleanups.
What is required to to have a drm driver that could do the same?
Note: I will take a look at
) takes care of cleanup */
> drm_fb_helper_unregister_fbi(fb_helper);
I could not find any better spot to clear deferred_setup - so I think
this is OK.
With the two spellign issues fixed:
Acked-by: Sam Ravnborg
No r-b as I an not too fluent in these code paths and all the locking.
Sam
Hi
On Tue, Jul 13, 2021 at 12:51:14PM +, Zheyu Ma wrote:
> The user can pass in any value to the driver through the 'ioctl'
> interface. The driver dost not check, which may cause DoS bugs.
>
> Fix this by checking if the divisor is 0
This fix is trying to avoid the situation on a too low
On Tue, Jul 13, 2021 at 07:44:12PM +0200, Daniel Vetter wrote:
> On Tue, Jul 13, 2021 at 7:14 PM Grace An wrote:
> > When CONFIG_PROVE_LOCKING is defined, the kernel randomly injects
> > -EDEADLK errors for all the ww_mutex. This results in
> > drm_atomic_get_private_obj_state randomly returning
Make it obvious that mode_fixup is deprecated and new drivers shall use
atomic_check.
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc: Andrzej Hajda
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
---
include/drm/drm_bridge.h | 3
Hi Laurent,
On Sat, Jul 10, 2021 at 11:46:24PM +0300, Laurent Pinchart wrote:
> Hi Sam,
>
> Thank you for the patch.
>
> On Sat, Jul 10, 2021 at 10:42:40AM +0200, Sam Ravnborg wrote:
> > drm_bridge_funcs includes several duplicated operations as atomic
> > varian
Hi Thomas,
> As I mention, struct mgag200_pll_values should store the PLL values. But the
> individual compute and set functions for each hardware revision mess this up
> completely. Sometimes they use 'function values' sometimes they use
> 'register values'. If you'd try to debug a failed
Hi Oliver.
On Sun, Jul 11, 2021 at 05:49:29PM +0200, Oliver Graute wrote:
> Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD
> to panel-simple.
>
> The panel spec from Variscite can be found at:
> https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdf
>
>
On Sun, Jul 11, 2021 at 11:16:44AM +0200, Sam Ravnborg wrote:
> drm_bridge_funcs includes several duplicated operations as atomic
> variants has been added over time.
> New bridge drivers shall use the atomic variants - mark the deprecated
> operations to try to avoid usage in new br
The drm mid-layer for irq's is not relevant for atomic display drivers,
and will be available only for legacy drivers in the future.
Drop usage in the atmel hlcdc driver.
Signed-off-by: Sam Ravnborg
Cc: Sam Ravnborg
Cc: Boris Brezillon
Cc: Nicolas Ferre
Cc: Alexandre Belloni
Cc: Ludovic
This is in preparation for removal of drm_irq use.
Functions are moved without any other changes.
Signed-off-by: Sam Ravnborg
Cc: Sam Ravnborg
Cc: Boris Brezillon
Cc: Nicolas Ferre
Cc: Alexandre Belloni
Cc: Ludovic Desroches
Cc: linux-arm-ker...@lists.infradead.org
---
drivers/gpu/drm
[Ignore the first mail - wrong patch was attached]
Two small patches to drop the use of the drm irq mid-layer.
My atmel hlcdc target has stopped working - so unfortunately un-tested :-(
I picked up this to continue the work of Thomas Zimmermann.
Sam
Sam Ravnborg (2):
drm/atmel
drm_bridge_funcs includes several duplicated operations as atomic
variants has been added over time.
New bridge drivers shall use the atomic variants - mark the deprecated
operations to try to avoid usage in new bridge drivers.
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc: Andrzej Hajda
Two small patches to drop the use of the drm irq mid-layer.
My atmel hlcdc target has stopped working - so unfortunately un-tested :-(
I picked up this to continue the work of Thomas Zimmermann.
Sam
Sam Ravnborg (2):
drm/atmel-hlcdc: Move interrupt helper funtions
drm
; + - power-supply
> > > + - reset-gpios
> > > +
> > > +unevaluatedProperties: false
> > I had expected:
> > additionalProperties: false
> >
> > With this fixed:
> > Reviewed-by: Sam Ravnborg
>
> I am not sure; the doc st
drm_bridge_funcs includes several duplicated operations as atomic
variants has been added over time.
New bridge drivers shall use the atomic variants - mark the deprecated
operations to try to avoid usage in new bridge drivers.
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc: Andrzej Hajda
Hi Jagan,
On Sun, Jul 04, 2021 at 03:04:33PM +0530, Jagan Teki wrote:
> nwl_dsi_plat_clk_config structure added in below commit but not
> used anywhere in the driver.
>
> commit <44cfc6233447c> ("drm/bridge: Add NWL MIPI DSI host controller
> support")
>
> Drop it.
>
> Cc: Guido Günther
>
Hi Thomas,
On Mon, Jul 05, 2021 at 02:45:09PM +0200, Thomas Zimmermann wrote:
> The fields in struct mgag200_pll_values currently hold the bits of
> each register. Store the PLL values instead and let the PLL-update
> code figure out the bits for each register.
>
> Signed-off-by: Thomas
be split in two patches - so the changes to
drm_simple_kms_helper can get more attention.
The patch as such looks fine so when split you can add my:
Acked-by: Sam Ravnborg
on the mgag200 parts.
And
Reviewed-by: Sam Ravnborg
on the drm_simple_kms_helper parts.
Sam
>
> Signed
ann
Looks good,
Acked-by: Sam Ravnborg
Sam
ann
Looks fine,
Acked-by: Sam Ravnborg
Sam
correct,
Acked-by: Sam Ravnborg
Sam
ic_drm *priv = dev_get_drvdata(dev);
> struct clk *parent_clk = clk_get_parent(priv->pix_clk);
> + struct drm_device *drm = >drm;
> + struct platform_device *pdev = to_platform_device(drm->dev);
> +
> + free_irq(platform_get_irq(pdev, 0), drm);
The dri
; handheld gaming consoles.
>
> While being 320x480, it is actually a horizontal 4:3
> panel with non-square pixels in delta arrangement.
>
> Signed-off-by: Christophe Branchereau
> Signed-off-by: Paul Cercueil
The drivers looks good.
Reviewed-by: Sam Ravnborg
lux,ej030na
> +
> + backlight: true
> + port: true
> + power-supply: true
> + reg: true
> + reset-gpios: true
> +
> +required:
> + - compatible
> + - reg
> + - power-supply
> + - reset-gpios
> +
> +unevaluatedProperties: false
I had expected:
additionalProper
Hi Yunus and Stefan,
On Fri, Jul 09, 2021 at 10:03:48PM +0200, Yunus Bas wrote:
> From: Stefan Riedmueller
>
> This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel
> to DRM simple panel driver.
>
> Signed-off-by: Stefan Riedmueller
> Signed-off-by: Yunus Bas
Thanks for
Hi Yunus,
On Fri, Jul 09, 2021 at 07:02:52PM +, Yunus Bas wrote:
> Hi Sam,
>
> Am Freitag, dem 09.07.2021 um 20:12 +0200 schrieb Sam Ravnborg:
> > Hi Yunus,
> >
> > On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yunus Bas wrote:
> > > From: Stefan Riedm
refactoring.
>
> Signed-off-by: Thomas Zimmermann
I guess I will soon learn why they all had s << 3.
This patch is
Acked-by: Sam Ravnborg
Ho Thomas,
On Mon, Jul 05, 2021 at 02:45:07PM +0200, Thomas Zimmermann wrote:
> The _set_plls() functions compute a pixel clock's PLL values
> and program the hardware accordingly. This happens during atomic
> commits.
>
> For atomic modesetting, it's better to separate computation and
>
1001 - 1100 of 3970 matches
Mail list logo
