From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 2 ++
1 file changed, 2
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 1 +
drivers/gpu/drm/xlnx/zynqmp_kms.c
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/bridge/lvds-codec.c | 1 +
1 file changed, 1 insertion
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/sprd/sprd_dpu.c | 2 ++
drivers/gpu/drm/sprd/sprd_drm.c | 1
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/scheduler/sched_main.c | 1 +
1 file changed, 1 insertion(+)
diff
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/vc4/vc4_crtc.c | 2 ++
drivers/gpu/drm/vc4/vc4_dpi.c | 1
From: Sam Ravnborg
drm_timeout_abs_to_jiffies() was implmented in drm_syncobj where
it really did not belong. Create a drm_util file and move the
implementation. Likewise move the prototype and update all users.
Suggested-by: Daniel Vetter
[https://lore.kernel.org/dri-devel/20190527185311
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/mcde/mcde_drv.c | 1 +
1 file changed, 1 insertion(+)
diff
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/i2c/tda998x_drv.c | 2 ++
1 file changed, 2 insertions
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/logicvc/logicvc_crtc.c | 2 ++
drivers/gpu/drm/logicvc
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 ++
drivers/gpu/drm/rcar-du
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/i915/display/icl_dsi.c| 2 ++
drivers/gpu/drm
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 ++
drivers/gpu/drm
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 2 ++
drivers/gpu/drm/bridge
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/exynos/exynos_dp.c| 1 +
drivers/gpu/drm/exynos
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/imx/dcss/dcss-crtc.c | 2 ++
drivers/gpu/drm/imx
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/gud/gud_drv.c | 1 +
1 file changed, 1 insertion(+)
diff
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 ++
drivers
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 2 ++
drivers/gpu/drm
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/bridge/ite-it6505.c | 3 ++-
drivers/gpu/drm/bridge/ite
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/radeon/r100.c | 1 +
drivers/gpu/drm/radeon/r300.c | 1
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/omapdrm/omap_fb.c | 1 +
1 file changed, 1 insertion(+)
diff --git
in an old mail). Another prototype was moved to a more
appropriate place.
The diffstat add more lines than we delete, but the positive thing here
is that the individual files now pull in less files when building.
Sam
---
Sam Ravnborg (86):
drm/komeda: Direct include headers from drm_print
From: Sam Ravnborg
Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.
Signed-off-by: Sam Ravnborg
---
drivers/gpu/drm/arm/display/komeda/d71/d71_component.c | 2 ++
drivers/gpu/drm/arm
Hi John/Douglas.
On Fri, Jan 20, 2023 at 01:44:38PM -0800, Doug Anderson wrote:
> Hi,
>
> On Fri, Jan 20, 2023 at 3:43 AM John Keeping wrote:
> >
> > Commit 15b9ca1641f0 ("drm: Config orientation property if panel provides
> > it") added a helper to set the panel panel orientation early but
; Reported-by: Daniel Vetter
> Reported-by: kernel test robot
> Signed-off-by: Neil Armstrong
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/pan
Hi Nirmoy,
On Tue, Jan 17, 2023 at 07:04:16PM +0100, Nirmoy Das wrote:
> Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR()
> with proper APIs.
Thanks for working on this!
Also thanks for Christian to take care and apply the patches.
Sam
- separate panel driver changes (2/2)
>
> This series adds proper support for 16-bit MIPI DSI brightness and
> cleans up existing panel drivers with 16-bit brightness.
The series is:
Reviewed-by: Sam Ravnborg
Neil - I hope you can land this in drm-misc.
Sam
On Tue, Jan 17, 2023 at 06:44:47PM +0100, Nirmoy Das wrote:
> There are no current users of DRM_DEBUG_KMS_RATELIMITED()
> so remove it.
Thanks
>
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Thomas Zimmermann
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Sa
off-by: Nirmoy Das
Thanks for adding this.
The patch as-is is:
Reviewed-by: Sam Ravnborg
It would have been nice to start adding kernel-doc to the
non-deprecated logging functions. But as everyone else is missing this,
it is OK that we miss it here.
A couple of nice follow-up patches would be
a very nice reduction of bloat! I hope this has a measureable
effect on building times.
I was working on something similar, but that approach only added missing
includes, and did not kill all the unnessesary includes - which I think
is the biggest win here.
All patches are:
Reviewed-by: Sam Ravnbor
_hdmi.c
> index 477cb6985b4d..37dc66332bbd 100644
> --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
> +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
> @@ -8,8 +8,8 @@
> #include
> #include
>
> -#include
> #include
> +#include
Move one up to maintain sorting.
W
On Mon, Jan 16, 2023 at 02:12:18PM +0100, Thomas Zimmermann wrote:
> Several source files include drm_crtc_helper.h without needing it or
> only to get its transitive include statements; leading to unnecessary
> compile-time dependencies.
>
> Directly include required headers and drop
ivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -39,6 +39,7 @@
> #include
> #include
> #include
> +#include
Move it one line up to keep the sorting.
With this fixed:
Reviewed-by: Sam Ravnborg
> #include
> #include
&g
een the
header file and the implementation.
I think sparse would also complain that the function is not declared
or something like that.
With this fixed:
Reviewed-by: Sam Ravnborg
> #include
> #include
> #include
> diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lea
Hi Richard,
On Fri, Jan 13, 2023 at 04:24:23PM -0500, Richard Acayan wrote:
> On Fri, Jan 13, 2023 at 05:34:55PM +0100, Sam Ravnborg wrote:
> > Hi Richard/Daniel.
> Not sure if you saw the original commit that I linked.
>
> This patch was written in 2017 for the Pixe
Hi Richard/Daniel.
On Thu, Jan 12, 2023 at 11:18:48PM -0500, Richard Acayan wrote:
> From: Daniel Mentz
>
> The MIPI DCS specification demands that brightness values are sent in
> big endian byte order. It also states that one parameter (i.e. one byte)
> shall be sent/received for 8 bit wide
ollowing coccicheck make command helped identify this change:
>
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch
> COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
>
> Signed-off-by: Deepak R Varma
Acked-by: Sam Ravnborg
Anyone up for testing this change?
ix komeda build (kernel test robot)
Whole series are:
Acked-by: Sam Ravnborg
Except for the patches where I added an explicit r-b.
Sam
On Wed, Jan 11, 2023 at 02:02:01PM +0100, Thomas Zimmermann wrote:
> Remove unnecessary include statements for . No functional
> changes. Include where the driver got the header file via
> .
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
> ---
> driver
Hi Ville,
On Wed, Jan 11, 2023 at 06:08:42PM +0200, Ville Syrjälä wrote:
> On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote:
> > Include in source files that need it. Some of DRM's
> > source code gets OF header via drm_crtc_helper.h and ,
> > which can leed to unnecessary
rtc_helper.h any longer.
Are you planning a clean-up of drm_crtc_helper.h later?
With a handful of forward it could losse all includes.
>
> Signed-off-by: Thomas Zimmermann
> Acked-by: Christian König # amd
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
Hi Stephen,
On Tue, Jan 10, 2023 at 11:29:41AM -0800, Stephen Boyd wrote:
> Quoting Sam Ravnborg (2023-01-07 12:28:41)
>
> >
> > For this case we could ask ourself if the display needs to enter sleep
> > mode right before we disable the regulator. But if the regulator is
&
Neil Armstrong
One small nit about sorting include files.
At least I consider them wrongly sorted. Up to you if you fix it while
applying or you keep it as is.
Reviewed-by: Sam Ravnborg
Sam
> ---
> drivers/gpu/drm/panel/Kconfig | 8 +
> drivers/gpu/drm/panel
Hi Christophe,
On Mon, Jan 09, 2023 at 05:44:46PM +, Christophe Leroy wrote:
>
>
> Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit :
> > From: Sam Ravnborg
> >
> > Introduce backlight_get_brightness() to simplify logic
> > and
Hi Daniel.
On Mon, Jan 09, 2023 at 11:06:35AM +, Daniel Thompson wrote:
> On Sat, Jan 07, 2023 at 07:26:29PM +0100, Sam Ravnborg via B4 Submission
> Endpoint wrote:
> > From: Sam Ravnborg
> >
> > With all users gone remove the deprecated fb_blank member in
Hi Stephen,
On Sun, Jan 08, 2023 at 08:28:17PM +0100, Stephen Kitt wrote:
> On Sat, 07 Jan 2023 19:26:23 +0100, Sam Ravnborg via B4 Submission Endpoint
> wrote:
>
> > From: Sam Ravnborg
> >
> > Avoiding direct access to backlight_properties.props.
> &
Hi Helge,
> >
> > Helge - could you pick the reviewed patches from:
> > https://lore.kernel.org/all/20220607192335.1137249-1-st...@sk2.org/
> > [This is the same mail as Stephen refer to above - looked up via lore].
>
> I just pulled those 7 patches into fbdev/for-next.
> If you need more,
Hi Stephen.
> Here are my pending patches from last June on lore:
>
All patches are handled I think except this:
> * https://lore.kernel.org/lkml/20220608205623.2106113-1-st...@sk2.org/
Can I ask you to drop the assignment that is not needed, and resend with
the collected acks/r-b.
With
Hi Robin.
On Sat, Jan 07, 2023 at 10:02:38PM +0100, Miguel Ojeda wrote:
> On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint
> wrote:
> >
> > Introduce backlight_get_brightness() to simplify logic
> > and avoid direct access to backlight properties.
Hi Stephen.
On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote:
> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint
> wrote:
> >From: Sam Ravnborg
> >
> >The atmel_lcdfb had code to save/restore power state.
> >This is not neede
On Fri, Jan 06, 2023 at 11:05:21AM +0800, xinlei@mediatek.com wrote:
> From: Xinlei Lee
>
> Since the panel spec stipulates that the time from lcm_reset to DSI to
> send the initial code should be greater than 6ms and less than 40ms,
> so reduce the delay before sending the initial code and
by the DSI spec, and less than
> the time specified by the DSI_RX (generally 6ms to 40ms), to avoid
> problems caused by the RX specification.
>
> [1]:mipi_D-PHY_specification_v1-1
>
> Fixes: 39e8d062b03c ("drm/mediatek: Keep dsi as LP00 before dcs cmds
> transfer")
> Si
s OK.
Please fix the unprepare to not jump out early, on top of or together
with the other fix.
Sam
>
> Fixes: 007ac0262b0d ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE")
> Fixes: a869b9db7adf ("drm/panel: support for boe tv101wum-nl6 wuxga dsi video
> mode panel"
From: Sam Ravnborg
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg
Cc: Antonino Daplas
Cc: linux-fb...@vger.kernel.org
---
drivers/video/fbdev/riva/fbdev.c | 8 +---
1 file changed, 1 insertion(+), 7
From: Sam Ravnborg
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg
Cc: Paul Mackerras
Cc: linux-fb...@vger.kernel.org
---
drivers/video/fbdev/aty/aty128fb.c | 11 ++-
1 file changed, 2 insertions
From: Sam Ravnborg
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg
Cc: Antonino Daplas
Cc: linux-fb...@vger.kernel.org
---
drivers/video/fbdev/nvidia/nv_backlight.c | 8 +---
1 file changed, 1 insertion
From: Sam Ravnborg
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg
Cc: Allison Randal
Cc: Sam Ravnborg
Cc: Greg Kroah-Hartman
Cc: Kate Stewart
Cc: Thomas Gleixner
Cc: Enrico Weigelt
Cc: Alexios Zavras
-off-by: Sam Ravnborg
---
drivers/video/backlight/tosa_bl.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/video/backlight/tosa_bl.c
b/drivers/video/backlight/tosa_bl.c
index f55b3d616a87..cb07f13dd886 100644
--- a/drivers/video/backlight/tosa_bl.c
+++ b/drivers
From: Sam Ravnborg
Rework backlight handling to avoid access to the deprecated
backlight_properties.fb_blank member.
The rework includes removal of get_brightness() operation,
because there was no read back from HW so no use for it.
Signed-off-by: Sam Ravnborg
Cc: Lee Jones
Cc: Daniel
From: Sam Ravnborg
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg
Cc: Robin van der Gracht
Cc: Miguel Ojeda
Cc: Geert Uytterhoeven
---
drivers/auxdisplay/ht16k33.c | 7 +--
1 file changed, 1 insertion
: linuxppc-...@lists.ozlabs.org
Cc: Stephen Kitt
Signed-off-by: Sam Ravnborg
---
Sam Ravnborg (14):
video: fbdev: atmel_lcdfb: Rework backlight handling
video: fbdev: atyfb: Introduce backlight_get_brightness()
video: fbdev: nvidia: Introduce backlight_get_brightness()
video
From: Sam Ravnborg
With all users gone remove the deprecated fb_blank member in
backlight_properties.
Signed-off-by: Sam Ravnborg
Cc: Lee Jones
Cc: Daniel Thompson
Cc: Jingoo Han
---
drivers/video/backlight/backlight.c | 2 --
include/linux/backlight.h | 22
From: Sam Ravnborg
Avoiding direct access to backlight_properties.props.
Access to the deprecated props.fb_blank replaced by backlight_is_blank().
Access to props.power is dropped - it was only used for debug.
Signed-off-by: Sam Ravnborg
Cc: Thomas Zimmermann
Cc: Andy Shevchenko
Cc: Javier
From: Sam Ravnborg
The atmel_lcdfb had code to save/restore power state.
This is not needed so drop it.
Introduce backlight_is_brightness() to make logic simpler.
Signed-off-by: Sam Ravnborg
Cc: Nicolas Ferre
Cc: Alexandre Belloni
Cc: Ludovic Desroches
Cc: linux-fb...@vger.kernel.org
Cc
From: Sam Ravnborg
Avoiding direct access to backlight_properties.props.
Access to the deprecated props.fb_blank replaced by backlight_is_blank().
Access to props.power is dropped - it was only used for debug.
Signed-off-by: Sam Ravnborg
Cc: Stephen Kitt
Cc: Greg Kroah-Hartman
Cc: Daniel
From: Sam Ravnborg
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg
Cc: Benjamin Herrenschmidt
Cc: Sam Ravnborg
Cc: linuxppc-...@lists.ozlabs.org
---
drivers/macintosh/via-pmu-backlight.c | 7 +--
1 file
From: Sam Ravnborg
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg
Cc: Sam Ravnborg
Cc: Kate Stewart
Cc: Thomas Gleixner
Cc: Laurent Pinchart
Cc: Greg Kroah-Hartman
Cc: Arnd Bergmann
Cc: Jani Nikula
From: Sam Ravnborg
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg
Cc: Bartlomiej Zolnierkiewicz
Cc: Sam Ravnborg
Cc: Daniel Vetter
Cc: Souptick Joarder
Cc: Maarten Lankhorst
Cc: Jason Yan
Cc: Jani Nikula
From: Sam Ravnborg
Introduce backlight_get_brightness() to simplify logic
and avoid direct access to backlight properties.
Signed-off-by: Sam Ravnborg
Cc: Benjamin Herrenschmidt
Cc: linux-fb...@vger.kernel.org
---
drivers/video/fbdev/aty/radeon_backlight.c | 10 +++---
1 file changed, 3
On Fri, Jan 06, 2023 at 05:48:55PM +0100, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from
es this from future changes.
>
> Signed-off-by: Stephen Kitt
Reviewed-by: Sam Ravnborg
> ---
> drivers/video/backlight/ipaq_micro_bl.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/video/backlight/ipaq_micro_bl.c
> b/drivers/vid
es this from future changes.
>
> Signed-off-by: Stephen Kitt
Reviewed-by: Sam Ravnborg
> ---
> drivers/video/backlight/tosa_bl.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/video/backlight/tosa_bl.c
> b/drivers/video/back
es this from future changes.
>
> Signed-off-by: Stephen Kitt
Reviewed-by: Sam Ravnborg
> ---
> drivers/video/backlight/arcxcnn_bl.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/video/backlight/arcxcnn_bl.c
> b/drivers/video/backlig
nd insulates this from future changes.
>
> Signed-off-by: Stephen Kitt
Nice cleanup.
Reviewed-by: Sam Ravnborg
> ---
> drivers/video/backlight/aat2870_bl.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/video/backlight/aat2870_
ve are not documented in panel-common.
> > But maybe I miss something and this is OK?
>
> It should be OK, the -supply properties are standard properties
Thanks for the explanation - patch is then:
Reviewed-by: Sam Ravnborg
Hi Neil,
>
> >
> > > +
> > > +struct visionox_vtdr6130 {
> > > + struct drm_panel panel;
> > > + struct mipi_dsi_device *dsi;
> > > + struct gpio_desc *reset_gpio;
> > > + struct regulator_bulk_data supplies[3];
> > > + bool prepared;
> > > +};
> > > +
> > > +static inline struct
Hi Chris.
On Tue, Jan 03, 2023 at 01:07:06PM -0600, Chris Morgan wrote:
> From: Chris Morgan
>
> Support Magnachip D53E6EA8966 based panels such as the Samsung
> AMS495QA01 panel as found on the Anbernic RG503. Note this driver
> supports only the AMS495QA01 today which receives video signals
host with the correct host and info with the correct node.
I think you need and empty line before Returns ...
This is what others does in the same file, so for consistency please add
it.
With this detail fixed:
Reviewed-by: Sam Ravnborg
> + * Returns zero if successful, -EPROBE_DEF
Hi Neil,
On Tue, Jan 03, 2023 at 03:22:28PM +0100, Neil Armstrong wrote:
> Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel
> found on the Qualcomm SM8550 MTP board.
>
> By default the the panel is configured to work with DSI compressed
> streams, but can work in uncompressed
Hi Neil,
On Tue, Jan 03, 2023 at 03:22:27PM +0100, Neil Armstrong wrote:
> Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings.
>
> Signed-off-by: Neil Armstrong
> ---
> .../bindings/display/panel/visionox,vtdr6130.yaml | 53
> ++
> 1 file changed, 53
On Mon, Jan 02, 2023 at 09:25:41PM +0100, Javier Martinez Canillas wrote:
> Change made using a `clang-format -i include/drm/drm_mipi_dsi.h` command.
>
> Suggested-by: Sam Ravnborg
> Signed-off-by: Javier Martinez Canillas
Thanks,
Reviewed-by: Sam Ravnborg
> ---
>
> C
Hi Javier,
> > (If you align '\' under each other it would be nicer, but I could see
> > that mipi_dsi_dcs_write_seq() do not do so).
>
> Yeah, I was actually thinking about doing like you suggested for this macro
> but preferred to keep it consistent with the existing mipi_dsi_dcs_write_seq()
>
Hi Javier.
On Wed, Dec 28, 2022 at 02:47:43AM +0100, Javier Martinez Canillas wrote:
> Hello,
>
> This series contains cleanups for DRM panel drivers that define their own
> DSI write macros instead of using what's already in .
>
> The changes are quite trivial but I've only tested this with
On Wed, Dec 28, 2022 at 02:47:55AM +0100, Javier Martinez Canillas wrote:
> There is a macro for this already in the header, use
> that instead and delete the custom DSI write macro defined in the driver.
>
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
> --
On Wed, Dec 28, 2022 at 02:47:53AM +0100, Javier Martinez Canillas wrote:
> There is a macro for this already in the header, use
> that instead and delete the custom DSI write macro defined in the driver.
>
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
> --
On Wed, Dec 28, 2022 at 02:47:50AM +0100, Javier Martinez Canillas wrote:
> There is a macro for this already in the header, use
> that instead and delete the custom DSI write macro defined in the driver.
>
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
> --
Hi Javier.
On Wed, Dec 28, 2022 at 02:47:57AM +0100, Javier Martinez Canillas wrote:
> There is a macro for this already in the header, use
> that instead and delete the custom DSI write macro defined in the driver.
>
> Signed-off-by: Javier Martinez Canillas
> ---
>
>
mipi_dsi_generic_write_seq(dsi, 0xee, 0x03);
> + mipi_dsi_generic_write_seq(dsi, 0xb0,
> 0x00, 0xb2, 0x00, 0xb3, 0x00, 0xb6, 0x00, 0xc3,
> 0x00, 0xce, 0x00, 0xe1, 0x00, 0xf3, 0x01, 0x11);
Fix indent - here and elsewhere.
With this
benefit from the more advanced macro,
and drop even more code.
Reviewed-by: Sam Ravnborg
> ---
>
> .../gpu/drm/panel/panel-sharp-ls060t1sx01.c | 19 ++-
> 1 file changed, 2 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sharp-
88a0_ams452ef01_on(struct
> s6e88a0_ams452ef01 *ctx)
> 0x6b, 0x68, 0x71, // V3 R,G,B
> 0x00, 0x00, 0x00);// V1 R,G,B
Fix indent - with this fixed:
Reviewed-by: Sam Ravnborg
> // set default Amoled
mipi_dsi_generic_write_seq(dsi, 0xd6, 0x01);
> + mipi_dsi_generic_write_seq(dsi, 0xec,
> 0x64, 0xdc, 0xec, 0x3b, 0x52, 0x00, 0x0b, 0x0b,
> 0x13, 0x15, 0x68, 0x0b, 0xb5);
Fix indent - with this fixed everywhere:
Reviewed-
x4c);
> + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_SET_3D_CONTROL, 0x10);
> + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE,
> DCS_ALLOW_HBM_RANGE);
> + mipi_dsi_dcs_write_seq(dsi, 0xf8,
> 0x00, 0x08, 0x10, 0x00, 0x22, 0x00, 0x00, 0x2d);
Fix i
pi_dsi_dcs_write_seq(dsi, KD35T133_CMD_POSITIVEGAMMA,
> 0x00, 0x13, 0x18, 0x04, 0x0f, 0x06, 0x3a, 0x56,
> 0x4d, 0x03, 0x0a, 0x06, 0x30, 0x3e, 0x0f);
Fix indent, here and later.
With this fixed:
Reviewed-by: Sam Ravnborg
&
cs_write_seq(dsi, 0xdf, 0x93, 0x65, 0xf8);
> - dsi_dcs_write_seq(dsi, 0xb0, 0x01, 0x03, 0x02, 0x00, 0x64, 0x06,
> + mipi_dsi_dcs_write_seq(dsi, 0xdf, 0x93, 0x65, 0xf8);
> + mipi_dsi_dcs_write_seq(dsi, 0xb0, 0x01, 0x03, 0x02, 0x00, 0x64, 0x06,
>
ETEXTC,
> + mipi_dsi_generic_write_seq(dsi, ST7703_CMD_SETEXTC,
> 0xF1, 0x12, 0x83);
Fix indent here, and in similar places below.
With that fixed:
Reviewed-by: Sam Ravnborg
> - dsi_generic_write_seq(dsi, ST7703_CMD_SETRGBIF,
> + mip
; +/**
> + * mipi_dsi_generic_write - transmit data using a generic write packet
s/mipi_dsi_generic_write/mipi_dsi_generic_write_seq
(As the bot also reported)
with this fixed:
Reviewed-by: Sam Ravnborg
> + * @dsi: DSI peripheral device
> + * @seq: buffer containing the payload
> + */
> +#define
On Tue, Dec 27, 2022 at 12:03:34PM +0100, Javier Martinez Canillas wrote:
> Add myself as maintainer for the driver and devicetree bindings schema.
>
> Signed-off-by: Javier Martinez Canillas
Acked-by: Sam Ravnborg
> ---
>
> (no changes since v1)
>
> MAINTAINERS | 7 +
gned-off-by: Kamil Trzciński
> Co-developed-by: Ondrej Jirman
> Signed-off-by: Ondrej Jirman
> Co-developed-by: Javier Martinez Canillas
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
Strictly speaking the binding should be applied before the driver.
Sam
Hi Javier.
On Thu, Dec 22, 2022 at 11:38:27PM +0100, Javier Martinez Canillas wrote:
> From: Kamil Trzciński
>
> The driver is for panels based on the Himax HX8394 controller, such as the
> HannStar HSD060BHW4 720x1440 TFT LCD panel that uses a MIPI-DSI interface.
A few comments/nitpicks in
301 - 400 of 3965 matches
Mail list logo
