Missing amdgpu firmware files

2015-10-27 Thread Seth Forshee
On Tue, Oct 27, 2015 at 04:10:33PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Seth Forshee [mailto:seth.forshee at canonical.com] > > Sent: Tuesday, October 27, 2015 12:06 PM > > To: Koenig, Christian > > Cc: Deucher, Ale

Missing amdgpu firmware files

2015-10-27 Thread Seth Forshee
On Tue, Oct 27, 2015 at 04:47:53PM +0100, Christian König wrote: > Well that's strange. Essentially those are just duplicates to the > existing files and the driver should fallback to them. > > IIRC the radeon/*_sdma1.bin files are only requested when you try to > use CIK support with amdgpu

Missing amdgpu firmware files

2015-10-27 Thread Seth Forshee
I've received reports from Ubuntu users about missing amdgpu firmware files with 4.2 kernels. The driver calls out a number of radeon/*_sdma1.bin files that are not present in the linux-firmware git repo. Are these files available anywhere (under a license that allows redistribution), and will

Re: [PATCH v5 0/4] Fix Win8 backlight issue

2013-10-12 Thread Seth Forshee
On Sat, Oct 12, 2013 at 04:44:30AM -0700, Josh Boyer wrote: On Fri, Oct 11, 2013 at 4:27 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Friday, October 11, 2013 06:01:43 PM Josh Boyer wrote: On Fri, Oct 11, 2013 at 6:10 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Friday,

[PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-11 Thread Seth Forshee
On Sun, Jun 09, 2013 at 07:01:36PM -0400, Matthew Garrett wrote: > Windows 8 introduced new policy for backlight control by pushing it out to > graphics drivers. This appears to have coincided with a range of vendors > adding Windows 8 checks to their backlight control code which trigger either >

Re: [PATCH 0/3] Fix backlight issues on some Windows 8 systems

2013-06-11 Thread Seth Forshee
On Sun, Jun 09, 2013 at 07:01:36PM -0400, Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have coincided with a range of vendors adding Windows 8 checks to their backlight control code which trigger either

[PATCH 0/7] Fixes for hybrid graphics Apple machines

2012-09-10 Thread Seth Forshee
before switcheroo is ready to a list and initializing these devices once switcheroo becomes ready. This behavior is restricted to Apple laptops to prevent causing problems on other machines. Thanks, Seth Seth Forshee (7): vga_switcheroo: Add support for switching only the DDC vga_switcheroo: Add

[PATCH 1/7] vga_switcheroo: Add support for switching only the DDC

2012-09-10 Thread Seth Forshee
-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/vga/vga_switcheroo.c | 39 +- include/linux/vga_switcheroo.h |4 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga

[PATCH 3/7] vga_switcheroo: Add notifier call chain for switcheroo events

2012-09-10 Thread Seth Forshee
and unregistration of handlers and clients. Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/vga/vga_switcheroo.c | 34 ++ include/linux/vga_switcheroo.h | 14 ++ 2 files changed, 48 insertions(+) diff --git a/drivers/gpu/vga

[PATCH 4/7] apple-gmux: Add switch_ddc support

2012-09-10 Thread Seth Forshee
The gmux allows muxing the DDC independently from the display, so support this functionality. This will allow reading the EDID for the inactive GPU, fixing issues with machines that either don't have a VBT or have invalid mode data in the VBT. Signed-off-by: Seth Forshee seth.fors

[PATCH 5/7] drm/edid: Switch DDC when reading the EDID

2012-09-10 Thread Seth Forshee
Some dual graphics machines support muxing the DDC separately from the display, so make use of this functionality when reading the EDID on the inactive GPU. Also serialize drm_get_edid() with a mutex to avoid races on the DDC mux state. Signed-off-by: Seth Forshee seth.fors...@canonical.com

[PATCH 6/7] drm/pci: Add drm_put_pci_dev()

2012-09-10 Thread Seth Forshee
-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/drm/ast/ast_drv.c |2 +- drivers/gpu/drm/cirrus/cirrus_drv.c |2 +- drivers/gpu/drm/drm_pci.c |8 +++- drivers/gpu/drm/gma500/psb_drv.c |2 +- drivers/gpu/drm/i915/i915_drv.c |2

[PATCH 7/7] drm/pci: Defer initialization of secondary graphics devices until switcheroo is ready

2012-09-10 Thread Seth Forshee
. To support this, delay calling the driver load() callback until the vga_switcheroo handler and active client have been registered. This is restricted to Apple notebooks via DMI data to avoid causing problems on machines without switcheroo support. Signed-off-by: Seth Forshee seth.fors...@canonical.com

Re: [PATCH 0/7] Fixes for hybrid graphics Apple machines

2012-09-10 Thread Seth Forshee
On Fri, Sep 07, 2012 at 10:35:04PM +0100, Dave Airlie wrote: On Fri, Sep 7, 2012 at 4:22 PM, Seth Forshee seth.fors...@canonical.com wrote: Many hybrid graphics Apple laptops fail to set up LVDS on the secondary GPU due to missing or incorrect mode information for the panel at init time

[PATCH 0/7] Fixes for hybrid graphics Apple machines

2012-09-08 Thread Seth Forshee
On Fri, Sep 07, 2012 at 10:35:04PM +0100, Dave Airlie wrote: > On Fri, Sep 7, 2012 at 4:22 PM, Seth Forshee > wrote: > > Many hybrid graphics Apple laptops fail to set up LVDS on the secondary > > GPU due to missing or incorrect mode information for the panel at init >

[PATCH 7/7] drm/pci: Defer initialization of secondary graphics devices until switcheroo is ready

2012-09-07 Thread Seth Forshee
. To support this, delay calling the driver load() callback until the vga_switcheroo handler and active client have been registered. This is restricted to Apple notebooks via DMI data to avoid causing problems on machines without switcheroo support. Signed-off-by: Seth Forshee --- drivers/gpu/drm

[PATCH 6/7] drm/pci: Add drm_put_pci_dev()

2012-09-07 Thread Seth Forshee
-by: Seth Forshee --- drivers/gpu/drm/ast/ast_drv.c |2 +- drivers/gpu/drm/cirrus/cirrus_drv.c |2 +- drivers/gpu/drm/drm_pci.c |8 +++- drivers/gpu/drm/gma500/psb_drv.c |2 +- drivers/gpu/drm/i915/i915_drv.c |2 +- drivers/gpu/drm/mgag200

[PATCH 5/7] drm/edid: Switch DDC when reading the EDID

2012-09-07 Thread Seth Forshee
Some dual graphics machines support muxing the DDC separately from the display, so make use of this functionality when reading the EDID on the inactive GPU. Also serialize drm_get_edid() with a mutex to avoid races on the DDC mux state. Signed-off-by: Seth Forshee --- drivers/gpu/drm/drm_edid.c

[PATCH 4/7] apple-gmux: Add switch_ddc support

2012-09-07 Thread Seth Forshee
The gmux allows muxing the DDC independently from the display, so support this functionality. This will allow reading the EDID for the inactive GPU, fixing issues with machines that either don't have a VBT or have invalid mode data in the VBT. Signed-off-by: Seth Forshee --- drivers/platform

[PATCH 3/7] vga_switcheroo: Add notifier call chain for switcheroo events

2012-09-07 Thread Seth Forshee
and unregistration of handlers and clients. Signed-off-by: Seth Forshee --- drivers/gpu/vga/vga_switcheroo.c | 34 ++ include/linux/vga_switcheroo.h | 14 ++ 2 files changed, 48 insertions(+) diff --git a/drivers/gpu/vga/vga_switcheroo.c b

[PATCH 2/7] vga_switcheroo: Add helper function to get the active client

2012-09-07 Thread Seth Forshee
Add vga_switcheroo_get_active_client() to allow drivers to get the active video client. This will be used by drivers wishing to temporarily mux only the DDC to the inactive client. Signed-off-by: Seth Forshee --- drivers/gpu/vga/vga_switcheroo.c | 14 ++ include/linux

[PATCH 1/7] vga_switcheroo: Add support for switching only the DDC

2012-09-07 Thread Seth Forshee
-by: Seth Forshee --- drivers/gpu/vga/vga_switcheroo.c | 39 +- include/linux/vga_switcheroo.h |4 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga/vga_switcheroo.c index e25cf31..ea6bcc2

[PATCH 0/7] Fixes for hybrid graphics Apple machines

2012-09-07 Thread Seth Forshee
before switcheroo is ready to a list and initializing these devices once switcheroo becomes ready. This behavior is restricted to Apple laptops to prevent causing problems on other machines. Thanks, Seth Seth Forshee (7): vga_switcheroo: Add support for switching only the DDC vga_switcheroo: Add

[RFC PATCH 1/7] vga_switcheroo: Add support for switching only the DDC

2012-08-21 Thread Seth Forshee
-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/vga/vga_switcheroo.c | 39 +- include/linux/vga_switcheroo.h |4 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga

[RFC PATCH 2/7] vga_switcheroo: Add helper function to get the active client

2012-08-21 Thread Seth Forshee
Add vga_switcheroo_get_active_client() to allow drivers to get the active video client. This will be used by drivers wishing to temporarily mux only the DDC to the inactive client. Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/vga/vga_switcheroo.c | 14

[RFC PATCH 4/7] apple-gmux: Add switch_ddc support

2012-08-21 Thread Seth Forshee
The gmux allows muxing the DDC independently from the display, so support this functionality. This will allow reading the EDID for the inactive GPU, fixing issues with machines that either don't have a VBT or have invalid mode data in the VBT. Signed-off-by: Seth Forshee seth.fors

[RFC PATCH 5/7] drm/edid: Switch DDC when reading the EDID

2012-08-21 Thread Seth Forshee
Some dual graphics machines support muxing the DDC separately from the display, so make use of this functionality when reading the EDID on the inactive GPU. Also serialize drm_get_edid() with a mutex to avoid races on the DDC mux state. Signed-off-by: Seth Forshee seth.fors...@canonical.com

[RFC PATCH 6/7] drm/pci: Add drm_put_pci_dev()

2012-08-21 Thread Seth Forshee
-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/drm/ast/ast_drv.c |2 +- drivers/gpu/drm/cirrus/cirrus_drv.c |2 +- drivers/gpu/drm/drm_pci.c |6 ++ drivers/gpu/drm/gma500/psb_drv.c |2 +- drivers/gpu/drm/i915/i915_drv.c |2 +- drivers

[RFC PATCH 7/7] drm/pci: Defer initialization of secondary graphics devices until switcheroo is ready

2012-08-20 Thread Seth Forshee
On Mon, Aug 20, 2012 at 04:57:41PM +0100, Matthew Garrett wrote: > On Mon, Aug 20, 2012 at 10:56:33AM -0500, Seth Forshee wrote: > > On Mon, Aug 20, 2012 at 04:36:40PM +0100, Matthew Garrett wrote: > > > Won't this break the multiple cards with independent outputs case? > >

[RFC PATCH 7/7] drm/pci: Defer initialization of secondary graphics devices until switcheroo is ready

2012-08-20 Thread Seth Forshee
On Mon, Aug 20, 2012 at 04:36:40PM +0100, Matthew Garrett wrote: > On Mon, Aug 20, 2012 at 10:31:04AM -0500, Seth Forshee wrote: > > + /* > > +* For secondary graphics devices shouldn't be initialized > > +* until the handler and primary graphics device have been

[RFC PATCH 7/7] drm/pci: Defer initialization of secondary graphics devices until switcheroo is ready

2012-08-20 Thread Seth Forshee
Deferring initiailzation of the secondary GPU until switcheroo is ready will allow successfully reading the EDID in systems which support muxing the DDC seperately from the display. Signed-off-by: Seth Forshee --- drivers/gpu/drm/drm_drv.c |3 + drivers/gpu/drm/drm_pci.c | 141

[RFC PATCH 5/7] drm/edid: Switch DDC when reading the EDID

2012-08-20 Thread Seth Forshee
Some dual graphics machines support muxing the DDC separately from the display, so make use of this functionality when reading the EDID on the inactive GPU. Also serialize drm_get_edid() with a mutex to avoid races on the DDC mux state. Signed-off-by: Seth Forshee --- drivers/gpu/drm/drm_edid.c

[RFC PATCH 4/7] apple-gmux: Add switch_ddc support

2012-08-20 Thread Seth Forshee
The gmux allows muxing the DDC independently from the display, so support this functionality. This will allow reading the EDID for the inactive GPU, fixing issues with machines that either don't have a VBT or have invalid mode data in the VBT. Signed-off-by: Seth Forshee --- drivers/platform

[RFC PATCH 3/7] vga_switcheroo: Add notifier call chain for switcheroo events

2012-08-20 Thread Seth Forshee
and unregistration of handlers and clients. Signed-off-by: Seth Forshee --- drivers/gpu/vga/vga_switcheroo.c | 34 ++ include/linux/vga_switcheroo.h | 14 ++ 2 files changed, 48 insertions(+) diff --git a/drivers/gpu/vga/vga_switcheroo.c b

[RFC PATCH 2/7] vga_switcheroo: Add helper function to get the active client

2012-08-20 Thread Seth Forshee
Add vga_switcheroo_get_active_client() to allow drivers to get the active video client. This will be used by drivers wishing to temporarily mux only the DDC to the inactive client. Signed-off-by: Seth Forshee --- drivers/gpu/vga/vga_switcheroo.c | 14 ++ include/linux

[RFC PATCH 1/7] vga_switcheroo: Add support for switching only the DDC

2012-08-20 Thread Seth Forshee
-by: Seth Forshee --- drivers/gpu/vga/vga_switcheroo.c | 39 +- include/linux/vga_switcheroo.h |4 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga/vga_switcheroo.c index e25cf31..ea6bcc2

[RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-20 Thread Seth Forshee
On Fri, Aug 10, 2012 at 05:19:48PM -0500, Seth Forshee wrote: > First, I don't have a solution for the ordering of initialization. It > just happens to work out for me right now. Okay, I've got a proof-of-concept implementation of delaying secondary GPU initialization until the i2c can be

[PATCH v2 0/3] Display switching support for Apple laptops

2012-08-18 Thread Seth Forshee
S3 Thanks, Seth Andreas Heider (1): apple-gmux: Add display mux support Seth Forshee (2): vga_switcheroo: Don't require handler init callback vga_switcheroo: Remove assumptions about registration/unregistration ordering drivers/gpu/drm/nouveau/nouveau_acpi.c |6 - drivers/gpu

[PATCH v2 1/3] vga_switcheroo: Don't require handler init callback

2012-08-18 Thread Seth Forshee
This callback is a no-op in nouveau, and the upcoming apple-gmux switcheroo support won't require it either. Rather than forcing drivers to stub it out, just make it optional and remove the callback from nouveau. Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/drm/nouveau

[PATCH v2 2/3] vga_switcheroo: Remove assumptions about registration/unregistration ordering

2012-08-18 Thread Seth Forshee
having a handler. These assumptions cannot be enforced if the handler is in a separate driver from both clients, as with the gmux found in Apple laptops. Remove this assumption. Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/vga/vga_switcheroo.c | 58

[PATCH v2 3/3] apple-gmux: Add display mux support

2012-08-18 Thread Seth Forshee
From: Andreas Heider andr...@meetr.de Add support for the gmux display muxing functionality and register a mux handler with vga_switcheroo. Signed-off-by: Andreas Heider andr...@meetr.de Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/platform/x86/apple-gmux.c | 224

[PATCH v2 3/3] apple-gmux: Add display mux support

2012-08-17 Thread Seth Forshee
From: Andreas Heider <andr...@meetr.de> Add support for the gmux display muxing functionality and register a mux handler with vga_switcheroo. Signed-off-by: Andreas Heider Signed-off-by: Seth Forshee --- drivers/platform/x86/apple-gmux.c | 224 +

[PATCH v2 2/3] vga_switcheroo: Remove assumptions about registration/unregistration ordering

2012-08-17 Thread Seth Forshee
having a handler. These assumptions cannot be enforced if the handler is in a separate driver from both clients, as with the gmux found in Apple laptops. Remove this assumption. Signed-off-by: Seth Forshee --- drivers/gpu/vga/vga_switcheroo.c | 58 +++--- 1 file

[PATCH v2 1/3] vga_switcheroo: Don't require handler init callback

2012-08-17 Thread Seth Forshee
This callback is a no-op in nouveau, and the upcoming apple-gmux switcheroo support won't require it either. Rather than forcing drivers to stub it out, just make it optional and remove the callback from nouveau. Signed-off-by: Seth Forshee --- drivers/gpu/drm/nouveau/nouveau_acpi.c |6

[PATCH v2 0/3] Display switching support for Apple laptops

2012-08-17 Thread Seth Forshee
S3 Thanks, Seth Andreas Heider (1): apple-gmux: Add display mux support Seth Forshee (2): vga_switcheroo: Don't require handler init callback vga_switcheroo: Remove assumptions about registration/unregistration ordering drivers/gpu/drm/nouveau/nouveau_acpi.c |6 - drivers/gpu

[PATCH 0/3] Display switching support for Apple laptops

2012-08-15 Thread Seth Forshee
into Linux to save power, but after S3 the gmux gets reset to the discrete GPU. Adding the display mux support will fix this problem by restoring the gmux state during resume. Thanks, Seth Andreas Heider (1): apple-gmux: Add display mux support Seth Forshee (2): vga_switcheroo: Don't require

[PATCH 1/3] vga_switcheroo: Don't require handler init callback

2012-08-15 Thread Seth Forshee
This callback is a no-op in nouveau, and the upcoming apple-gmux switcheroo support won't require it either. Rather than forcing drivers to stub it out, just make it optional and remove the callback from nouveau. Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/drm/nouveau

[PATCH 2/3] vga_switcheroo: Remove assumptions about registration/unregistration ordering

2012-08-15 Thread Seth Forshee
having a handler. These assumptions cannot be enforced if the handler is in a separate driver from both clients, as with the gmux found in Apple laptops. Remove this assumption. Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/vga/vga_switcheroo.c | 58

[PATCH 3/3] apple-gmux: Add display mux support

2012-08-15 Thread Seth Forshee
From: Andreas Heider andr...@meetr.de Add support for the gmux display muxing functionality and register a mux handler with vga_switcheroo. Signed-off-by: Andreas Heider andr...@meetr.de Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/platform/x86/apple-gmux.c | 222

[PATCH 3/3] apple-gmux: Add display mux support

2012-08-14 Thread Seth Forshee
From: Andreas Heider <andr...@meetr.de> Add support for the gmux display muxing functionality and register a mux handler with vga_switcheroo. Signed-off-by: Andreas Heider Signed-off-by: Seth Forshee --- drivers/platform/x86/apple-gmux.c | 222 +

[PATCH 2/3] vga_switcheroo: Remove assumptions about registration/unregistration ordering

2012-08-14 Thread Seth Forshee
having a handler. These assumptions cannot be enforced if the handler is in a separate driver from both clients, as with the gmux found in Apple laptops. Remove this assumption. Signed-off-by: Seth Forshee --- drivers/gpu/vga/vga_switcheroo.c | 58 +++--- 1 file

[PATCH 1/3] vga_switcheroo: Don't require handler init callback

2012-08-14 Thread Seth Forshee
This callback is a no-op in nouveau, and the upcoming apple-gmux switcheroo support won't require it either. Rather than forcing drivers to stub it out, just make it optional and remove the callback from nouveau. Signed-off-by: Seth Forshee --- drivers/gpu/drm/nouveau/nouveau_acpi.c |6

[PATCH 0/3] Display switching support for Apple laptops

2012-08-14 Thread Seth Forshee
into Linux to save power, but after S3 the gmux gets reset to the discrete GPU. Adding the display mux support will fix this problem by restoring the gmux state during resume. Thanks, Seth Andreas Heider (1): apple-gmux: Add display mux support Seth Forshee (2): vga_switcheroo: Don't require

Re: [RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-13 Thread Seth Forshee
On Mon, Aug 06, 2012 at 07:44:16AM +1000, Dave Airlie wrote: The correct approach is clearly to just have the drm core change the i2c mux before requesting edid, but that's made difficult because of the absence of ordering guarantees in initialisation. I don't like quirking this, since

[RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-10 Thread Seth Forshee
On Mon, Aug 06, 2012 at 07:44:16AM +1000, Dave Airlie wrote: > >> The "correct" approach is clearly to just have the drm core change the > >> i2c mux before requesting edid, but that's made difficult because of the > >> absence of ordering guarantees in initialisation. I don't like quirking > >>

Re: [RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-07 Thread Seth Forshee
On Mon, Aug 06, 2012 at 01:23:17PM +0100, Matthew Garrett wrote: On Sun, Aug 05, 2012 at 11:40:16PM +0200, Daniel Vetter wrote: As long as it's only apple shipping multi-gpu machines with broken/non-existing vbt, I'll happily stomach the quirk list entries. They're bad, but imo the lesser

[RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-06 Thread Seth Forshee
On Mon, Aug 06, 2012 at 01:23:17PM +0100, Matthew Garrett wrote: > On Sun, Aug 05, 2012 at 11:40:16PM +0200, Daniel Vetter wrote: > > > As long as it's only apple shipping multi-gpu machines with > > broken/non-existing vbt, I'll happily stomach the quirk list entries. > > They're bad, but imo

[RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-06 Thread Seth Forshee
On Sun, Aug 05, 2012 at 07:20:31PM -0400, Alex Deucher wrote: > On Sun, Aug 5, 2012 at 5:44 PM, Dave Airlie wrote: > > On Mon, Aug 6, 2012 at 7:40 AM, Daniel Vetter wrote: > >> On Sun, Aug 05, 2012 at 10:18:38PM +0100, Matthew Garrett wrote: > >>> On Sun, Aug 05, 2012 at 11:14:12PM +0200, Daniel

[RFC PATCH 0/5] i915 changes for hybrid graphics support on Macbooks

2012-08-05 Thread Seth Forshee
track. Thanks, Seth Andreas Heider (1): drm/i915: Add support for vga_switcheroo reprobe Seth Forshee (4): drm/i915: separate out code to get EDID from LVDS panel drm/i915: register LVDS connector even if we can't get a panel mode drm/i915: make intel_lvds_get_edid() more robust drm/i915

[RFC PATCH 1/5] drm/i915: Add support for vga_switcheroo reprobe

2012-08-05 Thread Seth Forshee
From: Andreas Heider andr...@meetr.de Signed-off-by: Andreas Heider andr...@meetr.de --- drivers/gpu/drm/i915/i915_dma.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index 9cf7dfe..5b5176d 100644

[RFC PATCH 2/5] drm/i915: separate out code to get EDID from LVDS panel

2012-08-05 Thread Seth Forshee
This code will be reused to support hybrid graphics on some Apple machines that can't get a mode for the LVDS panel at boot, so move it into a new function named intel_lvds_get_edid(). Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/drm/i915/intel_lvds.c | 95

[RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-05 Thread Seth Forshee
even if we can't find any panel modes. This makes it necessary to always check intel_lvds-fixed_mode before use, as it could now be NULL. Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/drm/i915/intel_lvds.c | 48 +++-- 1 file changed, 19

[RFC PATCH 4/5] drm/i915: make intel_lvds_get_edid() more robust

2012-08-05 Thread Seth Forshee
intel_lvds_get_edid() needs to be called when switching GPUs, but it's currently making assumptions that it will only be called once and that there's always an LVDS connector present when it's called. Fix these assumptions. Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu

[RFC PATCH 5/5] drm/i915: check LVDS for EDID on GPU switches

2012-08-05 Thread Seth Forshee
If the LVDS panel wasn't connected at boot then we won't have an EDID for it. To fix this, call intel_lvds_get_edid() from the vga_switcheroo reprobe callback. Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu/drm/i915/i915_dma.c |1 + drivers/gpu/drm/i915/intel_drv.h

Re: [RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-05 Thread Seth Forshee
On Fri, Aug 03, 2012 at 05:14:16PM +0100, Matthew Garrett wrote: On Fri, Aug 03, 2012 at 11:02:19AM -0500, Seth Forshee wrote: Some Apple hybrid graphics machines do not have the LVDS panel connected to the integrated GPU at boot and also do not supply a VBT. The LVDS connector

Re: [RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-05 Thread Seth Forshee
On Fri, Aug 03, 2012 at 05:27:02PM +0100, Matthew Garrett wrote: On Fri, Aug 03, 2012 at 11:24:51AM -0500, Seth Forshee wrote: This is one of the things I wasn't so sure about. There are various checks in intel_lvds_init() that can cause it to bail out before we try to get the EDID, and I

[RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-04 Thread Seth Forshee
On Fri, Aug 03, 2012 at 05:27:02PM +0100, Matthew Garrett wrote: > On Fri, Aug 03, 2012 at 11:24:51AM -0500, Seth Forshee wrote: > > > This is one of the things I wasn't so sure about. There are various > > checks in intel_lvds_init() that can cause it to bail out before

[RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-03 Thread Seth Forshee
On Fri, Aug 03, 2012 at 05:14:16PM +0100, Matthew Garrett wrote: > On Fri, Aug 03, 2012 at 11:02:19AM -0500, Seth Forshee wrote: > > Some Apple hybrid graphics machines do not have the LVDS panel connected > > to the integrated GPU at boot and also do not supply a VBT. The LVD

[RFC PATCH 5/5] drm/i915: check LVDS for EDID on GPU switches

2012-08-03 Thread Seth Forshee
If the LVDS panel wasn't connected at boot then we won't have an EDID for it. To fix this, call intel_lvds_get_edid() from the vga_switcheroo reprobe callback. Signed-off-by: Seth Forshee --- drivers/gpu/drm/i915/i915_dma.c |1 + drivers/gpu/drm/i915/intel_drv.h |1 + drivers/gpu/drm

[RFC PATCH 4/5] drm/i915: make intel_lvds_get_edid() more robust

2012-08-03 Thread Seth Forshee
intel_lvds_get_edid() needs to be called when switching GPUs, but it's currently making assumptions that it will only be called once and that there's always an LVDS connector present when it's called. Fix these assumptions. Signed-off-by: Seth Forshee --- drivers/gpu/drm/i915/intel_lvds.c

[RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode

2012-08-03 Thread Seth Forshee
even if we can't find any panel modes. This makes it necessary to always check intel_lvds->fixed_mode before use, as it could now be NULL. Signed-off-by: Seth Forshee --- drivers/gpu/drm/i915/intel_lvds.c | 48 +++-- 1 file changed, 19 insertions(+),

[RFC PATCH 2/5] drm/i915: separate out code to get EDID from LVDS panel

2012-08-03 Thread Seth Forshee
This code will be reused to support hybrid graphics on some Apple machines that can't get a mode for the LVDS panel at boot, so move it into a new function named intel_lvds_get_edid(). Signed-off-by: Seth Forshee --- drivers/gpu/drm/i915/intel_lvds.c | 95

[RFC PATCH 1/5] drm/i915: Add support for vga_switcheroo reprobe

2012-08-03 Thread Seth Forshee
From: Andreas Heider Signed-off-by: Andreas Heider --- drivers/gpu/drm/i915/i915_dma.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index 9cf7dfe..5b5176d 100644 ---

[RFC PATCH 0/5] i915 changes for hybrid graphics support on Macbooks

2012-08-03 Thread Seth Forshee
track. Thanks, Seth Andreas Heider (1): drm/i915: Add support for vga_switcheroo reprobe Seth Forshee (4): drm/i915: separate out code to get EDID from LVDS panel drm/i915: register LVDS connector even if we can't get a panel mode drm/i915: make intel_lvds_get_edid() more robust drm/i915

[PATCH v2] drm/i915: ignore pipe select bit when checking for LVDS register initialization

2012-06-14 Thread Seth Forshee
The Lenovo Thinkpad T410 has the LVDS_PIPEB_SELECT bit set in the LVDS register when booted with the lid closed, even though the LVDS hasn't really been initialized. Ignore this bit so that the VBT value will be used instead. Signed-off-by: Seth Forshee seth.fors...@canonical.com --- drivers/gpu

Re: [PATCH v2] drm/i915: ignore pipe select bit when checking for LVDS register initialization

2012-06-14 Thread Seth Forshee
On Wed, Jun 13, 2012 at 09:46:15PM +0200, Daniel Vetter wrote: On Wed, Jun 13, 2012 at 01:46:58PM -0500, Seth Forshee wrote: The Lenovo Thinkpad T410 has the LVDS_PIPEB_SELECT bit set in the LVDS register when booted with the lid closed, even though the LVDS hasn't really been initialized

[PATCH v2] drm/i915: ignore pipe select bit when checking for LVDS register initialization

2012-06-13 Thread Seth Forshee
On Wed, Jun 13, 2012 at 09:46:15PM +0200, Daniel Vetter wrote: > On Wed, Jun 13, 2012 at 01:46:58PM -0500, Seth Forshee wrote: > > The Lenovo Thinkpad T410 has the LVDS_PIPEB_SELECT bit set in the LVDS > > register when booted with the lid closed, even though the LVDS hasn't

[PATCH v2] drm/i915: ignore pipe select bit when checking for LVDS register initialization

2012-06-13 Thread Seth Forshee
The Lenovo Thinkpad T410 has the LVDS_PIPEB_SELECT bit set in the LVDS register when booted with the lid closed, even though the LVDS hasn't really been initialized. Ignore this bit so that the VBT value will be used instead. Signed-off-by: Seth Forshee --- drivers/gpu/drm/i915/intel_display.c

i915: lvds panel always blank when booted with lid closed

2012-06-13 Thread Seth Forshee
When I boot my Thinkpad T410 in a docking station with the lid closed, the lvds panel remains blank even when this output is active. This happens up to and including 3.5-rc2. I've determined that this happens because lvds isn't being initialized by the bios when I boot this way, and booting with

[PATCH] drm/i915: ignore LVDS_PIPEB_SELECT when checking for LVDS register initialization

2012-06-12 Thread Seth Forshee
The Lenovo Thinkpad T410 has this bit set in the LVDS register when booted with the lid closed, even though the LVDS hasn't really been initialized. Ignore this bit so that the VBT value will be used instead. Signed-off-by: Seth Forshee --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file

[PATCH] drm/radeon/kms: disable output polling when suspended

2012-02-01 Thread Seth Forshee
Polling the outputs when the device is suspended can result in erroneous status updates. Disable output polling during suspend to prevent this from happening. Signed-off-by: Seth Forshee Reviewed-by: Alex Deucher Cc: stable at vger.kernel.org --- drivers/gpu/drm/radeon/radeon_device.c |4

[PATCH] drm/radeon/kms: disable output polling when suspended

2012-02-01 Thread Seth Forshee
Polling the outputs when the device is suspended can result in erroneous status updates. Disable output polling during suspend to prevent this from happening. Signed-off-by: Seth Forshee seth.fors...@canonical.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com Cc: sta...@vger.kernel.org

radeon issues on MacBook Pro 8,2

2012-01-31 Thread Seth Forshee
On Fri, Jan 20, 2012 at 05:08:31PM -0600, Seth Forshee wrote: > > Can you track down who is calling the connector->detect() callbacks > > during suspend and resume? > > I got two different stack traces, see below. > > And to slightly amend my statement above, I'm onl

[PATCH 1/1] drm/radeon/kms: disable output polling when suspended

2012-01-31 Thread Seth Forshee
Polling the outputs when the device is suspended can result in erroneous status updates. Disable output polling during suspend to prevent this from happening. Signed-off-by: Seth Forshee --- drivers/gpu/drm/radeon/radeon_device.c |4 1 files changed, 4 insertions(+), 0 deletions

Re: radeon issues on MacBook Pro 8,2

2012-01-31 Thread Seth Forshee
On Fri, Jan 20, 2012 at 05:08:31PM -0600, Seth Forshee wrote: Can you track down who is calling the connector-detect() callbacks during suspend and resume? I got two different stack traces, see below. And to slightly amend my statement above, I'm only seeing the wrong status returned

Re: radeon issues on MacBook Pro 8,2

2012-01-21 Thread Seth Forshee
On Fri, Jan 20, 2012 at 02:38:37PM -0500, Alex Deucher wrote: On Fri, Jan 20, 2012 at 10:53 AM, Seth Forshee seth.fors...@canonical.com wrote: On Thu, Jan 19, 2012 at 02:53:17PM -0600, Seth Forshee wrote:  2. Occasional long delays when suspending. When this happens I see    messages

Re: radeon issues on MacBook Pro 8,2

2012-01-21 Thread Seth Forshee
On Fri, Jan 20, 2012 at 04:39:31PM -0500, Alex Deucher wrote: On Fri, Jan 20, 2012 at 4:12 PM, Seth Forshee seth.fors...@canonical.com wrote: On Fri, Jan 20, 2012 at 02:38:37PM -0500, Alex Deucher wrote: On Fri, Jan 20, 2012 at 10:53 AM, Seth Forshee seth.fors...@canonical.com wrote

Re: radeon issues on MacBook Pro 8,2

2012-01-21 Thread Seth Forshee
On Fri, Jan 20, 2012 at 11:09:29PM +0200, Pasi Kärkkäinen wrote: On Thu, Jan 19, 2012 at 02:53:17PM -0600, Seth Forshee wrote: On Thu, Jan 19, 2012 at 02:48:52PM -0500, Alex Deucher wrote: On Thu, Jan 19, 2012 at 12:18 PM, Seth Forshee seth.fors...@canonical.com wrote: I'm seeing

radeon issues on MacBook Pro 8,2

2012-01-20 Thread Seth Forshee
On Fri, Jan 20, 2012 at 11:09:29PM +0200, Pasi K?rkk?inen wrote: > On Thu, Jan 19, 2012 at 02:53:17PM -0600, Seth Forshee wrote: > > On Thu, Jan 19, 2012 at 02:48:52PM -0500, Alex Deucher wrote: > > > On Thu, Jan 19, 2012 at 12:18 PM, Seth Forshee > > > wrote: > &

radeon issues on MacBook Pro 8,2

2012-01-20 Thread Seth Forshee
On Fri, Jan 20, 2012 at 04:39:31PM -0500, Alex Deucher wrote: > On Fri, Jan 20, 2012 at 4:12 PM, Seth Forshee > wrote: > > On Fri, Jan 20, 2012 at 02:38:37PM -0500, Alex Deucher wrote: > >> On Fri, Jan 20, 2012 at 10:53 AM, Seth Forshee > >> wrote: > >> >

radeon issues on MacBook Pro 8,2

2012-01-20 Thread Seth Forshee
On Fri, Jan 20, 2012 at 02:38:37PM -0500, Alex Deucher wrote: > On Fri, Jan 20, 2012 at 10:53 AM, Seth Forshee > wrote: > > On Thu, Jan 19, 2012 at 02:53:17PM -0600, Seth Forshee wrote: > >> > > ?2. Occasional long delays when suspending. When this happens I se

radeon issues on MacBook Pro 8,2

2012-01-20 Thread Seth Forshee
On Thu, Jan 19, 2012 at 02:53:17PM -0600, Seth Forshee wrote: > > > ?2. Occasional long delays when suspending. When this happens I see > > > ? ?messages like following in dmesg: > > > > > > ? ? ?[drm:atom_op_jump] *ERROR* atombios stuck in loop

radeon issues on MacBook Pro 8,2

2012-01-19 Thread Seth Forshee
On Thu, Jan 19, 2012 at 02:48:52PM -0500, Alex Deucher wrote: > On Thu, Jan 19, 2012 at 12:18 PM, Seth Forshee > wrote: > > I'm seeing several issues related to the radeon driver on a MacBook Pro > > 8,2 with the following graphics card: > > > > ?ATI Technologies Inc

radeon issues on MacBook Pro 8,2

2012-01-19 Thread Seth Forshee
I'm seeing several issues related to the radeon driver on a MacBook Pro 8,2 with the following graphics card: ATI Technologies Inc Whistler [AMD Radeon HD 6600M Series] [1002:6741] All problems were observed when using kernel version 3.2.1. None are seen when using fglrx. 1. Excessive power

Re: radeon issues on MacBook Pro 8,2

2012-01-19 Thread Seth Forshee
On Thu, Jan 19, 2012 at 02:48:52PM -0500, Alex Deucher wrote: On Thu, Jan 19, 2012 at 12:18 PM, Seth Forshee seth.fors...@canonical.com wrote: I'm seeing several issues related to the radeon driver on a MacBook Pro 8,2 with the following graphics card:  ATI Technologies Inc Whistler [AMD