Re: [PATCH 3/7] ARM: configs: imx_v6_v7: Enable DRM_DW_HDMI

2024-04-21 Thread Shawn Guo
e > sure it's still enabled. > > Fixes: 4fc8cb47fcfd ("drm/display: Move HDMI helpers into display-helper > module") > Reported-by: Mark Brown > Reported-by: Alexander Stein > Signed-off-by: Maxime Ripard Acked-by: Shawn Guo

Re: [PATCH RFC for upstream 4/4] arm64: defconfig: enable i.MX8MP ldb bridge

2024-02-06 Thread Shawn Guo
On Fri, Jan 26, 2024 at 09:57:26AM +0100, Yannic Moog wrote: > Enable the i.MX8MP LDB driver used for display support of the i.MX8MP > LVDS interface. > > Signed-off-by: Yannic Moog Applied, thanks!

Re: [PATCH RFC for upstream 3/4] arm64: dts: imx8mp-phyboard-pollux-rdk: add etml panel support

2024-02-06 Thread Shawn Guo
On Fri, Jan 26, 2024 at 09:57:25AM +0100, Yannic Moog wrote: > The imx8mp-phyboard-pollux has on-board lvds interface connections. An > edt,etml1010g3dra panel is supported for this interface. Add device tree > nodes for backlight and panel. > > Signed-off-by: Yannic Moog Applied, thanks!

Re: [PATCH 2/2] ARM: dts: imx7: add MIPI-DSI support

2023-12-05 Thread Shawn Guo
On Mon, Nov 27, 2023 at 05:12:29PM +0100, Roland Hieber wrote: > From: Marco Felsch > > This adds the device tree support for the MIPI-DSI block. The block can > be used as encoder for the parallel signals coming from the lcdif block. > > Signed-off-by: Marco Felsch > Signed-off-by: Roland

Re: [PATCH 2/2] ARM: dts: imx: add support for the ATM0700D4 panel attached to sk-imx53

2023-09-24 Thread Shawn Guo
On Sun, Aug 27, 2023 at 12:54:29AM +0300, Dmitry Baryshkov wrote: > The SK-ATM0700D4-Plug is an extension board (provided by the same > manufacturer, [1]) which can be connected to the SK-IMX53 panel kit. The > panel can be connected either using the RGB parallel bus or using the > LVDS connector

Re: [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros

2023-01-24 Thread Shawn Guo
On Thu, Jun 16, 2022 at 01:14:07AM +0300, Laurent Pinchart wrote: > Now that a header exists with macros for the media interface bus-type > values, replace hardcoding numerical constants with the corresponding > macros in the DT sources. > > Signed-off-by: Laurent Pinchart Applied, thanks!

Re: [PATCH v1 8/8] ARM: dts: imx6qdl-victgo: add CAN termination support

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:12AM +0100, Oleksij Rempel wrote: > From: David Jander > > The gpio1 0 pin is controlling CAN termination, not USB H1 VBUS. So, > remove wrong regulator and assign this gpio to new DT CAN termination > property. > > Signed-off-by: David Jander > Signed-off-by:

Re: [PATCH v1 7/8] ARM: dts: imx6dl-victgo: The TGO uses a lg,lb070wv8 compatible 7" display

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:11AM +0100, Oleksij Rempel wrote: > From: Robin van der Gracht > > This series of devices is using lg,lb070wv8 instead of kyo,tcg121xglp. > > Signed-off-by: Robin van der Gracht > Signed-off-by: Oleksij Rempel Applied, thanks!

Re: [PATCH v1 6/8] ARM: dts: imx6dl-victgo: Add interrupt-counter nodes

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:10AM +0100, Oleksij Rempel wrote: > From: Robin van der Gracht > > Interrupt counter is mainlined, now we can add missing counter nodes. > > Signed-off-by: Robin van der Gracht > Signed-off-by: Oleksij Rempel Applied, thanks!

Re: [PATCH v1 4/8] ARM: dts: imx6qdl-vicut1: update gpio-line-names for some GPIOs

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:08AM +0100, Oleksij Rempel wrote: > From: David Jander > > countedX lines have different board names (YACO_x). And REV_ and BOARD_ pins > have multiple functions. So, use names exposed to the OS. > > Signed-off-by: David Jander > Signed-off-by: Oleksij Rempel

Re: [PATCH v1 3/8] ARM: dts: imx6qdl-vicut1/vicutgo: Add backlight_led node

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:07AM +0100, Oleksij Rempel wrote: > From: David Jander > > backlight_led is the dimmable backlight for the rubber border on the case. It > is also used to highlight the power- and some other buttons. > > MX6QDL_PAD_SD4_DAT1__PWM3_OUT is also assigned as output for

Re: [PATCH v1 2/8] ARM: dts: imx6qdl-vicut1/vicutgo: Rename backlight to backlight_lcd

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:06AM +0100, Oleksij Rempel wrote: > From: David Jander > > We have two backlight sources on this boards. Use more specific name for > the LCD backlight to see the difference. > > Signed-off-by: David Jander > Signed-off-by: Robin van der Gracht > Signed-off-by:

Re: [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote: > From: David Jander > > Recover default behavior of the device and set maximal brightness > > Signed-off-by: David Jander > Signed-off-by: Oleksij Rempel Applied, thanks!

Re: [PATCH v1 5/8] ARM: dts: imx6qdl-vicut1/vicutgo: The sgtl5000 uses i2s not ac97

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:09AM +0100, Oleksij Rempel wrote: > From: Robin van der Gracht > > According to Documentation/devicetree/bindings/sound/fsl,ssi.txt > 'fsl,mode' should be specified for AC97 mode only. > > The 'fsl,ssi' documentation doesn't say anything about specifying >

Re: [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum

2022-04-05 Thread Shawn Guo
On Wed, Apr 6, 2022 at 9:23 AM Shawn Guo wrote: > > On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote: > > From: David Jander > > > > Recover default behavior of the device and set maximal brightness > > > > Signed-off-by: David Jande

Re: [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote: > From: David Jander > > Recover default behavior of the device and set maximal brightness > > Signed-off-by: David Jander > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/imx6dl-victgo.dts | 2 +- >

Re: [PATCH v3 3/5] ARM: dts: imx6qdl-vicut1: add CAN termination support

2022-02-12 Thread Shawn Guo
On Fri, Feb 11, 2022 at 02:30:33PM +0100, Oleksij Rempel wrote: > The gpio1 0 pin is controlling CAN termination, not USB H1 VBUS. So, > remove wrong regulator and assign this gpio to new DT CAN termnation Sigh, the typo is still there with a new version. Fixed it up and applied the series.

Re: [PATCH v2 2/5] ARM: dts: imx6dl-prtvt7: Add missing tvp5150 video decoder node

2022-02-11 Thread Shawn Guo
On Mon, Jan 31, 2022 at 11:28:38AM +0100, Oleksij Rempel wrote: > From: Robin van der Gracht > > Signed-off-by: Robin van der Gracht Please write up some commit log. Also your SoB is missing. Shawn > --- > arch/arm/boot/dts/imx6dl-prtvt7.dts | 42 + > 1 file

Re: [PATCH v1 4/4] ARM: dts: imx6dl: plym2m, prtvt7, victgo: make use of new resistive-adc-touch driver

2022-01-25 Thread Shawn Guo
On Wed, Jan 05, 2022 at 12:04:34PM +0100, Oleksij Rempel wrote: > Hi Shawn, > > sorry for the delay, I just came back to work. > > On Mon, Dec 06, 2021 at 09:06:28AM +0800, Shawn Guo wrote: > > On Mon, Nov 22, 2021 at 01:43:10PM +0100, Oleksij Rempel wrote: > > &

Re: [PATCH v1 4/4] ARM: dts: imx6dl: plym2m, prtvt7, victgo: make use of new resistive-adc-touch driver

2021-12-06 Thread Shawn Guo
On Mon, Nov 22, 2021 at 01:43:10PM +0100, Oleksij Rempel wrote: > The tsc2046 is an ADC used as touchscreen controller. To share as mach > code as possible, we should use it as actual ADC + virtual tochscreen > controller. > With this patch we make use of the new kernel IIO and HID infrastructure.

Re: [PATCH v1 2/4] ARM: dts: imx6dl-prtvt7: Add missing tvp5150 video decoder node

2021-12-06 Thread Shawn Guo
On Mon, Nov 22, 2021 at 01:43:08PM +0100, Oleksij Rempel wrote: > From: Robin van der Gracht > > Signed-off-by: Robin van der Gracht > --- > arch/arm/boot/dts/imx6dl-prtvt7.dts | 40 + > 1 file changed, 40 insertions(+) > > diff --git

Re: [PATCH v2 2/2] drm/panel: Add Sony Tulip Truly NT35521 driver

2021-09-21 Thread Shawn Guo
On Tue, Aug 24, 2021 at 09:59:04PM +0200, Sam Ravnborg wrote: > On Tue, Aug 24, 2021 at 10:58:31AM +0800, Shawn Guo wrote: > > On Mon, Aug 09, 2021 at 01:10:08PM +0800, Shawn Guo wrote: > > > It adds a DRM panel driver for Sony Tulip Truly NT35521 5.24" 1280x720 > > &g

Re: [PATCH v2 2/2] drm/panel: Add Sony Tulip Truly NT35521 driver

2021-08-23 Thread Shawn Guo
On Mon, Aug 09, 2021 at 01:10:08PM +0800, Shawn Guo wrote: > It adds a DRM panel driver for Sony Tulip Truly NT35521 5.24" 1280x720 > DSI panel, which can be found on Sony Xperia M4 Aqua phone. The panel > backlight is managed through DSI link. > > The driver is built using

Re: [PATCH v34 0/3] Mainline imx6 based SKOV boards

2021-08-13 Thread Shawn Guo
On Wed, Aug 04, 2021 at 06:34:36AM +0200, Oleksij Rempel wrote: > changes v4: > - add vref-supply to adc@0 > - split gpio assignment for the mdio node > > changes v3: > - drop panel bindings patches, it is already in drm-misc-next > - remove some new lines > - reorder compatibles at the start of

Re: [PATCH 1/2] dt-bindings: display: panel: Add Truly NT35521 panel support

2021-08-13 Thread Shawn Guo
On Wed, Aug 11, 2021 at 12:51:56PM -0600, Rob Herring wrote: > On Wed, Aug 04, 2021 at 04:13:51PM +0800, Shawn Guo wrote: > > The Truly NT35521 is a 5.24" 1280x720 DSI panel, and the backlight is > > managed through DSI link. > > > > Signed-off-by: Shawn Guo &

[PATCH v2 2/2] drm/panel: Add Sony Tulip Truly NT35521 driver

2021-08-08 Thread Shawn Guo
GPIOs with regulators and adding Backlight GPIO support. [1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator Signed-off-by: Shawn Guo --- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile| 1 + .../panel/panel-sony-

[PATCH v2 1/2] dt-bindings: display: Add Sony Tulip Truly NT35521 panel support

2021-08-08 Thread Shawn Guo
The Sony Tulip Truly NT35521 is a 5.24" 1280x720 DSI panel, which can be found on Sony Xperia M4 Aqua phone. The backlight is managed through DSI link. Signed-off-by: Shawn Guo --- .../panel/sony,tulip-truly-nt35521.yaml | 72 +++ 1 file changed, 72 insertions(+) c

[PATCH v2 0/2] Add Sony Tulip Truly NT35521 panel support

2021-08-08 Thread Shawn Guo
el 5V control GPIOs with regulators. - Rename Backlight GPIO as "backlight-gpios". [1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator Shawn Guo (2): dt-bindings: display: Add Sony Tulip Truly NT35521 panel support drm/panel: Add Sony Tulip Truly NT35521 driver

Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-08 Thread Shawn Guo
On Sun, Aug 08, 2021 at 05:29:30PM +0200, Stephan Gerhold wrote: > > 2) The driver works good, if the kernel is launched via "fastboot boot". > >But if the kernel is flashed to eMMC and launched by bootloader with > >splash screen, kernel will fail to bring up the panel. After kernel > >

Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-08 Thread Shawn Guo
Hi Sam, On Wed, Aug 04, 2021 at 06:24:12PM +0200, Sam Ravnborg wrote: > Hi Shawn, > > see a few comments in the following. Thanks for the review comments! All of them will be addressed in v2. Shawn > On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote: > > It

Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-08 Thread Shawn Guo
Hi Stephan, Thanks for looking at the patch! On Wed, Aug 04, 2021 at 02:09:19PM +0200, Stephan Gerhold wrote: > Hi Shawn, > > Thanks for the patch! > > On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote: > > It adds a drm driver for Truly NT35521 5.24" 1280x72

Re: [PATCH 1/2] dt-bindings: display: panel: Add Truly NT35521 panel support

2021-08-08 Thread Shawn Guo
On Wed, Aug 04, 2021 at 06:03:54PM +0200, Sam Ravnborg wrote: > Hi Shawn, > > On Wed, Aug 04, 2021 at 04:13:51PM +0800, Shawn Guo wrote: > > The Truly NT35521 is a 5.24" 1280x720 DSI panel, and the backlight is > > managed through DSI link. > > > > Signed-o

[PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-04 Thread Shawn Guo
It adds a drm driver for Truly NT35521 5.24" 1280x720 DSI panel, which can be found on Sony Xperia M4 Aqua phone. The panel backlight is managed through DSI link. Signed-off-by: Shawn Guo --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile

[PATCH 1/2] dt-bindings: display: panel: Add Truly NT35521 panel support

2021-08-04 Thread Shawn Guo
The Truly NT35521 is a 5.24" 1280x720 DSI panel, and the backlight is managed through DSI link. Signed-off-by: Shawn Guo --- .../bindings/display/panel/truly,nt35521.yaml | 62 +++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/di

[PATCH 0/2] Add Truly NT35521 panel driver support

2021-08-04 Thread Shawn Guo
It adds a drm driver for Truly NT35521 5.24" 1280x720 DSI panel, which can be found on Sony Xperia M4 Aqua phone. Shawn Guo (2): dt-bindings: display: panel: Add Truly NT35521 panel support drm/panel: Add Truly NT35521 panel driver .../bindings/display/panel/truly,nt35521.yaml

Re: [PATCH v2 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards

2021-07-25 Thread Shawn Guo
On Wed, Jul 14, 2021 at 06:53:49AM +0200, Oleksij Rempel wrote: > From: Sam Ravnborg > > Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards. > > Signed-off-by: Sam Ravnborg > Signed-off-by: Søren Andersen > Signed-off-by: Juergen Borleis > Signed-off-by: Ulrich Ölmann > Signed-off-by:

Re: [PATCH v2 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards

2021-07-22 Thread Shawn Guo
On Sun, Jul 18, 2021 at 10:22:14PM +0200, Sam Ravnborg wrote: > Hi Oleksij, > On Wed, Jul 14, 2021 at 06:53:49AM +0200, Oleksij Rempel wrote: > > From: Sam Ravnborg > > The real author one these dts files are Juergen Borleis IIRC. > I made some internal refactoring / renaming which is why I

Re: [PATCH v1 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards

2021-07-13 Thread Shawn Guo
On Wed, Jun 09, 2021 at 02:10:50PM +0200, Oleksij Rempel wrote: > From: Sam Ravnborg > > Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards. > > Signed-off-by: Sam Ravnborg > Signed-off-by: Søren Andersen > Signed-off-by: Juergen Borleis > Signed-off-by: Ulrich Ölmann > Signed-off-by:

Re: [PATCHv2 5/5] ARM: dts: imx6: Add GE B1x5v2

2021-05-22 Thread Shawn Guo
On Thu, Apr 29, 2021 at 12:29:53AM +0200, Sebastian Reichel wrote: > This adds device tree files for the General Electric Healthcare > (GEHC) B1x5v2 series. All models make use of Congatec's QMX6 module, > which is described in its own device tree include, so that it can > also be used by other

Re: [PATCH v7 0/8] mainline Plymovent M2M and BAS board

2021-01-06 Thread Shawn Guo
On Mon, Dec 07, 2020 at 03:09:31PM +0100, Oleksij Rempel wrote: > changes v7: > - panel-simple.yaml: fix comments and part order > - panel-simple.yaml: invent a product description for the Kyocera tcg070wvlq > panel > > changes v6: > - do more panel-simple.yaml related cleanups > > changes v5:

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2020-12-10 Thread Shawn Guo
Hi Uwe, On Thu, Dec 10, 2020 at 9:05 PM Uwe Kleine-König wrote: > > > @@ -111,6 +118,8 @@ > > > > > > #define SN_LINK_TRAINING_TRIES 10 > > > > > > +#define SN_PWM_GPIO3 > > > > So this maps to the GPIO4 described in sn65dsi86 datasheet. I'm > > wondering if

[PATCH] drm/bridge: ti-sn65dsi86: rename GPIO register bits

2020-12-10 Thread Shawn Guo
From: Shawn Guo It renames GPIO register bits to drop 'SN_' prefix, so that they are consistent to other definitions - prefixing register name with 'SN_' but not for bit fields. Signed-off-by: Shawn Guo --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 26 +- 1 file changed

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2020-12-09 Thread Shawn Guo
On Mon, Dec 07, 2020 at 10:40:22PM -0600, Bjorn Andersson wrote: > The SN65DSI86 provides the ability to supply a PWM signal on GPIO 4, > with the primary purpose of controlling the backlight of the attached > panel. Add an implementation that exposes this using the standard PWM > framework, to

Re: [PATCH] Revert "i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630"

2020-11-29 Thread Shawn Guo
> Disable DMA processing on the Lenovo Yoga C630")'. > > Signed-off-by: Bjorn Andersson Acked-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-21 Thread Shawn Guo
On Mon, Oct 19, 2020 at 05:48:29PM +0200, Daniel Vetter wrote: > On Fri, Oct 16, 2020 at 07:46:41PM +0800, Shawn Guo wrote: > > Indeed! Adding drm_crtc_vblank_reset() into driver crtc reset hook > > removes the WARNING for me. Really appreciate your comments, Daniel! >

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Shawn Guo
On Fri, Oct 16, 2020 at 11:30:04AM +0200, Daniel Vetter wrote: > On Fri, Oct 16, 2020 at 10:54 AM Shawn Guo wrote: > > > > On Fri, Oct 16, 2020 at 09:58:46AM +0200, Daniel Vetter wrote: > > > On Fri, Oct 16, 2020 at 9:13 AM Shawn Guo wrote: > > > > > >

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Shawn Guo
On Fri, Oct 16, 2020 at 09:58:46AM +0200, Daniel Vetter wrote: > On Fri, Oct 16, 2020 at 9:13 AM Shawn Guo wrote: > > > > Commit 5caa0feafcc6 ("drm/vblank: Lock down vblank->hwmode more") added > > WARN_ON_ONCE() for atomic drivers to warn the case that vsync is

[PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Shawn Guo
ting services may treat kernel WARNINGS as crashes. Let's drop WARN_ON_ONCE() and change drm_dbg_core() to drm_warn_once() for warning undefined mode timing. Signed-off-by: Shawn Guo --- drivers/gpu/drm/drm_vblank.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

Re: [PATCH 03/13] dt-bindings: arm: fsl: Fix matching Purism Librem5 phones

2020-09-21 Thread Shawn Guo
On Fri, Sep 04, 2020 at 04:53:02PM +0200, Krzysztof Kozlowski wrote: > All Purism Librem5 phones have three compatibles so they need their own > entry to fix dbts_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: /: > compatible: ['purism,librem5r2',

Re: [PATCH 08/13] arm64: dts: imx8mm-var-som-symphony: Use newer interrupts property

2020-09-12 Thread Shawn Guo
On Fri, Sep 04, 2020 at 04:53:07PM +0200, Krzysztof Kozlowski wrote: > The int-gpios was deprecated in favor of generic interrupts property. > > Signed-off-by: Krzysztof Kozlowski Applied patch #8 ~ #13, thanks. ___ dri-devel mailing list

Re: [PATCH for v5.9] ARM: dts: mxs: Replace HTTP links with HTTPS ones

2020-07-19 Thread Shawn Guo
> Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov s/mxs/imx in the subject. Otherwise: Acked-by: Shawn Guo > --- > Continuing my work started at 93431e0607e5. > See also: git log --oneline '--author=Alexander A. Klimov > ' v5.7..master

Re: [PATCH v2] drm/atomic_helper: add a flag for duplicating drm_private_obj state

2020-07-11 Thread Shawn Guo
On Sat, Jun 27, 2020 at 7:53 PM Shawn Guo wrote: > > From: Shawn Guo > > The msm/mdp5 driver uses state of drm_private_obj as its global atomic > state, which keeps the assignment of hwpipe to plane. With > drm_private_obj missing from duplicate state call in context of atomi

[PATCH v2] drm/atomic_helper: add a flag for duplicating drm_private_obj state

2020-06-27 Thread Shawn Guo
From: Shawn Guo The msm/mdp5 driver uses state of drm_private_obj as its global atomic state, which keeps the assignment of hwpipe to plane. With drm_private_obj missing from duplicate state call in context of atomic suspend/resume helpers, mdp5 suspend works with no problem only for the very

[PATCH] drm/atomic_helper: duplicate state for drm_private_obj

2020-06-25 Thread Shawn Guo
From: Shawn Guo The msm/mdp5 driver uses drm_private_obj as its global atomic state, which keeps the assignment of hwpipe to plane. With drm_private_obj missing from duplicate state call, mdp5 suspend works with no problem only for the very first time. Any subsequent suspend will hit

Re: [PATCH v1 1/3] drm/msm: Attach the IOMMU device during initialization

2020-05-23 Thread Shawn Guo
On Fri, May 22, 2020 at 04:03:14PM -0600, Jordan Crouse wrote: > diff --git a/drivers/gpu/drm/msm/msm_gpummu.c > b/drivers/gpu/drm/msm/msm_gpummu.c > index 34980d8eb7ad..0ad0f848560a 100644 > --- a/drivers/gpu/drm/msm/msm_gpummu.c > +++ b/drivers/gpu/drm/msm/msm_gpummu.c > @@ -21,11 +21,6 @@

Re: [PATCH v1 0/3] drm/msm: Cleanups ahead of per-instance pagetables

2020-05-23 Thread Shawn Guo
ress space initialization > drm/msm: Update the MMU helper function APIs FWIW, on A405 with glmark2: Tested-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/4] ARM: dts: ims53: Group port definitions for the dvi-converter

2020-05-19 Thread Shawn Guo
On Thu, May 14, 2020 at 04:36:10PM +0200, Ricardo Cañuelo wrote: > Group the port definitions of the dvi-converter in a 'ports' node to > make it compliant with the ti,tfp410 binding. > > Signed-off-by: Ricardo Cañuelo s/ims53/imx53-cx9020 in subject. I fixed it up and applied the patch.

Re: [PATCH] drm/zte: remove unneeded semicolon

2020-05-19 Thread Shawn Guo
> > Signed-off-by: Jason Yan Acked-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Freedreno] [v2 PATCH] drivers: gpu: drm: Add MDP5 configuration for MSM8x36.

2020-05-09 Thread Shawn Guo
git log of file/folder changed here. Other than that: Reviewed-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] drm/msm/a4xx: add a405_registers for a405 device

2020-05-09 Thread Shawn Guo
adreno_gpu_init(). Signed-off-by: Shawn Guo --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 53 +-- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a4xx_gpu.c b/drivers/gpu/drm/msm/adreno/a4xx_gpu.c index 70de59751188..9e244982974e 100644

[PATCH 1/2] drm/msm/a4xx: add adreno a405 support

2020-05-09 Thread Shawn Guo
-by: Shawn Guo --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 29 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 11 drivers/gpu/drm/msm/adreno/adreno_gpu.c| 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h| 5 4 files changed, 34 insertions(+), 13

[PATCH 0/2] Add adreno a405 GPU support

2020-05-09 Thread Shawn Guo
The series adds support for adreno a405 found on MSM8936/MSM8939 and APQ variants. Shawn Guo (2): drm/msm/a4xx: add adreno a405 support drm/msm/a4xx: add a405_registers for a405 device drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 82 ++ drivers/gpu/drm/msm/adreno

Re: [PATCH] drivers: gpu: drm: Add MDP5 configuration for MSM8x36 and its derivatives, such as MSM8939.

2020-05-08 Thread Shawn Guo
Hi Konrad, On Fri, May 01, 2020 at 10:51:59PM +0200, Konrad Dybcio wrote: > Signed-off-by: Konrad Dybcio Please write up some commit log. Since this is based on msm8x16_config, maybe document the differences from it in commit log? > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 70

Re: [PATCH] backlight: l4f00242t03: Convert to GPIO descriptors

2020-04-28 Thread Shawn Guo
t;enable" and "reset" as found in > the device tree bindings for panel GPIOs. > > This saves a lot of code in the driver and makes it possible > to get rid of the platform data header altogether. > > Cc: Sascha Hauer > Cc: Anson Huang > Cc: Shawn Guo > Cc:

Re: [PATCH 07/11] dts: arm64: layerscape: add dma-ranges property to qoric-mc node

2019-10-14 Thread Shawn Guo
On Mon, Oct 14, 2019 at 12:00:25PM +0200, Nicolas Saenz Julienne wrote: > On Mon, 2019-10-14 at 16:28 +0800, Shawn Guo wrote: > > On Tue, Sep 24, 2019 at 08:12:38PM +0200, Nicolas Saenz Julienne wrote: > > > qoriq-mc's dpmacs DMA configuration is inherited from their parent node

Re: [PATCH 08/11] dts: arm64: layerscape: add dma-ranges property to pcie nodes

2019-10-14 Thread Shawn Guo
On Tue, Sep 24, 2019 at 08:12:39PM +0200, Nicolas Saenz Julienne wrote: > The bus behind the board's PCIe core has DMA addressing limitations. Add > an empty 'dma-ranges' property on all PCIe bus descriptions to inform > the OF core that a translation is due further down the line. > >

Re: [PATCH 07/11] dts: arm64: layerscape: add dma-ranges property to qoric-mc node

2019-10-14 Thread Shawn Guo
On Tue, Sep 24, 2019 at 08:12:38PM +0200, Nicolas Saenz Julienne wrote: > qoriq-mc's dpmacs DMA configuration is inherited from their parent node, > which acts a bus in this regard. So far it maked all devices as > dma-coherent but no dma-ranges recommendation is made. > > The truth is that the

Re: [PATCH v2 1/2] dts: arm64: imx8mq: Enable gpu passive throttling

2019-10-06 Thread Shawn Guo
On Wed, Sep 11, 2019 at 07:40:35PM -0700, Guido Günther wrote: > Temperature and hysteresis were picked after the CPU. > > Signed-off-by: Guido Günther The patch prefix should be 'arm64: dts: ...' I fixed it up and applied the patch. Shawn > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi |

Re: [PATCH v2 2/2] dt-bindings: etnaviv: Add #cooling-cells

2019-10-06 Thread Shawn Guo
On Mon, Sep 16, 2019 at 04:32:55PM +0200, Lucas Stach wrote: > On Mi, 2019-09-11 at 19:40 -0700, Guido Günther wrote: > > Add #cooling-cells for when the gpu acts as a cooling device. > > > > Signed-off-by: Guido Günther > > Reviewed-by: Lucas Stach Lucas, I assume you will pick it up.

Re: [PATCH v4 13/23] drm: zte: Provide ddc symlink in vga connector sysfs directory

2019-07-23 Thread Shawn Guo
On Thu, Jul 11, 2019 at 01:26:40PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freede

Re: [PATCH v4 12/23] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

2019-07-22 Thread Shawn Guo
On Thu, Jul 11, 2019 at 01:26:39PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freede

Re: [PATCH v1 10/33] drm/zte: drop use of drmP.h

2019-07-18 Thread Shawn Guo
On Sun, Jun 30, 2019 at 08:18:59AM +0200, Sam Ravnborg wrote: > Drop use of the deprecated drmP.h header file. > Fix fallout. > > Signed-off-by: Sam Ravnborg > Cc: Shawn Guo > Cc: David Airlie > Cc: Daniel Vetter Acked-by: Shawn Guo

Re: [PATCH 39/59] drm/zte: Drop drm_gem_prime_export/import

2019-06-18 Thread Shawn Guo
On Fri, Jun 14, 2019 at 10:35:55PM +0200, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: Shawn Guo Acked-by: Shawn Guo > --- > drivers/g

Re: [EXT] Re: [PATCH 0/2] drm: imx: Add NWL MIPI DSI host controller support

2019-05-28 Thread Shawn Guo
Hi Laurentiu, On Tue, May 28, 2019 at 07:03:54AM +, Laurentiu Palcu wrote: > Hi Shawn, Lucas, > > On Tue, May 28, 2019 at 09:38:02AM +0800, Shawn Guo wrote: > > Caution: EXT Email > > > > Hi Lucas, > > > > On Mon, May 27, 2019 at 03:36:53PM +0200

Re: [PATCH 0/2] drm: imx: Add NWL MIPI DSI host controller support

2019-05-27 Thread Shawn Guo
Hi Lucas, On Mon, May 27, 2019 at 03:36:53PM +0200, Lucas Stach wrote: > We have been looking at how to support DCSS in mainline for a while, > but most of the actual work got pushed behind in schedule due to other > priorities. I have some time to contribute. Would you suggest how I should

Re: [PATCH 0/2] drm: imx: Add NWL MIPI DSI host controller support

2019-05-26 Thread Shawn Guo
On Wed, May 08, 2019 at 07:18:27PM +0200, Guido Günther wrote: > If somebody is working on DCSS support it'd be cool to know since this I have some time slots here and will start looking at it, if no one else is already working on it. Shawn > driver is currently a component of

Re: [PATCH] ARM: imx_v6_v7_defconfig: Enable CONFIG_PWM_IMX27

2019-03-21 Thread Shawn Guo
On Thu, Mar 21, 2019 at 10:49:03AM +0100, Uwe Kleine-König wrote: > Hello, > > On Wed, Mar 20, 2019 at 01:01:26PM +, Leonard Crestez wrote: > > Commit d80f8206905c ("pwm: imx: Split into two drivers") also adds a new > > CONFIG_PWM_IMX27 for the PWM block on recent IMX chips and we should > >

Re: [PATCH v1 0/4] ARM: dts: ccimx6ulsbcpro: Add 10" AUO/Goodix LVDS panel accessory kit

2018-12-04 Thread Shawn Guo
On Thu, Oct 25, 2018 at 05:09:29PM +0200, Alex Gonzalez wrote: > Alex Gonzalez (4): > drm/panel: simple: Add AUO G101EVN010 panel support > ARM: dts: ccimx6ulsbcpro: Enable AUO G101EVN010 lcdif panel > ARM: imx_v6_v7_defconfig: Select TOUCHSCREEN_GOODIX > ARM: dts: ccimx6ulsbcpro: Add

Re: [PATCH 3/9] drm: replace "drm_dev_unref" function with "drm_dev_put"

2018-11-19 Thread Shawn Guo
On Thu, Nov 15, 2018 at 11:16:23PM +0100, Fernando Ramos wrote: > This patch unifies the naming of DRM functions for reference counting as > requested on Documentation/gpu/todo.rst > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/arc/arcpgu_drv.c | 4 ++-- >

Re: [PATCH v2 3/4] PCI: imx: Add multi-pd support

2018-11-19 Thread Shawn Guo
On Fri, Nov 16, 2018 at 12:25:41PM +, Lorenzo Pieralisi wrote: > On Mon, Oct 08, 2018 at 06:06:21PM +, Leonard Crestez wrote: > > On some chips the PCIE and PCIE_PHY blocks are in separate power domains > > which can be power-gated independently. The pci driver needs to handle > > this by

Re: [PATCH v1 0/4] ARM: dts: ccimx6ulsbcpro: Add 10" AUO/Goodix LVDS panel accessory kit

2018-11-04 Thread Shawn Guo
On Thu, Oct 25, 2018 at 05:09:29PM +0200, Alex Gonzalez wrote: > Alex Gonzalez (4): > drm/panel: simple: Add AUO G101EVN010 panel support > ARM: dts: ccimx6ulsbcpro: Enable AUO G101EVN010 lcdif panel > ARM: imx_v6_v7_defconfig: Select TOUCHSCREEN_GOODIX > ARM: dts: ccimx6ulsbcpro: Add

Re: [PATCH v2 4/4] ARM: dts: imx6sx: Add DISPLAY power domain support

2018-11-03 Thread Shawn Guo
On Wed, Oct 31, 2018 at 12:17:50PM +, Leonard Crestez wrote: > On 10/31/2018 8:12 AM, Shawn Guo wrote: > > On Mon, Oct 08, 2018 at 06:06:23PM +, Leonard Crestez wrote: > >> This was implemented in the driver but not actually defined and > >> referenced i

Re: [PATCH v2 4/4] ARM: dts: imx6sx: Add DISPLAY power domain support

2018-10-31 Thread Shawn Guo
On Mon, Oct 08, 2018 at 06:06:23PM +, Leonard Crestez wrote: > This was implemented in the driver but not actually defined and > referenced in dts. This makes it always on. > > From reference manual in section "10.4.1.4.1 Power Distribution": > > "Display domain - The DISPLAY domain contains

Re: [PATCH v2 1/4] soc: imx: gpc: Increase GPC_CLK_MAX to 7

2018-10-31 Thread Shawn Guo
On Mon, Oct 08, 2018 at 06:06:19PM +, Leonard Crestez wrote: > The DISPLAY power domain on imx6sx has 7 clocks. > > Signed-off-by: Leonard Crestez Applied, thanks. ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH 2/3] PCI: imx: Add multi-pd support

2018-10-07 Thread Shawn Guo
On Mon, Oct 01, 2018 at 11:56:17PM +0300, Leonard Crestez wrote: > On some chips the PCIE and PCIE_PHY blocks are in separate power domains > which can be power-gated independently. The driver needs to handle this > by keeping both domain active. > > This is intended for imx6sx where PCIE is in

Re: [PATCH 14/21] drm/zte: Use drm_atomic_helper_shutdown

2018-10-05 Thread Shawn Guo
should > use drm_atomic_helper_shutdown() instead. > > Reviewed-by: Ville Syrjälä > Signed-off-by: Daniel Vetter > Cc: Shawn Guo Acked-by: Shawn Guo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RESEND PATCH] drm/zte: Replace drm_dev_unref with drm_dev_put

2018-09-30 Thread Shawn Guo
ermann > Acked-by: Shawn Guo Pushed to drm-misc-next, thanks. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

2018-09-19 Thread Shawn Guo
On Tue, Sep 18, 2018 at 05:19:09PM +0200, Daniel Vetter wrote: > On Mon, Aug 27, 2018 at 9:18 AM, Shawn Guo wrote: > > On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote: > >> for_each_available_child_of_node will get and put the node properly, > >> the foll

Re: [PATCH 19/20] drm/zte: Use drm_fbdev_generic_setup()

2018-09-09 Thread Shawn Guo
his is done to highlight the fact that fbdev emulation is an > internal client that makes use of the driver, it is not part of the > driver as such. If fbdev setup fails, an error is printed, but the driver > succeeds probing. > > Cc: Shawn Guo >

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

2018-08-27 Thread Shawn Guo
On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote: > for_each_available_child_of_node will get and put the node properly, > the following of_node_put will lead to the double put. So just > remove it. > > Signed-off-by: zhong jiang Acke

Re: [PATCH] drm/zte: Replace drm_dev_unref with drm_dev_put

2018-07-18 Thread Shawn Guo
mermann Acked-by: Shawn Guo > --- > drivers/gpu/drm/zte/zx_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c > b/drivers/gpu/drm/zte/zx_drm_drv.c > index 6f4205e80378..02ae1caf6e8a 100644 > --- a/drivers/g

Re: [PATCH v2] ARM: dts: imx6sl: Add vivante gpu nodes

2018-07-17 Thread Shawn Guo
On Fri, Jul 13, 2018 at 12:39:35PM +0300, Leonard Crestez wrote: > The imx6sl soc has gpu_2d and gpu_vg, no 3d support: > > etnaviv-gpu 220.gpu: model: GC320, revision: 5007 > etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215 > > The IP blocks seem to be already supported. > >

Re: [PATCH v4 6/7] ARM: dts: Add support for emtrion emCON-MX6 series

2018-05-04 Thread Shawn Guo
On Thu, May 03, 2018 at 12:00:06PM +0200, Türk, Jan wrote: > > > +/ { > > > + aliases { > > > + mmc0 = > > > + mmc2 = > > > + mmc1 = > > > + mmc3 = > > > + boardID = > > > > Why do you need this boardID alias? > I wanted to have a generic

Re: [PATCH v4 6/7] ARM: dts: Add support for emtrion emCON-MX6 series

2018-04-27 Thread Shawn Guo
On Fri, Apr 27, 2018 at 03:24:41PM +0200, jan.tu...@emtrion.com wrote: > From: Jan Tuerk > > This patch adds support for the emtrion GmbH emCON-MX6 modules. > They are available with imx.6 Solo, Dual-Lite, Dual and Quad > equipped with Memory from 512MB to 2GB (configured

Re: [PATCH v4 0/7] Add basic support for emtrion emCON-MX6 modules

2018-04-27 Thread Shawn Guo
On Fri, Apr 27, 2018 at 03:24:35PM +0200, jan.tu...@emtrion.com wrote: > From: Jan Tuerk > > Changes for v4: > - re-arrange the Patch-series to match the DT-submitting-patches > - Additional patch for the Documentation of the new DT-bindings > > [PATCH v4 1/7]

Re: [PATCH v3 5/6] ARM: dts: Add support for emtrion emCON-MX6 series

2018-04-23 Thread Shawn Guo
On Fri, Apr 20, 2018 at 02:50:52PM +0200, jan.tu...@emtrion.com wrote: > From: Jan Tuerk > > This patch adds support for the emtrion GmbH emCON-MX6 modules. > They are available with imx.6 Solo, Dual-Lite, Dual and Quad > equipped with Memory from 512MB to 2GB (configured

Re: [PATCH v2 13/23] drm/zte: Stop consulting plane->fb

2018-03-26 Thread Shawn Guo
t log? Other than that: Acked-by: Shawn Guo <shawn...@kernel.org> > > v2: Use old_state->crtc (Maarten) > > Cc: Shawn Guo <shawn...@kernel.org> > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux

Re: [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()'

2018-03-12 Thread Shawn Guo
ff-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Shawn Guo <shawn...@kernel.org> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] fix double ;;s in code

2018-02-24 Thread Shawn Guo
On Sat, Feb 24, 2018 at 09:52:27AM +0100, Pavel Machek wrote: > Hi! > > > > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > > > index 53f7275..cfb42f5 100644 > > > --- a/drivers/soc/imx/gpc.c > > > +++ b/drivers/soc/imx/gpc.c > > > @@ -348,7 +348,7 @@ static int

Re: [PATCH] fix double ;;s in code

2018-02-22 Thread Shawn Guo
Hi Pavel, On Sat, Feb 17, 2018 at 10:19:55PM +0100, Pavel Machek wrote: ... > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > index 53f7275..cfb42f5 100644 > --- a/drivers/soc/imx/gpc.c > +++ b/drivers/soc/imx/gpc.c > @@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device

  1   2   3   4   >