[PATCH] drm/amd/display: Remove duplicate header.

2022-07-07 Thread Souptick Joarder
From: "Souptick Joarder (HPE)" kernel test robot throws below warning -> includecheck warnings: (new ones prefixed by >>) >> drivers/gpu/drm/amd/display/dc/os_types.h: drm/drm_print.h is included more than once. Remove duplicate header. Reported-by: kernel test robot

[PATCH] drm/amd/display: Removed unused variable ret

2022-06-24 Thread Souptick Joarder
From: "Souptick Joarder (HPE)" Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c: In function 'dc_link_reduce_mst_payload': drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:3782:32: warning: variable 'ret' set but not u

[PATCH] drm/amd/display: Remove unused variable 'abo'

2022-06-17 Thread Souptick Joarder
From: "Souptick Joarder (HPE)" Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9143:27: warning: variable 'abo' set but not used [-Wunused-but-set-variable] Remove the unused variable. Reported-by: Kernel test robot Signed-off

[PATCH] drm/amdgpu: Initialize value of r in amdgpu_fill_buffer()

2022-02-18 Thread Souptick Joarder
From: "Souptick Joarder (HPE)" Kernel test robot reported warning -> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:2129:2: warning: Undefined or garbage value returned to caller [clang-analyzer-core. uninitialized.UndefReturn] Initialize r inside amdgpu_fill_buffer(). Reported-by: kern

Re: [PATCH] drm/msm/dp: Remove unused variable

2021-08-02 Thread Souptick Joarder
On Thu, Jul 15, 2021 at 3:09 AM Stephen Boyd wrote: > > Quoting Souptick Joarder (2021-07-08 19:48:34) > > Kernel test roobot throws below warning -> > > > > drivers/gpu/drm/msm/dp/dp_display.c:1017:21: > > warning: variable 'drm' set but not used [-Wunused-

[PATCH] drm/msm/dp: Remove unused variable

2021-07-08 Thread Souptick Joarder
Kernel test roobot throws below warning -> drivers/gpu/drm/msm/dp/dp_display.c:1017:21: warning: variable 'drm' set but not used [-Wunused-but-set-variable] Removed unused variable drm. Reported-by: kernel test robot Signed-off-by: Souptick Joarder --- drivers/gpu/drm/msm/dp/dp_display.c

[PATCH] drm/rockchip: remove of_match_ptr() from vop_driver_dt_match

2021-06-07 Thread Souptick Joarder
ported-by: kernel test robot Signed-off-by: Souptick Joarder Cc: Robin Murphy --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c index ca7cc8

[PATCH v2] drm/rockchip: remove of_match_ptr()

2021-06-07 Thread Souptick Joarder
ch_ptr(). Reported-by: kernel test robot Signed-off-by: Souptick Joarder Cc: Robin Murphy --- v2: Address review comment from Robin. updated change logs and subject line. drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] drm/rockchip: defined struct rockchip_dp_dt_ids[] under CONFIG_OF

2021-06-07 Thread Souptick Joarder
On Wed, Jun 2, 2021 at 3:37 PM Robin Murphy wrote: > > On 2021-06-02 09:02, Souptick Joarder wrote: > > Kernel test robot throws below warning when CONFIG_OF > > is not set. > > > >>> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:457:34: > > wa

[PATCH] drm/rockchip: defined struct vop_driver_dt_match[] under CONFIG_OF

2021-06-02 Thread Souptick Joarder
under CONFIG_OF. Reported-by: kernel test robot Signed-off-by: Souptick Joarder --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c index ca7cc8

[PATCH] drm/rockchip: defined struct rockchip_dp_dt_ids[] under CONFIG_OF

2021-06-02 Thread Souptick Joarder
fining rockchip_dp_dt_ids[] under CONFIG_OF. Reported-by: kernel test robot Signed-off-by: Souptick Joarder --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c

[PATCH v2] drm/amdgpu: Added missing prototype

2021-04-24 Thread Souptick Joarder
dgpu_amdkfd_arcturus.c:246:5: warning: >> no previous prototype for 'kgd_arcturus_hqd_sdma_destroy' >> [-Wmissing-prototypes] 246 | int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void *mqd, | ^ Added prototype for these functions. Reported-by: kerne

Re: [PATCH] drm/amdgpu: Added missing prototype

2021-04-24 Thread Souptick Joarder
On Sat, Apr 24, 2021 at 5:03 AM Felix Kuehling wrote: > > Am 2021-04-23 um 5:39 p.m. schrieb Souptick Joarder: > > Kernel test robot throws below warning -> > > > >>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:125:5: warning: > >>> no previ

[PATCH] drm/amdgpu: Added missing prototype

2021-04-23 Thread Souptick Joarder
~ Added prototype for these functions. Reported-by: kernel test robot Signed-off-by: Souptick Joarder --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index dc3a692.

[PATCH] drm/amd/display: Remove condition which is always set to True

2021-04-23 Thread Souptick Joarder
if (!(aconnector->port && >mst_port->mst_mgr)) ~~ ~~^~~ Remove the condition which is always set to True. Reported-by: kernel test robot Signed-off-by: Souptick Joarder --- drivers/gpu/drm/amd/display/

[PATCH] drm/amdgpu: Mark mmhub_v1_7_setup_vm_pt_regs() as static

2021-03-12 Thread Souptick Joarder
Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c:56:6: warning: no previous prototype for 'mmhub_v1_7_setup_vm_pt_regs' [-Wmissing-prototypes] Mark mmhub_v1_7_setup_vm_pt_regs() as static. Reported-by: kernel test robot Signed-off-by: Souptick Joar

[PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-22 Thread Souptick Joarder
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9714:7: note: initialize the variable 'i' to silence this warning int i; ^ = 0 1 warning generated. Initialize the variable 'i'. Reported-by: kernel test robot Signed-off-by: Souptick Joarder

[PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static

2021-01-13 Thread Souptick Joarder
ype for function 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes] Mark vangogh_clk_dpm_is_enabled() as static. Reported-by: kernel test robot Signed-off-by: Souptick Joarder --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH] drm/amd/display: Fixed kernel test robot warning

2020-12-14 Thread Souptick Joarder
_dm/amdgpu_dm.c:5373:5: warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes] As these functions are only used inside amdgpu_dm.c, these can be made static. Reported-by: kernel test robot Signed-off-by: Souptick Joarder --- drivers/gpu/drm/amd/disp

[PATCH linux-next] drm/amd/display: Adding prototype for dccg21_update_dpp_dto()

2020-12-14 Thread Souptick Joarder
Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_dccg.c:46:6: warning: no previous prototype for 'dccg21_update_dpp_dto' [-Wmissing-prototypes] Adding prototype for dccg21_update_dpp_dto(). Reported-by: kernel test robot Signed-off-by: Soupt

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-06-09 Thread Souptick Joarder
On Fri, May 29, 2020 at 12:58 PM John Hubbard wrote: > > On 2020-05-28 23:49, Souptick Joarder wrote: > ... > >> This is what case 3 was *intended* to cover, but it looks like case 3 > >> needs to > >> be written a little better. I'll attempt that,

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-30 Thread Souptick Joarder
On Thu, May 28, 2020 at 12:37 AM John Hubbard wrote: > > On 2020-05-27 01:51, Daniel Vetter wrote: > > On Wed, May 27, 2020 at 10:48:52AM +0200, Daniel Vetter wrote: > >> On Tue, May 26, 2020 at 03:57:45PM -0700, John Hubbard wrote: > >>> On 2020-05

[PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-27 Thread Souptick Joarder
basically, this is a small part of fixing a long-standing disconnect between pinning pages, and file systems' use of those pages. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages": https://lwn.net/Articles/807108/ Signed-off-by: Souptick Joarder C

Re: [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-23 Thread Souptick Joarder
Hi John, On Tue, May 19, 2020 at 5:51 AM John Hubbard wrote: > > This needs to go through Andrew's -mm tree, due to adding a new gup.c > routine. However, I would really love to have some testing from the > drm/i915 folks, because I haven't been able to run-time test that part > of it. > >

Re: [PATCH] video/fbdev/matroxfb: Remove dead code

2020-05-04 Thread Souptick Joarder
On Sun, May 3, 2020 at 11:10 PM Sam Ravnborg wrote: > > Hi Souptick > > On Sat, May 02, 2020 at 03:28:11AM +0530, Souptick Joarder wrote: > > These are dead code since 3.15. If there is no plan to use it further > > it can be removed forever. > Could you explain why you

Re: [Nouveau] [PATCH] drm/nouveau/dispnv04: Remove dead code

2020-05-02 Thread Souptick Joarder
0, 2020 at 4:19 PM Souptick Joarder wrote: > > > > These are dead code since 3.10. If there is no plan to use > > it further, these can be removed forever. > > > > Signed-off-by: Souptick Joarder > > --- > > drivers/gpu/drm/nouveau/dispnv04/crtc.c

[PATCH] video/fbdev/matroxfb: Remove dead code

2020-05-02 Thread Souptick Joarder
These are dead code since 3.15. If there is no plan to use it further it can be removed forever. Signed-off-by: Souptick Joarder --- drivers/video/fbdev/matrox/matroxfb_DAC1064.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c b

[PATCH] drm/nouveau/dispnv04: Remove dead code

2020-05-01 Thread Souptick Joarder
These are dead code since 3.10. If there is no plan to use it further, these can be removed forever. Signed-off-by: Souptick Joarder --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv04

[PATCH] drm/gma500: Remove dead code

2020-04-21 Thread Souptick Joarder
These are dead code since 3.7. If there is no plan to use them further, these can be removed forever. Signed-off-by: Souptick Joarder --- drivers/gpu/drm/gma500/cdv_intel_dp.c| 31 + drivers/gpu/drm/gma500/cdv_intel_lvds.c | 83 --- drivers/gpu/drm

[PATCH] video/fbdev/riva: Remove dead code

2020-04-21 Thread Souptick Joarder
These are dead code since 3.15. These can be removed forever if no plan to use it further. Signed-off-by: Souptick Joarder --- drivers/video/fbdev/riva/riva_hw.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva

[PATCH] video: fbdev: radeon: Remove dead code

2020-02-19 Thread Souptick Joarder
This is dead code since 3.15 and can be removed if not going to be useful further. Signed-off-by: Souptick Joarder --- drivers/video/fbdev/aty/radeon_base.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty

Re: [PATCH] drm/ttm: Restore ttm prefaulting

2019-09-16 Thread Souptick Joarder
with the pre-determined number of prefaults. > > Fixes: 4daa4fba3a38 ("gpu: drm: ttm: Adding new return type vm_fault_t") > Cc: Souptick Joarder > Cc: Christian König > Signed-off-by: Thomas Hellstrom This commit merged into 4.19. Need to Cc stable. Cc: sta...@vge

[PATCH] video/fbdev/68328fb: Remove dead code

2019-09-02 Thread Souptick Joarder
This is dead code since 3.15. If their is no plan to use it further, these can be removed forever. Signed-off-by: Souptick Joarder --- drivers/video/fbdev/68328fb.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/video/fbdev/68328fb.c b/drivers/video/fbdev/68328fb.c

Re: [PATCH] video: fbdev:via: Remove dead code

2019-08-18 Thread Souptick Joarder
On Mon, Aug 12, 2019 at 5:37 PM Souptick Joarder wrote: > > On Wed, Aug 7, 2019 at 2:11 PM Souptick Joarder wrote: > > > > On Wed, Jul 31, 2019 at 12:59 AM Souptick Joarder > > wrote: > > > > > > This is dead code since 3.15. If there is no plan to

Re: [PATCH] video/fbdev/aty128fb: Remove dead code

2019-08-14 Thread Souptick Joarder
On Wed, Aug 7, 2019 at 2:12 PM Souptick Joarder wrote: > > On Wed, Jul 31, 2019 at 12:38 AM Souptick Joarder > wrote: > > > > This is dead code since 3.15. If there is no plan to use it > > further, this can be removed forever. > > Any comment on this p

Re: [PATCH] video: fbdev:via: Remove dead code

2019-08-12 Thread Souptick Joarder
On Wed, Aug 7, 2019 at 2:11 PM Souptick Joarder wrote: > > On Wed, Jul 31, 2019 at 12:59 AM Souptick Joarder > wrote: > > > > This is dead code since 3.15. If there is no plan to use > > it further, this can be removed forever. > > > > Any comment on

Re: [PATCH] video/fbdev/aty128fb: Remove dead code

2019-08-07 Thread Souptick Joarder
On Wed, Jul 31, 2019 at 12:38 AM Souptick Joarder wrote: > > This is dead code since 3.15. If there is no plan to use it > further, this can be removed forever. Any comment on this patch ? > > Signed-off-by: Souptick Joarder > --- > drivers/video/fbdev/

Re: [PATCH] video: fbdev:via: Remove dead code

2019-08-07 Thread Souptick Joarder
On Wed, Jul 31, 2019 at 12:59 AM Souptick Joarder wrote: > > This is dead code since 3.15. If there is no plan to use > it further, this can be removed forever. > Any comment on this patch ? > Signed-off-by: Souptick Joarder > --- > drivers/video/fbde

[PATCH] video: fbdev:via: Remove dead code

2019-07-30 Thread Souptick Joarder
This is dead code since 3.15. If there is no plan to use it further, this can be removed forever. Signed-off-by: Souptick Joarder --- drivers/video/fbdev/via/via-core.c | 43 -- 1 file changed, 43 deletions(-) diff --git a/drivers/video/fbdev/via/via-core.c

[PATCH] video/fbdev/aty128fb: Remove dead code

2019-07-30 Thread Souptick Joarder
This is dead code since 3.15. If there is no plan to use it further, this can be removed forever. Signed-off-by: Souptick Joarder --- drivers/video/fbdev/aty/aty128fb.c | 18 -- drivers/video/fbdev/aty/atyfb_base.c | 29 - 2 files changed, 47

Re: [PATCH 1/6] mm: always return EBUSY for invalid ranges in hmm_range_{fault, snapshot}

2019-07-23 Thread Souptick Joarder
On Mon, Jul 22, 2019 at 3:14 PM Christoph Hellwig wrote: > > We should not have two different error codes for the same condition. In > addition this really complicates the code due to the special handling of > EAGAIN that drops the mmap_sem due to the FAULT_FLAG_ALLOW_RETRY logic > in the core

Re: [PATCH] video: fbdev: nvidia: Remove dead code

2019-07-22 Thread Souptick Joarder
On Wed, Jul 10, 2019 at 11:41 PM Souptick Joarder wrote: > > This is dead code since 3.15. If there is no plan to use it > further, this can be removed forever. Any comment on this patch ? > > Signed-off-by: Souptick Joarder > --- > drivers/video/fbdev/n

Re: [PATCH] video: fbdev: nvidia: Remove extra return

2019-07-22 Thread Souptick Joarder
On Wed, Jul 10, 2019 at 11:28 PM Souptick Joarder wrote: > > Minor cleanup to remove extra return statement. > Any comment on this patch ? > Signed-off-by: Souptick Joarder > --- > drivers/video/fbdev/nvidia/nv_backlight.c | 2 -- > 1 file changed, 2 deletions(-) >

[PATCH] video: fbdev: nvidia: Remove dead code

2019-07-10 Thread Souptick Joarder
This is dead code since 3.15. If there is no plan to use it further, this can be removed forever. Signed-off-by: Souptick Joarder --- drivers/video/fbdev/nvidia/nv_setup.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b

[PATCH] video: fbdev: nvidia: Remove extra return

2019-07-10 Thread Souptick Joarder
Minor cleanup to remove extra return statement. Signed-off-by: Souptick Joarder --- drivers/video/fbdev/nvidia/nv_backlight.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nv_backlight.c b/drivers/video/fbdev/nvidia/nv_backlight.c index e705a78..2ce5352 100644

Re: [PATCH v2 hmm 10/11] mm/hmm: Do not use list*_rcu() for hmm->ranges

2019-06-09 Thread Souptick Joarder
On Fri, Jun 7, 2019 at 12:15 AM Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > This list is always read and written while holding hmm->lock so there is > no need for the confusing _rcu annotations. > > Signed-off-by: Jason Gunthorpe > Reviewed-by: Jérôme

Re: [PATCH v2 hmm 07/11] mm/hmm: Use lockdep instead of comments

2019-06-09 Thread Souptick Joarder
On Fri, Jun 7, 2019 at 12:15 AM Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > So we can check locking at runtime. Little more descriptive change log would be helpful. Acked-by: Souptick Joarder > > Signed-off-by: Jason Gunthorpe > Reviewed-by: Jérôme Glisse >

Re: [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault()

2019-06-09 Thread Souptick Joarder
Hi Jason, On Tue, May 21, 2019 at 12:27 AM Souptick Joarder wrote: > > Convert to use hmm_range_fault(). > > Signed-off-by: Souptick Joarder Would you like to take it through your new hmm tree or do I need to resend it ? > --- > drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-

Re: [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault()

2019-05-28 Thread Souptick Joarder
On Tue, May 21, 2019 at 12:27 AM Souptick Joarder wrote: > > Convert to use hmm_range_fault(). Any comment on this patch ? > > Signed-off-by: Souptick Joarder > --- > drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

[PATCH] drm/nouveau/svm: Convert to use hmm_range_fault()

2019-05-22 Thread Souptick Joarder
Convert to use hmm_range_fault(). Signed-off-by: Souptick Joarder --- drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c index 93ed43c..8d56bd6 100644

Re: [PATCH 1/9] mm: Allow the [page|pfn]_mkwrite callbacks to drop the mmap_sem

2019-04-18 Thread Souptick Joarder
On Wed, Apr 17, 2019 at 4:28 PM Thomas Hellstrom wrote: > > Hi, Souptick, > > On Sat, 2019-04-13 at 20:41 +0530, Souptick Joarder wrote: > > On Fri, Apr 12, 2019 at 9:34 PM Thomas Hellstrom < > > thellst...@vmware.com> wrote: > > > Driver fault callback

[REBASE PATCH v5 2/9] arm: mm: dma-mapping: Convert to use vm_map_pages()

2019-04-17 Thread Souptick Joarder
Convert to use vm_map_pages() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder --- arch/arm/mm/dma-mapping.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index f1e2922

[REBASE PATCH v5 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_map_pages()

2019-04-17 Thread Souptick Joarder
Convert to use vm_map_pages() to map range of kernel memory to user vma. Tested on Rockchip hardware and display is working, including talking to Lima via prime. Signed-off-by: Souptick Joarder Tested-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 ++--- 1

[REBASE PATCH v5 7/9] videobuf2/videobuf2-dma-sg.c: Convert to use vm_map_pages()

2019-04-17 Thread Souptick Joarder
Convert to use vm_map_pages() to map range of kernel memory to user vma. vm_pgoff is treated in V4L2 API as a 'cookie' to select a buffer, not as a in-buffer offset by design and it always want to mmap a whole buffer from its beginning. Signed-off-by: Souptick Joarder Suggested-by: Marek

[REBASE PATCH v5 3/9] drivers/firewire/core-iso.c: Convert to use vm_map_pages_zero()

2019-04-17 Thread Souptick Joarder
ction name and if that causes regressions, it gives us an easy way to revert. Signed-off-by: Souptick Joarder --- drivers/firewire/core-iso.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c index 35e784c..5414

[REBASE PATCH v5 9/9] xen/privcmd-buf.c: Convert to use vm_map_pages_zero()

2019-04-17 Thread Souptick Joarder
egressions, it gives us an easy way to revert. Signed-off-by: Souptick Joarder Reviewed-by: Boris Ostrovsky --- drivers/xen/privcmd-buf.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/xen/privcmd-buf.c b/drivers/xen/privcmd-buf.c index de01a6d..d02dc43 100644 --- a/d

[REBASE PATCH v5 1/9] mm: Introduce new vm_map_pages() and vm_map_pages_zero() API

2019-04-17 Thread Souptick Joarder
nd display is working, including talking to Lima via prime. Signed-off-by: Souptick Joarder Suggested-by: Russell King Suggested-by: Matthew Wilcox Reviewed-by: Mike Rapoport Tested-by: Heiko Stuebner --- include/linux/mm.h | 4 +++ mm/memory.c

[REBASE PATCH v5 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_map_pages()

2019-04-17 Thread Souptick Joarder
Convert to use vm_map_pages() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front_gem.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/xen

[REBASE PATCH v5 6/9] iommu/dma-iommu.c: Convert to use vm_map_pages()

2019-04-17 Thread Souptick Joarder
Convert to use vm_map_pages() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder --- drivers/iommu/dma-iommu.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index d19f3d6..bacebff

[REBASE PATCH v5 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API

2019-04-17 Thread Souptick Joarder
ther change apart from renaming and using the new interface. Patch[1/9] & [4/9], Tested on Rockchip hardware. v3 -> v4: Fixed build warnings on patch [8/9] reported by kbuild test robot. v4 -> v5: Rebase the code to 5.1-rc5. Souptick Joarder (9):

[REBASE PATCH v5 8/9] xen/gntdev.c: Convert to use vm_map_pages()

2019-04-17 Thread Souptick Joarder
Convert to use vm_map_pages() to map range of kernel memory to user vma. map->count is passed to vm_map_pages() and internal API verify map->count against count ( count = vma_pages(vma)) for page array boundary overrun condition. Signed-off-by: Souptick Joarder Reviewed-by: Boris Ost

[PATCH] drm/panel: Remove duplicate header

2019-04-15 Thread Souptick Joarder
Remove duplicate header which is included twice. Signed-off-by: Souptick Joarder --- drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi

Re: [PATCH 1/9] mm: Allow the [page|pfn]_mkwrite callbacks to drop the mmap_sem

2019-04-15 Thread Souptick Joarder
iel > Cc: Minchan Kim > Cc: Michal Hocko > Cc: Huang Ying > Cc: Souptick Joarder > Cc: "Jérôme Glisse" > Cc: linux...@kvack.org > Cc: linux-ker...@vger.kernel.org > > Signed-off-by: Thomas Hellstrom > --- > mm/memory.c | 10 ++ > 1 file cha

Re: [RESEND PATCH v4 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API

2019-04-09 Thread Souptick Joarder
Hi Andrew/ Michal, On Mon, Apr 1, 2019 at 10:56 AM Souptick Joarder wrote: > > Hi Andrew, > > On Tue, Mar 19, 2019 at 7:47 AM Souptick Joarder wrote: > > > > Previouly drivers have their own way of mapping range of > > kernel pages/memory into user vma and

Re: [RESEND PATCH v4 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API

2019-04-01 Thread Souptick Joarder
Hi Andrew, On Tue, Mar 19, 2019 at 7:47 AM Souptick Joarder wrote: > > Previouly drivers have their own way of mapping range of > kernel pages/memory into user vma and this was done by > invoking vm_insert_page() within a loop. > > As this pattern is common across differe

[RESEND PATCH v4 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_map_pages()

2019-03-19 Thread Souptick Joarder
Convert to use vm_map_pages() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front_gem.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/xen

[RESEND PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_map_pages()

2019-03-19 Thread Souptick Joarder
Convert to use vm_map_pages() to map range of kernel memory to user vma. Tested on Rockchip hardware and display is working, including talking to Lima via prime. Signed-off-by: Souptick Joarder Tested-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 ++--- 1

[RESEND PATCH v4 1/9] mm: Introduce new vm_map_pages() and vm_map_pages_zero() API

2019-03-19 Thread Souptick Joarder
nd display is working, including talking to Lima via prime. Signed-off-by: Souptick Joarder Suggested-by: Russell King Suggested-by: Matthew Wilcox Reviewed-by: Mike Rapoport Tested-by: Heiko Stuebner --- include/linux/mm.h | 4 +++ mm/memory.c

[RESEND PATCH v4 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API

2019-03-19 Thread Souptick Joarder
ther change apart from renaming and using the new interface. Patch[1/9] & [4/9], Tested on Rockchip hardware. v3 -> v4: Fixed build warnings on patch [8/9] reported by kbuild test robot. Souptick Joarder (9): mm: Introduce new vm_map_pages() and vm_map_pages_zero() API

Re: [RESEND PATCH 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-21 Thread Souptick Joarder
Hi Ira, On Wed, Feb 20, 2019 at 11:01 AM wrote: > > From: Ira Weiny > > To facilitate additional options to get_user_pages_fast() change the > singular write parameter to be gup_flags. > > This patch does not change any functionality. New functionality will > follow in subsequent patches. > >

Re: [PATCH v4 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API

2019-02-21 Thread Souptick Joarder
On Fri, Feb 15, 2019 at 8:06 AM Souptick Joarder wrote: > > Previouly drivers have their own way of mapping range of > kernel pages/memory into user vma and this was done by > invoking vm_insert_page() within a loop. > > As this pattern is common across different drivers, it ca

[PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_map_pages()

2019-02-18 Thread Souptick Joarder via dri-devel
Convert to use vm_map_pages() to map range of kernel memory to user vma. Tested on Rockchip hardware and display is working, including talking to Lima via prime. Signed-off-by: Souptick Joarder Tested-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 ++--- 1

[PATCH v4 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_map_pages()

2019-02-18 Thread Souptick Joarder via dri-devel
Convert to use vm_map_pages() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front_gem.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/xen

[PATCH v4 1/9] mm: Introduce new vm_map_pages() and vm_map_pages_zero() API

2019-02-18 Thread Souptick Joarder via dri-devel
nd display is working, including talking to Lima via prime. Signed-off-by: Souptick Joarder Suggested-by: Russell King Suggested-by: Matthew Wilcox Reviewed-by: Mike Rapoport Tested-by: Heiko Stuebner --- include/linux/mm.h | 4 +++ mm/memory.c

[PATCH v4 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API

2019-02-18 Thread Souptick Joarder via dri-devel
ther change apart from renaming and using the new interface. Patch[1/9] & [4/9], Tested on Rockchip hardware. v3 -> v4: Fixed build warnings on patch [8/9] reported by kbuild test robot. Souptick Joarder (9): mm: Introduce new vm_map_pages() and vm_map_pages_zero() API

[PATCH v3 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API

2019-02-14 Thread Souptick Joarder via dri-devel
ther change apart from renaming and using the new interface. Patch[1/9] & [4/9], Tested on Rockchip hardware. Souptick Joarder (9): mm: Introduce new vm_map_pages() and vm_map_pages_zero() API arm: mm: dma-mapping: Convert to use vm_map_pages() drivers/firewire/core-iso.c: Conver

[PATCH v3 1/9] mm: Introduce new vm_map_pages() and vm_map_pages_zero() API

2019-02-14 Thread Souptick Joarder via dri-devel
nd display is working, including talking to Lima via prime. Signed-off-by: Souptick Joarder Suggested-by: Russell King Suggested-by: Matthew Wilcox Reviewed-by: Mike Rapoport Tested-by: Heiko Stuebner --- include/linux/mm.h | 4 +++ mm/memory.c

[PATCH v3 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_map_pages()

2019-02-14 Thread Souptick Joarder via dri-devel
Convert to use vm_map_pages() to map range of kernel memory to user vma. Tested on Rockchip hardware and display is working, including talking to Lima via prime. Signed-off-by: Souptick Joarder Tested-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 ++--- 1

[PATCH v3 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_map_pages()

2019-02-14 Thread Souptick Joarder via dri-devel
Convert to use vm_map_pages() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front_gem.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/xen

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-12 Thread Souptick Joarder
On Fri, Feb 8, 2019 at 10:52 AM Souptick Joarder wrote: > > On Thu, Feb 7, 2019 at 10:17 PM Matthew Wilcox wrote: > > > > On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote: > > > Just thought to take opinion for documentation before placing it in v

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-08 Thread Souptick Joarder
Hi Mike, On Thu, Jan 31, 2019 at 2:09 PM Mike Rapoport wrote: > > On Thu, Jan 31, 2019 at 08:38:12AM +0530, Souptick Joarder wrote: > > Previouly drivers have their own way of mapping range of > > kernel pages/memory into user vma and this was done by > > invoking vm_ins

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-08 Thread Souptick Joarder
On Thu, Feb 7, 2019 at 9:27 PM Mike Rapoport wrote: > > Hi Souptick, > > On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote: > > Hi Mike, > > > > Just thought to take opinion for documentation before placing it in v3. > > Does it looks fine ? &

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-08 Thread Souptick Joarder
On Thu, Feb 7, 2019 at 10:17 PM Matthew Wilcox wrote: > > On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote: > > Just thought to take opinion for documentation before placing it in v3. > > Does it looks fine ? > > > > +/** > > + * __vm_insert_

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-01 Thread Souptick Joarder
On Thu, Jan 31, 2019 at 6:04 PM Heiko Stuebner wrote: > > Am Donnerstag, 31. Januar 2019, 13:31:52 CET schrieb Souptick Joarder: > > On Thu, Jan 31, 2019 at 5:37 PM Heiko Stuebner wrote: > > > > > > Am Donnerstag, 31. Januar 2019, 04:08:12 CET schrieb Souptick Joar

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-01 Thread Souptick Joarder
On Thu, Jan 31, 2019 at 5:37 PM Heiko Stuebner wrote: > > Am Donnerstag, 31. Januar 2019, 04:08:12 CET schrieb Souptick Joarder: > > Previouly drivers have their own way of mapping range of > > kernel pages/memory into user vma and this was done by > > invoking vm_ins

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-01 Thread Souptick Joarder
On Thu, Jan 31, 2019 at 2:09 PM Mike Rapoport wrote: > > On Thu, Jan 31, 2019 at 08:38:12AM +0530, Souptick Joarder wrote: > > Previouly drivers have their own way of mapping range of > > kernel pages/memory into user vma and this was done by > > invoking vm_ins

[PATCHv2 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2019-01-31 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b

[PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-01-31 Thread Souptick Joarder
_could_ then at a later "fix" these drivers which are using vm_insert_range_buggy() to behave according to the normal vm_pgoff offsetting simply by removing the _buggy suffix on the function name and if that causes regressions, it gives us an easy way to revert. Signed-off-by: Soupti

Re: [PATCH] drm/bridge/panel: Remove duplicate header

2019-01-31 Thread Souptick Joarder
On Wed, Jan 30, 2019 at 8:07 PM Brajeswar Ghosh wrote: > > On Wed, Dec 26, 2018 at 3:09 PM Laurent Pinchart > wrote: > > > > Hi Brajeswar, > > > > Thank you for the patch. > > > > On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote: > > > Remove drm/drm_panel.h which is included more

[PATCHv2 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range

2019-01-31 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front_gem.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm

[PATCHv2 0/9] Use vm_insert_range and vm_insert_range_buggy

2019-01-31 Thread Souptick Joarder
ng with Marek and vm_insert_range could be used instead of vm_insert_range_buggy. Souptick Joarder (9): mm: Introduce new vm_insert_range and vm_insert_range_buggy API arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range drivers/firewire/core-iso.c: Convert to use vm_insert_rang

Re: [PATCH 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2019-01-28 Thread Souptick Joarder
On Fri, Jan 11, 2019 at 8:35 PM Souptick Joarder wrote: > > Convert to use vm_insert_range() to map range of kernel > memory to user vma. > > Signed-off-by: Souptick Joarder Any comment on this patch ? > --- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 ++

Re: [PATCH 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-01-22 Thread Souptick Joarder
On Fri, Jan 11, 2019 at 8:33 PM Souptick Joarder wrote: > > Previouly drivers have their own way of mapping range of > kernel pages/memory into user vma and this was done by > invoking vm_insert_page() within a loop. > > As this pattern is common across different drivers, it ca

Re: [PATCH 0/9] Use vm_insert_range and vm_insert_range_buggy

2019-01-18 Thread Souptick Joarder
On Fri, Jan 11, 2019 at 8:31 PM Souptick Joarder wrote: > > Previouly drivers have their own way of mapping range of > kernel pages/memory into user vma and this was done by > invoking vm_insert_page() within a loop. > > As this pattern is common across different drivers, it ca

[PATCH 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-01-13 Thread Souptick Joarder
_could_ then at a later "fix" these drivers which are using vm_insert_range_buggy() to behave according to the normal vm_pgoff offsetting simply by removing the _buggy suffix on the function name and if that causes regressions, it gives us an easy way to revert. Signed-off-by: Soupti

[PATCH 0/9] Use vm_insert_range and vm_insert_range_buggy

2019-01-13 Thread Souptick Joarder
ug in [7/9], where user passed length is not verified against object_count. For any value of length > object_count it will end up overrun page array which could lead to a potential bug. This is fixed as part of these conversion. Souptick Joarder (9): mm: Introduce new vm_insert_range and vm_inser

[PATCH 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range

2019-01-13 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder --- drivers/gpu/drm/xen/xen_drm_front_gem.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu

[PATCH 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2019-01-13 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b

Re: [PATCH v5 0/9] Use vm_insert_range

2018-12-26 Thread Souptick Joarder
On Mon, Dec 24, 2018 at 8:51 PM Russell King - ARM Linux wrote: > > Having discussed with Matthew offlist, I think we've come to the > following conclusion - there's a number of drivers that buggily > ignore vm_pgoff. > > So, what I proposed is: > > static int __vm_insert_range(struct vm_struct

[PATCH v5 0/9] Use vm_insert_range

2018-12-26 Thread Souptick Joarder
those error check we might end up overrun the page array. In rockchip/rockchip_drm_gem.c, added error check which was removed in v1, as without this it might overrun page array. Adjusted page_count parameter before passing it to vm_insert_range(). Souptick Joarder

  1   2   3   >