axiong Tian
Reviewed-by: Stanislaw Gruszka
> ---
> drivers/gpu/drm/drm_debugfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index f4715a67e340..4d299152c302 100644
> --- a/drivers/gpu/drm/drm_debug
t; On Sat, 28 Oct 2023 at 18:00, Stanislaw Gruszka
> wrote:
> >
> > Stop job_done thread when going to suspend. Use kthread_park() instead
> > of kthread_stop() to avoid memory allocation and potential failure
> > on resume.
> >
> > Use separate functio
On Sat, Oct 28, 2023 at 05:59:28PM +0200, Stanislaw Gruszka wrote:
> Various driver updates:
> - MMU page tables handling optimizations
> - Rebrand to NPU
> - FW profiling frequency knob
> - job done thread suspend handling
>
> This is based on top of pre
From: Jacek Lawrynowicz
Use struct drm_gem_shmem_object as a base for struct ivpu_bo.
This cuts by 50% the buffer management code.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Jeffrey Hugo
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/Kconfig| 2 +-
drivers/accel/ivpu
of DRM_IVPU_BO_UNCACHED buffers was removed from user-space
driver and will not be part of first UMD release.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Jeffrey Hugo
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_fw.c | 2 +-
drivers/accel/ivpu/ivpu_gem.c | 3 ---
include/uapi/drm/ivpu_accel.h
.
Also rename ivpu_bo_free_vpu_addr() to ivpu_bo_unbind() because this
function does more then just free vpu_addr.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Jeffrey Hugo
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.c | 7 +-
drivers/accel/ivpu/ivpu_drv.h
field.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Jeffrey Hugo
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_gem.c | 66 ---
drivers/accel/ivpu/ivpu_gem.h | 1 -
drivers/accel/ivpu/ivpu_mmu_context.c | 2 +
3 files changed, 32 insertions(
Use GEM shmem for buffer management code;
Previously sent as RFC:
https://lore.kernel.org/dri-devel/20230901164842.178654-1-stanislaw.grus...@linux.intel.com/
Compared to RFC only changelog's were improved.
Jacek Lawrynowicz (4):
accel/ivpu: Allocate vpu_addr in gem->open() callback
On Mon, Oct 30, 2023 at 08:05:28AM -0600, Jeffrey Hugo wrote:
> On 10/28/2023 2:18 AM, Stanislaw Gruszka wrote:
> > On Fri, Oct 27, 2023 at 08:47:11AM -0600, Jeffrey Hugo wrote:
> > > On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote:
> > > > From: Karol Wachowski
&
On Sat, Oct 28, 2023 at 03:34:04PM +0200, Stanislaw Gruszka wrote:
> Various driver updates:
>
> - FW api update
> - suspend/resume optimizations
> - dynamic valtage and frequency mode knob
> - new test modes
>
> v2:
> - fix spelling mistakes pointed Jeffrey
no resize.
> After this patch all the slice in BO should behave exactly like slice 2 in
> above example.
>
> Refactor copy_partial_exec_reqs() to make it more readable and less
> complex.
>
> Signed-off-by: Pranjal Ramajor Asha Kanojiya
> Reviewed-by: Jeffrey Hugo
> Signed-off-by: Jeffrey Hugo
Reviewed-by: Stanislaw Gruszka
ceptable.
>
> Reported-by: kernel test robot
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202310182253.bcb9jcyj-...@intel.com/
> Signed-off-by: Carl Vanderlip
> Reviewed-by: Pranjal Ramajor Asha Kanojiya
> Reviewed-by: Jeffrey Hugo
> Signed-off-by: Jeffrey Hugo
Reviewed-by: Stanislaw Gruszka
On Fri, Oct 27, 2023 at 05:26:23PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The usage count of struct dev_pm_info is an implementation detail that
> is only available if CONFIG_PM is enabled, so printing it in a debug message
> causes a build failure in configurations without PM:
>
From: Jacek Lawrynowicz
VPU was rebranded as NPU (Neural Processing Unit) so user facing
strings have to be updated but the code remains as is and the module
is still called intel_vpu.ko.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
From: Karol Wachowski
Add checking of error reason bits in IVPU_MMU_CMDQ_CONS
register when waiting for consumer timeout occurred.
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_mmu.c | 34
From: Jacek Lawrynowicz
CMD_SYNC does not need any args as we poll for completion anyway.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_mmu.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git
a single write memory
barrier to flush write-combined buffer to memory which simplifies the
driver and significantly reduce time of map/unmap operations.
Mapping time of 255 MB is reduced from 2.5 ms to 500 us.
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw
there is pending IPC processing or pending job.
Reviewed-by: Karol Wachowski
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_ipc.c | 20 +---
drivers/accel/ivpu/ivpu_ipc.h | 3 ++-
drivers/accel/ivpu/ivpu_job.c | 1 +
3 files changed, 20 insertions(+), 4 deletions(-)
diff
We should not leave device half enabled if there is failure somewhere
it power up sequence. Fix device init and resume paths.
Reviewed-by: Karol Wachowski
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.c | 2 +-
drivers/accel/ivpu/ivpu_pm.c | 30
it.
For vpu37xx the implementation is empty as profiling frequency can only
be changed on VPU4 or newer.
Signed-off-by: Krystian Pradzynski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_debugfs.c | 29 +
drivers/accel/ivpu
to change profiling frequency
Stanislaw Gruszka (3):
accel/ivpu: Assure device is off if power up sequence fail
accel/ivpu: Stop job_done_thread on suspend
accel/ivpu: Abort pending rx ipc on reset
drivers/accel/ivpu/Kconfig| 9 +-
drivers/accel/ivpu/ivpu_debugfs.c | 29
-by: Karol Wachowski
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.c | 2 ++
drivers/accel/ivpu/ivpu_ipc.c | 17 +++--
drivers/accel/ivpu/ivpu_job.c | 20
drivers/accel/ivpu/ivpu_job.h | 2 ++
4 files changed, 35 insertions(+), 6 deletions
. If the driver does not wait for the VPU to enter
IDLE state it could cause warm boot failures.
Signed-off-by: Andrzej Kacprowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.h | 10 +--
drivers/accel/ivpu/ivpu_fw.c | 48
Print warning if VPUIP is not idle during power down.
Use warn log level also when we fail to enter reset state
as this is not really an error but unexpected behavior.
Reviewed-by: Krystian Pradzynski
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 7 +--
1 file
for D0i3 entry IPC message addition
in the separate change.
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_ipc.c | 33 ++---
drivers/accel/ivpu/ivpu_ipc.h | 8 +---
2 files changed, 27
- this allows the VPU firmware
to generate monotonic timestamps for the logs.
Signed-off-by: Andrzej Kacprowski
Reviewed-by: Stanislaw Gruszka
Reviewed-by: Jeffrey Hugo
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_fw.c | 17 -
drivers/accel/ivpu
From: Karol Wachowski
Change meaning of test_mode module parameter from integer value
to bitmask allowing setting different test features with corresponding
bits.
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Reviewed-by: Jeffrey Hugo
Signed-off-by: Stanislaw Gruszka
From: Andrzej Kacprowski
The driver needs to capture the D0i3 entry timestamp to
calculate D0i3 residency time.
The D0i3 residency time and the VPU timestamp are passed
to the firmware at D0i3 exit (warm boot).
Signed-off-by: Andrzej Kacprowski
Reviewed-by: Stanislaw Gruszka
Reviewed
software and VPU firmware.
Unlike the null hardware mode, the null submission mode will
still work even if UMD uses VPU fences to track job completion.
Signed-off-by: Andrzej Kacprowski
Reviewed-by: Stanislaw Gruszka
Reviewed-by: Jeffrey Hugo
Signed-off-by: Stanislaw Gruszka
---
drivers/accel
From: Karol Wachowski
Setting a non-zero work point resets the IP hence IP_RESET
trigger is redundant.
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Reviewed-by: Jeffrey Hugo
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 4
drivers/accel/ivpu
Cleanup drm_driver declaration leftover.
Reviewed-by: Krystian Pradzynski
Reviewed-by: Jeffrey Hugo
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
index
From: Tomasz Rusinowicz
Add new debugfs file to set dvfs_mode FW boot parameter and restart
the FW to allow experimenting with DVFS (dynamic voltage & frequency
scaling).
Signed-off-by: Tomasz Rusinowicz
Reviewed-by: Jeffrey Hugo
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/
From: Krystian Pradzynski
Bump boot API to 4.20
Bump JSM API to 3.15
Signed-off-by: Krystian Pradzynski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_jsm_msg.c | 17 ++
drivers/accel/ivpu/vpu_boot_api.h | 90 -
drivers/accel/ivpu
: Update FW API
Stanislaw Gruszka (2):
accel/ivpu: Remove unneeded drm_driver declaration
accel/ivpu/37xx: Print warning when VPUIP is not idle during power
down
Tomasz Rusinowicz (1):
accel/ivpu: Add dvfs_mode file to debugfs
drivers/accel/ivpu/ivpu_debugfs.c | 28 +++
drivers/accel
On Fri, Oct 27, 2023 at 09:07:22AM -0600, Jeffrey Hugo wrote:
> > + if (!ivpu_hw_37xx_is_idle(vdev)) {
> > + ivpu_warn(vdev, "VPU not idle during power down\n");
> > + if (ivpu_hw_37xx_ip_reset(vdev))
> > + ivpu_err(vdev, "Failed to reset the VPU\n");
> > +
On Fri, Oct 27, 2023 at 08:49:21AM -0600, Jeffrey Hugo wrote:
> On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote:
> > From: Karol Wachowski
> >
> > Split ivpu_ipc_send_receive() implementation to have a version
> > that does not call pm_runtime_resume_and_get().
On Fri, Oct 27, 2023 at 09:09:16AM -0600, Jeffrey Hugo wrote:
> On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote:
> > From: Andrzej Kacprowski
> >
> > The VPU needs non zero time to enter IDLE state after responding to
> > D0i3 entry message. If the driver does no
On Fri, Oct 27, 2023 at 08:47:11AM -0600, Jeffrey Hugo wrote:
> On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote:
> > From: Karol Wachowski
> >
> > Change meaning of test_mode module parameter from integer value
> > to bitmask allowing setting different test features
Hi
On Fri, Oct 27, 2023 at 08:37:39AM -0600, Jeffrey Hugo wrote:
> On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote:
> > From: Krystian Pradzynski
> >
> > Bump boot API to 4.20
> > Bump JSM API to 3.15
> >
> > Signed-off-by: Krystian Pradzynski
> > R
On Thu, Oct 19, 2023 at 12:43:54AM +0530, Deepak R Varma wrote:
> The work items listed in the TODO file of this driver file are either
> completed or dropped. The file is no more significant according
> to the maintainers. Hence removing it from the sources.
>
> Suggested-by: St
On Tue, Oct 24, 2023 at 06:19:52PM +0200, Stanislaw Gruszka wrote:
> From: Karol Wachowski
>
> Move sequence of masking and unmasking global interrupts from buttress
> interrupt handler to generic one that handles both VPUIP and BTRS
> interrupts. Unmasking global interrupts will
message sent from the host driver only when the driver is about
to enter D0i3 - this reduces power consumption and latency for
certain workloads, for example audio workloads that submit
inference every 10 ms.
Signed-off-by: Andrzej Kacprowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw
From: Andrzej Kacprowski
The VPU needs non zero time to enter IDLE state after responding to
D0i3 entry message. If the driver does not wait for the VPU to enter
IDLE state it could cause warm boot failures.
Signed-off-by: Andrzej Kacprowski
Reviewed-by: Stanislaw Gruszka
Signed-off
From: Tomasz Rusinowicz
Add new debugfs file to set dvfs_mode FW boot parameter and restart
the FW to allow experimenting with DVFS (dynamic voltage & frequency
scaling).
Signed-off-by: Tomasz Rusinowicz
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_debugfs.c
From: Andrzej Kacprowski
The driver needs to capture the D0i3 entry timestamp to
calculate D0i3 residency time.
The D0i3 residency time and the VPU timestamp are passed
to the firmware at D0i3 exit (warm boot).
Signed-off-by: Andrzej Kacprowski
Reviewed-by: Stanislaw Gruszka
Signed-off
- this allows the VPU firmware
to generate monotonic timestamps for the logs.
Signed-off-by: Andrzej Kacprowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_fw.c | 17 -
drivers/accel/ivpu/ivpu_hw.h | 2
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_ipc.c | 33 ++---
drivers/accel/ivpu/ivpu_ipc.h | 8 +---
2 files changed, 27 insertions(+), 14 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_ipc.c b/drivers/accel/ivpu
From: Karol Wachowski
Change meaning of test_mode module parameter from integer value
to bitmask allowing setting different test features with corresponding
bits.
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.c
Cleanup drm_driver declaration leftover.
Reviewed-by: Krystian Pradzynski
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
index 790603017653..346dd7fdcacb
From: Krystian Pradzynski
Bump boot API to 4.20
Bump JSM API to 3.15
Signed-off-by: Krystian Pradzynski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_jsm_msg.c | 17 ++
drivers/accel/ivpu/vpu_boot_api.h | 90 -
drivers/accel/ivpu
to bitmask
accel/ivpu: Introduce ivpu_ipc_send_receive_active()
Krystian Pradzynski (1):
accel/ivpu: Update FW API
Stanislaw Gruszka (1):
accel/ivpu: Remove unneeded drm_driver dectaration
Tomasz Rusinowicz (1):
accel/ivpu: Add dvfs_mode file to debugfs
drivers/accel/ivpu/ivpu_debugfs.c
software and VPU firmware.
Unlike the null hardware mode, the null submission mode will
still work even if UMD uses VPU fences to track job completion.
Signed-off-by: Andrzej Kacprowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.c | 2
From: Karol Wachowski
Setting a non-zero work point resets the IP hence IP_RESET
trigger is redundant.
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 4
drivers/accel/ivpu/ivpu_hw_40xx.c | 6
From: Jacek Lawrynowicz
IP reset has to followed by ivpu_pll_disable() to properly enter
reset state.
Fixes: 828d63042aec ("accel/ivpu: Don't enter d0i3 during FLR")
Cc: sta...@vger.kernel.org
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanisl
to miss any
VPUIP interrupt that comes after reading VPU_37XX_HOST_SS_ICB_STATUS_0
and before clearing all active interrupt sources.
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 11 +--
1 file changed
From: Jacek Lawrynowicz
IP reset has to followed by ivpu_pll_disable() to properly enter
reset state.
Fixes: 828d63042aec ("accel/ivpu: Don't enter d0i3 during FLR")
Cc: sta...@vger.kernel.org
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanisl
On Fri, Oct 20, 2023 at 12:44:55PM +0200, Stanislaw Gruszka wrote:
> Random changes across the driver.
>
> Karol Wachowski (1):
> accel/ivpu: Read clock rate only if device is up
>
> Krystian Pradzynski (3):
> accel/ivpu: Use ratelimited warn and err in IPC/JSM
>
hat environment.
>
> Signed-off-by: Pranjal Ramajor Asha Kanojiya
> Reviewed-by: Jeffrey Hugo
> Reviewed-by: Carl Vanderlip
> Signed-off-by: Jeffrey Hugo
Reviewed-by: Stanislaw Gruszka
gt;
> Signed-off-by: Ajit Pal Singh
> Signed-off-by: Pranjal Ramajor Asha Kanojiya
> Reviewed-by: Jeffrey Hugo
> Reviewed-by: Carl Vanderlip
> Reviewed-by: Pranjal Ramajor Asha Kanojiya
> Signed-off-by: Jeffrey Hugo
Reviewed-by: Stanislaw Gruszka
> @@
ev_test/Avg_test))
>
> Signed-off-by: Carl Vanderlip
> Reviewed-by: Pranjal Ramajor Asha Kanojiya
> Reviewed-by: Jeffrey Hugo
> Signed-off-by: Jeffrey Hugo
Reviewed-by: Stanislaw Gruszka
We do not run 37xx VPU on non-silicon platforms any longer.
Remove deprecated code to make it cleaner.
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 57 +--
1 file changed, 8 insertions(+), 49 deletions(-)
diff --git a/drivers/accel/ivpu
Initialize HW specific parameters only once. We do not have to do this
on every power_up (performed during initialization and on resume). Move
corresponding code to ->init_info()
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_hw_37xx.c | 8
drivers/accel/i
From: Krystian Pradzynski
Introduce ivpu_jsm_msg_type_to_str() helper to print type of IPC
message. This will make reading logs and debugging IPC issues easier.
Co-developed-by: Maciej Falkowski
Signed-off-by: Maciej Falkowski
Signed-off-by: Krystian Pradzynski
Reviewed-by: Stanislaw Gruszka
From: Karol Wachowski
Do not unnecessarily wake up device to read clock rate.
Return 0 as clk_rate if device is suspended.
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.c | 18 +-
drivers/accel
-by: Krystian Pradzynski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_hw_reg_io.h | 32
drivers/accel/ivpu/ivpu_mmu.c | 47 +
2 files changed, 48 insertions(+), 31 deletions(-)
diff --git a/drivers
Pradzynski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_ipc.c | 29 -
drivers/accel/ivpu/ivpu_jsm_msg.c | 18 ++
2 files changed, 26 insertions(+), 21 deletions(-)
diff --git a/drivers/accel/ivpu
Stanislaw Gruszka (2):
accel/ivpu: Do no initialize parameters on power up
accel/ivpu/37xx: Remove support for FPGA and simics
drivers/accel/ivpu/ivpu_drv.c | 18 ++-
drivers/accel/ivpu/ivpu_hw_37xx.c | 63 --
drivers/accel/ivpu/ivpu_hw_40xx.c | 8 +--
drivers
On Wed, Oct 18, 2023 at 10:49:15PM +0530, Deepak R Varma wrote:
> > > > 2. Is it absolutely necessary for me to have a specialized hardware to
> > > > test my
> > > > patches? Is it limited to the 14thGen or above CPU or do I need more
> > > > than that?
> > Yes, I don't think someone can work
On Tue, Oct 17, 2023 at 10:43:07AM +0200, Stanislaw Gruszka wrote:
> On Fri, Oct 06, 2023 at 09:25:29AM -0600, Jeffrey Hugo wrote:
> > On 10/3/2023 12:42 AM, Stanislaw Gruszka wrote:
> > > From: Jacek Lawrynowicz
> > >
> > > Fix a bug on some platforms where F
On Wed, Oct 18, 2023 at 01:01:13PM +0200, Stanislaw Gruszka wrote:
> From: "Wludzik, Jozef"
>
> Allow to use whole address range in MMU context mmap which is up to 48
> bits. Return invalid argument from MMU context mmap in case address is
> not aligned to MMU page s
On Tue, Oct 17, 2023 at 02:13:53PM +0200, Stanislaw Gruszka wrote:
> This reverts commit 645d694559cab36fe6a57c717efcfa27d9321396.
>
> The commit cause issues with memory access from the device side.
> Switch back to write-combined memory mappings until the issues
> will be pro
isallowing to run large models on VPU4
Signed-off-by: Wludzik, Jozef
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_mmu_context.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_mmu_context.c
b/dri
Hi
On Tue, Oct 17, 2023 at 10:25:19PM +0530, Deepak R Varma wrote:
> On Fri, Oct 13, 2023 at 12:54:43PM +0530, Deepak R Varma wrote:
> > Hello,
> > I am shortlisted as a mentee for the LF Mentorship program. I looked at the
> > TODO
> > file for the ivpu driver for my project tasks. Could you
ess() is
modified.
Reviewed-by: Karol Wachowski
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_fw.c | 9 -
drivers/accel/ivpu/ivpu_gem.h | 5 -
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_fw.c b/drivers/accel/ivpu/ivpu_fw.c
in
On Fri, Oct 06, 2023 at 09:25:29AM -0600, Jeffrey Hugo wrote:
> On 10/3/2023 12:42 AM, Stanislaw Gruszka wrote:
> > From: Jacek Lawrynowicz
> >
> > Fix a bug on some platforms where FLR causes complete system
> > hang when CPU is low power states (C8 or above).
>
&
From: Jacek Lawrynowicz
Fix a bug on some platforms where FLR causes complete system
hang when CPU is low power states (C8 or above).
Fixes: 852be13f3bd3 ("accel/ivpu: Add PM support")
Cc: sta...@vger.kernel.org
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Stanislaw Gruszka
On Thu, Sep 07, 2023 at 09:26:09AM +0200, Stanislaw Gruszka wrote:
> Use new drm debugfs helpers. This is needed after changes from
> commit 78346ebf9f94 ("drm/debugfs: drop debugfs_init() for the render
> and accel node v2").
Applied to drm-misc-next
Thanks
Stanislaw
On Mon, Sep 25, 2023 at 02:11:31PM +0200, Stanislaw Gruszka wrote:
> - dmesg flood fix
> - HW power-on and interrupt handling fixes for VPU4
> - FW loading/mapping fix
Pushed to drm-misc-fixes.
I had to resolve conflict when rebuilding tip, hope everything is ok there.
Thanks
to missed wmb).
Fixes: 02d5b0aacd05 ("accel/ivpu: Implement firmware parsing and booting")
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
v2: Actually use DRM_IVPU_BO_CACHED instead of DRM_IVPU_BO_WC..
drivers/accel/ivpu/ivpu
Use local variable for debugfs root, just to make further changes
easier.
Signed-off-by: Stanislaw Gruszka
---
I'll squash that patch into patch 1
drivers/accel/ivpu/ivpu_debugfs.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/accel/ivpu
to missed wmb).
Fixes: 02d5b0aacd05 ("accel/ivpu: Implement firmware parsing and booting")
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_fw.c | 8 +---
drivers/accel/ivpu/ivpu_gem.h | 5 +
2 files c
any VPUIP interrupt that
comes after reading VPU_40XX_HOST_SS_ICB_STATUS_0 and before clearing
all active interrupt sources.
Fixes: 79cdc56c4a54 ("accel/ivpu: Add initial support for VPU 4")
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanisl
Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_hw_40xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/accel/ivpu/ivpu_hw_40xx.c
b/drivers/accel/ivpu/ivpu_hw_40xx.c
index f4a251a58ca4..87b1085d44cf 100644
--- a/drivers/
for the CLOCK_RESOURCE_OWN_ACK before
proceeding with the remainder of the power-up sequence.
Fixes: 79cdc56c4a54 ("accel/ivpu: Add initial support for VPU 4")
Signed-off-by: Karol Wachowski
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu
From: Jacek Lawrynowicz
Use ivpu_dbg() to print the VPU ready message so it doesn't pollute
the dmesg.
Signed-off-by: Jacek Lawrynowicz
Reviewed-by: Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
firmware to finish IPC processing.
Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
Reviewed-by: Karol Wachowski
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_ipc.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/
frequency change interrupt
accel/ivpu/40xx: Fix missing VPUIP interrupts
accel/ivpu: Use cached buffers for FW loading
Stanislaw Gruszka (1):
accel/ivpu: Do not use wait event interruptible
drivers/accel/ivpu/ivpu_drv.c | 2 +-
drivers/accel/ivpu/ivpu_fw.c | 8
; (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct ivpu_job.
>
> [1]
> https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Jacek
On Fri, Sep 22, 2023 at 09:24:08AM -0600, Jeffrey Hugo wrote:
> On 9/22/2023 7:22 AM, Stanislaw Gruszka wrote:
> > Enable VPU on Arrow Lake CPUs.
> >
> > Reviewed-by: Krystian Pradzynski
> > Reviewed-by: Karol Wachowski
> > Signed-off-by: Stanislaw Gruszka
Enable VPU on Arrow Lake CPUs.
Reviewed-by: Krystian Pradzynski
Reviewed-by: Karol Wachowski
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_drv.c | 1 +
drivers/accel/ivpu/ivpu_drv.h | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers
On Mon, Sep 11, 2023 at 09:24:42AM -0600, Jeffrey Hugo wrote:
> On 9/1/2023 10:48 AM, Stanislaw Gruszka wrote:
> > From: Jacek Lawrynowicz
> >
> > Usages of DRM_IVPU_BO_UNCACHED should be replaced by DRM_IVPU_BO_WC.
> > There is no functional benefi
On Mon, Sep 11, 2023 at 09:19:03AM -0600, Jeffrey Hugo wrote:
> On 9/1/2023 10:48 AM, Stanislaw Gruszka wrote:
> > From: Jacek Lawrynowicz
> >
> > gem->open() is called during handle creation for a gem object.
> > It is called during prime import and in BO_CREATE io
/accel/qaic/qaic_drv.c | 1 +
> include/uapi/drm/qaic_accel.h | 24 +++-
> 5 files changed, 175 insertions(+), 53 deletions(-)
Do not see any serious issues with the set.
Reviewed-by: Stanislaw Gruszka for the
whole series.
On Fri, Sep 01, 2023 at 11:22:47AM -0600, Jeffrey Hugo wrote:
> From: Pranjal Ramajor Asha Kanojiya
>
> Once a BO is attached with slicing configuration that BO can only be used
> for that particular setting. With this new feature user can detach slicing
> configuration off an already sliced BO
On Fri, Sep 01, 2023 at 11:22:46AM -0600, Jeffrey Hugo wrote:
> From: Pranjal Ramajor Asha Kanojiya
>
> This makes sure that we have a single place to initialize and
> re-initialize BO.
>
> Use this new API to cleanup release_dbc()
>
> We will need this for next patch to detach slicing to a
Only compile ivpu_debugfs.c file with CONFIG_DEBUG_FS.
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/Makefile | 3 ++-
drivers/accel/ivpu/ivpu_debugfs.h | 4
drivers/accel/ivpu/ivpu_drv.c | 2 --
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers
Use new drm debugfs helpers. This is needed after changes from
commit 78346ebf9f94 ("drm/debugfs: drop debugfs_init() for the render
and accel node v2").
Signed-off-by: Stanislaw Gruszka
---
drivers/accel/ivpu/ivpu_debugfs.c | 50 +++
drivers/
tial negative
> values for "PSOC_RAZWI_ENG_STR_SIZE - str_size") use scnprintf()
> instead of snprintf().
>
> Fixes: c0e6df916050 ("accel/habanalabs: fix address decode RAZWI handling")
> Signed-off-by: Christophe JAILLET
Reviewed-by: Stanislaw Gruszka
would be device reset not require
unregister/register.
> + drm_dev_get(drm);
> + drm_dev_unregister(drm);
That looks odd. I guess there is use-after-free problem if you just do
drm_dev_unregister(). Additional drm_dev_get() does not seems to be right
solution, but I'm not 100% sure, so ...
Reviewed-by: Stanislaw Gruszka
Regards
Stanislaw
Pranjal Ramajor Asha Kanojiya
> Reviewed-by: Carl Vanderlip
> Reviewed-by: Jeffrey Hugo
> Signed-off-by: Jeffrey Hugo
Reviewed-by: Stanislaw Gruszka
1 - 100 of 332 matches
Mail list logo
