Re: [PATCH v2] ARM: dts: bcm2835: Enable 3D rendering through V3D

2024-04-15 Thread Stefan Wahren
Hi Maíra, Am 16.04.24 um 03:02 schrieb Maíra Canal: On 4/15/24 13:54, Andre Przywara wrote: On Mon, 15 Apr 2024 13:00:39 -0300 Maíra Canal wrote: Hi, RPi 0-3 is packed with a GPU that provides 3D rendering capabilities to the RPi. Currently, the downstream kernel uses an overlay to enable

Re: [PATCH] ARM: dts: bcm2835: Enable 3D rendering through V3D

2024-04-14 Thread Stefan Wahren
Hi Phil, Am 14.04.24 um 20:43 schrieb Phil Elwell: Hello all, On Fri, 12 Apr 2024 at 18:17, Stefan Wahren wrote: Hi Maíra, [add Phil & Dave] Am 12.04.24 um 15:25 schrieb Maíra Canal: RPi 0-3 is packed with a GPU that provides 3D rendering capabilities to the RPi. Currently, the downst

Re: [PATCH] ARM: dts: bcm2835: Enable 3D rendering through V3D

2024-04-12 Thread Stefan Wahren
Hi Maíra, [add Phil & Dave] Am 12.04.24 um 15:25 schrieb Maíra Canal: RPi 0-3 is packed with a GPU that provides 3D rendering capabilities to the RPi. Currently, the downstream kernel uses an overlay to enable the GPU and use GPU hardware acceleration. When deploying a mainline kernel to the

[PATCH] drm/vc4: drv: Avoid possible NPD when booted without KMS

2024-02-17 Thread Stefan Wahren
d KMS support for Raspberry Pi.") Signed-off-by: Dom Cobley Signed-off-by: Stefan Wahren --- drivers/gpu/drm/vc4/vc4_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index c133e96b8aca..4f17840df9d3 100644 --- a/drive

Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support

2024-01-09 Thread Stefan Wahren
Hi Neil, Am 09.01.24 um 12:19 schrieb neil.armstr...@linaro.org: Hi, On 09/01/2024 08:09, Shengyang Chen wrote: This patchset adds waveshare 7inch touchscreen panel support for the StarFive JH7110 SoC. Could you precise which SKU you're referring to ? is it 19885 =>

Re: [PATCH v1 0/2] Add waveshare 7inch touchscreen panel support

2023-11-24 Thread Stefan Wahren
Hi Shengyang, [fix address of Emma] Am 24.11.23 um 11:44 schrieb Shengyang Chen: This patchset adds waveshare 7inch touchscreen panel support for the StarFive JH7110 SoC. Patch 1 add new compatible for the raspberrypi panel driver and its dt-binding. Patch 2 add new display mode and new

Re: [PATCH v2 3/4] dt-bindings: gpu: v3d: Add BCM2712's compatible

2023-10-30 Thread Stefan Wahren
Hi Iago, Am 30.10.23 um 11:18 schrieb Iago Toral: El lun, 30-10-2023 a las 10:57 +0100, Stefan Wahren escribió: Hi Iago, Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga: BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its specific compatible to the bindings. v2: new, requested

Re: [PATCH v2 3/4] dt-bindings: gpu: v3d: Add BCM2712's compatible

2023-10-30 Thread Stefan Wahren
Hi Iago, Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga: BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its specific compatible to the bindings. v2: new, requested by Stefan Wahren. Thanks for sending this but the line above belongs below --- since it's not relevant after

Re: [PATCH v2 2/4] drm/v3d: fix up register addresses for V3D 7.x

2023-10-30 Thread Stefan Wahren
Hi Iago, Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga: This patch updates a number of register addresses that have been changed in Raspberry Pi 5 (V3D 7.1) and updates the code to use the corresponding registers and addresses based on the actual V3D version. v2: - added s-o-b and commit

Re: [PATCH v2 2/4] drm/v3d: fix up register addresses for V3D 7.x

2023-10-30 Thread Stefan Wahren
Hi Iago, Am 30.10.23 um 11:14 schrieb Iago Toral: Hi Stefan, El lun, 30-10-2023 a las 10:58 +0100, Stefan Wahren escribió: Hi Iago, Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga: This patch updates a number of register addresses that have been changed in Raspberry Pi 5 (V3D 7.1

Re: [PATCH v2 4/4] drm/v3d: add brcm,2712-v3d as a compatible V3D device

2023-10-30 Thread Stefan Wahren
Hi Iago, Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga: This is required to get the V3D module to load with Raspberry Pi 5. v2: - added s-o-b and commit message. (Maíra) - keep order of compatible strings. (Stefan Wahren) as in the other patch, please move the changelog below

Re: [PATCH 3/3] drm/v3d: add brcm, 2712-v3d as a compatible V3D device

2023-09-29 Thread Stefan Wahren
Hi Iago, additional to Maria's comments: Please keep the order of the compatible strings. Also you need to update the device tree binding before this patch: Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml Also make sure that the series is send to the maintainers, not just dri-devel by

Re: [PATCH] drm/vc4: drop all currently held locks if deadlock happens

2022-12-30 Thread Stefan Wahren
by: Stefan Wahren Signed-off-by: Maíra Canal i cannot provide a review, but at least you can have my: Tested-by: Stefan Wahren

Re: WARNING: CPU: 2 PID: 42 at drivers/gpu/drm/drm_modeset_lock.c:276

2022-12-28 Thread Stefan Wahren
k crtc->mutex inside the driver and let the right lock be automatically acquired by drm_atomic_get_crtc_state(). Reported-by: Stefan Wahren Signed-off-by: Maíra Canal ---  drivers/gpu/drm/vc4/vc4_hdmi.c | 4  1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/dr

Re: WARNING: CPU: 2 PID: 42 at drivers/gpu/drm/drm_modeset_lock.c:276

2022-12-28 Thread Stefan Wahren
Hi, Am 21.12.22 um 20:46 schrieb Stefan Wahren: Hi, if i enable PROVE_LOCKING on the Raspberry Pi 3 B+ (arm/multi_v7_defconfig) using v6.1 (didn't test older versions) i'm getting the following warning: [  204.043396] WARNING: CPU: 2 PID: 42 at drivers/gpu/drm/drm_modeset_lock.c:276

WARNING: CPU: 2 PID: 42 at drivers/gpu/drm/drm_modeset_lock.c:276

2022-12-21 Thread Stefan Wahren
Hi, if i enable PROVE_LOCKING on the Raspberry Pi 3 B+ (arm/multi_v7_defconfig) using v6.1 (didn't test older versions) i'm getting the following warning: [  204.043396] WARNING: CPU: 2 PID: 42 at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x6c/0x70 [  204.043426] Modules

Re: [PATCH 1/2] drm/vc4: hdmi: Enforce the minimum rate at runtime_resume

2022-11-13 Thread Stefan Wahren
Am 11.11.22 um 22:08 schrieb Stefan Wahren: Hi Maxime, Am 29.09.22 um 11:21 schrieb Maxime Ripard: This is a revert of commit fd5894fa2413 ("drm/vc4: hdmi: Remove clock rate initialization"), with the code slightly moved around. It turns out that we can't downright remove that

Re: [PATCH 1/2] drm/vc4: hdmi: Enforce the minimum rate at runtime_resume

2022-11-11 Thread Stefan Wahren
Hi Maxime, Am 29.09.22 um 11:21 schrieb Maxime Ripard: This is a revert of commit fd5894fa2413 ("drm/vc4: hdmi: Remove clock rate initialization"), with the code slightly moved around. It turns out that we can't downright remove that code from the driver, since the Pi0-3 and Pi4 are in

Re: [PATCH v2 3/7] firmware: raspberrypi: Provide a helper to query a clock max rate

2022-10-10 Thread Stefan Wahren
Hi Maxime, Am 20.09.22 um 14:50 schrieb Maxime Ripard: The firmware allows to query for its clocks the operating range of a given clock. We'll need this for some drivers (KMS, in particular) to infer the state of some configuration options, so let's create a function to do so. Signed-off-by:

Re: [PATCH 0/2] drm/vc4: hdmi: Fixes for the RaspberryPi 0-3 stalls

2022-10-10 Thread Stefan Wahren
. This has been tested with 5.19.12. Earlier versions might need a backport of 88110a9f6209 ("clk: bcm2835: fix bcm2835_clock_choose_div"). Could you test/review this? Looks good to me: Tested-by: Stefan Wahren Thanks Maxime

Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()

2022-09-29 Thread Stefan Wahren
Am 29.09.22 um 11:35 schrieb Maxime Ripard: On Tue, Sep 27, 2022 at 03:15:17PM +0200, Maxime Ripard wrote: On Tue, Sep 27, 2022 at 02:25:12PM +0200, Maxime Ripard wrote: On Tue, Sep 27, 2022 at 01:42:40PM +0200, Maxime Ripard wrote: On Tue, Sep 27, 2022 at 01:12:35PM +0200, Stefan Wahren

Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()

2022-09-27 Thread Stefan Wahren
Hi Maxime, Am 27.09.22 um 15:15 schrieb Maxime Ripard: On Tue, Sep 27, 2022 at 02:25:12PM +0200, Maxime Ripard wrote: On Tue, Sep 27, 2022 at 01:42:40PM +0200, Maxime Ripard wrote: On Tue, Sep 27, 2022 at 01:12:35PM +0200, Stefan Wahren wrote: Am 27.09.22 um 11:42 schrieb Maxime Ripard

Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()

2022-09-27 Thread Stefan Wahren
Am 27.09.22 um 11:42 schrieb Maxime Ripard: On Tue, Sep 27, 2022 at 09:25:54AM +0200, Maxime Ripard wrote: Hi Stefan, On Mon, Sep 26, 2022 at 08:50:12PM +0200, Stefan Wahren wrote: Am 26.09.22 um 14:47 schrieb Maxime Ripard: On Mon, Sep 26, 2022 at 02:40:48PM +0200, Marc Kleine-Budde wrote

Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()

2022-09-27 Thread Stefan Wahren
Hi Maxime, Am 27.09.22 um 09:25 schrieb Maxime Ripard: Hi Stefan, On Mon, Sep 26, 2022 at 08:50:12PM +0200, Stefan Wahren wrote: Am 26.09.22 um 14:47 schrieb Maxime Ripard: On Mon, Sep 26, 2022 at 02:40:48PM +0200, Marc Kleine-Budde wrote: On 26.09.2022 14:08:04, Stefan Wahren wrote: Hi

Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()

2022-09-26 Thread Stefan Wahren
Hi Maxime, Am 26.09.22 um 14:47 schrieb Maxime Ripard: On Mon, Sep 26, 2022 at 02:40:48PM +0200, Marc Kleine-Budde wrote: On 26.09.2022 14:08:04, Stefan Wahren wrote: Hi Marc, Am 26.09.22 um 12:21 schrieb Marc Kleine-Budde: On 22.09.2022 17:06:00, Maxime Ripard wrote: I'm on a Raspberry Pi

Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()

2022-09-26 Thread Stefan Wahren
Hi Marc, Am 26.09.22 um 12:21 schrieb Marc Kleine-Budde: On 22.09.2022 17:06:00, Maxime Ripard wrote: I'm on a Raspberry Pi 3 Model B+ running current Debian testing ARM64, using Debian's v5.19 kernel (Debian's v5.18 was working flawless). | [0.00] Booting Linux on physical CPU

Re: Raspberry Pi 3 Model B+ hangs in vc4_hdmi_runtime_resume()

2022-09-22 Thread Stefan Wahren
Hi Marc, Am 22.09.22 um 16:54 schrieb Marc Kleine-Budde: Hello, I'm on a Raspberry Pi 3 Model B+ running current Debian testing ARM64, using Debian's v5.19 kernel (Debian's v5.18 was working flawless). | [0.00] Booting Linux on physical CPU 0x00 [0x410fd034] | [0.00]

Re: [PATCH v2 2/7] firmware: raspberrypi: Move the clock IDs to the firmware header

2022-09-20 Thread Stefan Wahren
Hi Maxime, Am 20.09.22 um 14:50 schrieb Maxime Ripard: We'll need the clock IDs in more drivers than just the clock driver from now on, so let's move them in the firmware header. recently as i reviewed the clk-raspberrypi i noticed this, too. But from my point of view the clock ids should go

Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum

2022-09-15 Thread Stefan Wahren
Hi Maxime, Am 15.09.22 um 09:54 schrieb Maxime Ripard: On Wed, Sep 14, 2022 at 08:26:55PM +0200, Stefan Wahren wrote: Am 14.09.22 um 20:14 schrieb Stephen Boyd: Quoting Stefan Wahren (2022-09-14 11:09:04) Am 14.09.22 um 20:05 schrieb Stephen Boyd: Quoting Stefan Wahren (2022-09-14 10:45:48

Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum

2022-09-15 Thread Stefan Wahren
Hi Stephen, Am 14.09.22 um 20:20 schrieb Stephen Boyd: Quoting Stefan Wahren (2022-09-14 11:09:04) Am 14.09.22 um 20:05 schrieb Stephen Boyd: Quoting Stefan Wahren (2022-09-14 10:45:48) Am 14.09.22 um 17:50 schrieb Stephen Boyd: Furthermore, I wonder if even that part needs

Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum

2022-09-14 Thread Stefan Wahren
Am 14.09.22 um 20:14 schrieb Stephen Boyd: Quoting Stefan Wahren (2022-09-14 11:09:04) Am 14.09.22 um 20:05 schrieb Stephen Boyd: Quoting Stefan Wahren (2022-09-14 10:45:48) Am 14.09.22 um 17:50 schrieb Stephen Boyd: Furthermore, I wonder if even that part needs to be implemented. Why

Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum

2022-09-14 Thread Stefan Wahren
Am 14.09.22 um 20:05 schrieb Stephen Boyd: Quoting Stefan Wahren (2022-09-14 10:45:48) Am 14.09.22 um 17:50 schrieb Stephen Boyd: Furthermore, I wonder if even that part needs to be implemented. Why not make a direct call to rpi_firmware_property() and get the max rate? All of that can live

Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum

2022-09-14 Thread Stefan Wahren
Hi, Am 14.09.22 um 17:50 schrieb Stephen Boyd: Quoting Maxime Ripard (2022-08-15 08:31:24) @@ -254,6 +255,33 @@ static int raspberrypi_fw_dumb_determine_rate(struct clk_hw *hw, return 0; } +unsigned long rpi_firmware_clk_get_max_rate(struct clk *clk) +{ + const struct

Re: [PATCH v2 00/41] drm: Analog TV Improvements

2022-09-07 Thread Stefan Wahren
Hi Maxime, Am 05.09.22 um 16:57 schrieb Maxime Ripard: On Fri, Sep 02, 2022 at 01:28:16PM +0200, Noralf Trønnes wrote: Den 01.09.2022 21.35, skrev Noralf Trønnes: I have finally found a workaround for my kernel hangs. Dom had a look at my kernel and found that the VideoCore was fine, and

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-10 Thread Stefan Wahren
Hi Florian, Am 09.08.22 um 21:02 schrieb Florian Fainelli: On 8/4/22 16:11, Florian Fainelli wrote: On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain attached to the HDMI block, handled in Linux through runtime_pm.

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-09 Thread Stefan Wahren
Hi Florian, Am 05.08.22 um 01:11 schrieb Florian Fainelli: On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain attached to the HDMI block, handled in Linux through runtime_pm. That power domain is shared with the VEC

Re: [next] Rpi4 : WARNING: at drivers/gpu/drm/vc4/vc4_hdmi_regs.h:487 vc5_hdmi_reset+0x1f0/0x240 [vc4]

2022-06-30 Thread Stefan Wahren
Hi Naresh, thanks for your report. Am 30.06.22 um 18:11 schrieb Naresh Kamboju: The following kernel warning found on Rpi4 while booting linux next-20220630. Boot log details [1] & [2]. i think this is related to this: https://lists.freedesktop.org/archives/dri-devel/2022-June/362244.html

Re: drm-misc-next: WARNING: at drivers/gpu/drm/vc4/vc4_hdmi_regs.h:487

2022-06-30 Thread Stefan Wahren
Hi Maxime, Am 30.06.22 um 09:37 schrieb Maxime Ripard: Hi Stefan, On Wed, Jun 29, 2022 at 10:50:21PM +0200, Stefan Wahren wrote: Hi Maxime, i tested todays drm-misc-next 9db35bb349 with Raspberry Pi 3 B Plus (arm/multi_v7_defconfig, mainline DTB) and get the following warning in the kernel

drm-misc-next: WARNING: at drivers/gpu/drm/vc4/vc4_hdmi_regs.h:487

2022-06-29 Thread Stefan Wahren
Hi Maxime, i tested todays drm-misc-next 9db35bb349 with Raspberry Pi 3 B Plus (arm/multi_v7_defconfig, mainline DTB) and get the following warning in the kernel logs: [   25.698459] vc4-drm soc:gpu: bound 3f40.hvs (ops vc4_hvs_ops [vc4]) [   25.698657] [ cut here

Re: drm/vc4: module dysfunctional on Raspberry Pi 3B as of 5.18.0

2022-06-10 Thread Stefan Wahren
Hi, Am 09.06.22 um 23:33 schrieb Stefan Wahren: Hi Peter, Am 09.06.22 um 13:52 schrieb Peter Robinson: As of Linux 5.18.0, module vc4 apparently isn't working on Raspberry Pi 3B any more. If a monitor is attached to the device, the boot messages show up as usual, but right when KMS starts

Re: drm/vc4: module dysfunctional on Raspberry Pi 3B as of 5.18.0

2022-06-09 Thread Stefan Wahren
Hi Peter, Am 09.06.22 um 13:52 schrieb Peter Robinson: As of Linux 5.18.0, module vc4 apparently isn't working on Raspberry Pi 3B any more. If a monitor is attached to the device, the boot messages show up as usual, but right when KMS starts, the screen turns black. Similarly, the screen also

Re: drm/vc4: module dysfunctional on Raspberry Pi 3B as of 5.18.0

2022-06-08 Thread Stefan Wahren
Hi, Am 08.06.22 um 16:36 schrieb Maxime Ripard: Hi Peter(s) On Wed, Jun 08, 2022 at 02:10:19PM +0100, Peter Robinson wrote: Hi Peter, Adding Stefan and Maxime As of Linux 5.18.0, module vc4 apparently isn't working on Raspberry Pi 3B any more. If a monitor is attached to the device, the

Re: [PATCH v6 0/6] Raspberry PI 4 V3D enablement

2022-06-08 Thread Stefan Wahren
Hi Melissa, Am 08.06.22 um 14:51 schrieb Melissa Wen: On 06/03, Peter Robinson wrote: This is a follow up from my v4 patchset. The power management pieces have been split out to a separate independent set of patches by Stefan [1]. This version 5 of the DRM patches are independent and given the

drm/vc4: module dysfunctional on Raspberry Pi 3B as of 5.18.0

2022-06-05 Thread Stefan Wahren
Hi Peter, i didn't subscribe to dri-devel, but i noticed your bug report. Could you please provide more information: Which kernel config do you use (is it a defconfig)? Do you use the mainline device tree blob or the Raspberry Pi DTB? Please provide the version/date of the GPU firmware? Do you

Re: [PATCH v5 6/6] arm64: config: Enable DRM_V3D

2022-06-02 Thread Stefan Wahren
Am 01.06.22 um 13:02 schrieb Peter Robinson: From: Nicolas Saenz Julienne BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its predecessors. Enable it. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren

Re: [PATCH v5 4/6] ARM: dts: bcm2711: Enable V3D

2022-06-02 Thread Stefan Wahren
Hi Peter, Am 01.06.22 um 13:02 schrieb Peter Robinson: This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) and the associated firmware clock entry. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson --- Changes since v5: - Move the firmware clock to

Re: [PATCH v5 3/6] drm/v3d: Add support for bcm2711

2022-06-02 Thread Stefan Wahren
[add Melissa] Am 01.06.22 um 13:02 schrieb Peter Robinson: Add compatible string and Kconfig options for bcm2711. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren --- Changes since v5: - Change compatible to align downstream and othee HW

Re: [PATCH v5 1/6] dt-bindings: gpu: v3d: Add BCM2711's compatible

2022-06-02 Thread Stefan Wahren
Am 01.06.22 um 13:02 schrieb Peter Robinson: BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific compatible to the bindings. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren

Re: [PATCH v5 5/6] ARM: configs: Enable DRM_V3D

2022-06-02 Thread Stefan Wahren
Am 01.06.22 um 13:02 schrieb Peter Robinson: BCM2711, the SoC used on the Raspberry Pi 4 has a different 3D render GPU IP than its predecessors. Enable it it on multi v7 and bcm2835 configs. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Peter Robinson Reviewed-by: Stefan Wahren

Re: vc4: Couldn't stop firmware display driver during boot

2022-05-20 Thread Stefan Wahren
Hi, Am 11.04.22 um 13:00 schrieb Stefan Wahren: Hi Maxime, Am 11.04.22 um 09:35 schrieb Maxime Ripard: Hi Stefan, On Sun, Apr 10, 2022 at 02:32:02AM +0200, Stefan Wahren wrote: Am 09.04.22 um 21:25 schrieb Stefan Wahren: Hi, today i tested Linux 5.18-rc1 on my Raspberry Pi 400 connected

[PATCH 1/2] drm/panel/raspberrypi-touchscreen: Avoid NULL deref if not initialised

2022-04-15 Thread Stefan Wahren
ier in probe. Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.") Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren --- drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH 0/2] drm/panel/raspberrypi-touchscreen: Fix minor issues

2022-04-15 Thread Stefan Wahren
This small patch series tries to upstream 2 minor issues which has been fixed in the vendor tree by Dave Stevenson. Dave Stevenson (2): drm/panel/raspberrypi-touchscreen: Avoid NULL deref if not initialised drm/panel/raspberrypi-touchscreen: Initialise the bridge in prepare

[PATCH 2/2] drm/panel/raspberrypi-touchscreen: Initialise the bridge in prepare

2022-04-15 Thread Stefan Wahren
berry Pi 7" Touchscreen.") Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren --- drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/

Re: vc4: Couldn't stop firmware display driver during boot

2022-04-11 Thread Stefan Wahren
Hi Maxime, Am 11.04.22 um 09:35 schrieb Maxime Ripard: Hi Stefan, On Sun, Apr 10, 2022 at 02:32:02AM +0200, Stefan Wahren wrote: Am 09.04.22 um 21:25 schrieb Stefan Wahren: Hi, today i tested Linux 5.18-rc1 on my Raspberry Pi 400 connected to my HDMI display (multi_v7_defconfig

Re: vc4: Couldn't stop firmware display driver during boot

2022-04-09 Thread Stefan Wahren
Am 09.04.22 um 21:25 schrieb Stefan Wahren: Hi, today i tested Linux 5.18-rc1 on my Raspberry Pi 400 connected to my HDMI display (multi_v7_defconfig + CONFIG_ARM_LPAE, firmware: 2021-01-08T14:31:16) and i'm getting these strange errors from raspberrypi-firmware driver / vc4 during boot

Re: vc4: Couldn't stop firmware display driver during boot

2022-04-09 Thread Stefan Wahren
Hi Phil, Am 09.04.22 um 22:03 schrieb Phil Elwell: You know the drill, Stefan - what's in your config.txt? sure. Everything commented out. Regards Phil On Sat, 9 Apr 2022, 20:26 Stefan Wahren, wrote: Hi, today i tested Linux 5.18-rc1 on my Raspberry Pi 400 connected to my

vc4: Couldn't stop firmware display driver during boot

2022-04-09 Thread Stefan Wahren
Hi, today i tested Linux 5.18-rc1 on my Raspberry Pi 400 connected to my HDMI display (multi_v7_defconfig + CONFIG_ARM_LPAE, firmware: 2021-01-08T14:31:16) and i'm getting these strange errors from raspberrypi-firmware driver / vc4 during boot: [   13.094733] fb0: switching to vc4 from

Re: [PATCH] drm/vc4: crtc: Fix runtime_pm reference counting

2022-02-13 Thread Stefan Wahren
Hi Maxime, i applied your patch on top of Linux 5.17-rc4 and it fixes the tones of warnings after boot (see below). So you can have my Tested-by: Stefan Wahren [    8.341814] [ cut here ] [    8.341820] WARNING: CPU: 1 PID: 7 at drivers/gpu/drm/vc4/vc4_hdmi_regs.h:417

Re: [Regression] No framebuffer console on Rpi since 5.14-rc1

2021-07-28 Thread Stefan Wahren
Hi, Am 15.07.21 um 18:35 schrieb Stefan Wahren: > Hi guys, > > starting with Linux 5.14-rc1 the framebuffer console on Raspberry Pi 3/4 > (no U-Boot, multi_v7_defconfig) isn't available anymore. The display > shows the rainbow screen from the bootloader and than the HDMI scre

[Regression] No framebuffer console on Rpi since 5.14-rc1

2021-07-15 Thread Stefan Wahren
Hi guys, starting with Linux 5.14-rc1 the framebuffer console on Raspberry Pi 3/4 (no U-Boot, multi_v7_defconfig) isn't available anymore. The display shows the rainbow screen from the bootloader and than the HDMI screen goes black instead of kernel messages. I bisected the issue:

Re: [PATCH RFC] drm/vc4: hdmi: Fix connector detect logic

2021-07-07 Thread Stefan Wahren
Hi Maxime, Am 07.07.21 um 15:11 schrieb Maxime Ripard: > On Tue, Jul 06, 2021 at 05:45:27PM +0200, Stefan Wahren wrote: >> Hi Maxime, >> >> Am 06.07.21 um 15:21 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Tue, Jul 06, 2021 at 12:48:05PM +0200

Re: [PATCH RFC] drm/vc4: hdmi: Fix connector detect logic

2021-07-06 Thread Stefan Wahren
Hi Maxime, Am 06.07.21 um 15:21 schrieb Maxime Ripard: > Hi Stefan, > > On Tue, Jul 06, 2021 at 12:48:05PM +0200, Stefan Wahren wrote: >> Am 06.07.21 um 11:58 schrieb Maxime Ripard: >>> Hi, >>> >>> On Mon, Jul 05, 2021 at 11:36:34PM +0200, Stefan Wahren

Re: [PATCH RFC] drm/vc4: hdmi: Fix connector detect logic

2021-07-06 Thread Stefan Wahren
Hi, Am 06.07.21 um 11:58 schrieb Maxime Ripard: > Hi, > > On Mon, Jul 05, 2021 at 11:36:34PM +0200, Stefan Wahren wrote: >> Commit "drm/vc4: hdmi: Convert to gpiod" changes the behavior of >> vc4_hdmi_connector_detect() which results into CPU hangs in case there

[PATCH RFC] drm/vc4: hdmi: Fix connector detect logic

2021-07-05 Thread Stefan Wahren
: hdmi: Convert to gpiod") Signed-off-by: Stefan Wahren --- drivers/gpu/drm/vc4/vc4_hdmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index aab1b36..cf8339c 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi

Re: vc4: hdmi: audio: ASoC: error at snd_soc_dai_startup on fef00700.hdmi

2021-06-28 Thread Stefan Wahren
Am 28.06.21 um 14:28 schrieb Maxime Ripard: > On Thu, Jun 17, 2021 at 07:41:09PM +0200, Stefan Wahren wrote: >> Hi Maxime, >> >> Am 17.06.21 um 17:25 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Sat, Jun 12, 2021 at 12:04:08PM +0200, Stefan Wah

Re: vc4_bo_create: Failed to allocate from CMA

2021-06-17 Thread Stefan Wahren
Hi Nicolas, Am 17.06.21 um 11:36 schrieb nicolas saenz julienne: > On Sat, 2021-06-12 at 17:17 +0200, Stefan Wahren wrote: >> Hi, >> >> while testing the mainline kernel (arm64, defconfig) on Raspberry Pi 3 B >> Plus with Raspberry Pi OS - 64 bit, sometimes X do

Re: vc4: hdmi: audio: ASoC: error at snd_soc_dai_startup on fef00700.hdmi

2021-06-17 Thread Stefan Wahren
Hi Maxime, Am 17.06.21 um 17:25 schrieb Maxime Ripard: > Hi Stefan, > > On Sat, Jun 12, 2021 at 12:04:08PM +0200, Stefan Wahren wrote: >> Hi Maxime, >> >> Am 04.06.21 um 11:02 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> I would assume it's

vc4_bo_create: Failed to allocate from CMA

2021-06-12 Thread Stefan Wahren
Hi, while testing the mainline kernel (arm64, defconfig) on Raspberry Pi 3 B Plus with Raspberry Pi OS - 64 bit, sometimes X doesn't start into desktop properly (unexpected and unusable login screen instead of auto login or mouse pointer is show shorty and than switch back to black screen in a

Re: vc4: hdmi: audio: ASoC: error at snd_soc_dai_startup on fef00700.hdmi

2021-06-12 Thread Stefan Wahren
Hi Maxime, Am 04.06.21 um 11:02 schrieb Maxime Ripard: > Hi Stefan, > > I would assume it's due to this: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/vc4/vc4_hdmi.c#n1083 > > It pre-dates my time working on the vc4 driver so I'm not really sure > what

vc4: hdmi: audio: ASoC: error at snd_soc_dai_startup on fef00700.hdmi

2021-05-26 Thread Stefan Wahren
Hi, yesterday i was testing with Linux 5.13-rc3 on my Raspberry Pi 4 B (multi_v7_defconfig) and i'm getting the following errors during boot: [   25.947494] vc4_hdmi fef00700.hdmi: ASoC: error at snd_soc_dai_startup on fef00700.hdmi: -19 [   25.947512]  MAI: soc_pcm_open() failed (-19) [  

Re: [PATCH RFC] drm/vc4: hdmi: Avoid ASoC error messages on startup

2021-01-18 Thread Stefan Wahren
Hi, Am 15.01.21 um 19:39 schrieb Mark Brown: > On Fri, Jan 15, 2021 at 07:14:37PM +0100, Maxime Ripard wrote: >> On Wed, Jan 13, 2021 at 11:42:23AM +, Mark Brown wrote: >>> On Wed, Jan 13, 2021 at 10:19:57AM +0100, Maxime Ripard wrote: I'd like to get Mark's opinion before merging though

[PATCH V4] dt-bindings: gpu: Convert v3d to json-schema

2021-01-13 Thread Stefan Wahren
This converts the v3d bindings to yaml format. Signed-off-by: Stefan Wahren --- Changes in V4: - define order for required reg-names - adapt example Changes in V3: - drop redundant maxItems in case we already have items defined - fix order of reg-names enum - tag required items in description

Re: [PATCH V3] dt-bindings: gpu: Convert v3d to json-schema

2021-01-13 Thread Stefan Wahren
Hi Maxime, Am 13.01.21 um 10:15 schrieb Maxime Ripard: > Hi, > > On Sat, Jan 09, 2021 at 11:50:32AM +0100, Stefan Wahren wrote: >> This converts the v3d bindings to yaml format. >> >> Signed-off-by: Stefan Wahren >> --- ... >> diff --git a/Documentation/de

Re: [PATCH RFC] drm/vc4: hdmi: Avoid ASoC error messages on startup

2021-01-09 Thread Stefan Wahren
Hi Maxime, Am 29.12.20 um 16:36 schrieb Stefan Wahren: > During startup of Raspberry Pi 4 there seems to be a race between > VC4 probing and Pulseaudio trying to open its PCM device: > > ASoC: error at snd_soc_dai_startup on fef05700.hdmi: -19 > > Avoid these errors by retu

[PATCH V3] dt-bindings: gpu: Convert v3d to json-schema

2021-01-09 Thread Stefan Wahren
This converts the v3d bindings to yaml format. Signed-off-by: Stefan Wahren --- Changes in V3: - drop redundant maxItems in case we already have items defined - fix order of reg-names enum - tag required items in description - add reg-names to required properties - drop clock-names

[PATCH RFC] drm/vc4: hdmi: Avoid ASoC error messages on startup

2020-12-29 Thread Stefan Wahren
During startup of Raspberry Pi 4 there seems to be a race between VC4 probing and Pulseaudio trying to open its PCM device: ASoC: error at snd_soc_dai_startup on fef05700.hdmi: -19 Avoid these errors by returning EPROBE_DEFER in this situation. Signed-off-by: Stefan Wahren --- drivers/gpu

[PATCH 4/4] dt-bindings: gpu: Convert v3d to json-schema

2020-12-23 Thread Stefan Wahren
This converts the v3d bindings to yaml format. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/gpu/brcm,bcm-v3d.txt | 33 -- .../devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 76 ++ 2 files changed, 76 insertions(+), 33 deletions(-) delete mode

[PATCH 0/4] drm/v3d: Minor improvements

2020-12-23 Thread Stefan Wahren
Saenz Julienne (1): drm/v3d: Use platform_get_irq_optional() to get optional IRQs Phil Elwell (2): drm/v3d: Set dma_mask as well as coherent_dma_mask drm/v3d: Don't clear MMU control bits on exception Stefan Wahren (1): dt-bindings: gpu: Convert v3d to json-schema .../devicetree/bindings

[PATCH 3/4] drm/v3d: Don't clear MMU control bits on exception

2020-12-23 Thread Stefan Wahren
From: Phil Elwell MMU exception conditions are reported in the V3D_MMU_CTRL register as write-1-to-clear (W1C) bits. The MMU interrupt handling code clears any exceptions, but does so by masking out any other bits and writing the result back. There are some important control bits in that

[PATCH 2/4] drm/v3d: Set dma_mask as well as coherent_dma_mask

2020-12-23 Thread Stefan Wahren
From: Phil Elwell Both coherent_dma_mask and dma_mask act as constraints on allocations and bounce buffer usage, so be sure to set dma_mask to the appropriate value otherwise the effective mask could be incorrect. Signed-off-by: Phil Elwell --- drivers/gpu/drm/v3d/v3d_drv.c | 4 ++-- 1 file

[PATCH 1/4] drm/v3d: Use platform_get_irq_optional() to get optional IRQs

2020-12-23 Thread Stefan Wahren
From: Nicolas Saenz Julienne Aside from being more correct, the non optional version of the function prints an error when failing to find the IRQ. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/v3d_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH V2 4/4] dt-bindings: gpu: Convert v3d to json-schema

2020-12-23 Thread Stefan Wahren
This converts the v3d bindings to yaml format. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/gpu/brcm,bcm-v3d.txt | 33 -- .../devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 76 ++ 2 files changed, 76 insertions(+), 33 deletions(-) delete mode

[PATCH V2 0/4] drm/v3d: Minor improvements

2020-12-23 Thread Stefan Wahren
in V2: - add missing sob Nicolas Saenz Julienne (1): drm/v3d: Use platform_get_irq_optional() to get optional IRQs Phil Elwell (2): drm/v3d: Set dma_mask as well as coherent_dma_mask drm/v3d: Don't clear MMU control bits on exception Stefan Wahren (1): dt-bindings: gpu: Convert v3d to json

[PATCH V2 2/4] drm/v3d: Set dma_mask as well as coherent_dma_mask

2020-12-23 Thread Stefan Wahren
From: Phil Elwell Both coherent_dma_mask and dma_mask act as constraints on allocations and bounce buffer usage, so be sure to set dma_mask to the appropriate value otherwise the effective mask could be incorrect. Signed-off-by: Phil Elwell Signed-off-by: Stefan Wahren --- drivers/gpu/drm

[PATCH V2 3/4] drm/v3d: Don't clear MMU control bits on exception

2020-12-23 Thread Stefan Wahren
in that register, including MMU_ENABLE, so a safer approach is to simply write back the value just read unaltered. Signed-off-by: Phil Elwell Signed-off-by: Stefan Wahren --- drivers/gpu/drm/v3d/v3d_irq.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_irq.c b

[PATCH V2 1/4] drm/v3d: Use platform_get_irq_optional() to get optional IRQs

2020-12-23 Thread Stefan Wahren
From: Nicolas Saenz Julienne Aside from being more correct, the non optional version of the function prints an error when failing to find the IRQ. Signed-off-by: Nicolas Saenz Julienne Signed-off-by: Stefan Wahren --- drivers/gpu/drm/v3d/v3d_irq.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] dt-bindings: bcm2835-vec: Add power-domains property

2020-12-23 Thread Stefan Wahren
Adding the missing property power-domains to the bcm2835-vec schema to fix the following dtbs_check issue: vec@7e806000: 'power-domains' does not match any of the regexes: ... Signed-off-by: Stefan Wahren --- Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml | 3 +++ 1 file

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-09-30 Thread Stefan Wahren
;>>> Reviewed-by: Dave Stevenson >>>> Tested-by: Chanwoo Choi >>>> Tested-by: Hoegeun Kwon >>>> Tested-by: Stefan Wahren >>>> Signed-off-by: Maxime Ripard >>> Apologies if this has already been reported or have a

Re: [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output

2020-09-01 Thread Stefan Wahren
Hi Maxime, Am 01.09.20 um 11:58 schrieb Maxime Ripard: > Hi Stefan > > On Tue, Aug 25, 2020 at 11:30:58PM +0200, Stefan Wahren wrote: >> Am 25.08.20 um 17:06 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Wed, Jul 29, 2020 at 05:50:31PM +0200, Stef

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-28 Thread Stefan Wahren
Hi Maxime, Am 28.08.20 um 17:25 schrieb Maxime Ripard: > Hi, > > On Fri, Aug 28, 2020 at 02:45:49PM +0200, Stefan Wahren wrote: >> Am 28.08.20 um 08:30 schrieb Hoegeun Kwon: >>> On 8/27/20 6:49 PM, Stefan Wahren wrote: >>>> Am 27.08.20 um 06:35 s

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-28 Thread Stefan Wahren
Hi, Am 28.08.20 um 08:30 schrieb Hoegeun Kwon: > On 8/27/20 6:49 PM, Stefan Wahren wrote: >> Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: >>> Hi Stefan, >>> >>> Thank you for your review. >>> >>> >>> On 8/26/20 7:04 PM, Stefan Wahren

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-27 Thread Stefan Wahren
Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: > Hi Stefan, > > Thank you for your review. > > > On 8/26/20 7:04 PM, Stefan Wahren wrote: >> Hi Hoeguen, >> >> Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: >>> There is a problem that the output does not wor

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-26 Thread Stefan Wahren
Hi Hoeguen, Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: > There is a problem that the output does not work at a resolution > exceeding FHD. To solve this, we need to adjust the bvb clock at a > resolution exceeding FHD. this patch introduces a mandatory clock, please update brcm,bcm2835-hdmi.yaml

Re: [PATCH 0/3] drm/vc4: Support HDMI QHD or higher output

2020-08-26 Thread Stefan Wahren
Hi Hoegeun, Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: > Hi everyone, > > There is a problem that the output does not work at a resolution > exceeding FHD. To solve this, we need to adjust the bvb clock at a > resolution exceeding FHD. thanks for providing this. > > Rebased on top of

Re: [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output

2020-08-25 Thread Stefan Wahren
Hi Maxime, Am 25.08.20 um 17:06 schrieb Maxime Ripard: > Hi Stefan, > > On Wed, Jul 29, 2020 at 05:50:31PM +0200, Stefan Wahren wrote: >> Am 29.07.20 um 16:42 schrieb Maxime Ripard: >>> Hi, >>> >>> On Wed, Jul 29, 2020 at 03:09:21PM +0100, Dave Stevens

Re: [PATCH] drm/vc4/vc4_hdmi: fill ASoC card owner

2020-08-25 Thread Stefan Wahren
Am 10.07.20 um 11:47 schrieb Stefan Wahren: > Hi Marek, > > Am 02.07.20 um 08:58 schrieb Marek Szyprowski: >> On 01.07.2020 20:49, Stefan Wahren wrote: >>> Am 01.07.20 um 09:39 schrieb Marek Szyprowski: >>>> card->owner is a required property and since comm

Re: [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output

2020-07-29 Thread Stefan Wahren
Hi Maxime, Am 29.07.20 um 16:42 schrieb Maxime Ripard: > Hi, > > On Wed, Jul 29, 2020 at 03:09:21PM +0100, Dave Stevenson wrote: >> On Wed, 8 Jul 2020 at 18:43, Maxime Ripard wrote: >>> In order to avoid pixels getting stuck in the (unflushable) FIFO between >>> the HVS and the PV, we need to

Re: [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline

2020-07-10 Thread Stefan Wahren
ify the FIFO level stuff > - Reordered the patches according to Eric's reviews > - Fixed a regression with VID_CTL setting on RPI3 > i additionally applied "drm/vc4/vc4_hdmi: fill ASoC card owner" on top of your series (potential merge conflict). I didn't see any issues wi

Re: [PATCH] drm/vc4/vc4_hdmi: fill ASoC card owner

2020-07-10 Thread Stefan Wahren
Hi Marek, Am 02.07.20 um 08:58 schrieb Marek Szyprowski: > On 01.07.2020 20:49, Stefan Wahren wrote: >> Am 01.07.20 um 09:39 schrieb Marek Szyprowski: >>> card->owner is a required property and since commit 81033c6b584b ("ALSA: >>> core: Warn on empty module&q

Re: [PATCH] drm/vc4/vc4_hdmi: fill ASoC card owner

2020-07-01 Thread Stefan Wahren
Hi Marek, Am 01.07.20 um 09:39 schrieb Marek Szyprowski: > card->owner is a required property and since commit 81033c6b584b ("ALSA: > core: Warn on empty module") a warning is issued if it is empty. Fix lack > of it. This fixes following warning observed on RaspberryPi 3B board > with ARM 32bit

  1   2   >