Re: [DO NOT MERGE v8 14/36] clk: Compatible with narrow registers

2024-05-29 Thread Stephen Boyd
Quoting Yoshinori Sato (2024-05-29 01:01:00) > divider and gate only support 32-bit registers. > Older hardware uses narrower registers, so I want to be able to handle > 8-bit and 16-bit wide registers. > > Seven clk_divider flags are used, and if I add flags for 8bit access and > 16bit access,

Re: [RFC PATCH 1/4] drm/msm: register a fault handler for display mmu faults

2024-05-20 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-05-17 16:37:56) > diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu/drm/msm/msm_kms.c > index af6a6fcb1173..62c8e6163e81 100644 > --- a/drivers/gpu/drm/msm/msm_kms.c > +++ b/drivers/gpu/drm/msm/msm_kms.c > @@ -200,6 +200,28 @@ struct msm_gem_address_space

Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-08 Thread Stephen Boyd
Quoting Jani Nikula (2024-05-08 01:43:56) > On Tue, 07 May 2024, Abhinav Kumar wrote: > > Since commit 5acf49119630 ("drm/msm: import gen_header.py script from > > Mesa"), > > compilation is broken on machines having python versions older than 3.9 > > due to dependency on

Re: [PATCH v3 12/17] clk: mediatek: mt8365-mm: fix DPI0 parent

2024-04-19 Thread Stephen Boyd
Quoting Alexandre Mergnat (2024-04-18 07:17:00) > To have a working display through DPI, a workaround has been > implemented downstream to add "mm_dpi0_dpi0" and "dpi0_sel" to > the DPI node. Shortly, that add an extra clock. > > It seems consistent to have the "dpi0_sel" as parent. >

Re: [PATCH v4 0/5] Pinephone video out fixes (flipping between two frames)

2024-04-08 Thread Stephen Boyd
Quoting Frank Oltmanns (2024-04-03 08:31:47) > Dear clk and sunxi-ng maintainers, > > Patches 1-4 have been reviewed and there are no pending issues. If there > is something else you need me to do to get this applied, please let me > know. > I'm assuming sunxi maintainers will pick up the clk

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-04-03 14:28:52) > > > On 4/3/2024 1:04 PM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2024-04-03 12:58:50) > >> > >> > >> On 4/3/2024 12:51 PM, Stephen Boyd wrote: > >>> Quoting Kuogee Hsieh (2024-03-29 12:

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-04-03 12:58:50) > > > On 4/3/2024 12:51 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2024-03-29 12:50:35) > >> Currently qmp_combo_dp_power_on() always return 0 in regardless of > >> return value of cfg->configure_dp_phy(). Th

Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-04-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2024-03-29 12:50:35) > Currently qmp_combo_dp_power_on() always return 0 in regardless of > return value of cfg->configure_dp_phy(). This patch propagate > return value of cfg->configure_dp_phy() all the way back to caller. Is this found via code inspection or because the

Re: [PATCH v1] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-03-28 Thread Stephen Boyd
Quoting Kuogee Hsieh (2024-03-28 14:07:15) > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index 36632fa..884973a 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -2754,6

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-03-28 13:24:34) > + Johan and Bjorn for FYI > > On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: > > For internal HPD case, hpd_event_thread is created to handle HPD > > interrupts generated by HPD block of DP controller. It converts > > HPD interrupts into events and executed

[PATCH] drm/msm: Add newlines to some debug prints

2024-03-25 Thread Stephen Boyd
m/msm: Move FB debug prints to drm_dbg_state()") Fixes: 721c6e0c6aed ("drm/msm: Move vblank debug prints to drm_dbg_vbl()") Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_fb.c | 6 +++--- drivers/gpu/drm/msm/msm_kms.c | 4 ++-- 2 files changed, 5 insertions(+), 5 dele

Re: [PATCH v2 4/4] drm/msm/dp: Fix typo in static function (ststus => status)

2024-03-18 Thread Stephen Boyd
Quoting Douglas Anderson (2024-03-15 14:36:32) > This is a no-op change to just fix a typo in the name of a static function. > > Signed-off-by: Douglas Anderson > --- > > Changes in v2: > - ("Fix typo in static function (ststus => status)") new for v2. This was sent at

Re: [PATCH] drm/msm/dp: fix runtime_pm handling in dp_wait_hpd_asserted

2024-02-28 Thread Stephen Boyd
function to use pm_runtime_resume_and_get() and return an > error if resume fails. > > Fixes: e2969ee30252 ("drm/msm/dp: move of_dp_aux_populate_bus() to eDP > probe()") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

[PATCH 06/22] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-02-09 Thread Stephen Boyd
Cc: Daniel Vetter Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm_bridge.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 3fce0d8d7dcb..5097e7c65ddf 100644 --- a/drivers/gpu/drm

[PATCH 05/22] drm/atomic-helper: Introduce lane remapping support to bridges

2024-02-09 Thread Stephen Boyd
Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm_atomic_state_helper.c | 2 ++ drivers

[PATCH 00/22] platform/chrome: Add DT USB/DP muxing/topology to Trogdor

2024-02-09 Thread Stephen Boyd
is version in the cover letter so we can all get the full context. I don't expect to merge this through one maintainer tree immediately, so I set the 'To' line to chrome-platform to reflect the overall target audience. Prashant Malani (1): platform/chrome: cros_ec_typec: Purge blocking switch devlinks St

Re: [PATCH] drm/bridge: ps8640: Fix size mismatch warning w/ len

2023-12-18 Thread Stephen Boyd
d >'typeof (msg->size) *' (aka 'unsigned long *')) > [-Werror,-Wcompare-distinct-pointer-types] > > Fix it by declaring the `len` as size_t. > > Fixes: 26195af57798 ("drm/bridge: ps8640: Drop the ability of ps8640 to fetch > the EDID") > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 2/2] drm/bridge: ti-sn65dsi86: Never store more than msg->size bytes in AUX xfer

2023-12-16 Thread Stephen Boyd
de7a ("drm/bridge: ti-sn65dsi86: Update reply on aux failures") > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 1/2] drm/bridge: parade-ps8640: Never store more than msg->size bytes in AUX xfer

2023-12-16 Thread Stephen Boyd
this is what was happening in the crash I looked at. > > Fixes: 13afcdd7277e ("drm/bridge: parade-ps8640: Add support for AUX channel") > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/dpu: drop obsolete documentation for dpu_encoder_virt

2023-12-16 Thread Stephen Boyd
m/msm/dpu: move encoder status to standard encoder > debugfs dir") > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 1/2] drm/bridge: parade-ps8640: Never increase the length when reading from AUX

2023-12-13 Thread Stephen Boyd
Quoting Douglas Anderson (2023-12-11 16:55:26) > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > b/drivers/gpu/drm/bridge/parade-ps8640.c > index 8161b1a1a4b1..fb2ec4264549 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -302,7

Re: [PATCH v7 0/7] incorporate pm runtime framework and eDP clean up

2023-10-10 Thread Stephen Boyd
rm/msm/dp/dp_aux.c | 39 +++- > drivers/gpu/drm/msm/dp/dp_display.c | 333 > Tested-by: Stephen Boyd # Trogdor.Lazor I ran some suspend cycles too with the lid open and closed.

Re: [PATCH] drm/msm/dp: support setting the DP subconnector type

2023-10-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-03 15:24:32) > Read the downstream port info and set the subconnector type accordingly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/bridge: ti-sn65dsi86: Associate DSI device lifetime with auxiliary device

2023-10-05 Thread Stephen Boyd
Quoting Doug Anderson (2023-10-02 17:31:41) > Hi, > > On Mon, Oct 2, 2023 at 4:54 PM Stephen Boyd wrote: > > > > The kernel produces a warning splat and the DSI device fails to register > > in this driver if the i2c driver probes, populates child auxiliary >

[PATCH] drm/bridge: ti-sn65dsi86: Associate DSI device lifetime with auxiliary device

2023-10-02 Thread Stephen Boyd
faster. Cc: Douglas Anderson Cc: Maxime Ripard Fixes: c3b75d4734cb ("drm/bridge: sn65dsi86: Register and attach our DSI device at probe") Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-10-02 Thread Stephen Boyd
Quoting Abhinav Kumar (2023-09-28 17:46:11) > On 9/27/2023 3:01 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2023-09-25 09:07:18) > >> > >> However for external DP case, link training can not be guarantee always > >> success without link rate or lan

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-27 Thread Stephen Boyd
Quoting Kuogee Hsieh (2023-09-25 09:07:18) > > On 9/22/2023 6:35 PM, Abhinav Kumar wrote: > > > > Doing link training when we get hpd instead of atomic_enable() is a > > design choice we have been following for a while because for the case > > when link training fails in atomic_enable() and

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-27 Thread Stephen Boyd
Quoting Abhinav Kumar (2023-09-22 18:35:27) > On 9/22/2023 2:54 PM, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2023-09-19 02:50:12) > >> > >> This should be hpd_notify, who starts link training, not some event. > > > > I think this driver sho

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-22 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-19 02:50:12) > On Mon, 18 Sept 2023 at 20:48, Kuogee Hsieh wrote: > > > > > > On 9/15/2023 6:21 PM, Dmitry Baryshkov wrote: > > > On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh > > > wrote: > > >> Add pm_runtime_force_suspend()/resume() to complete incorporating

Re: [PATCH] drm/msm/dp: support setting the DP subconnector type

2023-09-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-07 14:48:54) > On 08/09/2023 00:34, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2023-09-03 15:24:32) > >> diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c > >> b/drivers/gpu/drm/msm/dp/dp_panel.c > >> index 97ba41593820..1c

Re: [PATCH] drm/msm/dp: skip validity check for DP CTS EDID checksum

2023-09-07 Thread Stephen Boyd
ther in the future. > > (*) drm_get_edid() ignores checksum errors on CTA extensions. > > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Kuogee Hsieh > Cc: Marijn Suijten > Cc: Rob Clark > Cc: Sean Paul > Cc: Stephen Boyd > Cc: linux-arm-...@vger.kern

Re: [PATCH] drm/msm/dp: support setting the DP subconnector type

2023-09-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-03 15:24:32) > diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c > b/drivers/gpu/drm/msm/dp/dp_panel.c > index 97ba41593820..1cb54f26f5aa 100644 > --- a/drivers/gpu/drm/msm/dp/dp_panel.c > +++ b/drivers/gpu/drm/msm/dp/dp_panel.c > @@ -162,6 +162,11 @@ int

Re: [PATCH 4/6] drm/msm: add a kernel param to select between MDP5 and DPU drivers

2023-09-06 Thread Stephen Boyd
ers. > > All platforms supported by both drivers are by default handled by the > MDP5 driver. To let them be handled by the DPU driver pass the > `msm.prefer_mdp5=false` kernel param. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/6] drm/msm/dpu: support binding to the mdp5 devices

2023-09-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-05 10:43:50) > diff --git a/drivers/gpu/drm/msm/msm_io_utils.c > b/drivers/gpu/drm/msm/msm_io_utils.c > index 59d2788c4510..9d0d76f3a319 100644 > --- a/drivers/gpu/drm/msm/msm_io_utils.c > +++ b/drivers/gpu/drm/msm/msm_io_utils.c > @@ -50,6 +50,24 @@ struct clk

Re: [PATCH 2/6] drm/msm/mdss: generate MDSS data for MDP5 platforms

2023-09-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-05 10:43:49) > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index 348c66b14683..fb6ee93b5abc 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -222,6 +222,36 @@ static void

Re: [PATCH v3 5/8] drm/msm/dpu: enable INTF TE operations only when supported by HW

2023-09-06 Thread Stephen Boyd
nstances, check for the major && INTF type. > > Reviewed-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 6/8] drm/msm/dpu: drop DPU_INTF_TE feature flag

2023-09-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-03 19:04:52) > Replace the only user of the DPU_INTF_TE feature flag with the direct > DPU version comparison. > > Reviewed-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 7/8] drm/msm/dpu: drop useless check from dpu_encoder_phys_cmd_te_rd_ptr_irq()

2023-09-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-03 19:04:53) > The dpu_encoder_phys_cmd_te_rd_ptr_irq() function uses neither hw_intf > nor hw_pp data, so we can drop the corresponding check. > > Reviewed-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 8/8] drm/msm/dpu: move INTF tearing checks to dpu_encoder_phys_cmd_init

2023-09-06 Thread Stephen Boyd
g this check in dpu_encoder_phys_cmd_tearcheck_config() is less > useful, as this function returns void. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 4/8] drm/msm/dpu: inline _setup_intf_ops()

2023-09-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-03 19:04:50) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c > index 8ec6505d9e78..dd67686f5403 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c > +++

Re: [PATCH v3 3/8] drm/msm/dpu: drop the DPU_PINGPONG_TE flag

2023-09-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-03 19:04:49) > The DPU_PINGPONG_TE flag became unused, we can drop it now. > > Reviewed-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 2/8] drm/msm/dpu: enable PINGPONG TE operations only when supported by HW

2023-09-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-03 19:04:48) > The DPU_PINGPONG_TE bit is set for all PINGPONG blocks on DPU < 5.0. > Rather than checking for the flag, check for the presense of the s/presense/presence/ > corresponding interrupt line. The patch checks for the major version though?

Re: [PATCH v3 1/8] drm/msm/dpu: inline _setup_pingpong_ops()

2023-09-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-03 19:04:47) > Inline the _setup_pingpong_ops() function, it makes it easier to handle > different conditions involving PINGPONG configuration. > > Reviewed-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

[PATCH 2/2] drm/msm/dp: Remove error message when downstream port not connected

2023-09-06 Thread Stephen Boyd
count device. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index 97ba41593820..ae778e1a6fd0 100644 --- a/drivers

[PATCH 1/2] drm/msm/dp: Inline dp_display_is_sink_count_zero()

2023-09-06 Thread Stephen Boyd
This function is basically a one-liner when you ignore the debug logging. Just inline the function and drop the log to simplify the code. Suggested-by: Dmitry Baryshkov Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_display.c | 10 +- 1

[PATCH 0/2] drm/msm/dp: More DPCD cleanups

2023-09-06 Thread Stephen Boyd
This is a follow-on to this series[1]. I can resend the whole pile if desired. [1] https://lore.kernel.org/r/20230829184735.2841739-1-swb...@chromium.org Stephen Boyd (2): drm/msm/dp: Inline dp_display_is_sink_count_zero() drm/msm/dp: Remove error message when downstream port not connected

Re: [PATCH 7/7] drm/msm/dp: Remove dp_display_is_ds_bridge()

2023-09-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-03 15:40:49) > On 29/08/2023 21:47, Stephen Boyd wrote: > > This function is simply drm_dp_is_branch() so use that instead of > > open-coding it. > > > > Cc: Vinod Polimera > > Cc: Kuogee Hsieh > > Signed-off-by: Stephen

[PATCH 6/7] drm/msm/dp: Inline dp_link_parse_sink_count()

2023-08-29 Thread Stephen Boyd
ust use drm_dp_read_sink_count() in the one place this function is called to simplify. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_link.c | 38 +++- 1 file changed, 3 insertions(+), 35 deletions(-) diff --git a/driv

[PATCH 2/7] drm/msm/dp: Use drm_dp_read_sink_count() helper

2023-08-29 Thread Stephen Boyd
Use the common function drm_dp_read_sink_count() instead of open-coding it. This shrinks the kernel text a tiny bit. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions

[PATCH 7/7] drm/msm/dp: Remove dp_display_is_ds_bridge()

2023-08-29 Thread Stephen Boyd
This function is simply drm_dp_is_branch() so use that instead of open-coding it. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_display.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp

[PATCH 5/7] drm/msm/dp: Simplify with drm_dp_{max_link_rate, max_lane_count}()

2023-08-29 Thread Stephen Boyd
These are open-coded versions of common functions. Replace them with the common code to improve readability. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 4/7] drm/msm/dp: Remove aux_cfg_update_done and related code

2023-08-29 Thread Stephen Boyd
The member 'aux_cfg_update_done' is always false. This is dead code that never runs. Remove it. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/gpu/drm/msm/dp

[PATCH 3/7] drm/msm/dp: Remove dead code related to downstream cap info

2023-08-29 Thread Stephen Boyd
to downstream ports. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 25 +++-- drivers/gpu/drm/msm/dp/dp_panel.h | 6 -- 2 files changed, 3 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/msm/dp

[PATCH 1/7] drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps()

2023-08-29 Thread Stephen Boyd
Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 42 --- drivers/gpu/drm/msm/dp/dp_panel.h | 4 +-- 2 files changed, 6 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp

[PATCH 0/7] drm/msm/dp: Simplify DPCD related code with helpers

2023-08-29 Thread Stephen Boyd
, but I haven't tried to do that yet. Stephen Boyd (7): drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps() drm/msm/dp: Use drm_dp_read_sink_count() helper drm/msm/dp: Remove dead code related to downstream cap info drm/msm/dp: Remove aux_cfg_update_done and related code drm/msm/dp: Simplify

[PATCH] drm/connector: Add newline to debug printk

2023-08-25 Thread Stephen Boyd
Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 3ed4cfcb350c..ab1467a15f9a 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drive

[PATCH] drm/msm/dp: Add newlines to debug printks

2023-08-25 Thread Stephen Boyd
These debug printks are missing newlines, causing drm debug logs to be hard to read. Add newlines so that the messages are on their own line. Cc: Kuogee Hsieh Cc: Vinod Polimera Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_link.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v1] drm/msm/dp: do not reinitialize phy unless retry during link training

2023-08-25 Thread Stephen Boyd
t; failed. > > [drm:dp_aux_isr] *ERROR* Unexpected DP AUX IRQ 0x0100 when not busy > > Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") > Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/30 > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH] clk: Annotate struct clk_hw_onecell_data with __counted_by

2023-08-22 Thread Stephen Boyd
ialization earlier. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Joel Stanley > Cc: Andrew Jeffery > Cc: Taichi Sugaya > Cc: Takao Orito > Cc: Qin Jia

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Fix auxiliary bus lifetime

2023-06-13 Thread Stephen Boyd
nce to the parent), the parent's "devm" allocated memory is a > different story. That appears to be freed much earlier. > > Let's make this better for ti-sn65dsi86 by allocating each auxiliary > with kzalloc and then free that memory in the release(). > > Fixes: bf73537f411b (&quo

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix auxiliary bus lifetime

2023-06-12 Thread Stephen Boyd
nce to the parent), the parent's "devm" allocated memory is a > different story. That appears to be freed much earlier. > > Let's make this better for ti-sn65dsi86 by allocating each auxiliary > with kzalloc and then free that memory in the release(). > > Fixes: bf73537f411b (&quo

Re: [PATCH v4 00/68] clk: Make determine_rate mandatory for muxes

2023-06-08 Thread Stephen Boyd
Quoting Maxime Ripard (2023-05-05 04:25:02) > Hi, > > This is a follow-up to a previous series that was printing a warning > when a mux has a set_parent implementation but is missing > determine_rate(). > > The rationale is that set_parent() is very likely to be useful when > changing the rate,

Re: [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-12 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-05-11 17:54:19) > On Fri, 12 May 2023 at 03:16, Kuogee Hsieh wrote: > > 1) DP with GPIO: No downstream drm_bridge are connected, is_edp = false > > and internal HPD-logic is in used (internal_hpd = true). Power needs to > > be on at all times etc. > > > > 2) DP

Re: [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-11 Thread Stephen Boyd
Quoting Bjorn Andersson (2023-05-11 08:44:16) > On Wed, May 10, 2023 at 05:39:07PM -0700, Abhinav Kumar wrote: > > > > > > On 5/10/2023 4:55 PM, Stephen Boyd wrote: > > > Quoting Kuogee Hsieh (2023-05-10 13:31:04) > > > > The internal_hpd flag was in

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-05-11 Thread Stephen Boyd
Quoting Pin-yen Lin (2023-05-09 20:41:54) > On Sat, Apr 29, 2023 at 12:47 PM Stephen Boyd wrote: > > > > Good point. I'm suggesting to make the drm bridge chain into a tree. We > > need to teach drm_bridge core about a mux, and have some logic to > > navigate atomicall

Re: [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2023-05-10 13:31:04) > The internal_hpd flag was introduced to handle external DP HPD derived from > GPIO > pinmuxed into DP controller. Was it? It looks more like it was done to differentiate between eDP and DP, because internal_hpd is set only if DRM_BRIDGE_OP_HPD is set

Re: [PATCH v1 2/2] drm/msm/dp: add mutex to protect internal_hpd against race condition between different threads

2023-05-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2023-05-10 13:31:05) > Intrenal_hpd is referenced by event thread but set by drm bridge callback > context. Add mutex to protect internal_hpd to avoid conflicts between > threads. > > Signed-off-by: Kuogee Hsieh > --- This patch looks completely unnecessary. How can

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-28 Thread Stephen Boyd
Quoting Pin-yen Lin (2023-04-20 02:10:46) > On Thu, Apr 20, 2023 at 2:10 PM Stephen Boyd wrote: > > > > Quoting Stephen Boyd (2023-04-13 17:22:46) > > > Quoting Pin-yen Lin (2023-04-13 02:50:44) > > > > > > > > Actually t

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-20 Thread Stephen Boyd
Quoting Stephen Boyd (2023-04-13 17:22:46) > Quoting Pin-yen Lin (2023-04-13 02:50:44) > > > > Actually the `mode-switch` property here is mainly because > > `fwnode_typec_mux_get`[1] and `typec_mux_match`[2] only return matches > > when the property is present. I am

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-13 Thread Stephen Boyd
Quoting Pin-yen Lin (2023-04-13 02:50:44) > Hi Stephen, > > On Wed, Apr 12, 2023 at 10:38 AM Stephen Boyd wrote: > > > > Quoting Pin-yen Lin (2023-03-31 02:11:39) > > > diff --git > > > a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625

Re: [PATCH v3 00/65] clk: Make determine_rate mandatory for muxes

2023-04-13 Thread Stephen Boyd
Quoting Maxime Ripard (2023-04-04 03:10:50) > Hi, > > This is a follow-up to a previous series that was printing a warning > when a mux has a set_parent implementation but is missing > determine_rate(). > > The rationale is that set_parent() is very likely to be useful when > changing the rate,

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-11 Thread Stephen Boyd
Quoting Pin-yen Lin (2023-03-31 02:11:39) > diff --git > a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index b42553ac505c..604c7391d74f 100644 > ---

Re: [PATCH v2 2/2] drm/msm/adreno: change adreno_is_* functions to accept const argument

2023-04-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-04-11 09:19:03) > All adreno_is_*() functions do not modify their argument in any way, so > they can be changed to accept const struct adreno_gpu pointer. > > Suggested-by: Stephen Boyd > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 1/2] drm/msm/adreno: warn if chip revn is verified before being set

2023-04-11 Thread Stephen Boyd
ry so that the warning is displayed really just once instead of > being displayed for each of comparisons. > > Suggested-by: Stephen Boyd > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/adreno: warn if chip revn is verified before being set

2023-04-10 Thread Stephen Boyd
ry so that the warning is displayed really just once instead of > being displayed for each of comparisons. > > Suggested-by: Stephen Boyd > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 63 - > 1 file changed, 40 in

Re: [RFC PATCH] drm/msm/a5xx: really check for A510 in a5xx_gpu_init

2023-04-10 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-04-08 18:13:29) > The commit 010c8bbad2cb ("drm: msm: adreno: Disable preemption on Adreno > 510") added special handling for a510 (this SKU doesn't seem to support > preemption, so the driver should clamp nr_rings to 1). However the > gpu->revn is not yet set (it is

Re: [PATCH] drm/msm/adreno: fix sparse warnings in a6xx code

2023-04-10 Thread Stephen Boyd
gt; @@ -51,8 +51,8 @@ struct a6xx_gmu { > > struct msm_gem_address_space *aspace; > > - void * __iomem mmio; > - void * __iomem rscc; > + void __iomem * mmio; > + void __iomem * rscc; Should stick that * to the member name. void __iomem *rscc; with that Reviewed-by: Stephen Boyd

Re: [PATCH v15 01/10] device property: Add remote endpoint to devcon matcher

2023-04-07 Thread Stephen Boyd
Quoting Pin-yen Lin (2023-03-31 02:11:36) > From: Prashant Malani > > When searching the device graph for device matches, check the > remote-endpoint itself for a match. > > Some drivers register devices for individual endpoints. This allows > the matcher code to evaluate those for a match too,

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2023-03-29 Thread Stephen Boyd
Quoting Maxime Ripard (2023-03-29 12:50:49) > On Wed, Mar 22, 2023 at 04:31:04PM -0700, Stephen Boyd wrote: > > > The clk_set_parent() path is valid for those cases. Probably nobody > > cares about determine_rate because they don't set rates on these clks. > > Some driv

Re: [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support

2023-03-27 Thread Stephen Boyd
Quoting Bjorn Andersson (2023-03-26 09:35:56) > On Sun, Mar 26, 2023 at 09:27:23AM -0700, Bjorn Andersson wrote: > > On Thu, Mar 02, 2023 at 10:03:17PM +0530, Vinod Polimera wrote: > > > For the PSR to kick in, self_refresh_aware has to be set. > > > Initialize it based on the PSR support for the

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-03-22 Thread Stephen Boyd
Quoting Maxime Ripard (2022-11-09 03:00:45) > On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: > > > > Maxime Ripard writes: > > > > > Hi, > > > > > > On Fri, Nov 04, 2022 at 05:35:29PM +, Aidan MacDonald wrote: > > > > Assigning the parent clock in the DT works once, at

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2023-03-22 Thread Stephen Boyd
Quoting Maxime Ripard (2022-11-07 07:26:03) > On Mon, Nov 07, 2022 at 12:06:07PM +, Mark Brown wrote: > > On Mon, Nov 07, 2022 at 09:43:22AM +0100, Maxime Ripard wrote: > > > On Fri, Nov 04, 2022 at 03:59:53PM +, Mark Brown wrote: > > > > > > Well, hopefully everyone for whom it's an

Re: [PATCH v2 00/65] clk: Make determine_rate mandatory for muxes

2023-03-22 Thread Stephen Boyd
Quoting Maxime Ripard (2023-03-22 03:01:53) > Hi Stephen, > > On Tue, Mar 21, 2023 at 04:55:03PM -0700, Stephen Boyd wrote: > > Quoting Maxime Ripard (2022-11-04 06:17:17) > > > Hi, > > > > > > This is a follow-up to a previous series that was printing a

Re: [PATCH v2 00/65] clk: Make determine_rate mandatory for muxes

2023-03-21 Thread Stephen Boyd
Quoting Maxime Ripard (2022-11-04 06:17:17) > Hi, > > This is a follow-up to a previous series that was printing a warning > when a mux has a set_parent implementation but is missing > determine_rate(). > > The rationale is that set_parent() is very likely to be useful when > changing the rate,

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-21 Thread Stephen Boyd
Quoting Matti Vaittinen (2023-03-20 22:45:52) > Morning Stephen, > > On 3/20/23 21:23, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2023-03-18 23:36:20) > >>> > >>> I think you would have an easier time if you just copied and renamed > >>>

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-20 Thread Stephen Boyd
Quoting Matti Vaittinen (2023-03-18 23:36:20) > > > > I think you would have an easier time if you just copied and renamed > > them into the kunit folder as an preparation series. > > Yes. That would simplify the syncing between the trees. It slightly bugs > me to add dublicate code in

Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'

2023-03-06 Thread Stephen Boyd
ith comments which were not intended to be > comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and > brcm,bcmgenet.yaml. > > Signed-off-by: Rob Herring Reviewed-by: Stephen Boyd > diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml > b/Doc

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-03-01 Thread Stephen Boyd
re exposed and fixed. > > Signed-off-by: Rob Herring > --- Reviewed-by: Stephen Boyd > diff --git a/Documentation/devicetree/bindings/clock/ti,lmk04832.yaml > b/Documentation/devicetree/bindings/clock/ti,lmk04832.yaml > index 73d17830f165..13d7b3d03d84 100644 > --- a/Docu

Re: [PATCH] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-02-27 Thread Stephen Boyd
n > interrupt received") > Signed-off-by: Kuogee Hsieh The code looks OK to me, so Reviewed-by: Stephen Boyd once the commit text is cleaned up to indicate the proper function names.

Re: [PATCH v1] drm/msm/disp/dpu: fix sc7280_pp base address

2023-02-27 Thread Stephen Boyd
Quoting Kuogee Hsieh (2023-02-27 09:04:31) > Correct sc7280 pp block base address. What goes wrong if this is left unchanged? How important is it to fix this? Does the display fail to work? Does it fix something for a new feature that isn't yet enabled upstream? This information is useful to put

Re: [PATCH v6 2/2] drm/msm/dp: enhance dp controller isr

2023-01-18 Thread Stephen Boyd
Quoting Doug Anderson (2023-01-18 10:29:59) > Hi, > > On Tue, Dec 27, 2022 at 6:16 PM Kuogee Hsieh wrote: > > + > > if (isr & DP_INTR_AUX_ERROR) { > > aux->aux_error_num = DP_AUX_ERR_PHY; > > dp_catalog_aux_clear_hw_interrupts(aux->catalog); > > +

Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable

2023-01-18 Thread Stephen Boyd
Quoting Stephen Boyd (2023-01-13 12:49:43) > Quoting Sam Ravnborg (2023-01-13 06:52:09) > > Hi Stephen, > > On Tue, Jan 10, 2023 at 11:29:41AM -0800, Stephen Boyd wrote: > > > > > > After this patch the unprepare only bails out early if the bool > &

Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable

2023-01-17 Thread Stephen Boyd
Quoting Dave Stevenson (2023-01-16 06:11:02) > Hi Stephen > > On Fri, 13 Jan 2023 at 21:12, Stephen Boyd wrote: > > > > > > Thanks for the info! It says "Drivers that need the underlying device to > > be powered to perform these operations will first ne

Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable

2023-01-13 Thread Stephen Boyd
Quoting Dave Stevenson (2023-01-13 08:27:29) > Hi Stephen > > On Fri, 6 Jan 2023 at 03:01, Stephen Boyd wrote: > > > > The unprepare sequence has started to fail after moving to panel bridge > > code in the msm drm driver (commit 007ac0262b0d ("drm/msm/dsi

Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable

2023-01-13 Thread Stephen Boyd
Quoting Sam Ravnborg (2023-01-13 06:52:09) > Hi Stephen, > On Tue, Jan 10, 2023 at 11:29:41AM -0800, Stephen Boyd wrote: > > Quoting Sam Ravnborg (2023-01-07 12:28:41) > > > > > > > > For this case we could ask ourself if the display needs to enter slee

Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable

2023-01-10 Thread Stephen Boyd
Quoting Sam Ravnborg (2023-01-07 12:28:41) > On Thu, Jan 05, 2023 at 07:01:08PM -0800, Stephen Boyd wrote: > > The unprepare sequence has started to fail after moving to panel bridge > > code in the msm drm driver (commit 007ac0262b0d ("drm/msm/dsi: switch to > > DRM_P

[PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable

2023-01-05 Thread Stephen Boyd
7ac0262b0d ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE") Fixes: a869b9db7adf ("drm/panel: support for boe tv101wum-nl6 wuxga dsi video mode panel") Cc: yangcong Cc: Douglas Anderson Cc: Jitao Shi Cc: Sam Ravnborg Cc: Rob Clark Cc: Dmitry Baryshkov Signed-off-by: Stephen Bo

Re: [PATCH 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag

2022-12-16 Thread Stephen Boyd
Quoting Akhil P Oommen (2022-12-15 07:10:58) > Add support for the newly added 'synced_poweroff' genpd flag. This allows > some clients (like adreno gpu driver) to request gdsc driver to ensure > a votable gdsc (like gpucc cx gdsc) has collapsed at hardware. > > Signed-off-by: Akhil P Oommen >

Re: [PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-12-15 13:12:49) > On 15/12/2022 02:38, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-12-14 14:56:23) > >> > >> Once link training start, then there are no any interactions between > >> controller and phy during link traini

Re: [PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-15 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-12-15 09:08:04) > > On 12/14/2022 4:38 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-12-14 14:56:23) > >> On 12/13/2022 3:06 PM, Stephen Boyd wrote: > >>> Quoting Kuogee Hsieh (2022-12-13 13:44:05) > > > >> There

  1   2   3   4   5   6   7   8   9   10   >