RE: [PATCH v9 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-25 Thread Stephen Boyd
Quoting Sankeerth Billakanti (QUIC) (2022-04-24 19:55:29) > >Quoting Sankeerth Billakanti (2022-04-22 02:11:04) > > > >> int dp_catalog_ctrl_get_interrupt(struct dp_catalog *dp_catalog) diff > >> --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index

RE: [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-25 Thread Stephen Boyd
00644 > >> --- a/drivers/gpu/drm/msm/dp/dp_display.c > >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c > > > >Some nitpicks > > > >Reviewed-by: Stephen Boyd > > > >> @@ -1508,7 +1509,8 @@ void msm_dp_irq_postinstall(struct msm_dp > >> *dp_d

Re: [PATCH] drm/msm: fix returnvar.cocci warning

2022-04-25 Thread Stephen Boyd
Quoting Guo Zhengkui (2022-04-25 05:22:21) > Fix the following coccicheck warning: > drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c:24:5-8: Unneeded variable: > "ret". Return "0" on line 75. > > Signed-off-by: Guo Zhengkui > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread Stephen Boyd
;) > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi > --- This one fixes a commit that moved away from platform APIs! Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread Stephen Boyd
t") > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi > --- Question still stands why we can't use platform device APIs. Reviewed-by: Stephen Boyd

Re: [PATCH v9 4/4] drm/msm/dp: Support the eDP modes given by panel

2022-04-22 Thread Stephen Boyd
opulate only > the supported modes for now. > > Signed-off-by: Sankeerth Billakanti > Reviewed-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v9 3/4] drm/msm/dp: wait for hpd high before aux transaction

2022-04-22 Thread Stephen Boyd
or a DP sink. > > Signed-off-by: Sankeerth Billakanti > Reviewed-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v9 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-22 Thread Stephen Boyd
this replug interrupt question below. Otherwise Reviewed-by: Stephen Boyd > int dp_catalog_ctrl_get_interrupt(struct dp_catalog *dp_catalog) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 055681a..dea4de9 100644 > --- a/drivers/gpu/

Re: [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-22 Thread Stephen Boyd
picks Reviewed-by: Stephen Boyd > @@ -1508,7 +1509,8 @@ void msm_dp_irq_postinstall(struct msm_dp *dp_display) > > dp_hpd_event_setup(dp); > > - dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100); > + if (!dp_display->is_edp) > + dp_add_event(dp, EV_HP

Re: [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-22 Thread Stephen Boyd
ired for >mode_config.mutex while > adding fail safe mode since it has been hold by drm thread already. Reported-by: Douglas Anderson Fixes: 8b2c181e3dcf ("drm/msm/dp: add fail safe mode outside of event_mutex context") Reviewed-by: Stephen Boyd

Re: [PATCH 37/48] ARM: pxa: move smemc register access from clk to platform

2022-04-22 Thread Stephen Boyd
Michael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Link: https://lore.kernel.org/lkml/87pnielzo4@belgarion.home/ > Signed-off-by: Arnd Bergmann > --- Acked-by: Stephen Boyd

Re: [PATCH 36/48] cpufreq: pxa3: move clk register access to clk driver

2022-04-22 Thread Stephen Boyd
Quoting Arnd Bergmann (2022-04-19 09:37:58) > diff --git a/include/linux/clk/pxa.h b/include/linux/clk/pxa.h > new file mode 100644 > index ..e5516c608c99 > --- /dev/null > +++ b/include/linux/clk/pxa.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +#ifdef

Re: [PATCH] drm/msm/dp: fix error check return value of irq_of_parse_and_map()

2022-04-22 Thread Stephen Boyd
Quoting cgel@gmail.com (2022-04-22 01:49:51) > From: Lv Ruyi > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return an negative value. > > Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon > Chipsets") > Reported-by: Zeal Robot >

Re: [PATCH v2] drm/msm/dp: enhance both connect and disconnect pending_timeout handle

2022-04-20 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-15 17:06:48) > > On 4/14/2022 4:34 PM, Dmitry Baryshkov wrote: > > > > I'm not sure how should the driver react if the client doesn't disable > > the output, but then the sink gets reattached? > > I do not know that either. > > But it should not happen as long as

Re: [PATCH] drm/msm/dp: tear down main link at unplug handle immediately

2022-04-20 Thread Stephen Boyd
2. With this approach, dp driver is much > more resilient to any different scenarios. Also redundant both > dp_connect_pending_timeout() and dp_disconnect_pending_timeout() > are removed to reduce logic complexity. > > Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapd

Re: [PATCH v9] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-18 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-15 16:47:25) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 01453db..5b289b9 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -266,9 +269,18 @@ static int

Re: [PATCH v6] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-15 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-15 08:41:16) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 01453db..92c9819 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -230,6 +231,14 @@ void

Re: [PATCH] drm/msm: remove unused hotplug and edid macros from msm_drv.h

2022-04-15 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-04-15 12:09:42) > Remove unused MSM_DISPLAY_CAP_HOT_PLUG and MSM_DISPLAY_CAP_EDID > macros from msm_drv.h. > > Even if we need these, there are drm equivalent ones present. > > Reported-by: Dmitry Baryshkov > Signed-off-by: Abhinav Kumar > -

Re: [PATCH v5] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-14 Thread Stephen Boyd
truct device *dev, struct device *master, >void *data) > { Otherwise Reviewed-by: Stephen Boyd

Re: [RFC PATCH 1/6] drm/dp: Helpers to make it easier for drivers to use DP AUX bus properly

2022-04-14 Thread Stephen Boyd
Quoting Douglas Anderson (2022-04-08 19:36:23) > As talked about in the kerneldoc for "struct dp_aux_ep_client" in this > patch and also in the past in commit a1e3667a9835 ("drm/bridge: > ti-sn65dsi86: Promote the AUX channel to its own sub-dev"), to use the > DP AUX bus properly we really need

Re: [PATCH v3] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-14 10:25:37) > Current DP driver implementation, event thread is kept running > after DP display is unbind. This patch fix this problem by disabling > DP irq and stop event thread to exit gracefully at dp_display_unbind(). > > Changes in v2: > -- start event thread at

Re: [PATCH v7 0/4] Add support for the eDP panel over aux_bus

2022-04-14 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-14 12:20:31) > On 14/04/2022 19:40, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 14, 2022 at 5:19 AM Sankeerth Billakanti > > wrote: > >> > >> This series adds support for generic eDP panel over aux_bus. > >> > >> These changes are dependent on the following

Re: [PATCH v7 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-14 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-14 12:16:14) > > I think it's too verbose and a bit incorrect. > This is a bit saner: > /* > * These ops do not make sense for eDP, since they are provided > * by the panel-bridge corresponding to the attached eDP panel. > */ > > My question was whether we

Re: [PATCH v2] drm/msm/dp: enhance both connect and disconnect pending_timeout handle

2022-04-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-14 09:34:55) > > On 4/13/2022 5:02 PM, Stephen Boyd wrote: > > The subject is still misleading. It is fixing something. It may be > > enhancing it as well but it is clearly fixing it first. > > [...] > > I'd prefer this part to be a diff

Re: [PATCH v2] drm/msm/dp: enhance both connect and disconnect pending_timeout handle

2022-04-13 Thread Stephen Boyd
The subject is still misleading. It is fixing something. It may be enhancing it as well but it is clearly fixing it first. Quoting Kuogee Hsieh (2022-04-06 14:28:13) > dp_hpd_plug_handle() is responsible for setting up main link and send > uevent to notify user space framework to start video

Re: [PATCH v2] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-13 14:04:25) > Current DP driver implementation, event thread is kept running > after DP display is unbind. This patch fix this problem by disabling > DP irq and stop event thread to exit gracefully at dp_display_unbind(). > > Changes in v2: > -- start event thread at

Re: [PATCH v2] drm/msm/dp: add fail safe mode outside of event_mutex context

2022-04-11 Thread Stephen Boyd
s patch move setting fail safe mode > out of event_mutex scope. > Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-11 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-04-11 17:29:17) > > > On 4/11/2022 5:22 PM, Dmitry Baryshkov wrote: > > On 12/04/2022 03:21, Stephen Boyd wrote: > >> Quoting Kuogee Hsieh (2022-04-11 17:08:49) > >>> -   kthread_run(hpd_event_thread, dp_priv, "dp_hpd

Re: [PATCH] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-11 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-11 17:08:49) > Current DP driver implementation, event thread is kept running > after DP display is unbind. This patch fix this problem by disabling > DP irq and stop event thread to exit gracefully at dp_display_unbind(). > > Fixes: e91e3065a806 ("drm/msm/dp: Add DP

Re: [PATCH v2] drm/msm: properly add and remove internal bridges

2022-04-11 Thread Stephen Boyd
/0x220 > kernel_init_freeable from kernel_init+0x18/0x12c > kernel_init from ret_from_fork+0x14/0x2c > > Fixes: 3d3f8b1f8b62 ("drm/bridge: make bridge registration independent of drm > flow") > Reported-by: kernel test robot > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 3/3] drm/msm: don't store created planes, connectors and encoders

2022-04-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-06 03:12:47) > There is no point now in storing arrays of creates planes, connectors > and encoders. Remove them from struct msm_drm_private. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2] drm/msm: remove unused plane_property field from msm_drm_private

2022-04-06 Thread Stephen Boyd
-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 1/4] drm/msm/hdmi: properly add and remove created bridges

2022-04-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-06 03:21:25) > On 06/04/2022 05:51, Stephen Boyd wrote: > > > > Is there any Fixes tag for this? Still seems worthwhile to have one even > > if this is a lockdep warning. > I thought about this before sending v1, but ended up not doing so.

Re: [PATCH 3/3] drm/msm: don't store created planes, connectors and encoders

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-05 16:50:59) > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index d661debb50f1..ee3093890d97 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -184,23 +184,14 @@ struct msm_drm_private { > >

Re: [PATCH 2/3] drm/msm: loop over encoders using drm_for_each_encoder()

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-05 16:50:58) > Rather than manually looping over encoders array, use standard > drm_for_each_encoder() macro. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 1/3] drm/msm/dpu: remove manual destruction of DRM objects

2022-04-05 Thread Stephen Boyd
do it's work. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 1/4] drm/msm/hdmi: properly add and remove created bridges

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-05 16:45:48) > Add calls to drm_bridge_add()/drm_bridge_remove() for the internal HDMI > bridges. This fixes the following warning. > > [2.195003] [ cut here ] Usually this line is left out > [2.195044] WARNING: CPU: 0 PID: 1 at

Re: [PATCH] drm/msm: remove unused plane_property field from msm_drm_private

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-05 16:41:21) > Remove from struct msm_drm_private unused field plane_property. > > Fixes: 7d36db0be3b9 ("drm/msm/mdp5: switch to standard zpos property") > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_drv.h | 3 --- > 1 file changed, 3

Re: [PATCH v2 4/4] drm/msm/dp: make dp_connector_mode_valid() more precise

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-30 15:30:08) > Make dp_connector_mode_valid() return precise MODE_CLOCK_HIGH rather > than generic MODE_BAD in case the mode clock is higher than > DP_MAX_PIXEL_CLK_KHZ (675 MHz). > > Signed-off-by: Dmitry Baryshkov > --- Suggested-by: Step

Re: [PATCH] drm/msm/dp: enhance both connect and disconnect pending_timeout handle

2022-04-05 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-05 11:17:07) > HPD plugin handle is responsible for setting up main link and depend on Is "HPD plugin handle" a function? Can you use the function name? > user space frame work to start video stream. Similarly, HPD unplugged > handle is responsible for tearing down

Re: [PATCH v6 02/12] clk: Introduce Kunit Tests for the framework

2022-03-25 Thread Stephen Boyd
Quoting Daniel Latypov (2022-02-24 15:21:57) > On Thu, Feb 24, 2022 at 2:54 PM Stephen Boyd wrote: > > > > Quoting Daniel Latypov (2022-02-23 14:50:59) > > > On Wed, Feb 23, 2022 at 2:56 AM Maxime Ripard wrote: > > > > > > > > Let's test various pa

RE: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-25 Thread Stephen Boyd
Quoting Sankeerth Billakanti (QUIC) (2022-03-25 06:30:58) > > > > > + vdda-1p2-supply = <_l6b_1p2>; > > > + vdda-0p9-supply = <_l10c_0p8>; > > > + > > > + aux-bus { > > > > Can this move to sc7280.dtsi and get a phandle? > > > > Okay, I will move this to sc7280.dtsi like below. >

Re: [PATCH v4 6/6] drm/msm: make mdp5/dpu devices master components

2022-03-25 Thread Stephen Boyd
gt; > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 6/6] drm/msm: make mdp5/dpu devices master components

2022-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-23 02:25:38) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 38627ccf3068..ab8a35e09bc9 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -381,8

Re: [PATCH v3 3/6] drm/msm: split the main platform driver

2022-03-24 Thread Stephen Boyd
v > --- With the match table fixed and the nit below Reviewed-by: Stephen Boyd > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > index 3cf476c55158..c5c0650414c5 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > +++

Re: [PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example

2022-03-24 Thread Stephen Boyd
erring > Cc: Loic Poulain > Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for QCM2290 > DPU bindings") > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/3] drm/msm/dp: simplify dp_connector_get_modes()

2022-03-24 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/3] drm/msm/dp: remove max_pclk_khz field from dp_panel/dp_display

2022-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-23 03:35:46) > Since the last commit, the max_pclk_khz became constant, it's set to > DP_MAX_PIXEL_CLK_KHZ and never changed afterwards. Remove it completely > and use DP_MAX_PIXEL_CLK_KHZ directly. > > Signed-off-by: Dmitry Baryshkov > --- Re

Re: [PATCH 1/3] drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()

2022-03-24 Thread Stephen Boyd
aryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v7 06/12] clk: Always set the rate on clk_set_range_rate

2022-03-24 Thread Stephen Boyd
Quoting Maxime Ripard (2022-03-23 01:51:40) > Hi, > > > The whole point of this patch is to give an opportunity to every driver > to change the rate whenever the boundaries have changed, so we very much > want to have the option to change it if clk_set_rate() has never been > called. > >

Re: [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-18 Thread Stephen Boyd
Quoting Doug Anderson (2022-03-18 14:58:55) > Hi, > > On Fri, Mar 18, 2022 at 1:17 PM Stephen Boyd wrote: > > > > > > > + ret = dp_catalog_aux_wait_for_hpd_connect_state(aux->catalog); > > > > > > > > Why are we making aux transacti

Re: [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-18 Thread Stephen Boyd
Quoting Doug Anderson (2022-03-18 09:24:17) > Hi, > > On Thu, Mar 17, 2022 at 6:19 PM Stephen Boyd wrote: > > > > Quoting Sankeerth Billakanti (2022-03-16 10:35:51) > > > The source device should ensure the sink is ready before > > > proceeding to

Re: [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:51) > The source device should ensure the sink is ready before > proceeding to read the sink capability or performing any aux transactions. > The sink will indicate its readiness by asserting the HPD line. > > The eDP sink requires

[PATCH] drm/msm/dsi: Use connector directly in msm_dsi_manager_connector_init()

2022-03-17 Thread Stephen Boyd
aul Fixes: 6d5e78406991 ("drm/msm/dsi: Move dsi panel init into modeset init path") Signed-off-by: Stephen Boyd --- I don't know if this is superseeded by something else but I found this while trying to use the connector from msm_dsi in this function. drivers/gpu/drm/msm/dsi/dsi_manage

Re: [PATCH v5 5/9] drm/msm/dp: Add eDP support via aux_bus

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:50) > This patch adds support for generic eDP sink through aux_bus. Please unindent commit text paragraphs. This isn't a book. > The eDP/DP controller driver should support aux transactions originating > from the panel-edp driver and hence

Re: [PATCH v5 4/9] drm/panel-edp: add LQ140M1JW46 edp panel entry

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:49) > Add panel identification entry for the sharp LQ140M1JW46 eDP panel > with power sequencing delay information. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 3/9] arm64: dts: qcom: sc7280: Enable backlight for eDP panel

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:48) > Enable backlight support for eDP panel on CRD platform for sc7280. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v5: > - Separate out backlight nodes > > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 18 ++ > 1

Re: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:47) > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index e2efbdd..2df654e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -7,6 +7,7 @@ >

Re: [PATCH v5 1/9] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:46) > Rename the edp_out label in the sc7280 platform to mdss_edp_out > so that the nodes related to mdss are all grouped together in > the board specific files. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 1/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe

2022-03-17 Thread Stephen Boyd
Quoting Vinod Polimera (2022-03-14 07:46:53) > use max clock during probe/bind sequence from the opp table. > The clock will be scaled down when framework sends an update. Capitalize 'use'. Why is it important to use max frequency during probe/bind? Does not setting the clk rate during probe

Re: [PATCH v7 00/12] clk: Improve clock range handling

2022-03-11 Thread Stephen Boyd
Quoting Maxime Ripard (2022-02-25 06:35:22) > Hi, > > This is a follow-up of the discussion here: > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > > and here: > https://lore.kernel.org/all/20210914093515.260031-1-max...@cerno.tech/ > > While the initial proposal

Re: [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-03-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 23:58:58) > On Fri, 4 Mar 2022 at 07:31, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2022-03-03 20:23:06) > > > On Fri, 4 Mar 2022 at 01:32, Stephen Boyd wrote: > > > > > > > > Quoting Dmitry Baryshko

Re: [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

2022-03-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 19:21:06) > MSM DRM driver already allows one to compile out the DP or DSI support. > Add support for disabling other features like MDP4/MDP5/DPU drivers or > direct HDMI output support. > > Suggested-by: Stephen Boyd > Signed-off-by

Re: [PATCH v3 4/5] drm/msm: stop using device's match data pointer

2022-03-08 Thread Stephen Boyd
. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 3/5] drm/msm: split the main platform driver

2022-03-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 19:21:04) > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index 857eefbb8649..c89de88ed2d1 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -255,3 +258,170 @@ struct msm_mdss

Re: [PATCH v3 2/5] drm/msm: remove extra indirection for msm_mdss

2022-03-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 19:21:03) > Since now there is just one mdss subdriver, drop all the indirection, > make msm_mdss struct completely opaque (and defined inside msm_mdss.c) > and call mdss functions directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 1/5] drm/msm: unify MDSS drivers

2022-03-08 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/adreno: fix cast in adreno_get_param()

2022-03-08 Thread Stephen Boyd
t;drm/msm/adreno: Expose speedbin to userspace") > Signed-off-by: Dan Carpenter > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 1/5] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-08 Thread Stephen Boyd
te property and set mdp clk during resume sequence. > - Add fixes tag. > > Changes in v3: > - Remove extra line after fixes tag.(Stephen Boyd) This changelog should be removed. > > Fixes: 62fbdce91("arm64: dts: qcom: sc7280: add display dt nodes") I thought folks we

Re: [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 20:23:06) > On Fri, 4 Mar 2022 at 01:32, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2022-02-16 21:55:27) > > > The only clock for which we set the rate is the "stream_pixel". Rather > > > than storing the r

Re: [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-03 15:50:50) > On Thu, 3 Mar 2022 at 12:40, Vinod Polimera wrote: > > > > Kernel clock driver assumes that initial rate is the > > max rate for that clock and was not allowing it to scale > > beyond the assigned clock value. > > > > Drop the assigned clock rate

Re: [PATCH v2 4/4] drm/msm: stop using device's match data pointer

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-19 14:40:05) > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index 759076357e0e..f83dca99f03d 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -314,11 +314,11 @@ static const struct

Re: [PATCH v2 3/4] drm/msm: split the main platform driver

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-19 14:40:04) > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index 06d26c5fb274..6895c056be19 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -451,10 +451,18 @@ static inline void

Re: [PATCH v2 2/4] drm/msm: remove extra indirection for msm_mdss

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-19 14:40:03) > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index be06a62d7ccb..f18dfbb614f0 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -1211,19 +1212,32 @@ static int

Re: [PATCH v2 1/4] drm/msm: unify MDSS drivers

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-19 14:40:02) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c > b/drivers/gpu/drm/msm/msm_mdss.c > similarity index 58% > rename from drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c > rename to drivers/gpu/drm/msm/msm_mdss.c > index 9f5cc7f9e9a9..f5429eb0ae52

Re: [PATCH 00/12] Add writeback block support for DPU

2022-03-03 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-02-04 13:17:13) > This series adds support for writeback block on DPU. Writeback > block is extremely useful to validate boards having no physical displays > in addition to many other use-cases where we want to get the output > of the display pipeline to examine whether

Re: [PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Stephen Boyd
Quoting Rob Clark (2022-03-03 13:47:14) > On Thu, Mar 3, 2022 at 1:17 PM Rob Clark wrote: > > > > On Thu, Mar 3, 2022 at 12:47 PM Stephen Boyd wrote: > > > > > > Quoting Rob Clark (2022-03-03 11:46:47) > > > > + > > > > + /* then

Re: [PATCH v5 5/5] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 21:55:29) > In order to simplify DP code, drop hand-coded loops over clock arrays, > replacing them with clk_bulk_* functions. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 4/5] drm/msm/dp: inline dp_power_clk_set_rate()

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 21:55:28) > Inline the dp_power_clk_set_rate() function, replacing it with the call > to msm_dss_enable_clk(). > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 3/5] drm/msm/dp: set stream_pixel rate directly

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 21:55:27) > The only clock for which we set the rate is the "stream_pixel". Rather > than storing the rate and then setting it by looping over all the > clocks, set the clock rate directly. > > Signed-off-by: Dmitry Baryshkov [...] > diff --git

Re: [PATCH v5 2/5] drm/msm/dp: "inline" dp_ctrl_set_clock_rate("ctrl_link")

2022-03-03 Thread Stephen Boyd
) directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 1/5] drm/msm/dpu: simplify clocks handling

2022-03-03 Thread Stephen Boyd
andled using devres instead. > > DP implementation is unchanged for now. > > Tested-by: Jessica Zhang # RB3 (sdm845) and RB5 > (qrb5165) > Reviewed-by: Jessica Zhang > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2] drm/msm/disp/dpu1: add inline rotation support for sc7280 target

2022-03-03 Thread Stephen Boyd
Quoting Vinod Polimera (2022-03-03 03:42:59) > - Some DPU versions support inline rot90. It is supported only for > limited amount of UBWC formats. > - There are two versions of inline rotators, v1 (present on sm8250 and > sm7250) and v2 (sc7280). These versions differ in the list of supported >

Re: [PATCH v4 4/4] arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
lated value during the usecase. > > Fixes: 7c1dffd471("arm64: dts: qcom: sm8250.dtsi: add display system nodes") > Signed-off-by: Vinod Polimera > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 3/4] arm64/dts/qcom/sdm845: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
lated value during the usecase. > > Fixes: 08c2a076d1("arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file") > Signed-off-by: Vinod Polimera > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 2/4] arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
lated value during the usecase. > > Fixes: a3db7ad1af("arm64: dts: qcom: sc7180: add display dt nodes") > Signed-off-by: Vinod Polimera > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 1/4] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-03 Thread Stephen Boyd
lated value during the usecase. > > Changes in v2: > - Remove assigned-clock-rate property and set mdp clk during resume sequence. > - Add fixes tag. > > Changes in v3: > - Remove extra line after fixes tag.(Stephen Boyd) > This changelog goes below triple dash when they ar

Re: [PATCH v3 0/6] drm/msm/dpu: simplify IRQ helpers

2022-03-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-16 20:31:42) > This is the second part of > https://patchwork.freedesktop.org/series/91631/ reworked and cleaned up. > > Changes since v1: v2? > - Fix warning ins dpu_trace.h related to >dpu_core_irq_unregister_callback event Any plans to migrate to

Re: [PATCH v3 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-03-03 Thread Stephen Boyd
longer needs to remember which function is called. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 3/6] drm/msm/dpu: allow just single IRQ callback

2022-03-03 Thread Stephen Boyd
upt handling code. > > Reported-by: kernel test robot > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 4/4] drm/msm/dpu: drop INTF_EDP from interface type conditions

2022-03-03 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/4] drm/msm/dpu: drop obsolete INTF_EDP comment

2022-03-03 Thread Stephen Boyd
s no purpose. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/4] drm/msm/dpu: drop INTF_TYPE_MAX symbol

2022-03-03 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 1/4] drm/msm/dpu: document INTF_EDP/INTF_DP difference

2022-03-03 Thread Stephen Boyd
d DP interfaces handled by the msm/dp > driver. The DPU driver does not make a difference between them. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/4] drm/msm: Add SYSPROF param

2022-03-03 Thread Stephen Boyd
Quoting Rob Clark (2022-03-03 11:46:47) > diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h > index fde9a29f884e..0ba1dbd4e50f 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.h > +++ b/drivers/gpu/drm/msm/msm_gpu.h > @@ -330,6 +337,24 @@ struct msm_file_private { >

Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml

2022-03-01 Thread Stephen Boyd
Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 5/5] arm64: dts: qcom: sm8250: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 4/5] arm64: dts: qcom: sdm845: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 3/5] arm64: dts: qcom: sdm660: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/5] arm64: dts: qcom: sdm630: Drop flags for mdss irqs

2022-03-01 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

<    1   2   3   4   5   6   7   8   9   10   >