Re: [PATCH 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-07-09 10:46:41) > On 2021-07-08 00:33, Stephen Boyd wrote: > >> + > >> +static bool dp_ctrl_any_lane_cr_lose(struct dp_ctrl_private *ctrl, > >> + u8 *cr_status) > >> +{ >

Re: [PATCH] drm/msm/dp: Remove unused variable

2021-07-14 Thread Stephen Boyd
el test robot > Signed-off-by: Souptick Joarder > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-08 Thread Stephen Boyd
Quoting maitreye (2021-07-08 12:13:44) > From: Maitreyee Rao > > Add trace points across the MSM DP driver to help debug > interop issues. > > Changes in v2: > - Got rid of redundant log messages. > - Added %#x instead of 0x%x wherever required. > - Got rid of __func__ calls in debug messages.

Re: [PATCH 4/7] drm/msm/dp: replug event is converted into an unplug followed by an plug events

2021-07-08 Thread Stephen Boyd
y: Kuogee Hsieh > --- This needs a Fixes tag of some kind. Reviewed-by: Stephen Boyd

Re: [PATCH 3/7] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed.

2021-07-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-06 10:20:16) > Aux hardware calibration sequence requires resetting the aux controller > in order for the new setting to take effect. However resetting the AUX > controller will also clear HPD interrupt status which may accidentally > cause pending unplug interrupt to

Re: [PATCH 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-06 10:20:15) > Reduce link rate and re start link training if link training 1 > failed due to loss of clock recovery done to fix Link Layer > CTS case 4.3.1.7. Also only update voltage and pre-emphasis > swing level after link training started to fix Link Layer CTS >

Re: [PATCH 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-06 10:20:20) > Main link symbol locked is achieved at end of link training 2. Some > dongle main link symbol may become unlocked again if host did not end > link training soon enough after completion of link training 2. Host > have to re train main link if loss of

Re: [PATCH 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-07-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-06 10:20:18) > Response with correct edid checksum saved at connector after corrupted edid > checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_panel.c | 9 +++-- > 1 file changed, 7

Re: [PATCH 1/7] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run

2021-07-08 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-06 10:20:14) > DP cable should always connect to DPU during the entire PHY compliance > testing run. Since DP PHY compliance test is executed at irq_hpd event > context, dp_ctrl_off_link_stream() should be used instead of dp_ctrl_off(). > dp_ctrl_off() is used for

[PATCH] drm/msm/dpu: Add newlines to printks

2021-07-08 Thread Stephen Boyd
Add some missing newlines to the various DRM printks in this file. Noticed while looking at logs. While we're here unbreak quoted strings so grepping them is easier. Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +--- 1 file changed, 5 insertions(+), 7

Re: [PATCH] drm/dp_mst: Fix return code on sideband message failure

2021-06-29 Thread Stephen Boyd
ot;sideband msg failed to send\n"); > - drm_dp_mst_dump_sideband_msg_tx(, txmsg); > + drm_printf(, "sideband msg failed to send\n"); > + drm_dp_mst_dump_sideband_msg_tx(, txmsg); > + } > return ret; > } > With the above fixed up Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/dsi: Stash away calculated vco frequency on recalc

2021-06-18 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-06-09 09:03:14) > On 09/06/2021 01:11, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2021-06-08 14:41:21) > >> Hi Stephen, > >> > >> On 08/06/2021 22:55, Stephen Boyd wrote: > >>> A problem was reported on CoachZ

Re: [PATCH] drm/msm/dp: add logs across DP driver for ease of debugging

2021-06-17 Thread Stephen Boyd
Quoting maitreye (2021-06-16 18:08:54) > From: Maitreyee Rao > > Add trace points across the MSM DP driver to help debug > interop issues. > > Signed-off-by: Maitreyee Rao > --- > drivers/gpu/drm/msm/dp/dp_aux.c | 5 +++-- > drivers/gpu/drm/msm/dp/dp_catalog.c | 4 >

Re: [PATCH] drm/msm/dsi: Stash away calculated vco frequency on recalc

2021-06-08 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-06-08 14:41:21) > Hi Stephen, > > On 08/06/2021 22:55, Stephen Boyd wrote: > > A problem was reported on CoachZ devices where the display wouldn't come > > up, or it would be distorted. It turns out that the PLL code here wasn't &g

[PATCH] drm/msm/dsi: Stash away calculated vco frequency on recalc

2021-06-08 Thread Stephen Boyd
pare op so that it doesn't even try to call the set rate function. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Fixes: 001d8dc33875 ("drm/msm/dsi: remove temp data from global pll structure") Signed-off-by: Stephen Boyd --- I didn't update the 14nm file as the caching logic looks different. But betw

Re: [PATCH] drm/msm: remove no need local variable

2021-06-05 Thread Stephen Boyd
Quoting Bernard Zhao (2021-06-05 05:35:20) > Unneeded variable: "ret". Return "0" on line 880 But the variable is "rc". > > Signed-off-by: Bernard Zhao > --- Otherwise Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH 4/4] drm/msm/dp: Add support for SC8180x eDP

2021-06-04 Thread Stephen Boyd
Quoting abhin...@codeaurora.org (2021-05-28 16:40:32) > On 2021-05-10 21:20, Bjorn Andersson wrote: > > The eDP controller found in SC8180x is at large compatible with the > > current implementation, but has its register blocks at slightly > > different offsets. > > > > Add the compatible and the

Re: [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog'

2021-06-02 Thread Stephen Boyd
warning: Excess function parameter > 'aux' description in 'dp_catalog_aux_reset' > > Cc: Rob Clark > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Chandan Uddaraju > Cc: Stephen Boyd > Cc: linux-arm-...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org &

Re: [PATCH v3] drm/msm/dp: power off DP phy at suspend

2021-06-01 Thread Stephen Boyd
Please add dri-devel@lists.freedesktop.org next time Quoting Kuogee Hsieh (2021-06-01 16:50:08) > Normal DP suspend operation contains two steps, display off followed > by dp suspend, to complete system wide suspending cycle if display is > up at that time. In this case, DP phy will be powered

Re: [PATCH 3/3] drm/msm/dp: Handle aux timeouts, nacks, defers

2021-05-24 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-05-24 09:33:49) > On 2021-05-07 14:25, Stephen Boyd wrote: > > @@ -367,36 +347,38 @@ static ssize_t dp_aux_transfer(struct drm_dp_aux > > *dp_aux, > > } > > > > ret = dp_aux_cmd_fifo_tx(aux,

Re: [PATCH 7/7] drm/msm: Migrate to aggregate driver

2021-05-24 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-20 12:58:52) > On Wed, May 19, 2021 at 05:25:19PM -0700, Stephen Boyd wrote: > > @@ -1306,7 +1322,8 @@ static int msm_pdev_probe(struct platform_device > > *pdev) > > if (ret) > > goto fail; > > > > -

Re: [PATCH 3/7] component: Introduce struct aggregate_device

2021-05-24 Thread Stephen Boyd
Quoting Saravana Kannan (2021-05-20 13:20:45) > On Wed, May 19, 2021 at 5:25 PM Stephen Boyd wrote: > > > > - master->parent = parent; > > - master->ops = ops; > > - master->match = match; > > + id = ida_alloc

Re: [PATCH 27/38] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog'

2021-05-21 Thread Stephen Boyd
warning: Excess function parameter > 'aux' description in 'dp_catalog_aux_reset' > > Cc: Rob Clark > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Chandan Uddaraju > Cc: Stephen Boyd > Cc: linux-arm-...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org &

Re: [PATCH v2] drm/msm: Use nvmem_cell_read_variable_le_u32() to read speed bin

2021-05-21 Thread Stephen Boyd
Quoting Doug Anderson (2021-05-21 15:35:33) > Hi, > > On Fri, May 21, 2021 at 3:02 PM Stephen Boyd wrote: > > > > Quoting Douglas Anderson (2021-05-21 13:45:50) > > > Let's use the newly-added nvmem_cell_read_variable_le_u32() to future > > > proof ourselv

Re: [PATCH v2] drm/msm: Use nvmem_cell_read_variable_le_u32() to read speed bin

2021-05-21 Thread Stephen Boyd
Quoting Douglas Anderson (2021-05-21 13:45:50) > Let's use the newly-added nvmem_cell_read_variable_le_u32() to future > proof ourselves a little bit. > > Signed-off-by: Douglas Anderson > --- > The patch that this depends on is now in mainline so it can be merged > at will. I'm just sending this

Re: [PATCH 0/3] drm/msm/dp: Simplify aux code

2021-05-21 Thread Stephen Boyd
Quoting Stephen Boyd (2021-05-07 14:25:02) > Here's a few patches that simplify the aux handling code and bubble up > timeouts and nacks to the upper DRM layers. The goal is to get DRM to > know that the other side isn't there or that there's been a timeout, > instead of saying tha

Re: [PATCH v17 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings

2021-05-21 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-05-21 09:00:29) > On Fri 21 May 05:27 CDT 2021, Krishna Manikandan wrote: > > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > > b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > [..] > > + ports: > > +$ref:

Re: [PATCH v17 3/4] dt-bindings: msm: dsi: add yaml schemas for DSI PHY bindings

2021-05-21 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-05-21 03:27:23) > Add YAML schema for the device tree bindings for DSI PHY. > > Signed-off-by: Krishna Manikandan > > Changes in v1: >- Merge dsi-phy.yaml and dsi-phy-10nm.yaml (Stephen Boyd) >- Remove qcom,dsi-phy-regulator-l

Re: [PATCH v17 2/4] dt-bindings: msm: dsi: add yaml schemas for DSI bindings

2021-05-21 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-05-21 03:27:22) > Add YAML schema for the device tree bindings for DSI > > Signed-off-by: Krishna Manikandan > > Changes in v1: > - Separate dsi controller bindings to a separate patch (Stephen Boyd) > - Merge dsi-common-controller.ya

Re: [PATCH v17 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings

2021-05-21 Thread Stephen Boyd
file (Rob Herring) > - Use unevaluatedProperties and additionalProperties > wherever required > - Remove duplicate properties from common yaml files > > Changes in v10: > - Split the patch into separate patches for DPU, DSI and > PHY (Stephen Boyd) &g

Re: [PATCH v17 4/4] dt-bindings: msm/dp: Add bindings of MSM DisplayPort controller

2021-05-21 Thread Stephen Boyd
patch as it does not contain PLL bindings anymore > - Remove redundant properties > - Remove use of IRQ flag > - Fix ports property > > Changes in v11: > - add ports required of both #address-cells and #size-cells > - add required operating-points-v2 > - add required #so

Re: [PATCH 0/7] component: Make into an aggregate bus

2021-05-19 Thread Stephen Boyd
Quoting Saravana Kannan (2021-05-19 18:27:50) > On Wed, May 19, 2021 at 5:25 PM Stephen Boyd wrote: > > > > This series is from discussion we had on reordering the device lists for > > drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put > > the aggreg

[PATCH 7/7] drm/msm: Migrate to aggregate driver

2021-05-19 Thread Stephen Boyd
shutdown hooks are called. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- As stated in the cover letter, this isn't perfect but it still works. I get a warning from runtime PM that the parent device (e

[PATCH 3/7] component: Introduce struct aggregate_device

2021-05-19 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 249 -- include/linux/component.h | 2 +- 2 files changed, 134 insertions(+), 117 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index 5e

[PATCH 2/7] component: Rename 'dev' to 'parent'

2021-05-19 Thread Stephen Boyd
: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 89 +++- 1 file changed, 42 insertions(+), 47 deletions(-) diff --git a/drivers/base/component.c

[PATCH 6/7] component: Move struct aggregate_device out to header file

2021-05-19 Thread Stephen Boyd
This allows aggregate driver writers to use the device passed to their probe/remove/shutdown functions properly instead of treating it as an opaque pointer. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --

[PATCH 5/7] component: Use dev.parent instead of adev->parent

2021-05-19 Thread Stephen Boyd
We left this in place to ease the code diff, but now we can remove it because the aggregate device parent pointer is the same. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/compon

[PATCH 4/7] component: Introduce the aggregate bus_type

2021-05-19 Thread Stephen Boyd
in the correct order. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 429 +++--- include/linux/component.h | 60 +- 2 files changed, 359 insertio

[PATCH 1/7] component: Drop 'dev' argument to component_match_realloc()

2021-05-19 Thread Stephen Boyd
This argument isn't used. Drop it. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/base/com

[PATCH 0/7] component: Make into an aggregate bus

2021-05-19 Thread Stephen Boyd
[1] https://lore.kernel.org/r/20210508074118.1621729-1-swb...@chromium.org Stephen Boyd (7): component: Drop 'dev' argument to component_match_realloc() component: Rename 'dev' to 'parent' component: Introduce struct aggregate_device component: Introduce the aggregate bus_type component: Use

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Stephen Boyd
Quoting Russell King - ARM Linux admin (2021-05-11 07:42:37) > On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > > Within the component device framework this usually isn't that bad > > because the real driver work is done at bind time via > > compone

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-11 06:39:36) > On Tue, May 11, 2021 at 12:52 PM Rafael J. Wysocki wrote: > > > > On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: > > > > [cut] > > > > > > > > > > > > > > I will try it, but

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Stephen Boyd
Quoting Rafael J. Wysocki (2021-05-11 03:52:06) > On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: > > [cut] > > > > > > > > > > I will try it, but then I wonder about things like system wide > > > > suspend/resume too. The drm encode

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-10 11:26:40) > On Mon, May 10, 2021 at 7:52 PM Stephen Boyd wrote: > > The device list now has msm, i2c, bridge in that order. When we go to > > system wide shutdown the bridge is shutdown first, then the i2c bus, and > > then msm calls drm_a

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-10 09:05:21) > On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > > The device lists are poorly ordered when the component device code is > > used. This is because component_master_add_with_match() returns 0 > > regardless of comp

Re: [PATCH v2 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-10 Thread Stephen Boyd
70e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei > --- Reviewed-by: Stephen Boyd

Re: [PATCH 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-08 Thread Stephen Boyd
Quoting Leizhen (ThunderTown) (2021-05-08 00:55:04) > > > On 2021/5/8 14:09, Stephen Boyd wrote: > > Quoting Zhen Lei (2021-05-07 19:42:54) > >> Fix to return a negative error code from the error handling case instead > >> of 0, as done elsewhere in this functi

[PATCH] component: Move host device to end of device lists on binding

2021-05-08 Thread Stephen Boyd
sell King Cc: Rob Clark Cc: Signed-off-by: Stephen Boyd --- drivers/base/component.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/base/component.c b/drivers/base/component.c index dcfbe7251dc4..de645420bae2 100644 --- a/drivers/base/component.c +++ b/drivers/bas

Re: [PATCH 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-08 Thread Stephen Boyd
Quoting Zhen Lei (2021-05-07 19:42:54) > Fix to return a negative error code from the error handling case instead > of 0, as done elsewhere in this function. > > Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei > --- >

[PATCH 1/3] drm/msm/dp: Simplify aux irq handling code

2021-05-07 Thread Stephen Boyd
Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_aux.c | 22 -- drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +- drivers/gpu/drm/msm/dp/dp_catalog.h | 2 +- 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/msm/dp

[PATCH 3/3] drm/msm/dp: Handle aux timeouts, nacks, defers

2021-05-07 Thread Stephen Boyd
core can figure out that things are just not going well. The important thing is that we're now returning -ETIMEDOUT when the message times out and nacks for bad addresses. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen

[PATCH 2/3] drm/msm/dp: Shrink locking area of dp_aux_transfer()

2021-05-07 Thread Stephen Boyd
Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_aux.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c b/drivers/gpu/drm/msm/dp/dp_aux.c index 91188466cece..b49810396513 100644 --- a/drivers/gpu/drm/msm/dp/dp_aux.c

[PATCH 0/3] drm/msm/dp: Simplify aux code

2021-05-07 Thread Stephen Boyd
. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Stephen Boyd (3): drm/msm/dp: Simplify aux irq handling code drm/msm/dp: Shrink locking area of dp_aux_transfer() drm/msm/dp: Handle aux timeouts, nacks, defers drivers/gpu/drm/msm/dp

Re: [PATCH v4 3/4] drm/msm/dp: check main link status before start aux read

2021-05-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-21 16:37:37) > Maybe when the cable is disconnected the DP phy should be shutdown and > some bit in the phy could effectively "cut off" the aux channel and then > NAKs would start coming through here in the DP controller I/O register > space. This patch have DP aux

Re: [PATCH v4 4/4] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-05-03 Thread Stephen Boyd
V4: > -- split this patch as stand alone patch > > Signed-off-by: Kuogee Hsieh Can this patch come before the one previously? And then some fixes tag be added? Otherwise looks good to me. Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd ___ dr

Re: [PATCH v4 2/4] drm/msm/dp: initialize audio_comp when audio starts

2021-05-03 Thread Stephen Boyd
> > Changes in v3: > -- restore dp_display_handle_plugged_change() at dp_hpd_unplug_handle(). > > Changes in v4: > -- none > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd Fixes: c703d5789590 ("drm/msm/

Re: [PATCH v4 1/4] drm/msm/dp: check sink_count before update is_connected status

2021-05-03 Thread Stephen Boyd
m/dp: reset dp controller only at boot up and > pm_resume") > Reported-by: Stephen Boyd > Reviewed-by: Stephen Boyd > Tested-by: Stephen Boyd > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_display.c | 15 --- > 1 file changed, 8

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-05-03 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-05-03 12:23:31) > On 2021-04-29 20:11, Stephen Boyd wrote: > > Quoting khs...@codeaurora.org (2021-04-29 10:23:31) > >> On 2021-04-29 02:26, Stephen Boyd wrote: > >> > Quoting khs...@codeaurora.org (2021-04-28 10:38:11) > >&g

Re: [PATCH 0/2] clk: Implement a clock request API

2021-04-30 Thread Stephen Boyd
Quoting Maxime Ripard (2021-04-13 03:13:18) > Hi, > > This is a follow-up of the discussion here: > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > > This implements a mechanism to raise and lower clock rates based on consumer > workloads, with an example of such an

[PATCH 6/6] drm/msm/disp: Move various debug logs to atomic bucket

2021-04-30 Thread Stephen Boyd
...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 22 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 38 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++--- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 6

[PATCH 1/6] drm/msm: Move vblank debug prints to drm_dbg_vbl()

2021-04-30 Thread Stephen Boyd
Put these debug prints in the vblank code into the appropriate vblank category via drm_dbg_vbl(). Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2

[PATCH 5/6] drm/msm/disp: Use plane debug print helper

2021-04-30 Thread Stephen Boyd
Use the DPU_DEBUG_PLANE() helper to print the plane number instead of open coding it. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 17 +++-- 1 file

[PATCH 2/6] drm/msm: Use VERB() for extra verbose logging

2021-04-30 Thread Stephen Boyd
useless. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 16 2 files changed, 9 insertions(+), 9

[PATCH 4/6] drm/msm: Move FB debug prints to drm_dbg_state()

2021-04-30 Thread Stephen Boyd
Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_fb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c index d42f0665359a..90514d3179bb 100644 --- a/drivers/gpu/drm/msm/msm_fb.c +++ b/drivers/gpu/drm

[PATCH 0/6] drm/msm: Trim down drm debugging logs

2021-04-30 Thread Stephen Boyd
that felt appropriate. Please review. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Stephen Boyd (6): drm/msm: Move vblank debug prints to drm_dbg_vbl() drm/msm: Use VERB() for extra verbose logging drm/msm/dp: Drop malformed debug

[PATCH 3/6] drm/msm/dp: Drop malformed debug print

2021-04-30 Thread Stephen Boyd
This print is missing a newline, and doesn't really provide any value. Drop it. Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Kuogee Hsieh Cc: aravi...@codeaurora.org Cc: Sean Paul Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH] drm/msm/dpu: Delete bonkers code

2021-04-30 Thread Stephen Boyd
a0 >[ 20.950058] el0_svc+0x20/0x30 >[ 20.953145] el0_sync_handler+0x88/0xb0 >[ 20.957014] el0_sync+0x13c/0x140 > > The reason for the codepath seems dubious, the atomic suspend/resume > heplers should handle the power-collapse case. If not, the CRTC's > atom

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-29 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-29 10:23:31) > On 2021-04-29 02:26, Stephen Boyd wrote: > > Quoting khs...@codeaurora.org (2021-04-28 10:38:11) > >> On 2021-04-27 17:00, Stephen Boyd wrote: > >> > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) &g

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-29 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-28 10:38:11) > On 2021-04-27 17:00, Stephen Boyd wrote: > > Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) > >> On 2021-04-21 10:26, khs...@codeaurora.org wrote: > >> >> > >> >&g

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-27 Thread Stephen Boyd
Quoting aravi...@codeaurora.org (2021-04-21 11:55:21) > On 2021-04-21 10:26, khs...@codeaurora.org wrote: > >> > >>> + > >>> mutex_unlock(>event_mutex); > >>> > >>> return 0; > >>> @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp, > >>> struct drm_encoder

Re: [PATCH v3 3/3] drm/msm/dp: check main link status before start aux read

2021-04-20 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-16 10:38:51) > Maybe when the cable is disconnected the DP phy should be shutdown and > some bit in the phy could effectively "cut off" the aux channel and then > NAKs would start coming through here in the DP controller I/O register > space. This patch have DP aux

Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending

2021-04-20 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-16 13:27:57) > Some dongle may generate more than one irq_hpd events in a short period of > time. This patch will treat those irq_hpd events as single one and service > only one irq_hpd event. Why is it bad to get multiple irq_hpd events in a short period of time?

Re: [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-15 15:02:40) > On 2021-04-15 13:06, Stephen Boyd wrote: > > > > Is it really necessary to have this patch at all? I think there are > > bigger problems with suspend/resume of the DP driver in relation to the > > kthread stopping.

Re: [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-15 10:37:29) > On 2021-04-14 14:09, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-04-13 16:11:44) > >> Make sure main link is in connection state before start aux > >> read/write operation to avoid unnecessary long delay due

Re: [PATCH v2 2/3] drm/msm/dp: initialize audio_comp when audio starts

2021-04-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-14 14:02:50) > Initialize audio_comp when audio starts and wait for audio_comp at > dp_display_disable(). This will take care of both dongle unplugged > and display off (suspend) cases. > > Changes in v2: > -- add dp_display_start_audio() > > Signed-off-by: Kuogee

Re: [PATCH v2 1/3] drm/msm/dp: check sink_count before update is_connected status

2021-04-14 Thread Stephen Boyd
only at boot up and > pm_resume") > Reported-by: Stephen Boyd > Reviewed-by: Stephen Boyd > Tested-by: Stephen Boyd > Signed-off-by: Kuogee Hsieh > --- Can you please thread your emailed patches? I see them all as toplevel messages in my inbox :( > drivers/gpu/drm/msm

Re: [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-13 16:11:44) > Make sure main link is in connection state before start aux > read/write operation to avoid unnecessary long delay due to > main link had been unplugged. > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_aux.c | 5 + >

Re: [PATCH v2 2/3] drm/msm/dp: do not re initialize of audio_comp at display_disable()

2021-04-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-13 16:11:30) > At dongle unplug, dp initializes audio_comp followed by sending disconnect > event notification to audio and to make sure audio had shutdown completely > by wait for audio completion notification at display_disable(). This patch Is this

Re: [PATCH v2 1/3] drm/msm/dp: check sink_count before update is_connected status

2021-04-13 Thread Stephen Boyd
only at boot up and > pm_resume") > Reported-by: Stephen Boyd > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] drm/msm/dp: do not re initialize of audio_comp

2021-04-12 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-12 10:03:23) > At dp_display_disable(), do not re initialize audio_comp if > hdp_state == ST_DISCONNECT_PENDING (unplug event) to avoid > race condition which cause 5 second timeout expired. More details please. > Also > add abort mechanism to reduce time spinning

Re: [PATCH 1/2] drm/msm/dp: check sink_count before update is_connected status

2021-04-12 Thread Stephen Boyd
ned-off-by: Kuogee Hsieh > --- Also please include Reported-by: Stephen Boyd in the next post. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm/msm/dp: check sink_count before update is_connected status

2021-04-12 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-12 10:02:51) > At pm_resume check link sisnk_count before update is_connected status s/sisnk_count/sink_count/ > base on HPD real time link status. Also print out error message only > when either EV_CONNECT_PENDING_TIMEOUT or EV_DISCONNECT_PENDING_TIMEOUT > happen.

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-10 Thread Stephen Boyd
asmus Villemoes > Signed-off-by: Andrew Morton > --- > drivers/clk/analogbits/wrpll-cln28hpc.c | 4 + Acked-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] clk: fixed: fix double free in resource managed fixed-factor clock

2021-04-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-04-07 15:57:01) > On Thu, 8 Apr 2021 at 01:41, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2021-04-06 16:06:06) > > > devm_clk_hw_register_fixed_factor_release(), the release function for > > > the devm_clk_

Re: [PATCH] clk: fixed: fix double free in resource managed fixed-factor clock

2021-04-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-04-06 16:06:06) > devm_clk_hw_register_fixed_factor_release(), the release function for > the devm_clk_hw_register_fixed_factor(), calls > clk_hw_unregister_fixed_factor(), which will kfree() the clock. However > after that the devres functions will also kfree the

Re: [PATCH] clk: fixed: fix double free in resource managed fixed-factor clock

2021-04-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-04-06 16:06:06) > devm_clk_hw_register_fixed_factor_release(), the release function for > the devm_clk_hw_register_fixed_factor(), calls > clk_hw_unregister_fixed_factor(), which will kfree() the clock. However > after that the devres functions will also kfree the

Re: [PATCH] drm/msm: remove unneeded variable ret

2021-04-07 Thread Stephen Boyd
Quoting Bernard Zhao (2021-04-07 06:06:21) > This patch fix coccicheck warning: > drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return > "0" on line 880 > Also remove unneeded function return value check. > > Signed-off-by: Bernard

Re: [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-03-30 Thread Stephen Boyd
Quoting Maxime Ripard (2021-03-30 08:35:27) > Hi Stephen, > > On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote: > > Trimming Cc list way down, sorry if that's too much. > > > > Quoting Maxime Ripard (2021-02-19 04:00:30) > > > Many drivers referen

Re: [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-03-29 Thread Stephen Boyd
Trimming Cc list way down, sorry if that's too much. Quoting Maxime Ripard (2021-02-19 04:00:30) > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_update or atomic_disable hooks, > which would be the new plane state in the global atomic

Re: [PATCH v3 00/25] drm/msm/dsi: refactor MSM DSI PHY/PLL drivers

2021-03-29 Thread Stephen Boyd
5c273dab308303a5217bd3e767d7083ddb: > > drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume > (2021-03-22 18:52:34 -0700) > > are available in the Git repository at: > > https://git.linaro.org/people/dmit

Re: [PATCH v3 13/25] drm/msm/dsi: use devm_of_clk_add_hw_provider

2021-03-29 Thread Stephen Boyd
Would make it devm_of_clk_add_hw_provider() in the subject Quoting Dmitry Baryshkov (2021-03-27 04:02:53) > Use devm_of_clk_add_hw_provider() to register provided clocks. This > allows dropping the remove function alltogether. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-b

Re: [PATCH v3 12/25] drm/msm/dsi: use devm_clk_*register to registe DSI PHY clocks

2021-03-29 Thread Stephen Boyd
Subject should say register instead of registe Quoting Dmitry Baryshkov (2021-03-27 04:02:52) > Use devres-enabled version of clock registration functions. This lets us > remove dsi_pll destroy callbacks completely. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dsi/dsi.h

Re: [PATCH v3 03/25] clk: divider: add devm_clk_hw_register_divider

2021-03-29 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-03-27 04:02:43) > Add devm_clk_hw_register_divider() - devres version of > clk_hw_register_divider(). > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar > --- Acked-by: Stephen Boyd ___

Re: [PATCH v3 02/25] clk: mux: provide devm_clk_hw_register_mux()

2021-03-29 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-03-27 04:02:42) > Add devm_clk_hw_register_mux() - devres-managed version of > clk_hw_register_mux(). > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar > --- Acked-by: Stephen Boyd ___

Re: [PATCH v4 4/4] arm64: dts: qcom: sm8250: fix display nodes

2021-03-29 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-03-29 05:00:51) > From: Jonathan Marek > > - Use sm8250 compatibles instead of sdm845 compatibles > Does it need the " - " prefix? > Signed-off-by: Jonathan Marek > Signed-off-by: Dmitry Baryshkov >

Re: [PATCH v4 2/4] dt-bindings: msm/disp: add compatibles for sm8150/sm8250 display

2021-03-29 Thread Stephen Boyd
> Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd This will conflict with the yaml changes to this file that are also in flight. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 3/4] drm/msm: add compatibles for sm8150/sm8250 display

2021-03-29 Thread Stephen Boyd
every new compatible in the condition. > > Signed-off-by: Jonathan Marek > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/3] drm/msm/dp: delete unnecessary debugfs error handling

2021-03-25 Thread Stephen Boyd
unctions are not supposed to be checked in the normal > case so delete this code. Also it silences the above Smatch > warnings that we're checking for NULL when these functions only > return error pointers. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-of

Re: [PATCH 2/3] drm/msm/dp: Fix incorrect NULL check kbot warnings in DP driver

2021-03-25 Thread Stephen Boyd
t; Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] drm/msm/dp: Fix indentation kbot warnings in DP driver

2021-03-25 Thread Stephen Boyd
rm/msm/dp/dp_power.c:203 dp_power_clk_enable() > warn: inconsistent indenting > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd ___ dri-devel mailing

<    5   6   7   8   9   10   11   12   13   14   >