Hi Yunfei,
Thank you for reflecting comments.
Reviewed-by: Steve Cho
On Mon, Dec 13, 2021 at 12:40 AM yunfei.d...@mediatek.com
wrote:
>
> Hi Steve,
>
> Thanks for your suggestion,
> On Thu, 2021-12-09 at 15:29 -0800, Steve Cho wrote:
> > Few comments and questions.
> &
Hi Yunfei,
Thank you for addressing my questions and comments.
Note that my comments for formatting are usually based on standards
from chromium & chrome os.
So feel free to reflect only if you think it is relevant.
Reviewed-by: Steve Cho
On Mon, Dec 13, 2021 at 12:52 AM yunf
Reviewed-by: Steve Cho
On Wed, Dec 1, 2021 at 7:46 PM Yunfei Dong wrote:
>
> Adds decoder dt-bindings for mt8192.
basic question: what is dt-bindings?
Is this yaml file supposed to be used for some settings?
>
> Signed-off-by: Yunfei Dong
> ---
> .../media/medi
On Wed, Dec 1, 2021 at 7:46 PM Yunfei Dong wrote:
>
> Add work queue to process core hardware information.
> First, get lat_buf from message queue, then call core
> hardware of each codec(H264/VP9/AV1) to decode, finally
> puts lat_buf back to the message.
>
> Signed-off-by: Yunfei Dong
> ---
>
Few comments and questions.
On Wed, Dec 1, 2021 at 7:46 PM Yunfei Dong wrote:
>
> There are more than two hardwares for decoder: LAT0, LAT1 and CORE. In order
> to
> manage these hardwares, register each hardware as independent platform device
> for the larbs are different.
basic question: what
Reviewed-by: Steve Cho
On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote:
>
> Using the needed param for pm init/release function and remove unused
> param mtkdev in 'struct mtk_vcodec_pm'.
nit: How about s/needed param/needed params |pdev| and |pm|/ ?
> Revi
Reviewed-by: Steve Cho
On Wed, Dec 1, 2021 at 4:09 AM AngeloGioacchino Del Regno
wrote:
>
> Il 29/11/21 04:41, Yunfei Dong ha scritto:
> > Register each hardware as platform device, need to call pm functions
> > to open/close power and clock from module mtk-vcodec
Reviewed-by: Steve Cho
On Wed, Dec 1, 2021 at 3:55 PM Steve Cho wrote:
>
> LGTM.
>
> On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote:
> >
> > Vdec and venc can use the same function to wake up interrupt event.
> >
> > Reviewed-by: Tzung-Bi Shih
> &g
Reviewed-by: Steve Cho
On Wed, Dec 1, 2021 at 4:10 AM AngeloGioacchino Del Regno
wrote:
>
> Il 29/11/21 04:41, Yunfei Dong ha scritto:
> > From: Yunfei Dong
> >
> > Adds MT8192's compatible "mediatek,mt8192-vcodec-dec".
> > Adds MT8192
LGTM.
On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote:
>
> Vdec and venc can use the same function to wake up interrupt event.
>
> Reviewed-by: Tzung-Bi Shih
> Reviewed-by: AngeloGioacchino Del Regno
>
> Signed-off-by: Yunfei Dong
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_dr
Hi Yunfei,
> This patch dependents on : "media: mtk-vcodec: support for MT8183 decoder"[1]
> and
> "Mediatek MT8192 clock support"[2].
>
> 1: Multi hardware decode is based on stateless decoder, MT8183 is the first
> time
> to add stateless decoder. Otherwise it will cause conflict. This patch w
Hi Ezequiel,
Thank you for reviewing these series from Yunfei!
This series is one of the main obstacles for us at the moment for MTK
so please continue to help & support reviewing this series.
> > According to google's suggestion, it's better not to use v4l2 async
> > also.
>
> Hum? I haven't see
> > [1]https://patchwork.linuxtv.org/project/linux-media/list/?series=5826
> This link seems to be no longer available.
It is probably because the default state is "Action Required", and
this series was accepted recently afterwards.
I can see the series with the below link.
https://patchwork.linu
13 matches
Mail list logo