On 19/09/2022 07:44, Adrián Larumbe wrote:
> Hi Steven,
>
> On 13.09.2022 09:45, Steven Price wrote:
>> On 12/09/2022 17:44, Adrián Larumbe wrote:
>>> Building Mesa's Perfetto requires including the panfrost drm uAPI header in
>>> C++ code, but the C++ compiler
2714a7dff0710ac5b8b457bcfe9ae52b458565 Mon Sep 17 00:00:00 2001
From: Steven Price
Date: Tue, 13 Sep 2022 09:37:55 +0100
Subject: [PATCH] drm/panfrost: Remove type name from internal structs
The two structs internal to struct panfrost_dump_object_header were
named, but sadly that is incompatible w
> Suggested-by: Viresh Kumar
> Signed-off-by: Clément Péron
Reviewed-by: Steven Price
Note this same sequence is used in the Lima driver, so it would be good
to submit the fix there too as it presumably is affected by the same
issue. I've CC'd Qiang for visibility.
I'll push this patch to
re efficient interface.
>
> Signed-off-by: Robin Murphy
Looks correct to me. Although the voodoo magic does take a little bit of
figuring out ;)
Reviewed-by: Steven Price
I'll push to drm-misc-next.
Thanks,
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 40 +++
han using magic numbers.
>
> Signed-off-by: Adrián Larumbe
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_regs.h | 42 ++--
> 1 file changed, 24 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_
On 29/07/2022 15:46, Adrián Larumbe wrote:
> In the event of a job timeout, debug dump information will be written into
> /sys/class/devcoredump.
>
> Inspired by etnaviv's similar feature.
>
> Signed-off-by: Adrián Larumbe
Reviewed-by: Steven Price
I'll push these to drm-
defines this, and secondly if
hardware did add more registers and change the stride then we'd still
need compatibility with the old hardware. So most likely we'd need a new
driver for the new hardware. So just drop the comment.
I'm not really sure why we have both _STRIDE and _SHIFT for the MMU
On 18/07/2022 18:24, Adrián Larumbe wrote:
> In the event of a job timeout, debug dump information will be written into
> /sys/class/devcoredump.
>
> Inspired by etnaviv's similar feature.
>
> Signed-off-by: Adrián Larumbe
LGTM
Reviewed-by: Steven Price
Steve
> -
static const struct panfrost_compatible mediatek_mt8183_data = {
> - .num_supplies = ARRAY_SIZE(mediatek_mt8183_supplies),
> + .num_supplies = ARRAY_SIZE(mediatek_mt8183_supplies) - 1,
> .supply_names = mediatek_mt8183_supplies,
> .num_pm_domains = ARRAY_SIZE(mediatek_mt8183_pm_domains),
> .pm_domain_names = mediatek_mt8183_pm_domains,
Reviewed-by: Steven Price
Thanks for the rework, much cleaner.
Steve
On 05/07/2022 05:34, Viresh Kumar wrote:
> On 04-07-22, 15:35, Steven Price wrote:
>> I have to say the 'new improved' list ending with NULL approach doesn't
>> work out so well for Panfrost. We already have to have a separate
>> 'num_supplies' variable for de
On 30/06/2022 21:05, Dmitry Osipenko wrote:
> This series fixes two minor bugs in the Panfrost driver.
>
> Changelog:
>
> v7: - Factored out Panfrost fixes from [1] since I'll be working on
> the dma-buf locking in a separate patchset now.
>
> [1]
>
On 04/07/2022 13:07, Viresh Kumar wrote:
> Make dev_pm_opp_set_regulators() accept a NULL terminated list of names
> instead of making the callers keep the two parameters in sync, which
> creates an opportunity for bugs to get in.
>
> Suggested-by: Greg Kroah-Hartman
> Signed-off-by: Viresh
On 22/06/2022 15:36, Adrián Larumbe wrote:
> In the event of a job timeout, debug dump information will be written into
> /sys/class/devcoredump.
>
> Inspired by etnaviv's similar feature.
>
> Signed-off-by: Adrián Larumbe
Looks pretty good, a few comments below.
> ---
>
On 22/06/2022 15:36, Adrián Larumbe wrote:
> Each Panfrost job has its own job slot and MMU address space set of
> registers, which are selected with a job-specific index.
>
> Turn the shift and stride used for selection of the right register set base
> into a define rather than using magic
ARM domain before attaching a new one.
Suggested-by: Robin Murphy
Signed-off-by: Steven Price
---
See also the thread[1] where I reported the regression.
[1]
https://lore.kernel.org/linux-kernel/da9cca0a-ec5b-2e73-9de0-a930f7d947b2%40arm.com
---
drivers/gpu/drm/rockchip/rockchip_drm_
it.
>
> Cc: sta...@vger.kernel.org
> Fixes: 013b65101315 ("drm/panfrost: Add madvise and shrinker support")
> Signed-off-by: Dmitry Osipenko
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 del
On 26/05/2022 12:42, Viresh Kumar wrote:
> The OPP core now provides a unified API for setting all configuration
> types, i.e. dev_pm_opp_set_config().
>
> Lets start using it.
>
> Signed-off-by: Viresh Kumar
Acked-by: Steven Price
> ---
> drivers/gpu/drm/panfros
t;
> As the first SoC with a Valhall GPU receiving mainline support, add a
> specific compatible for the MediaTek MT8192, which instantiates a
> Mali-G57.
>
> v2: Change compatible to arm,mali-valhall-jm (Daniel Stone).
>
> Signed-off-by: Alyssa Rosenzweig
> CC: devicet
ULL(HW_ISSUE_TTRX_2968_TTRX_3162) | \
> + BIT_ULL(HW_ISSUE_TTRX_3076) | \
> + BIT_ULL(HW_ISSUE_TTRX_3485))
There's no need to repeat the issues that are generic for g57 in the
r0p0 list. So this can be simplified to:
#define hw_issues_g57_r0p0 (\
BIT_ULL(HW_ISSUE_TTRX_3485))
With that fixed:
Reviewed-by: Steven Price
> +
> static inline bool panfrost_has_hw_issue(const struct panfrost_device *pfdev,
>enum panfrost_hw_issue issue)
> {
.
To fix this, drop the reference to panfrost_priv in the job structure
and add a direct reference to the MMU structure which is what's actually
needed.
Fixes: 7fdc48cc63a3 ("drm/panfrost: Make sure MMU context lifetime is not bound
to panfrost_priv")
Signed-off-by: Steven Price
---
d
On 17/05/2022 18:42, Adrián Larumbe wrote:
> In the event of a job timeout, debug dump information will be written into
> /sys/class/devcoredump.
>
> Inspired by etnaviv's similar feature.
>
> Signed-off-by: Adrián Larumbe
Nice! Some comments below.
> ---
> drivers/gpu/drm/panfrost/Kconfig
ot;drm/panfrost: Add the panfrost_gem_mapping concept")
Reviewed-by: Steven Price
Thanks,
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c
> b/drivers/gpu/drm/p
On 03/12/2021 13:08, Liviu Dudau wrote:
> On Fri, Dec 03, 2021 at 10:28:15AM +0000, Steven Price wrote:
>> While the check for format_count > 64 in __drm_universal_plane_init()
>> shouldn't be hit (it's a WARN_ON), in its current position it will then
>> leak the plane->
On 14/04/2022 12:51, AngeloGioacchino Del Regno wrote:
> Il 14/04/22 04:50, Nick Fan ha scritto:
>> Add devicetree schema for Arm Mali Valhall GPU
>>
>> Define a compatible string for the Mali Valhall GPU
>> for MediaTek's SoC platform.
>>
>> Signed-off-by: Nick Fan
>
> Hello Nick,
>
here is no good reason for releasing scheduler's jobs in IRQ
> context, hence use normal context to fix the trouble.
>
> Cc: sta...@vger.kernel.org
> Fixes: 542cff7893a3 ("drm/sched: Avoid lockdep spalt on killing a processes")
> Signed-off-by: Dmitry Osipenko
Revie
On 18/03/2022 14:41, Dmitry Osipenko wrote:
>
> On 3/17/22 02:04, Dmitry Osipenko wrote:
>>
>> On 3/16/22 18:04, Steven Price wrote:
>>> On 14/03/2022 22:42, Dmitry Osipenko wrote:
>>>> Replace Panfrost's memory shrinker with a generic DRM memory shrinker.
&
On 14/03/2022 22:42, Dmitry Osipenko wrote:
> Replace Panfrost's memory shrinker with a generic DRM memory shrinker.
>
> Signed-off-by: Dmitry Osipenko
> ---
I gave this a spin on my Firefly-RK3288 board and everything seems to
work. So feel free to add a:
Tested-by: Steven Price
On 14/03/2022 22:42, Dmitry Osipenko wrote:
> Introduce a common DRM SHMEM shrinker. It allows to reduce code
> duplication among DRM drivers, it also handles complicated lockings
> for the drivers. This is initial version of the shrinker that covers
> basic needs of GPU drivers.
>
> This patch
On 02/03/2022 12:45, t...@redhat.com wrote:
> From: Tom Rix
>
> For spdx
> change tab to space delimiter
> Use // for *.c
>
> Replacements
> commited to committed
> regsiters to registers
> initialze to initialize
>
> Signed-off-by: Tom Rix
Reviewed-b
On 01/03/2022 12:43, t...@redhat.com wrote:
> From: Tom Rix
>
> For spdx
> change tab to space delimiter
> Use // for *.c
>
> Replacements
> commited to committed, use multiline comment style
> regsiters to registers
> initialze to initialize
>
> Signed-off-by: Tom Rix
Thanks, most of the
useful
>>> to have the bit to record the feature bit when adding new models.
>>>
>>> Signed-off-by: Alyssa Rosenzweig
>>
>> Reviewed-by: Steven Price
>>
>> Sadly I don't have the hardware to try this out on, but it should be a
>> simple cas
On 14/02/2022 17:06, Alyssa Rosenzweig wrote:
> On Mon, Feb 14, 2022 at 04:23:18PM +0000, Steven Price wrote:
>> On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote:
>>> From: Alyssa Rosenzweig
>>>
>>> Some Valhall GPUs require resets when encountering b
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote:
> From: Alyssa Rosenzweig
>
> The most important Valhall-specific quirks have been handled, so add the
> Valhall compatible and probe.
>
> Signed-off-by: Alyssa Rosenzweig
Reviewed-by: Steven Price
> ---
>
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote:
> From: Alyssa Rosenzweig
>
> Add the features, issues, and GPU ID for Mali-G57, a first-generation
> Valhall GPU. Other first- and second-generation Valhall GPUs should be
> similar.
>
> Signed-off-by: Alyssa Rosenzweig
> ---
>
set to non-zero values. When
> left as zero, reads and writes are not throttled.
>
> Both kbase and panfrost always zero these registers. Per discussion with
> Steven Price, there are two reasons these quirks may be used:
>
> 1. Simulating slower memory subsystems. This use case i
y details. It's still useful
> to have the bit to record the feature bit when adding new models.
>
> Signed-off-by: Alyssa Rosenzweig
Reviewed-by: Steven Price
Sadly I don't have the hardware to try this out on, but it should be a
simple case of the below (untested):
8<
d
g has to be 'just
right' to hit the bug.
That said I think we should probably add pre-emption support sometime at
which point this could become an issue.
> Signed-off-by: Alyssa Rosenzweig
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_issues.h | 3 +++
> 1 fi
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote:
> From: Alyssa Rosenzweig
>
> Some Valhall GPUs require resets when encountering bus faults due to
> occlusion query writes. Add the issue bit for this and handle it.
>
> Signed-off-by: Alyssa Rosenzweig
Reviewe
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote:
> From: Alyssa Rosenzweig
>
> Logically, this function is free of side effects, so any pointers it
> takes should be const. Needed to avoid a warning in the next patch.
>
> Signed-off-by: Alyssa Rosenzweig
Reviewe
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote:
> From: Alyssa Rosenzweig
>
> Add handling for the HW_ISSUE_TTRX_2968_TTRX_3162 quirk. Logic ported
> from kbase. kbase lists this workaround as used on Mali-G57.
>
> Signed-off-by: Alyssa Rosenzweig
Reviewe
On 11/02/2022 20:27, alyssa.rosenzw...@collabora.com wrote:
> From: Alyssa Rosenzweig
>
> From the kernel's perspective, pre-CSF Valhall is more or less
> compatible with Bifrost, although they differ to userspace. Add a
> compatible for Valhall to the existing Bifrost bindings documentation.
>
ature mimicking kbase's behaviour.
>
> Tuning this register slightly improves performance of index-driven vertex
> shading. On Mali-G52 (with Mesa), overall glmark2 score is improved from 1026
> to
> 1037. Geometry-heavy scenes like -bshading are improved from 1068 to 1098.
>
> Signed
update the drivers that build upon GEM SHMEM
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 5 +++--
> drivers/gpu/drm/lima/lima_gem.c | 1 +
> drivers/gpu/drm/panfrost/panfrost_gem.c | 1 +
> driv
NFIG_DRM_KMS_CMA_HELPER option")
and with that...
Reviewed-by: Steven Price
Steve
> ---
> drivers/gpu/drm/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index 58a242871b28..6e3f1d600541 100644
> -
On 15/01/2022 16:06, Alexey Sheplyakov wrote:
> On a dual core group GPUs (such as T628) fragment shading can be
> performed over all cores (because a fragment shader job doesn't
> need coherency between threads), however vertex shading requires
> to be run on the same core group as the tiler
On 13/01/2022 10:01, Alexey Sheplyakov wrote:
> Hi, Steven!
>
> Thanks for such a detailed explanation of T628 peculiarities.
>
> On Wed, Jan 12, 2022 at 05:03:15PM +0000, Steven Price wrote:
>> On 10/01/2022 17:42, Alyssa Rosenzweig wrote:
>>>> Whether it's wo
On 12/01/2022 19:20, Alyssa Rosenzweig wrote:
>>> Now that we only list features of interest to kernel space, lots of GPUs
>>> have the same feature bits. To cut down on the repetition in the file,
>>> merge feature lists that are identical between similar GPUs.
>>>
>>> Note that this leaves some
On 10/01/2022 17:42, Alyssa Rosenzweig wrote:
>> Whether it's worth the effort depends on whether anyone really cares
>> about getting the full performance out of this particular GPU.
>>
>> At this stage I think the main UABI change would be to add the opposite
>> flag to kbase, (e.g.
On 09/01/2022 17:09, Alyssa Rosenzweig wrote:
> Now that we only list features of interest to kernel space, lots of GPUs
> have the same feature bits. To cut down on the repetition in the file,
> merge feature lists that are identical between similar GPUs.
>
> Note that this leaves some unmerged
rnel, leaving only those which do affect the
> register-level operation of the chip.
>
> Signed-off-by: Alyssa Rosenzweig
Reviewed-by: Steven Price
(although it's a good thing kbase never did this cleanup - it's a useful
source of public information ;) )
Steve
> ---
> drivers
: Set DMA masks earlier")
That commit just moved the code around, the actual missing error
handling dates from the very beginning (f3ba91228e8e ("drm/panfrost: Add
initial panfrost driver")). But I can fix that up when merging.
> Signed-off-by: Jiasheng Jiang
Reviewed-by: Steven
performance (although for individual test content this can
vary). AFAICT the performance impact isn't massive either.
> Applies on top of my feature clean up series which should go in first.
> (That's pure cleaunp, this is a behaviour change RFC needing
> discussion.)
>
> Signed-off-
On 09/01/2022 16:37, Alyssa Rosenzweig wrote:
> Update a comment stating create_bo took no flags, since it now takes a
> bit mask of optional flags NOEXEC and HEAP.
>
> Signed-off-by: Alyssa Rosenzweig
Reviewed-by: Steven Price
I'll push this to drm-misc-next.
Th
On 24/12/2021 08:56, Alexey Sheplyakov wrote:
> Hi,
>
> On 23.12.2021 18:11, Alyssa Rosenzweig wrote:
>>> The kernel driver itself can't guess which jobs need a such a strict
>>> affinity, so setting proper requirements is the responsibility of
>>> the userspace (Mesa). However the userspace is
On 17/12/2021 09:28, Dan Carpenter wrote:
> On Fri, Dec 17, 2021 at 09:16:19AM +0000, Steven Price wrote:
>> On 17/12/2021 09:10, Dan Carpenter wrote:
>>> On Fri, Dec 17, 2021 at 08:55:50AM +, Steven Price wrote:
>>>> However this one is harder to fix wi
On 17/12/2021 09:10, Dan Carpenter wrote:
> On Fri, Dec 17, 2021 at 08:55:50AM +0000, Steven Price wrote:
>> However this one is harder to fix without setting an arbitrary cap on
>> the number of BOs during a sumbit. I'm not sure how other drivers handle
>> this - the ones
On 16/12/2021 17:49, Alyssa Rosenzweig wrote:
>> This provides an easy method for user
>> space to trigger the OOM killer (by temporarily allocating large amounts
>> of kernel memory)
>
> panfrost user space has a lot of easy ways to trigger to the OOM killer
> unfortunately if this is
On 16/12/2021 17:12, Rob Herring wrote:
> On Thu, Dec 16, 2021 at 10:16 AM Steven Price wrote:
>>
>> panfrost_copy_in_sync() takes the number of fences from user space
>> (in_sync_count) and used to kvmalloc() an array to hold that number of
>> fences before processing
Reported-by: Dan Carpenter
Signed-off-by: Steven Price
---
drivers/gpu/drm/panfrost/panfrost_drv.c | 44 -
1 file changed, 14 insertions(+), 30 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c
b/drivers/gpu/drm/panfrost/panfrost_drv.c
index 96bb5a465627..12
On 16/12/2021 14:15, Boris Brezillon wrote:
> Hi Steve,
>
> On Thu, 16 Dec 2021 14:02:25 +
> Steven Price wrote:
>
>> + Boris
>>
>> On 16/12/2021 12:08, Dan Carpenter wrote:
>>> Hi DRM Devs,
>>>
>>> In commit 7661809d493b ("
+ Boris
On 16/12/2021 12:08, Dan Carpenter wrote:
> Hi DRM Devs,
>
> In commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls")
> from July, Linus added a WARN_ONCE() for "crazy" allocations over 2GB.
> I have a static checker warning for this and most of the warnings are
> from DRM
on: GPU interrupt
> + - description: Event interrupt
>
>interrupt-names:
> +minItems: 3
> items:
>- const: job
>- const: mmu
>- const: gpu
> + - const: event
FWIW: I think it's fair to add the "event" interrup
nction to avoid allocating those resources in the
first place.
Signed-off-by: Steven Price
---
drivers/gpu/drm/drm_plane.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
index 82afb854141b..fd0bf90fb4c2
> the common code.
>
> Reported-by: Steven Price
> Signed-off-by: Liviu Dudau
Reviewed-by: Steven Price
Looks correct, although I note there is a path in
__drm_universal_plane_init() which doesn't clean up properly. I'll send
a patch for that too.
Thanks,
Steve
> ---
> driv
On 01/12/2021 21:15, Liviu Dudau wrote:
> On Wed, Dec 01, 2021 at 03:44:03PM +0000, Steven Price wrote:
>> On 30/11/2021 14:25, Zhou Qingyang wrote:
>>> In komeda_plane_add(), komeda_get_layer_fourcc_list() is assigned to
>>> formats and used
On 30/11/2021 14:25, Zhou Qingyang wrote:
> In komeda_plane_add(), komeda_get_layer_fourcc_list() is assigned to
> formats and used in drm_universal_plane_init().
> drm_universal_plane_init() passes formats to
> __drm_universal_plane_init(). __drm_universal_plane_init() further
> passes formats to
ligns the callback with its callers. Fixes the ingenic driver,
> which already returns an error pointer.
>
> Also update the callers to handle the involved types more strictly.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Steven Price
> ---
> There is an alternat
On 01/11/2021 05:20, Bert Schiettecatte wrote:
> Hi John
>
>> Coincidentally, I've been looking at Panfrost on RK3288 this week as
>> well! I'm testing it with a project that has been using the binary blob
>> driver for several years and unfortunately Panfrost seems to use ~15%
>> more CPU.
>>
On 04/10/2021 13:24, Boris Brezillon wrote:
> On Mon, 4 Oct 2021 12:30:42 +0100
> Steven Price wrote:
[...]
>>
>> It took me a while to convince myself that the reference counting for
>> the PM reference is correct. Before panfrost_job_hw_submit() always
>> re
hen this
is clearly better.
A couple of minor points below, but as far as I can tell this is
functionally correct.
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 9 +++--
> drivers/gpu/drm/panfrost/panfrost_job.c | 6 ++
> include/uapi/drm/panfrost
fields by a version field which is mapped to
> a tuple internally
>
> v3:
> * Re-use panfrost_get_job_bos() and panfrost_get_job_in_syncs() in the
> old submit path
>
> Signed-off-by: Boris Brezillon
Reviewed-by: Steven Price
> ---
> drivers/gpu/drm/panfrost/panf
On 01/10/2021 15:34, Boris Brezillon wrote:
> This lets the driver reduce shareability domain of the MMU mapping,
> which can in turn reduce access time and save power on cache-coherent
> systems.
>
> Signed-off-by: Boris Brezillon
This seems reasonable to me - it matches the kbase
t looks like you're correct here - I've never looked closely into
exactly how pilot shaders work. It would appear that the DDK checks (in
user space) for the GPU-executable + GPU-writable condition and moans.
So this obviously isn't used by the DDK as it stands.
For the actual patch:
Reviewed-by: S
On 29/09/2021 19:33, Lucas De Marchi wrote:
> Like the IS_ENABLED() counterpart, we can make IS_CONFIG_NONZERO() to
> return the right thing when the config is not defined rather than a
> build error, with the limitation that it can't be used on preprocessor
> context.
>
> The trick here is that
hould it be static?
>
> drivers/gpu/drm/panfrost/panfrost_drv.c:642:12: warning: symbol
> 'mediatek_mt8183_pm_domains' was not declared. Should it be static?
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Reviewed-by: Steven Price
I'll push to drm-misc-next.
Than
On 20/09/2021 10:05, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang
> ---
Reviewed-by: Steven Price
I'll push this to drm-misc-next.
Thanks,
St
On 03/09/2021 10:49, Steven Price wrote:
> It turns out that when locking a region, the region must be a naturally
> aligned power of 2. The upshot of this is that if the desired region
> crosses a 'large boundary' the region size must be increased
> significantly to ensure that the l
from the
end because the end address is exclusive). The start address is then
aligned based on the size (this is technically unnecessary as the
hardware will ignore these bits, but the spec advises to do this "to
avoid confusion").
Reviewed-by: Boris Brezillon
Signed-off-by: St
On 03/09/2021 09:51, Boris Brezillon wrote:
> On Thu, 2 Sep 2021 15:00:38 +0100
> Steven Price wrote:
>
>> It turns out that when locking a region, the region must be a naturally
>> aligned power of 2. The upshot of this is that if the desired region
>> crosses a
from the
end because the end address is exclusive). The start address is then
aligned based on the size (this is technically unnecessary as the
hardware will ignore these bits, but the spec advises to do this "to
avoid confusion").
Signed-off-by: Steven Price
---
See previous di
On 31/08/2021 08:53, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing
Reviewed-by: Steven Price
I'll push this to drm-misc-next.
do the same mistake again.
>
> Fixes: 53516280cc38 ("drm/panfrost: use scheduler dependency tracking")
> Signed-off-by: Boris Brezillon
Reviewed-by: Steven Price
And also unlike last time...
Tested-by: Steven Price
Thanks for the clean up - I should have actually tested the pr
ly "creative" way of writing upper_32_bits.
>
> v2: Use helpers for one more call site and add review tag (Steven).
>
> Signed-off-by: Alyssa Rosenzweig
> Reviewed-by: Rob Herring (v1)
> Reviewed-by: Steven Price
Pushed to drm-misc-next
Thanks,
Steve
> ---
On 25/08/2021 15:07, Alyssa Rosenzweig wrote:
>>> In practice, the current callers pass PAGE_SIZE aligned inputs, avoiding
>>> the bug. Therefore this doesn't need to be backported. Still, that's a
>>> happy accident and not a precondition of lock_region, so we let's do the
>>> right thing to
er_32_bits(gpuva));
gpu_write(pfdev, GPU_INT_CLEAR,
GPU_IRQ_CLEAN_CACHES_COMPLETED |
GPU_IRQ_PERFCNT_SAMPLE_COMPLETED);
---8<--
With that squashed in:
Reviewed-by: Steven Price
Thanks,
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_
oundary) requires locking
*at least* 0x-0x2 (i.e. locking the first 8GB).
This appears to be broken in kbase (which actually does zero out the low
bits of the address) - I've raised a bug internally so hopefully someone
will tell me if I've read the spec completely wrong here.
Steve
> Signed
ed.
>
> The new form of the calculation corrects this special case and avoids
> the undefined behaviour.
>
> Signed-off-by: Alyssa Rosenzweig
> Reported-and-tested-by: Chris Morgan
> Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver")
> Cc:
On 23 August 2021 22:13:45 BST, Alyssa Rosenzweig wrote:
>> > When locking a region, we currently clamp to a PAGE_SIZE as the minimum
>> > lock region. While this is valid for Midgard, it is invalid for Bifrost,
>>
>> While the spec does seem to state it's invalid for Bifrost - kbase
>> didn't
On 23 August 2021 22:11:09 BST, Alyssa Rosenzweig wrote:
>> > Mali virtual addresses are 48-bit. Use a u64 instead of size_t to ensure
>> > we can express the "lock everything" condition as ~0ULL without relying
>> > on platform-specific behaviour.
>>
>> 'platform-specific behaviour' makes it
On 23 August 2021 22:09:08 BST, Alyssa Rosenzweig wrote:
>> > In lock_region, simplify the calculation of the region_width parameter.
>> > This field is the size, but encoded as log2(ceil(size)) - 1.
>> > log2(ceil(size)) may be computed directly as fls(size - 1). However, we
>> > want to use the
e 4k page size. Add a
> hardware definition for the minimum lock region size (corresponding to
> KBASE_LOCK_REGION_MIN_SIZE_LOG2 in kbase) and respect it.
>
> Signed-off-by: Alyssa Rosenzweig
> Tested-by: Chris Morgan
> Cc:
Reviewed-by: Steven Price
> ---
> drivers/gpu
itial panfrost driver")
Reviewed-by: Steven Price
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c
> b/drivers/gpu/drm/panfrost/
gger issue with it being completely wrong when size == ~0 (see below).
> Signed-off-by: Alyssa Rosenzweig
> Reported-and-tested-by: Chris Morgan
> Cc:
However, I've confirmed this returns the same values and is certainly
more simple, so:
Reviewed-by: Steven Price
> ---
> drive
r would also allow us to use dev_err_probe(). But as a point
fix this patch is fine and correct. Thanks!
> Signed-off-by: Chris Morgan
Reviewed-by: Steven Price
I'll apply this to drm-misc-next.
Thanks,
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 3 ++-
> 1 f
On 14/07/2021 16:26, Laurent Pinchart wrote:
> Hi Steven,
>
> Thank you for the patch.
>
> On Wed, Jul 14, 2021 at 03:33:00PM +0100, Steven Price wrote:
>> When bailing out due to the sanity check the iterator value needs to be
>> freed because the early return prev
When bailing out due to the sanity check the iterator value needs to be
freed because the early return prevents for_each_child_of_node() from
doing the dereference itself.
Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Signed-off-by: Steven Price
---
drive
On 12/07/2021 22:55, Laurent Pinchart wrote:
> Hi Steven,
Hi Laurent,
> On Mon, Jul 12, 2021 at 10:31:52PM +0100, Steven Price wrote:
>> On 12/07/2021 17:50, Laurent Pinchart wrote:
>>> On Mon, Jul 12, 2021 at 04:57:58PM +0100, Steven Price wrote:
>>>> When ba
On 12/07/2021 17:50, Laurent Pinchart wrote:
> Hi Steven,
>
> Thank you for the patch.
>
> On Mon, Jul 12, 2021 at 04:57:58PM +0100, Steven Price wrote:
>> When bailing out due to the sanity check the iterator value needs to be
>> freed because the early return prev
When bailing out due to the sanity check the iterator value needs to be
freed because the early return prevents for_each_child_of_node() from
doing the dereference itself.
Fixes: 4ee48cc5586b ("drm: of: Fix double-free bug")
Signed-off-by: Steven Price
---
drivers/gpu/drm/drm_of.c |
value
> to custom,so it's better fault_status don't (& 0xFF).
>
> Signed-off-by: ChunyouTang
Reviewed-by: Steven Price
Boris's change has actually modified panfrost_exception_name() to no
longer take pfdev in drm-misc-next. However, I'll just fix this up when
I apply it.
Thanks,
St
201 - 300 of 755 matches
Mail list logo
