related to crc reads and vertical blanking, in which case,
tests are skipped.
The patch is based on Rodrigo Siqueira's
patch(https://patchwork.freedesktop.org/patch/316851/?series=48469=3)
and the ensuing review.
Signed-off-by: Sumera Priyadarsini
---
Changes in V6:
- Skip CRC functions
Add a new function vkms_composer_common(). The actual plane
composition work has been moved to the helper function,
vkms_composer_common() which is called by vkms_composer_worker()
and will be called in the implementation of virtual_hw mode
as well.
Signed-off-by: Sumera Priyadarsini
---
Changes
for
subtests related to crc reads and vertical blanking, in which case,
tests are skipped.
Sumera Priyadarsini (2):
drm/vkms: Refactor vkms_composer_worker() to prep for virtual_hw mode
drm/vkms: Add support for virtual hardware mode
drivers/gpu/drm/vkms/vkms_composer.c | 92
that rely on vertical
blanking.
The patch is based on Rodrigo Siqueira's
patch(https://patchwork.freedesktop.org/patch/316851/?series=48469=3)
and the ensuing review.
Signed-off-by: Sumera Priyadarsini
---
Changes in V5:
- Move vkms_crtc_composer() to this patch(Melissa)
- Add more clarification
Add a new function vkms_composer_common(). The actual plane
composition work has been moved to the helper function,
vkms_composer_common() which is called by vkms_composer_worker()
and will be called in the implementation of virtual_hw mode
as well.
Signed-off-by: Sumera Priyadarsini
---
Changes
related to crc reads and skips tests that rely on vertical
blanking.
Sumera Priyadarsini (2):
drm/vkms: Refactor vkms_composer_worker() to prep for virtual_hw mode
drm/vkms: Add support for virtual hardware mode
drivers/gpu/drm/vkms/vkms_composer.c | 93 ++--
drivers
On Mon, Jul 12, 2021 at 6:53 PM Thomas Zimmermann wrote:
>
> Hi
>
> Am 12.07.21 um 13:56 schrieb Sumera Priyadarsini:
> > On Mon, Jul 5, 2021 at 1:16 PM Thomas Zimmermann
> > wrote:
> >>
> >> Vkms copies each plane's framebuffer into the output buff
5708ba
> --
> 2.32.0
>
Hi,
Thanks for the patches. The switch to shadow-plane helpers also solved
a bug that was causing a kernel
panic during some IGT kms_flip subtests on the vkms virtual hw patch.
Tested-by: Sumera Priyadarsini
Cheers,
Sumera
/igt-dev/2021-February/029355.html .
The patch is based on Rodrigo Siqueira's
patch(https://patchwork.freedesktop.org/patch/316851/?series=48469=3)
and the ensuing review.
Signed-off-by: Sumera Priyadarsini
---
Changes in V3:
- Refactor patchset(Melissa)
Changes in V2:
- Add atomic helper
virtual_hw mode.
Signed-off-by: Sumera Priyadarsini
---
Changes in V4:
- Fix warning
Changes in V3:
- Refactor patchset (Melissa)
Change in V2:
- Add vkms_composer_common() (Daniel)
---
drivers/gpu/drm/vkms/vkms_composer.c | 88 +---
drivers/gpu/drm/vkms/vkms_drv.h | 3 +
2
related to crc reads and skips tests that rely on vertical
blanking. This patchset must be tested after incorporating the
igt-tests patch:
https://lists.freedesktop.org/archives/igt-dev/2021-February/029355.html
Sumera Priyadarsini (2):
drm/vkms: Refactor vkms_composer_worker() to prep
git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:
> https://github.com/0day-ci/linux/commits/Sumera-Priyadarsini/Add-virtual-hardware-module/20210404-211300
> base: h
/igt-dev/2021-February/029355.html .
The patch is based on Rodrigo Siqueira's
patch(https://patchwork.freedesktop.org/patch/316851/?series=48469=3)
and the ensuing review.
Signed-off-by: Sumera Priyadarsini
---
Changes in V3:
- Refactor patchset(Melissa)
Changes in V2:
- Add atomic helper
virtual_hw mode.
Signed-off-by: Sumera Priyadarsini
---
Changes in V3:
- Refactor patchset (Melissa)
Change in V2:
- Add vkms_composer_common() (Daniel)
---
drivers/gpu/drm/vkms/vkms_composer.c | 88 +---
drivers/gpu/drm/vkms/vkms_drv.h | 3 +
2 files changed, 58
for
subtests related to crc reads and skips tests that rely on vertical
blanking. This patchset must be tested after incorporating the
igt-tests patch:
https://lists.freedesktop.org/archives/igt-dev/2021-February/029355.html
Sumera Priyadarsini (2):
drm/vkms: Refactor vkms_composer_worker
clearer and easier to test
virtual hardware mode.
Signed-off-by: Sumera Priyadarsini
---
Changes in V2:
- Add atomic helper functions in a separate struct for virtual hardware
mode (Daniel)
---
drivers/gpu/drm/vkms/vkms_crtc.c | 69 ++--
1 file changed, 39 insertions
-shot implementation of crc reads so I am
still working on that.
The patch is based on Rodrigo Siqueira's
patch(https://patchwork.freedesktop.org/patch/316851/?series=48469=3)
and the ensuing review.
Signed-off-by: Sumera Priyadarsini
Changes in V2:
- Remove spinlock across 'vkms_output->l
-February/029355.html .
Sumera Priyadarsini (2):
drm/vkms: Add support for virtual hardware mode
drm/vkms: Add crtc atomic helper functions for virtual mode
drivers/gpu/drm/vkms/vkms_composer.c | 88 +---
drivers/gpu/drm/vkms/vkms_crtc.c | 45 ++
drivers/gpu
/029355.html .
The patch is based on Rodrigo Siqueira's
patch(https://patchwork.freedesktop.org/patch/316851/?series=48469=3)
and the ensuing review.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/vkms/vkms_composer.c | 46
drivers/gpu/drm/vkms/vkms_crtc.c | 17
rity: ("Dereference null return value")
> Fixes: 2df7af93fdad ("drm/vkms: Add vkms_config type")
> Signed-off-by: Colin Ian King
Good catch, thank you!
Reviewed-by: Sumera Priyadarsini
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 6 +-
> 1 file changed, 5 in
Fix typo in intro chapter in drm_vblank.c.
Change 'sacn' to 'scan'.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/drm_vblank.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index d30e2f2b8f3c
Update vkms documentation to contain usage of `modinfo`
command and steps to load vkms with module options enabled.
Signed-off-by: Sumera Priyadarsini
---
Documentation/gpu/vkms.rst | 12
1 file changed, 12 insertions(+)
diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu
Add enable_writeback feature to vkms_config as a module.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/vkms/vkms_drv.c| 5 +
drivers/gpu/drm/vkms/vkms_drv.h| 1 +
drivers/gpu/drm/vkms/vkms_output.c | 9 ++---
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git
functions.
Modify usage of enable_cursor feature to reflect the changes in
relevant files.
Co-developed-by: Daniel Vetter
Signed-off-by: Daniel Vetter
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/vkms/vkms_drv.c| 40 --
drivers/gpu/drm/vkms/vkms_drv.h
is developed by Daniel Vetter.
Daniel Vetter (1):
drm/vkms: Add vkms_config type
Sumera Priyadarsini (3):
drm/vkms: Add vkms_config type
drm/vkms: Add support for writeback module
drm/vkms: Add information about module options
Documentation/gpu/vkms.rst | 12
drivers/gpu/drm/vkms
Update vkms documentation to contain usage of `modinfo`
command and steps to load vkms with module options enabled.
Signed-off-by: Sumera Priyadarsini
---
Documentation/gpu/vkms.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu
Add enable_writeback feature to vkms_config as a module.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/vkms/vkms_drv.c| 5 +
drivers/gpu/drm/vkms/vkms_drv.h| 1 +
drivers/gpu/drm/vkms/vkms_output.c | 9 ++---
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git
functions.
Modify usage of enable_cursor feature to reflect the changes in
relevant files.
Co-developed-by: Daniel Vetter
Signed-off-by: Daniel Vetter
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/vkms/vkms_drv.c| 40 --
drivers/gpu/drm/vkms/vkms_drv.h
is developed by Daniel Vetter.
Daniel Vetter (1):
drm/vkms: Add vkms_config type
Sumera Priyadarsini (3):
drm/vkms: Add vkms_config type
drm/vkms: Add support for writeback module
drm/vkms: Add information about module options
Documentation/gpu/vkms.rst | 10 +++
drivers/gpu/drm/vkms
functions.
Modify usage of enable_cursor feature to reflect the changes in
relevant files.
Add enable_writeback_connector feature to vkms_config type.
Co-developed-by: Daniel Vetter
Signed-off-by: Daniel Vetter
Signed-off-by: Sumera Priyadarsini
---
Changes in v2:
- add Co-developed-by tag
track of
by vkms_init and vkms_exit functions.
Modify usage of enable_cursor feature to reflect the changes in
relevant files.
Signed-off-by: Sumera Priyadarsini
Co-developed-by: Daniel Vetter
---
Changes in v2:
- add Co-developed-by tag
---
drivers/gpu/drm/vkms/vkms_drv.c| 40
track of
by vkms_init and vkms_exit functions.
Modify usage of enable_cursor feature to reflect the changes in
relevant files.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/vkms/vkms_drv.c| 40 --
drivers/gpu/drm/vkms/vkms_drv.h| 11 +---
drivers
Update the vkms documentation to contain steps to:
- setup the vkms driver
- run tests using igt
Signed-off-by: Sumera Priyadarsini
___
Changes in v2:
- Change heading to title case (Daniel)
- Add examples to run tests directly (Daniel)
- Add examples to run subtests (Melissa)
Changes
On Wed, Dec 9, 2020 at 6:24 AM Daniel Vetter wrote:
>
> On Wed, Dec 09, 2020 at 02:07:35AM +0530, Sumera Priyadarsini wrote:
> > Update the vkms documentation to contain steps to:
> >
> > - setup the vkms driver
> > - run tests using igt
> >
&g
Update the vkms documentation to contain steps to:
- setup the vkms driver
- run tests using igt
Signed-off-by: Sumera Priyadarsini
___
Changes in v2:
- Change heading to title case (Daniel)
- Add examples to run tests directly (Daniel)
- Add examples to run subtests (Melissa
Update the vkms documentation to contain steps to:
- setup the vkms driver
- run tests using igt
Signed-off-by: Sumera Priyadarsini
---
Documentation/gpu/vkms.rst | 47 ++
1 file changed, 47 insertions(+)
diff --git a/Documentation/gpu/vkms.rst b
On Fri, 30 Oct, 2020, 1:32 PM Greg KH, wrote:
> On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
> > > > Using DEFINE_DEBUGFS_ATTRIBUTE macro with
>
Bool initialisation should use 'true' and 'false' values instead of 0
and 1.
Modify amdgpu_amdkfd_gpuvm.c to initialise variable is_imported
to false instead of 0.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
1
.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index d6c38e24f130..4d1d1e1b005d 100644
--- a/drivers/gpu/drm/amd
in the relevant files.
Sumera Priyadarsini (5):
gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()
gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()
gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()
gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()
gpu: drm: amdgpu: Replace
On Thu, Oct 22, 2020 at 7:24 PM Greg KH wrote:
> On Thu, Oct 22, 2020 at 07:17:56PM +0530, Sumera Priyadarsini wrote:
> > Using snprintf() for show() methods holds the risk of buffer overrun
> > as snprintf() does not know the PAGE_SIZE maximum of the temporary
> > buffer
with Coccinelle.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
index 1721739def84..441e07ee1967 100644
.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index e5ea14774c0c..6d9901e1b4b0 100644
--- a/drivers/gpu/drm
with Coccinelle.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
index 469352e2d6ec..3c19862c94c7 100644
with Coccinelle.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index f7307af76452..7eef6b20578f 100644
Return statements for functions returning bool should use truth
and false instead of 1 and 0 respectively.
Modify cik_event_interrupt.c to return false instead of 0.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 4
46 matches
Mail list logo
