Re: [PATCH RESEND drm-misc 4/4] dma-buf: heaps: make dma_heap_class constant

ma_heap/%s", dev_name(dev)); > > -} > > - > > static int dma_heap_init(void) > > { > > int ret; > > @@ -314,12 +317,11 @@ static int dma_heap_init(void) > > if (ret) > > return ret; > > > > - dma_heap_class

Re: [PATCH] dma-buf: heaps: Don't track CMA dma-buf pages under RssFile

ruct dma_buf *dmabuf, struct > vm_area_struct *vma) > if ((vma->vm_flags & (VM_SHARED | VM_MAYSHARE)) == 0) > return -EINVAL; > > + vm_flags_set(vma, VM_IO | VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); > + > vma->vm_ops = _heap_vm_ops; > vma->vm_private_data = buffer; > > > > -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs

Re: [PATCH v2] Remove the parameter not described warning

ith all > * fences in the sync_file > -- > 2.34.1 > Best, Sumit. -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs

Re: [PATCH] Remove the parameter not described warning

file > * @pad: padding for 64-bit alignment, should always be zero > * @sync_fence_info: pointer to array of struct _fence_info with all > * fences in the sync_file > -- > 2.34.1 > Best, Sumit. -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs

Re: [PATCH v2] dma-buf: fix an error pointer vs NULL bug

drm_syncobj_assign_null_handle(), to check for NULL instead. > > > > Fixes: f781f661e8c9 ("dma-buf: keep the signaling time of merged fences v3") > > Signed-off-by: Dan Carpenter > Thanks for catching this! > Reviewed-by: Christian König Reviewed-by: Sumit Semwal

Re: [PATCH] MAINTAINERS: Add T.J. Mercier as reviewer for DMA-BUF HEAPS FRAMEWORK

Hi John, On Fri, 30 Jun 2023 at 10:22, John Stultz wrote: > > T.J. has been responsible for dmab-buf items on the Android team > for awhile now, so it would be great to have him on as a reviewer. > > Cc: T.J. Mercier > Cc: Sumit Semwal > Cc: Benjamin Gaignard > Cc: B

Re: [Freedreno] [PATCH 2/2] drm/msm/dpu/catalog: define DSPP blocks found on sdm845

_4_0_sdm845.h| 21 +++ > 1 file changed, 17 insertions(+), 4 deletions(-) Thanks for your patch, Dmitry. LGTM. Please feel free to add: Reviewed-by: Sumit Semwal > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h > b/drivers/gpu/drm/msm/disp/dpu1

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: do not enable color-management if DSPPs are not available

pcc color block in dpu > driver") > Reported-by: Yongqin Liu > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Thanks for your patch, Dmitry. LGTM. Please feel free to add: Reviewed-

Re: [PATCH] dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy

w.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > > [2] https://github.com/KSPP/linux/issues/89 Thank you for the patch; I'll queue it up. > > > > Signed-off-by: Azeem Shaikh > > Reviewed-by: Kees Cook > > -- > Kees Cook Best, Sumit. -- Thanks and rega

Re: [PATCH] dma-buf: fix dma_buf_export init order v2

anges to dma_bug_getfile() and a missing NULL > check in dma_buf_file_release() > > Signed-off-by: Christian König Thank you for this nice cleanup. Acked-by: Sumit Semwal Best, Sumit. > --- > drivers/dma-buf/dma-buf-sysfs-stats.c | 7 +-- > drivers/dma-buf/

Re: [PATCH 2/5] driver core: make struct class.devnode() take a const *

d propagate the function > > signature changes out into all relevant subsystems that use this > > callback. > > Acked-by: Mauro Carvalho Chehab > > Please feel free to add my Acked-by: Sumit Semwal for the dma-buf portion. Best, Sumit. > > Cc: Fenghua Yu > > Cc: R

Re: [PATCH v4] dma-buf: fix racing conflict of dma_heap_add()

+/* check the name is unique */ > >> +list_for_each_entry(h, _list, list) { > >> +if (!strcmp(h->name, exp_info->name)) { > >> +mutex_unlock(_list_lock); > >> +pr_err("dma_heap: Already registered heap named %s\n", > >> + exp_info->name); > >> +err_ret = ERR_PTR(-EINVAL); > >> +goto err3; > >> +} > >> +} > >> + > >> +/* Add heap to the list */ > >> list_add(>list, _list); > >> mutex_unlock(_list_lock); > >> > >> return heap; > >> > >> +err3: > >> +device_destroy(dma_heap_class, heap->heap_devt); > >> err2: > >> cdev_del(>heap_cdev); > >> err1: > >> -- > >> 2.25.1 > >> > -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs

Re: [PATCH v5 00/21] Move all drivers to a common dma-buf locking convention

drivers/infiniband/core/umem_dmabuf.c | 7 +- > .../common/videobuf2/videobuf2-dma-contig.c | 22 +- > .../media/common/videobuf2/videobuf2-dma-sg.c | 19 +- > .../common/videobuf2/videobuf2-vmalloc.c | 17 +- > .../platform/nvidia/tegra-vde/dmabuf-cache.c | 6 +-

Re: [PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification

return; > > + dma_resv_assert_held(dmabuf->resv); > + > BUG_ON(iosys_map_is_null(>vmap_ptr)); > BUG_ON(dmabuf->vmapping_counter == 0); > BUG_ON(!iosys_map_is_equal(>vmap_ptr, map)); > -- > 2.37.3 > -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs

Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag

gt; Suggested-by: Al Viro > > Cc: Sumit Semwal > > Cc: Christian König > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Jason A. Donenfeld > > I'm assuming this is part of a vfs cleanup and lands through that tree? > For that: > > Acked

Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support

Hi Joel, On Wed, 8 Jun 2022 at 22:10, Joel Selvaraj wrote: > > Hi Sumit, > > On 08/06/22 22:00, Sumit Semwal wrote: > > This is entirely my fault - It somehow missed my radar, and I didn't > > queue it up. I will push it via drm-misc tree tonight. Apologies > >

Re: [PATCH v2 1/3] drm/panel: nt36672a: add backlight support

Hi Joel, On Wed, 8 Jun 2022 at 00:01, Joel Selvaraj wrote: > > Hi, > > I can see that the dts changes from this patch series has been applied > to 5.19-rc1 release. However, this patch that has the related change to > the panel driver, is not applied in the 5.19-rc1 release. Any particular >

Re: [PATCH] dma-buf: add the name field to the table header

Hi Christian, On Thu, 28 Apr 2022 at 13:33, Christian König wrote: > > Am 28.04.22 um 08:39 schrieb Yuanzheng Song: > > 'cat /sys/kernel/debug/dma_buf/bufinfo' will print the Dma-buf > > Objects' information when the CONFIG_DEBUG_FS=y. > > However, the printed table header information does not

Re: [PATCH] dma-buf: check the return value of kstrdup()

anks for the patch; looks sane. > > Signed-off-by: Xiaoke Wang Acked-by: Sumit Semwal Will queue it up. > --- > drivers/dma-buf/selftest.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/dma-buf/selftest.c b/drivers/dma-buf/selftest.c > index c60b6

Re: [PATCH v2] dma-buf-map: Rename to iosys-map

-misc-next and provide a > >follow up to cleanup the MAINTAINERS file a bit more. Thank you for the patch; apologies for not being able to respond earlier (was out due to covid, just getting back slowly). With Christian's suggestions, looks good to me as well - feel free to add an Acked-by: S

Re: [PATCH] dma-buf: heaps: Fix potential spectre v1 gadget

Hello Jordy, On Tue, 1 Feb 2022 at 02:09, John Stultz wrote: > > On Sat, Jan 29, 2022 at 7:06 AM Jordy Zomer wrote: > > > > It appears like nr could be a Spectre v1 gadget as it's supplied by a > > user and used as an array index. Prevent the contents > > of kernel memory from being leaked to

Re: [PATCH] dma-buf: cma_heap: Fix mutex locking section

Hello Weizhao, On Tue, 4 Jan 2022 at 13:13, John Stultz wrote: > > On Mon, Jan 3, 2022 at 11:36 PM Weizhao Ouyang wrote: > > > > Fix cma_heap_buffer mutex locking critical section to protect vmap_cnt > > and vaddr. > > > > Fixes: a5d2d29e24be ("dma-buf: heaps: Move heap-helper logic into the >

Re: [PATCH v2] dma-buf: dma-heap: Add a size check for allocation

ndex 56bf5ad01ad5..e39d2be98d69 100644 > > > > --- a/drivers/dma-buf/dma-heap.c > > > > +++ b/drivers/dma-buf/dma-heap.c > > > > @@ -55,6 +55,8 @@ static int dma_heap_buffer_alloc(struct > > > > dma_heap *heap, size_t len, > > > > struct dma_buf *dmabuf; > > > > int fd; > > > > > > > > + if (len / PAGE_SIZE > totalram_pages()) > > > > + return -EINVAL; > > > > > > This seems sane. I know ION used to have some 1/2 of memory cap to > > > avoid unnecessary memory pressure on crazy allocations. > > > > > > Could you send again with an improved commit message? > > > > > > thanks > > > -john > > > > -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs

Re: [PATCH] MAINTAINERS: Update e-mail addresses for Laura Abbott

Kozlowski > Kuninori Morimoto > +Laura Abbott > +Laura Abbott > +Laura Abbott > Leonardo Bras > Leonid I Ananiev > Leon Romanovsky > diff --git a/MAINTAINERS b/MAINTAINERS > index 43007f2d29e0..21ab7c9d1bee 100644 > --- a/MAINTAINERS > +++ b/MAINTAINE

Re: [PATCH v4] dma-buf: system_heap: Use 'for_each_sgtable_sg' in pages free flow

0 ("dma-buf: system_heap: Allocate higher order pages if > > available") > > Signed-off-by: Guangming > > Reviewed-by: Robin Murphy > > Cc: # 5.11.* > > Thanks so much for catching this and sending in all the revisions! > > Reviewed-by: John Stultz Best, Sumit. -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs

Re: [PATCH v2] dma-buf: move dma-buf symbols into the DMA_BUF module namespace

> >> Cc: Thomas Zimmermann > >> Cc: Mauro Carvalho Chehab > >> Cc: dri-devel@lists.freedesktop.org > >> Acked-by: Daniel Vetter > >> Acked-by: Christian König > >> Acked-by: Arnd Bergmann > >> Acked-by: Sumit Semwal > >

Re: [PATCH] dma-buf: fix kerneldoc for renamed members

eucher > LGTM, but perhaps you want to send it from your amd.com account? Acked-by: Sumit Semwal > > > --- > > include/linux/dma-buf.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/dma-buf.h b/include/linux/dma-b

Re: [PATCH v2] dma-buf: remove restriction of IOCTL:DMA_BUF_SET_NAME

Hello Guangming, Christian, On Tue, 12 Oct 2021, 14:09 , wrote: > From: Guangming Cao > > > Am 09.10.21 um 07:55 schrieb guangming@mediatek.com: > > From: Guangming Cao > > > > > > If dma-buf don't want userspace users to touch the dmabuf buffer, > > > it seems we should add this

Re: [PATCH] dma-buf: move dma-buf symbols into the DMA_BUF module namespace

properly import the namespace to not break the build at the > same time. > > Now the output of modinfo shows the use of these symbols, making it > easier to watch for users over time: > > $ modinfo drivers/misc/fastrpc.ko | grep import > import_ns: DMA_BUF > > Cc: S

Re: [PATCH] dma-buf: system_heap: Avoid warning on mid-order allocations

fall back to single page allocatitions in that case. > > This is the similar to what we already do for large order > > allocations. > > > > Cc: Daniel Vetter > > Cc: Christian Koenig > > Cc: Sumit Semwal > > Cc: Liam Mark > > Cc: Chris Goldsworth

Re: [PATCH 0/3] dma-buf: Add missing dependencies on DMA_SHARED_BUFFER

Hello Geert, On Thu, 2 Sept 2021 at 18:19, Geert Uytterhoeven wrote: > > Hi Sumit, Christian, > > This patch series adds missing dependencies on DMA_SHARED_BUFFER to > various options of DMA-BUF, and drops a bogus select. > > As drivers/dma-buf/Kconfig contains interleaved options that

Re: [PATCH] dma-buf: cleanup kerneldoc of removed component

Hi Christian, On Wed, 1 Sept 2021 at 13:30, Christian König wrote: > > The seqno-fence was removed, cleanup the kerneldoc include as well. > > Signed-off-by: Christian König > Fixes: 992c238188a8 ("dma-buf: nuke seqno-fence") Thanks for fixing; LGTM, please feel free

Re: [PATCH] dma-buf: heaps: Set allocation limit for system heap

cation > > limits. > > > > Reviewed-by: John Stultz > > Thank you for taking a look John! Looks good to me; I will apply it to drm-misc today. > > Regards, > Hridya > > > > > thanks > > -john Best, Sumit. -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs

Re: [PATCH] dma-buf: heaps: Set allocation limit for system heap

or allocation > limits. > > > > Reviewed-by: John Stultz > > Thank you for taking a look John! > Looks good to me; I will apply it to drm-misc today. > > Regards, > Hridya > > > > > thanks > > -john > Best, Sumit. -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs

Re: [PATCH 4/7] dma-buf: Document DMA_BUF_IOCTL_SYNC

Signed-off-by: Jason Ekstrand > > Cc: Daniel Vetter > > Cc: Christian König > > Cc: Sumit Semwal > > We're still missing the doc for the SET_NAME ioctl, but maybe Sumit can be > motivated to fix that? > Yes, certainly, I'll cook up a patch and send

Re: [RFC][PATCH 2/2] dma-buf: heaps: Fix the name used when exporting dmabufs to be the actual heap name

ion with tooling, and there is > > > > the future potential where multiple heap types may be exported > > > > by the same module (but would all have the same name). > > > > > > > > So to avoid all this, set the exporter exp_name to the heap name. &g

Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

Hi Simon, On Thu, 28 Jan 2021 at 20:01, Simon Ser wrote: > > On Thursday, January 28th, 2021 at 1:03 PM, Sumit Semwal > wrote: > > > Since he didn't comment over Hridya's last clarification about the > > tracepoints to track total GPU memory allocations being orthogon

Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

On Thu, 28 Jan 2021 at 17:23, Christian König wrote: > > Am 28.01.21 um 12:00 schrieb Sumit Semwal: > > Hi Hridya, > > > > On Wed, 27 Jan 2021 at 17:36, Greg KH wrote: > >> On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote: > >>> This p

Re: [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

Hi Hridya, On Wed, 27 Jan 2021 at 17:36, Greg KH wrote: > > On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote: > > This patch allows statistics to be enabled for each DMA-BUF in > > sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. > > > > The following stats will be exposed

Re: [RESEND][PATCH 2/3] dma-buf: heaps: Add a WARN_ON should the vmap_cnt go negative

map count more than vmap count. Is there a specific need for this in the heaps? Best, Sumit. > > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya Valsaraju > Cc: Suren Baghdasaryan > Cc: Sandeep Patil > Cc: Daniel Mentz >

Re: [PATCH v4 1/2] dma-fence: allow signaling drivers to set fence timestamp

Hi Veera, On Wed, 20 Jan 2021 at 02:00, John Stultz wrote: > > On Fri, Jan 15, 2021 at 4:31 PM Veera Sundaram Sankaran > wrote: > > > > Some drivers have hardware capability to get the precise HW timestamp > > of certain events based on which the fences are triggered. The delta > > between the

Re: [RESEND][PATCH 3/3] dma-buf: heaps: Rework heep allocation hooks to return struct dma_buf instead of fd

handle creating the fd via > dma_buf_fd(). Thanks for the patch! LGTM, feels a lot neater now. I'll merge into drm-misc-next. > > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya Valsaraju > Cc: Suren Baghdasaryan > Cc: Sand

Re: [RESEND][PATCH 1/3] dma-buf: system_heap: Make sure to return an error if we abort

nto drm-misc-next. > > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya Valsaraju > Cc: Suren Baghdasaryan > Cc: Sandeep Patil > Cc: Daniel Mentz > Cc: Chris Goldsworthy > Cc: Ørjan Eide > Cc: Robin Murphy > Cc:

Re: [PATCH] dma-buf: cma_heap: Fix memory leak in CMA heap

ures the pagelist is also freed on release. Thanks for your patch. > > Cc: Bing Song > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya Valsaraju > Cc: Suren Baghdasaryan > Cc: Sandeep Patil > Cc: Daniel Mentz > Cc: Chr

Re: [Linaro-mm-sig] [PATCH] dmabuf: fix use-after-free of dmabuf's file->f_inode

Hi Charan, On Mon, 4 Jan 2021 at 17:22, Christian König wrote: > > Am 04.01.21 um 12:36 schrieb Charan Teja Reddy: > > It is observed 'use-after-free' on the dmabuf's file->f_inode with the > > race between closing the dmabuf file and reading the dmabuf's debug > > info. > > > > Consider the

Re: [PATCH] dma-buf: cma_heap: Include linux/vmalloc.h to fix build failures on MIPS

'cma_heap_do_vmap': > drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of > function 'vmap' Thanks for the patch; I've merged it to drm-misc-next-fixes. > > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya

Re: [PATCH v5 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

u, Nov 12, 2020 at 1:32 AM Daniel Vetter wrote: > > > > > On Thu, Nov 12, 2020 at 11:09:04AM +0530, Sumit Semwal wrote: > > > > > > On Tue, 10 Nov 2020 at 09:19, John Stultz > > > > > > wrote: > > > > > > > > > > > &

Re: [PATCH v5 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

> uncached heap allocations do result in *much* improved > performance on HiKey960 as it avoids a lot of flushing and > invalidating buffers that the cpu doesn't touch often. > > Feedback on these would be great! > > thanks > -john > > New in v5: > * Added a comment

Re: [PATCH v7 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

Hi Sam, On Thu, 15 Oct 2020 at 00:14, Sam Ravnborg wrote: > > Hi Sumit. > On Wed, Sep 02, 2020 at 12:14:06PM +0530, Sumit Semwal wrote: > > Novatek nt36672a is a display driver IC that can drive DSI panel. It > > is also present in the Tianma video mode panel,

Re: [PATCH -next] dma-buf: heaps: Remove unused variable ret

eturn "0" on line 215 > > > > Signed-off-by: Zou Wei > > Acked-by: Christian König > > Going to pick this up for drm-misc-next. Thanks Christian! Fwiw, feel free to add my Acked-by: Sumit Semwal > > > --- > > drivers/dma-buf/heaps/heap-helpers.c

Re: [PATCH v7 0/2]dd support for Tianma nt36672a video mode panel

Hi Sam / Theirry, On Wed, 2 Sep 2020 at 12:14, Sumit Semwal wrote: > > Some Poco F1 phones from Xiaomi have a FHD+ video mode panel based on the > Novatek NT36672A display controller; Add support for the same. This latest version (v7) had all the outstanding comments fixed, and Bjorn

Re: [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

Hi Thomas, On Fri, 18 Sep 2020 at 11:36, Sumit Semwal wrote: > > Hello Thomas, > > On Mon, 14 Sep 2020 at 16:55, Thomas Zimmermann wrote: > > > > Dma-buf provides vmap() and vunmap() for retrieving and releasing mappings > > of dma-buf memory in kernel addres

Re: [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

t dma_buf.vaddr_ptr > dma-buf: Use struct dma_buf_map in dma_buf_vmap() interfaces > dma-buf: Use struct dma_buf_map in dma_buf_vunmap() interfaces FWIW, for the series, please feel free to add my Acked-by: Sumit Semwal > > Documentation/driver-api/dma-buf.rst | 3 + > d

Re: [PATCH 08/29] dma-buf: Avoid comma separated statements

Hello Joe, On Wed, 26 Aug 2020 at 20:38, Christian König wrote: > > Am 25.08.20 um 06:56 schrieb Joe Perches: > > Use semicolons and braces. > > > > Signed-off-by: Joe Perches > > Acked-by: Christian König FWIW, Acked-by: Sumit Semwal > > > --- &

[PATCH v7 2/2] drm: panel: Add novatek nt36672a panel driver

Steini helped us fix the reset sequence timing (from 10ms to 20ms), to get the bootanimation to work on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2

[PATCH v7 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

added for this tianma fhd video mode panel. Signed-off-by: Sumit Semwal Reviewed-by: Rob Herring --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port'. v5: renamed to novatek,nt36672a, since the binding is for the IC

[PATCH v7 0/2]dd support for Tianma nt36672a video mode panel

less generic - updated the reset_gpio working to active_low - update MAINTAINERS for file name changes Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Novatek nt36672a drm: panel: Add novatek nt36672a panel driver .../display/panel/novatek,nt36672a.yaml | 87 +++

Re: [PATCH v5 2/2] drm: panel: Add novatek nt36672a panel driver

Hi Sam, On Sun, 30 Aug 2020 at 03:01, Sam Ravnborg wrote: > > Hi Sumit. > > On Wed, Aug 26, 2020 at 09:33:08PM +0530, Sumit Semwal wrote: > > Novatek NT36672a is a generic DSI IC that drives command and video mode > > panels. Add the driver for it. > > > > Ri

[PATCH v6 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

added for this tianma fhd video mode panel. Signed-off-by: Sumit Semwal Reviewed-by: Rob Herring --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port'. v5: renamed to novatek,nt36672a, since the binding is for the IC

[PATCH v6 2/2] drm: panel: Add novatek nt36672a panel driver

Steini helped us fix the reset sequence timing (from 10ms to 20ms), to get the bootanimation to work on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2

[PATCH v6 0/2] Add support for Tianma nt36672a video mode panel

rror printing to dev_err() - removed a few unnecessary bits Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Novatek nt36672a drm: panel: Add novatek nt36672a panel driver .../display/panel/novatek,nt36672a.yaml | 87 ++ MAINTAINERS

[PATCH v5 0/2] Add support for Tianma nt36672a video mode panel

ted changelog to add info about the generic Novatek DSI IC - corrected compatible string accordingly - removed pinctrl - used drm_panel* API for prepare/unprepare/disable/remove Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Novatek nt36672a drm: panel: Add nov

[PATCH v5 2/2] drm: panel: Add novatek nt36672a panel driver

Steini helped us fix the reset sequence timing (from 10ms to 20ms), to get the bootanimation to work on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2

[PATCH v5 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

added for this tianma fhd video mode panel. Signed-off-by: Sumit Semwal Reviewed-by: Rob Herring --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port'. v5: renamed to novatek,nt36672a, since the binding is for the IC

Re: [RESEND PATCH 1/2] dma-buf: Fix kerneldoc of dma_buf_set_name()

Hello Krzystof, On Wed, 19 Aug 2020 at 23:21, Krzysztof Kozlowski wrote: > > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/dma-buf/dma-buf.c:328: warning: Function parameter or member > 'dmabuf' not described in 'dma_buf_set_name' Thanks for the patch; I will apply it to

Re: [PATCH v4 2/2] drm: panel: Add tianma nt36672a panel driver

Hello Sam, Thanks very much for the review. On Fri, 14 Aug 2020 at 01:16, Sam Ravnborg wrote: > > Hi Sumit. > > On Tue, Aug 11, 2020 at 11:51:07PM +0530, Sumit Semwal wrote: > > Some Poco F1 phones have an LCD panel from Tianma, model nt36672a, > > with a resolution of

[PATCH v4 2/2] drm: panel: Add tianma nt36672a panel driver

on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2: increase reset sequence timing to a safe 200ms v4: Since "0425662fdf05: drm: Nuke mode->vrefresh&q

[PATCH v4 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal Reviewed-by: Rob Herring --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port

[PATCH v4 0/2] Add support for Tianma nt36672a video mode panel

with just port in panel@0 node. v4: Since "0425662fdf05: drm: Nuke mode->vrefresh", we have to calculate vrefresh on demand. Update for it. Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Tianma nt36672a panel drm: panel: Add tianma nt36672a panel driver .../

[RESEND PATCH v3 0/2] Add support for Tianma nt36672a video mode panel

with just port in panel@0 node. [1]: Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Tianma nt36672a panel drm: panel: Add tianma nt36672a panel driver .../display/panel/tianma,nt36672a.yaml| 95 ++ MAINTAINERS | 7 + drivers/gpu/drm

[RESEND PATCH v3 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal Reviewed-by: Rob Herring --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0

[RESEND PATCH v3 2/2] drm: panel: Add tianma nt36672a panel driver

on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2: increase reset sequence timing to a safe 200ms --- MAINTAINERS | 7

[PATCH v3 0/2] Add support for Tianma nt36672a video mode panel

with just port in panel@0 node. [1]: Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Tianma nt36672a panel drm: panel: Add tianma nt36672a panel driver .../display/panel/tianma,nt36672a.yaml| 95 ++ MAINTAINERS | 7 + drivers/gpu/drm

[PATCH v3 2/2] drm: panel: Add tianma nt36672a panel driver

on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2: increase reset sequence timing to a safe 200ms --- MAINTAINERS | 7

[PATCH v3 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

Hi Rob, Thanks for the review! On Thu, 23 Jul 2020 at 23:25, Rob Herring wrote: > > On Wed, Jul 22, 2020 at 11:28:15AM +0530, Sumit Semwal wrote: > > The nt36672a panel from Tianma is a FHD+ panel with a resolution of > > 1080x2246 > > and 6.18 inches size. It is foun

[PATCH v2 0/2] Add support for Tianma nt36672a video mode panel

is here [1] --- v2: In dt-binding, removed ports node, making port@0 directly under panel@0 node. Also updated the panel_on delay to a safer 200ms as needed for latest Android. Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Tianma nt36672a panel drm: panel: Add tianma

[PATCH v2 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal Change-Id: I401dfbfe23ff2d806c956002f45e349cb9688c16 --- v2: remove ports node, making port@0 directly under panel@0 node

[PATCH v2 2/2] drm: panel: Add tianma nt36672a panel driver

on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occassionally. Signed-off-by: Sumit Semwal Cc: Benni Steini Change-Id: Ib822ef12464abcb50d2e539d11b8983be87c31f2 --- v2: increase reset sequence timing to a safe 200ms

Re: [PATCH 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

Hello Rob, Thanks for the review! On Tue, 21 Jul 2020 at 09:03, Rob Herring wrote: > > On Thu, Jul 16, 2020 at 09:08:57PM +0530, Sumit Semwal wrote: > > The nt36672a panel from Tianma is a FHD+ panel with a resolution of > > 1080x2246 > > and 6.18 inches size. It is foun

[PATCH 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal --- .../display/panel/tianma,nt36672a.yaml| 110 ++ 1 file changed, 110 insertions(+) create mode

[PATCH 0/2] Add support for Tianma nt36672a video mode panel

is here [1] [1]: https://git.linaro.org/people/sumit.semwal/linux-dev.git/log/?h=dev/poco-panel-upstreaming Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Tianma nt36672a panel drm: panel: Add tianma nt36672a panel driver .../display/panel/tianma,nt36672a.yaml| 110

[PATCH 2/2] drm: panel: Add tianma nt36672a panel driver

on Android. Cc: Benni Steini Signed-off-by: Sumit Semwal --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-tianma-nt36672a.c | 859 ++ 4

Re: [PATCH] MAINTAINERS: Add myself as DMA-buf maintainer

Thanks for all the good work here, Christian! On Wed, 1 Jul 2020 at 17:20, Daniel Vetter wrote: > > On Wed, Jul 1, 2020 at 1:26 PM Christian König > wrote: > > > > As discussed on the list. > > > > Signed-off-by: Christian König > > Acked-by

Re: [PATCH] MAINTAINERS: Add myself as DMA-buf maintainer

Thanks for all the good work here, Christian! On Wed, 1 Jul 2020, 17:20 Daniel Vetter, wrote: > On Wed, Jul 1, 2020 at 1:26 PM Christian König > wrote: > > > > As discussed on the list. > > > > Signed-off-by: Christian König > > Acked-by: Dani

Re: [Intel-gfx] [PATCH 1/2] Revert "dma-buf: Report signaled links inside dma-fence-chain"

Hi Christian, On Fri, 26 Jun 2020, 18:10 Daniel Vetter, wrote: > On Fri, Jun 26, 2020 at 9:03 AM Christian König > wrote: > > > > Am 26.06.20 um 06:43 schrieb Sumit Semwal: > > > On Fri, 26 Jun 2020 at 01:24, Daniel Vetter wrote: > > >> Ignoring everyt

Re: [Intel-gfx] [PATCH 1/2] Revert "dma-buf: Report signaled links inside dma-fence-chain"

On Fri, 26 Jun 2020 at 01:24, Daniel Vetter wrote: > > Ignoring everything else ... > > On Thu, Jun 25, 2020 at 9:28 PM Jani Nikula > wrote: > > As a side note, there seem to be extra checks in place for acks when > > applying non-i915 patches to drm-intel; there are no such checks for > >

Re: [PATCH v2] dma-buf: Move dma_buf_release() from fops to dentry_ops

Hello Charan, On Tue, 16 Jun 2020 at 19:13, Charan Teja Kalla wrote: > > Thanks Sumit for the fix. > > On 6/11/2020 5:14 PM, Sumit Semwal wrote: > > Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which > > happens if the dma_buf_release() is ca

Re: [PATCH v2] dma-buf: Move dma_buf_release() from fops to dentry_ops

Hi Chris, On Tue, 16 Jun 2020 at 18:20, Chris Wilson wrote: > > Quoting Sumit Semwal (2020-06-16 13:42:13) > > Hello, > > > > If there are no objections to this, I will plan to merge it soon. > > I was going to suggest running it against our CI, but that

Re: [PATCH v2] dma-buf: Move dma_buf_release() from fops to dentry_ops

Hello, If there are no objections to this, I will plan to merge it soon. Daniel, Chris, Chenbo? On Thu, 11 Jun 2020 at 17:14, Sumit Semwal wrote: > > Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which > happens if the dma_buf_release() is called while the

Re: [PATCH] dmabuf: use spinlock to access dmabuf->name

Hi Daniel, Chris, On Thu, 11 Jun 2020 at 19:10, Charan Teja Kalla wrote: > > There exists a sleep-while-atomic bug while accessing the dmabuf->name > under mutex in the dmabuffs_dname(). This is caused from the SELinux > permissions checks on a process where it tries to validate the inherited >

[PATCH v2] dma-buf: Move dma_buf_release() from fops to dentry_ops

25 ("dma-buf: add DMA_BUF_SET_NAME ioctls") Reported-by: syzbot+3643a18836bce555b...@syzkaller.appspotmail.com Cc: [5.3+] Cc: Arnd Bergmann Reported-by: Charan Teja Reddy Reviewed-by: Arnd Bergmann Signed-off-by: Sumit Semwal --- v2: per Arnd: Moved dma_buf_release() above to avo

Re: [PATCH] dma-buf: Move dma_buf_release() from fops to dentry_ops

On Wed, 10 Jun 2020 at 14:57, Arnd Bergmann wrote: > > On Wed, Jun 10, 2020 at 10:33 AM Sumit Semwal wrote: > > > > Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which > > happens if the dma_buf_release() is called while the userspace is > > acc

[PATCH] dma-buf: Move dma_buf_release() from fops to dentry_ops

25 ("dma-buf: add DMA_BUF_SET_NAME ioctls") Reported-by: syzbot+3643a18836bce555b...@syzkaller.appspotmail.com Cc: [5.3+] Cc: Arnd Bergmann Reported-by: Charan Teja Reddy Signed-off-by: Sumit Semwal --- drivers/dma-buf/dma-buf.c | 13 +++-- 1 file changed, 7 insertions(+), 6 de

Re: [PATCH v3 1/4] dma-buf: add support for virtio exported objects

Hello David, On Fri, 15 May 2020 at 19:33, Daniel Vetter wrote: > > On Fri, May 15, 2020 at 02:07:06PM +0900, David Stevens wrote: > > On Thu, May 14, 2020 at 9:30 PM Daniel Vetter wrote: > > > On Thu, May 14, 2020 at 05:19:40PM +0900, David Stevens wrote: > > > > Sorry for the duplicate reply,

Re: [PATCH v2] dma-buf: fix use-after-free in dmabuffs_dname

On Wed, 13 May 2020 at 21:16, Daniel Vetter wrote: > > On Wed, May 13, 2020 at 02:51:12PM +0200, Greg KH wrote: > > On Wed, May 13, 2020 at 05:40:26PM +0530, Charan Teja Kalla wrote: > > > > > > Thank you Greg for the comments. > > > On 5/12/2020 2:22 PM, Greg KH wrote: > > > > On Fri, May 08,

Re: [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings

Hello Everyone, On Thu, 30 Apr 2020 at 10:07, Sam Ravnborg wrote: > > On Wed, Apr 29, 2020 at 11:27:22PM -0300, Vitor Massaru Iha wrote: > > On Wed, 2020-04-29 at 19:06 -0700, Randy Dunlap wrote: > > > On 4/29/20 6:59 PM, Vitor Massaru Iha wrote: > > > > Add missed ":" on kernel-doc function

Re: [PATCH] dma-buf: Fix SET_NAME ioctl uapi

Thanks Daniel, Martin, On Thu, 23 Apr 2020 at 20:21, Martin Liu wrote: > > On Thu, Apr 09, 2020 at 09:28:16AM +0530, Sumit Semwal wrote: > > Thanks for the patch, Daniel! > > > > > > On Tue, 7 Apr 2020 at 19:00, Daniel Vetter wrote: > > > >

Re: [PATCH -next] dma-buf: fix documentation build warnings

* @move_notify > > Signed-off-by: Randy Dunlap > Cc: Sumit Semwal > Cc: linux-me...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linaro-mm-...@lists.linaro.org > --- > drivers/dma-buf/dma-buf.c |4 ++-- > include/linux/dma-buf.h |3 +-- > 2 fi

Re: [PATCH] dma-buf: Fix SET_NAME ioctl uapi

; > Also, the type argument for the ioctl macros is for the type the void > __user *arg pointer points at, which in this case would be the > variable-sized char[] of a 0 terminated string. So this was botched in > more than just the usual ways. Yes, it shouldn't have passed through the cracks

  1   2   3   4   >