Re: [PATCH -next] dma-buf: fix documentation build warnings

* @move_notify > > Signed-off-by: Randy Dunlap > Cc: Sumit Semwal > Cc: linux-me...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linaro-mm-...@lists.linaro.org > --- > drivers/dma-buf/dma-buf.c |4 ++-- > include/linux/dma-buf.h |3 +-- > 2 fi

Re: [PATCH] dma-buf: Fix SET_NAME ioctl uapi

; > Also, the type argument for the ioctl macros is for the type the void > __user *arg pointer points at, which in this case would be the > variable-sized char[] of a 0 terminated string. So this was botched in > more than just the usual ways. Yes, it shouldn't have passed through the cracks

Re: [PATCH] dma-buf: support 32bit DMA_BUF_SET_NAME ioctl

gt; > static const struct file_operations dma_buf_fops = { > > .release= dma_buf_release, > > .mmap = dma_buf_mmap_internal, > > .llseek = dma_buf_llseek, > > .poll = dma_buf_poll, > > .unlocked_ioctl = dma

Re: [PATCH 1/6] dma-buf: add peer2peer flag

ned-off-by: Christian König > > On the series: > > Acked-by: Daniel Vetter > Fwiw, for the series, Acked-by: Sumit Semwal > --- > > drivers/dma-buf/dma-buf.c | 2 ++ > > include/linux/dma-buf.h | 10 ++ > > 2 files changed, 12 insertions(+) > > &

Re: [PATCH] MAINTAINERS: Better regex for dma_buf|fence|resv

. > > Cc: linux-me...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linaro-mm-...@lists.linaro.org > Cc: Joe Perches > Cc: Sumit Semwal > Cc: Sam Ravnborg > Signed-off-by: Daniel Vetter Acked-by: Sumit Semwal > --- > v2: No single quotes in MAINTAI

Re: + dma-buf-free-dmabuf-name-in-dma_buf_release.patch added to -mm tree

MA_BUF_SET_NAME ioctls") > Reported-by: syzbot+b2098bc44728a4efb...@syzkaller.appspotmail.com > Signed-off-by: Cong Wang > Reviewed-by: Andrew Morton > Acked-by: Chenbo Feng > Cc: Sumit Semwal > Cc: Greg Hackmann > Signed-off-by: Andrew Morton > --- > > drive

[PATCH] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static

From: zhong jiang Fix the following sparse warning. drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static? Acked-by: Andrew F. Davis Acked-by: John Stultz Signed-off-by: zhong jiang Signed-off-by: Sumit Semwal [sumits: rebased over

Re: [PATCH v2] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static

Hello Zhong Jiang, On Tue, 17 Dec 2019 at 07:56, zhong jiang wrote: > > On 2019/12/17 5:13, John Stultz wrote: > > On Mon, Dec 16, 2019 at 5:43 AM zhong jiang wrote: > >> Fix the following sparse warning. Thanks for the patch; could I request you to please use scripts/get_maintainer.pl to get

Re: [PATCH 00/15] Retire dma_buf_k(un)map

red. > > So since it was never used, and this idea's time is clearly over, let's > remove it all. As always, thanks for helping keep this code sane :) Fwiw, for the series, please feel free to add my Acked-by: Sumit Semwal > > Only real change I had to do (aside from deleting

Re: [PATCH v13 0/5] DMA-BUF Heaps (destaging ION)

On Fri, 25 Oct 2019 at 11:26, Sumit Semwal wrote: > > Hi John, > > On Tue, 22 Oct 2019 at 00:33, John Stultz wrote: > > > > Lucky number 13! :) > > > > Last week in v12 I had re-added some symbol exports to support > > later patches I have pending to

Re: [PATCH v13 0/5] DMA-BUF Heaps (destaging ION)

Hi John, On Tue, 22 Oct 2019 at 00:33, John Stultz wrote: > > Lucky number 13! :) > > Last week in v12 I had re-added some symbol exports to support > later patches I have pending to enable loading heaps from > modules. He reminded me that back around v3 (its been awhile!) I > had removed those

Re: [PATCH v12 0/5] DMA-BUF Heaps (destaging ION)

Hi John, Andrews, On Fri, 18 Oct 2019 at 10:53, John Stultz wrote: > > Andrew brought up a reasonable concern with the CMA heap > enumeration in the previous patch set, and I had a few other > minor cleanups to add, so here is yet another pass at the > dma-buf heaps patchset Andrew and I have

Re: [RESEND][PATCH v8 0/5] DMA-BUF Heaps (destaging ION)

o fix build issue on x86 > * Checkpatch whitespace fixups > > Thoughts and feedback would be greatly appreciated! > > thanks > -john Best, Sumit. > > Cc: Laura Abbott > Cc: Benjamin Gaignard > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Pratik Patel > Cc: Br

Re: [PATCH] dma-buf: rename reservation_object to dma_resv

hanks for doing this! Acked-by: Sumit Semwal > > Letting the compiler do the real work (for the bits I spot checked it > was the expected mechanical translation), and overwhelmingly agreeing with > the motivation, > Reviewed-by: Chris Wilson > -Chris > Best, Sumit. _

Re: [PATCH v5 0/3] Improve the dma-buf tracking

Hi Chenbo, On Fri, 14 Jun 2019 at 04:04, Chenbo Feng wrote: > > Currently, all dma-bufs share the same anonymous inode. While we can count > how many dma-buf fds or mappings a process has, we can't get the size of > the backing buffers or tell if two entries point to the same dma-buf. And > in

Re: [RESEND PATCH v3 2/3] dma-buf: add DMA_BUF_{GET,SET}_NAME ioctls

Hello Chenbo, Thanks very much for your patches. Other than a couple tiny nits below, I think these look good, and I will merge them before the end of this week. On Tue, 11 Jun 2019 at 05:32, Chenbo Feng wrote: > > From: Greg Hackmann > > This patch adds complimentary DMA_BUF_SET_NAME and

Re: [PATCH 01/12] dma-buf: add dynamic caching of sg_table

Hi Christian, On Sat, 27 Apr 2019 at 05:31, Liam Mark wrote: > > On Tue, 16 Apr 2019, Christian König wrote: > > > To allow a smooth transition from pinning buffer objects to dynamic > > invalidation we first start to cache the sg_table for an attachment > > unless the driver explicitly says to

Re: [PATCH] dma-buf: Make mmap callback actually optional

Hi Andrew, On Mon, 1 Apr 2019 at 20:38, Christian König wrote: > > Am 29.03.19 um 17:52 schrieb Andrew F. Davis: > > The docs state the callback is optional but it is not, make it optional. > > > > Signed-off-by: Andrew F. Davis > > Reviewed-by: Christian König Thanks for the patch; I will

Re: [RFC dma-buf 0/3] Improve the dma-buf tracking

Hi Daniel, On Fri, 15 Mar 2019 at 16:36, Daniel Vetter wrote: > > On Thu, Mar 14, 2019 at 6:49 PM Sumit Semwal wrote: > > > > Hello Chenbo,Thank you for your RFC series. > > > > On Wed, 27 Feb 2019 at 09:24, Chenbo Feng wrote: > > > > > > Curren

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

On Sat, 16 Mar 2019 at 04:15, Laura Abbott wrote: > > On 3/15/19 2:29 PM, John Stultz wrote: > > On Fri, Mar 15, 2019 at 1:18 PM Laura Abbott wrote: > >> > >> On 3/5/19 12:54 PM, John Stultz wrote: > >>> +DMA-BUF HEAPS FRAMEWORK > >>> +M: Laura Abbott > >>> +R: Liam Mark > >>> +R: Brian

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

On Sat, 16 Mar 2019 at 04:15, Laura Abbott wrote: > On 3/15/19 2:29 PM, John Stultz wrote: > > On Fri, Mar 15, 2019 at 1:18 PM Laura Abbott wrote: > >> > >> On 3/5/19 12:54 PM, John Stultz wrote: > >>> +DMA-BUF HEAPS FRAMEWORK > >>> +M: Laura Abbott > >>> +R: Liam Mark > >>> +R: Brian

Re: [RFC dma-buf 0/3] Improve the dma-buf tracking

Hello Chenbo,Thank you for your RFC series. On Wed, 27 Feb 2019 at 09:24, Chenbo Feng wrote: > > Currently, all dma-bufs share the same anonymous inode. While we can count > how many dma-buf fds or mappings a process has, we can't get the size of > the backing buffers or tell if two entries

Re: [EARLY RFC][PATCH] dma-buf: Add dma-buf heaps framework

On Mon, 25 Feb 2019 at 20:06, Andrew F. Davis wrote: > > This framework allows a unified userspace interface for dma-buf > exporters, allowing userland to allocate specific types of memory > for use in dma-buf sharing. > > Each heap is given its own device node, which a user can allocate > a

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

Hello everyone, (Thanks to Dan for letting me know my last email got corrupted :/ - resending it here) Sincere apologies for chiming in a bit late here, but was off due to some health issues. Also, adding Daniel Vetter to the mix, since he has been one of the core guys who shaped up dma-buf as

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

Hello everyone, Sincere apologies for chiming in a bit late here, but was off due to some health issues. Also, adding Daniel Vetter to the mix, since he has been one of the core guys who shaped up dma-buf as it is today. On Tue, 22 Jan 2019 at 02:51, Andrew F. Davis wrote: On 1/21/19 5:22

Re: [PATCH 2/5] dma-buf: remove kmap_atomic interface

was out of office for some time) - this looks ok to me, please feel free to add my Acked-by: Sumit Semwal > >> --- > >> drivers/dma-buf/dma-buf.c | 44 > >> -- > >> drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c

Re: [PATCH] dma-buf: Fix ifnullfree.cocci warnings

if (dma_buf_debugfs_dir) > - debugfs_remove_recursive(dma_buf_debugfs_dir); > + debugfs_remove_recursive(dma_buf_debugfs_dir); > } > #else > static inline int dma_buf_init_debugfs(void) > -- > 1.9.1 > -- Thanks and regards, Sumit

Re: [PATCH 0/4] dma-buf: Silence dma_fence __rcu sparse warnings

e I annotated all >> the accesses correctly. But I figured someone will scream at me if >> I got it wrong ;) >> >> Cc: Dave Airlie <airl...@redhat.com> >> Cc: Jason Ekstrand <ja...@jlekstrand.net> >> Cc: linaro-mm-...@lists.linaro.org >> Cc: linux-

Re: [PATCH 1/2] dma-buf: keep only not signaled fence in reservation_object_add_shared_replace v2

Hi Christian, On 30 October 2017 at 20:29, Christian König wrote: > From: Christian König > > The amdgpu issue to also need signaled fences in the reservation objects > should be fixed by now. > > Optimize the list by keeping only the

Re: tracing, dma-buf: Remove unused trace event dma_fence_annotate_wait_on

rights to drm-misc I assume you'll push this too. >> > > Will it cause conflict if I pull it through my tree? It's just removing > unused traecpoints. I added it to my tree already (but haven't pushed > it to linux-next yet), with th

Re: [PATCH 0/3] dma-buf changes for ttm and amdgpu

t;> (dma-buf doesn't exist anymore, all the dma-buf stuff is in drm-misc now). >> And you have commit rights for that even :-) > > Yeah, I just didn't want to step on Sumit's toes in case he preferred to > handle dma-buf patches himself. > Apologies for missing your ping! Plea

Re: [PATCH] dma-buf/sync_file: document flags field

Hi Gustavo, On 1 August 2017 at 01:06, Gustavo Padovan <gust...@padovan.org> wrote: > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > Documentation for it was missing. > > Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Acked-by: Sumi

Re: [PATCH 0/3] staging: android: ion: Minor clean ups and fixes

neja (3): > staging: android: ion: Remove unused members from ion_buffer > staging: android: ion: Remove ION_FLAG_CACHED_NEEDS_SYNC > staging: android: ion: Avoid calling free_duped_table() twice > Thanks for these patches! Please feel free to add my Reviewed-by: Sumit Semwal <

Re: [PATCHv2] drm/prime: Forward declare struct device

labb...@redhat.com> Thanks for the patch; feel free to add my Reviewed-by: Sumit Semwal <sumit.sem...@linaro.org> > --- > v2: Switch to foward declaration instead of including a header. > --- > include/drm/drm_prime.h | 2 ++ > 1 file changed, 2 insertions(+) > &g

Re: [PATCH 0/4] DMA-buf: Fine-tuning for four function implementations

Hello Markus, On 8 May 2017 at 14:40, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 8 May 2017 11:05:05 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring

Re: [PATCH 0/4] DMA-buf: Fine-tuning for four function implementations

Hi Markus, On May 8, 2017 14:40, "SF Markus Elfring" wrote: From: Markus Elfring Date: Mon, 8 May 2017 11:05:05 +0200 A few update suggestions were taken into account from static source code analysis. Thanks much for your patches;

Re: [PATCHv4 00/12] Ion cleanup in preparation for moving out of staging

with the CMA APIs so this is a new version to address that. I also > addressed some minor comments on the patch to collapse header files. For the series, please feel free to apply my Acked-by: Sumit Semwal <sumit.sem...@linaro.org> > > Thanks, > Laura > > Laura Abbott (12): >

Re: [PULL] drm-misc-next-fixes

On 21 April 2017 at 03:20, Daniel Vetter wrote: >> - Rename dma_buf_ops->kmap_* to avoid naming collision (Logan) > > This one touches v4l and ion and is acked by the corresponding > maintainers (but Sumit forgot to record that when applying the patch, > and Sean didn't

Re: [Intel-gfx] [PATCH v2] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

>>> diff --git a/drivers/staging/android/ion/ion.c >>> b/drivers/staging/android/ion/ion.c >>> index f45115f..95a7f16 100644 >>> --- a/drivers/staging/android/ion/ion.c >>> +++ b/drivers/staging/android/ion/ion.c >>> @@ -1020,10 +1020,10 @@ static const struct dma_buf_ops dma_b

Re: [Intel-gfx] [PATCH v2] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

om> >> Reviewed-by: Sinclair Yeh <s...@vmware.com> > > Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> Acked-by: Sumit Semwal <sumit.sem...@linaro.org> > > Probably simplest if we pull this in through the drm-misc tree for 4.12. > Can we have an ack fo

Re: [PATCH libdrm] Header: Add rotation property fields

> > Signed-off-by: Robert Foss <robert.f...@collabora.com> Thanks for the patch; fwiw, please feel free to add Reviewed-by: Sumit Semwal <sumit.sem...@linaro.org> > --- > include/drm/drm.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/include/drm/drm.h b/in

Re: [PATCH 1/7] sync_file: get rid of internal reference count.

;> drivers/dma-buf/sync_file.c | 13 ++--- >> include/linux/sync_file.h | 3 --- >> 2 files changed, 2 insertions(+), 14 deletions(-) > > Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.com> Acked-by: Sumit Semwal <sumit.sem...@linaro.org> >

Re: [Intel-gfx] [PATCH] drm: Document code of conduct

Hi Daniel, On 11 April 2017 at 13:03, Sumit Semwal <sumit.sem...@linaro.org> wrote: > On 11 April 2017 at 12:38, Daniel Stone <dan...@fooishbar.org> wrote: >> Hi, >> >> On 11 April 2017 at 07:48, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: >>> Not

Re: [Intel-gfx] [PATCH] drm: Document code of conduct

his involves the board and lots more >> people it'll take a while to get there. For now this is good enough I >> think. > > All true. > > Reviewed-by: Daniel Stone <dani...@collabora.com> > Thanks for this, Daniel! Reviewed-by: Sumit Semwal <sumit.sem...@lina

Re: [PATCH] dma-buf: align debugfs output

Hi Russell, On 31 March 2017 at 15:33, Russell King wrote: > Align the heading with the values output from debugfs. > > Signed-off-by: Russell King Thanks for your patch; applied to drm-misc-next. > --- > drivers/dma-buf/dma-buf.c | 3

Re: [PATCH v2 2/4] drm/etnaviv: submit support for in-fences

yet, so we have to extend the structure and trust that > drm_ioctl will clear the flags for us if an older userspace only submits > part of the struct. > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Please feel free to add my Reviewed-by: Sumit Semwal <sumit.sem...@linaro

Re: [PATCH v2 1/4] dma-fence: add dma_fence_match_context helper

igned-off-by: Philipp Zabel <p.za...@pengutronix.de> > --- Looks good to me, please feel free to add my Acked-by: Sumit Semwal <sumit.sem...@linaro.org> > drivers/dma-buf/dma-fence-array.c | 26 ++ > include/linux/dma-fence-array.h | 2 ++ > 2 f

Re: [RFC PATCH 08/12] cma: Store a name in the cma structure

Hi Laura, Thanks for the patch. On 3 March 2017 at 03:14, Laura Abbott wrote: > > Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it > useful to have an explicit name attached to each region. Store the name > in each CMA structure. > > Signed-off-by:

Re: [PATCH] dma-buf: add support for compat ioctl

rly an obvious screw-up in creating this api on our side :( So > feel free to smash my ack on the patch. > Daniel, Christian, I saw this just now, so if Christian hasn't already pulled it into drm-misc-next-fixes, I'll give it a stab. > Thanks, Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel Best, Sumit. -- Thanks and regards, Sumit Semwal Linaro Mobile Group - Kernel Team Lead Linaro.org │ Open source software for ARM SoCs ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dma-buf/dma-fence: improve doc for dma_fence_add_callback()

Hi Gustavo, On 16 February 2017 at 02:27, Chris Wilson wrote: > On Wed, Feb 15, 2017 at 03:57:25PM -0200, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Document return values for this function. >> >> Signed-off-by: Gustavo

Re: [PATCH] uapi: add missing install of dma-buf.h

ma-buf.h was added, but an > entry was not added on Kbuild to install it. This patch resolves this omission > so that "make headers_install" installs this header. > Thanks for the patch; please feel free to add my Acked-by: Sumit Semwal <sumit.sem...@linaro.org> > Signe

Re: [PATCH] uapi: add missing install of dma-buf.h

dma-buf.h was added, but > an > entry was not added on Kbuild to install it. This patch resolves this > omission > so that "make headers_install" installs this header. > > Thanks for the patch; please feel free to add my Acked-by: Sumit Semwal <sumit.sem...@linaro

Re: [PATCH] MAINTAINERS: add dma-fence* files to Sync File maintainership

a-fence* tracks it > > under SYNC FILE_FRAMEWORK as well. > > > > Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> > > Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> > > Of course, feel free to add my Acked-by: Sumit Semwal <sumit.s

Re: [PATCH] dma/fence: Export enable-signaling tracepoint for emission by drivers

to manually perform the hw enabling of the >> signaling and would like to emit this tracepoint for completeness. >> >> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> >> Cc: Sumit Semwal <sumit.sem...@linaro.org> >> Cc: Daniel Vetter <daniel.vet...@ffwll

[PATCH 3/3] dma-fence: Introduce drm_fence_set_error() helper

Hi Chris, On 4 January 2017 at 19:42, Chris Wilson wrote: > The dma_fence.error field (formerly known as dma_fence.status) is an > optional field that may be set by drivers before calling > dma_fence_signal(). The field can be used to indicate that the fence was > completed in err rather than

[PATCH 1/3] dma-fence: Clear fence->status during dma_fence_init()

pretty. On the series: > > Reviewed-by: Daniel Vetter > FWIW, please feel free, for this series, to apply my Reviewed-by: Sumit Semwal > I'll defer to Gustavo for another pass over it and merging it to drm-misc. > -Daniel > Best, Sumit. >> --- >> drivers/dma-buf/dma

[PATCH 0/5] sphinxification for dma-buf docs

Thanks Jonathan! On 12 December 2016 at 01:14, Jonathan Corbet wrote: > On Sun, 11 Dec 2016 18:35:42 +0100 > Daniel Vetter wrote: > >> > Here's a thought, though: how about if we slip in a little version of >> > dma-buf.rst now with a "coming soon, don't miss it!!" message? Then the >> > rest

[PATCH] staging/android: remove Sync Framework tasks from TODO

WIW, please feel free to add my Acked-by: Sumit Semwal to it. > --- > drivers/staging/android/TODO | 8 > 1 file changed, 8 deletions(-) > > diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO > index 64d8c87..8f3ac37 100644 > --- a/drivers/st

[PATCH 0/5] sphinxification for dma-buf docs

plicit vs. explicit fencing >> and how it's all supposed to work. >> Thanks for the patch series; I had something in the works too, but you beat me to it! :) Looks good to me, so please feel free to add my Acked-by: Sumit Semwal to the series. >> But just cleanup in the dma-b

[PATCH 2/3] MAINTAINERS: Move dma-buf to drm-misc git

f course, this is to help the current rapid development that is closely inter-related to drm changes. > Cc: Sumit Semwal > Cc: Gustavo Padovan > Signed-off-by: Daniel Vetter Acked-by: Sumit Semwal > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 1/4] dma-buf/fence: make timeout handling in fence_default_wait consistent (v2)

Hi Alex, Christian, On 8 November 2016 at 02:46, Alex Deucher wrote: > Kernel functions taking a timeout usually return 1 on success even > when they get a zero timeout. > > v2: agd: rebase on drm-next > > Reviewed-by: Alex Deucher > Signen-off-by: Christian König > Reviewed-by: Chunming Zhou

[PATCH 1/2] dma-buf: return index of the first signaled fence (v2)

Hi Alex, Christian, On 8 November 2016 at 04:12, Sumit Semwal wrote: > Hi Alex, > > On 07-Nov-2016 11:14 PM, "Alex Deucher" wrote: >> >> On Fri, Nov 4, 2016 at 6:03 PM, Sumit Semwal >> wrote: >> > Hi Alex, >> > >> > Thanks for

[PATCH] MAINTAINERS: update Sync File Framework files

drivers/dma-buf/sync_* > +F: drivers/dma-buf/sw_sync.c > F: include/linux/sync_file.h > +F: include/uapi/linux/sync_file.h > F: Documentation/sync_file.txt > T: git git://git.linaro.org/people/sumitsemwal/linux-dma-buf.git > > -- > 2.5.5 > -- Thank

[PATCH] dma-buf/sw_sync: put fence reference from the fence creation

On 27 October 2016 at 03:24, Chris Wilson wrote: > On Wed, Oct 26, 2016 at 06:59:59PM -0200, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Once sw_sync_ioctl_create_fence() returns we no longer have the >> *pt pointer to the fence base object thus we need to put the reference >> we have

[PATCH 1/2] dma-buf: return index of the first signaled fence (v2)

Hi Alex, On 07-Nov-2016 11:14 PM, "Alex Deucher" wrote: > > On Fri, Nov 4, 2016 at 6:03 PM, Sumit Semwal wrote: > > Hi Alex, > > > > Thanks for the patches. > > > > On 4 November 2016 at 14:16, Alex Deucher wrote: > >> From: "monk.

[PATCH 1/2] dma-buf: return index of the first signaled fence (v2)

gt; Signed-off-by: monk.liu > Signed-off-by: Alex Deucher > Cc: Sumit Semwal > --- > > This is the same patch set I send out yesterday, I just > squashed the amdgpu patches together and rebased everything on > the fence -> dma_fence renaming. This is used by our VK driver

[PATCH 1/3] dma-buf: return index of the first signaled fence

gned-off-by: Alex Deucher > Cc: Sumit Semwal > --- > drivers/dma-buf/fence.c | 19 ++- > include/linux/fence.h | 2 +- > 2 files changed, 15 insertions(+), 6 deletions(-) > > diff --git a/drivers/dma-buf/fence.c b/drivers/dma-buf/fence.c > index 64478f9.

[PATCH 2/3] drm/amdgpu: add the interface of waiting multiple fences (v3)

On 4 November 2016 at 11:14, Sumit Semwal wrote: > Hi Alex, > > Thanks for the patch! > > On 3 November 2016 at 11:41, Alex Deucher wrote: >> From: Junwei Zhang >> >> v2: agd: rebase and squash in all the previous optimizations and >> changes so everyt

[PATCH 2/3] drm/amdgpu: add the interface of waiting multiple fences (v3)

Hi Alex, Thanks for the patch! On 3 November 2016 at 11:41, Alex Deucher wrote: > From: Junwei Zhang > > v2: agd: rebase and squash in all the previous optimizations and > changes so everything compiles. > v3: squash in Slava's 32bit build fix > > Signed-off-by: Junwei Zhang > Reviewed-by:

Fixing zero timeout handling for fence functions

Hi Christian, On 25 October 2016 at 17:55, Christian König wrote: > Hi Sumit, > > sending this once more with all the patches in once set, cause the last one > turned out to be a bit chaotic because I send from the wrong branch. > > The following patch set fixes the handling in the fence and

[PATCH] dma-buf: Rename struct fence to dma_fence

ully it >> ( >> ... >> ) >> >> Signed-off-by: Chris Wilson Acked-by: Sumit Semwal Daniel, As we agreed, we should perhaps take it via the drm tree? > > Reviewed-by: Gustavo Padovan > > Gustavo > Best regards, Sumit.

[PATCH 02/11] drm/etnaviv: Remove manual call to reservation_object_test_signaled_rcu before wait

Hi Lucas, On 23 September 2016 at 18:25, Daniel Vetter wrote: > On Mon, Aug 29, 2016 at 08:08:25AM +0100, Chris Wilson wrote: >> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a >> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not >> need to handle such

[Intel-gfx] [PATCH 05/11] drm/vmwgfx: Remove call to reservation_object_test_signaled_rcu before wait

Hi Thomas, Sinclair, On 23 September 2016 at 18:26, Daniel Vetter wrote: > On Mon, Aug 29, 2016 at 08:08:28AM +0100, Chris Wilson wrote: >> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a >> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not >> need to

[Intel-gfx] [PATCH 04/11] drm/nouveau: Remove call to reservation_object_test_signaled_rcu before wait

Hi Ben, On 23 September 2016 at 18:25, Daniel Vetter wrote: > On Mon, Aug 29, 2016 at 08:08:27AM +0100, Chris Wilson wrote: >> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a >> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not >> need to handle such

[PATCH 01/11] drm/amdgpu: Remove call to reservation_object_test_signaled_rcu before wait

Hi Alex, On 23 September 2016 at 18:24, Daniel Vetter wrote: > On Mon, Aug 29, 2016 at 08:08:24AM +0100, Chris Wilson wrote: >> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a >> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not >> need to handle such

[PATCH v3] dma-buf/sync_file: Increment refcount of fence when all are signaled.

Hi Rafael, On 16 September 2016 at 00:44, Rafael Antognolli wrote: > When we merge several fences, if all of them are signaled already, we > still keep one of them. So instead of using add_fence(), which will not > increase the refcount of signaled fences, we should explicitly call > fence_get()

[PATCH] dma-buf/sync_file: fix documentation error

Hi Emilio, On 19 September 2016 at 17:40, Gustavo Padovan wrote: > Hi Emilio, > > 2016-09-19 Emilio López : > >> The ioctl name and description on the documentation block don't >> match the ioctl being defined. This was probably overlooked while >> renaming the ioctls during the sync file

[PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

>> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks for finding this. Thanks for the patch; this doesn't apply to mainline yet, since the de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. CC'ing him. Greg, would it be possible to please take this via your tree? > > Reviewed-by: Gustavo Padovan > Acked-by: Sumit Semwal > Gustavo > Best regards, Sumi

[PATCH] dma-buf/sync-file: Avoid enable fence signaling if poll(.timeout=0)

only install the callback once, the overhead comes from the atomic >> bit test that also causes serialisation between threads. >> >> Signed-off-by: Chris Wilson >> Cc: Sumit Semwal >> Cc: Gustavo Padovan >> Cc: linux-media at vger.kernel.org >> Cc: dri

[PATCH v2 2/2] Documentation/sphinx: link dma-buf rsts

Hi Jon, On 23 August 2016 at 18:38, Jonathan Corbet wrote: > On Tue, 23 Aug 2016 08:01:35 +0200 > Daniel Vetter wrote: > >> I'm also not too sure about whether dma-buf really should be it's own >> subdirectory. It's plucked from the device-drivers.tmpl, I think an >> overall device-drivers/ for

[PATCH v2 2/2] Documentation/sphinx: link dma-buf rsts

Include dma-buf sphinx documentation into top level index. Signed-off-by: Sumit Semwal --- Documentation/index.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/index.rst b/Documentation/index.rst index e0fc72963e87..8d05070122c2 100644 --- a/Documentation/index.rst +++ b

[PATCH v2 1/2] Documentation: move dma-buf documentation to rst

comments from Jonathan Corbet and Markus Heiser. Signed-off-by: Sumit Semwal --- Documentation/DocBook/device-drivers.tmpl | 41 --- Documentation/dma-buf-sharing.txt | 482 Documentation/dma-buf/guide.rst | 507

[PATCH v2 0/2] doc: dma-buf: sphinx conversion

Convert dma-buf documentation over to sphinx. While at that, convert dma-buf-sharing.txt as well, and make it the dma-buf API guide. There is no content change yet; only format conversion and creation of some hyperlinks. v2: Address review comments from Jonathan Corbet and Markus Heiser. Sumit

[PATCH] dma-buf: fix kernel-doc warning and typos

rning: No description found for > parameter 'signal_on_any' > > Signed-off-by: Randy Dunlap > Cc: Sumit Semwal > Cc: linux-media at vger.kernel.org > Cc: dri-devel at lists.freedesktop.org > Cc: linaro-mm-sig at lists.linaro.org > --- > drivers/dma-buf/

[RFC 0/4] doc: dma-buf: sphinx conversion and cleanup

Hi Jon! On 11 August 2016 at 20:06, Jonathan Corbet wrote: > On Thu, 11 Aug 2016 16:17:56 +0530 > Sumit Semwal wrote: > >> Convert dma-buf documentation over to sphinx; also cleanup to >> address sphinx warnings. >> >> While at that, convert dma-buf-sharing.tx

[PATCH 3/5] drm/msm: Remove call to reservation_object_test_signaled_rcu before wait

Hi Chris, On 11 August 2016 at 20:16, Chris Wilson wrote: > Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a > timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not > need to handle such conversion in the caller. The only challenge are > those callers that

[RFC 3/4] Documentation: move dma-buf documentation to rst

: > http://www.sphinx-doc.org/en/stable/markup/index.html > * Sphinx domains: http://www.sphinx-doc.org/en/stable/domains.html > * Sphinx cross references: > http://www.sphinx-doc.org/en/stable/markup/inline.html#cross-referencing-arbitrary-locations > > Am 11.08.2016 um 12:47 sch

[RFC 3/4] Documentation: move dma-buf documentation to rst

Hello Jani, On 11 August 2016 at 17:17, Jani Nikula wrote: > On Thu, 11 Aug 2016, Sumit Semwal wrote: >> diff --git a/Documentation/dma-buf/guide.rst >> b/Documentation/dma-buf/guide.rst >> new file mode 100644 >> index ..fd3534fdccb3 >> --- /dev/nu

[RFC 4/4] Documentation/sphinx: link dma-buf rsts

Include dma-buf sphinx documentation into top level index. Signed-off-by: Sumit Semwal --- Documentation/index.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/index.rst b/Documentation/index.rst index 43c722f15292..2fe8e82d7d8c 100644 --- a/Documentation/index.rst +++ b

[RFC 3/4] Documentation: move dma-buf documentation to rst

Branch out dma-buf related documentation into its own rst file to allow adding it to the sphinx documentation generated. While at it, move dma-buf-sharing.txt into rst as the dma-buf guide too. Signed-off-by: Sumit Semwal --- Documentation/DocBook/device-drivers.tmpl | 37 --- Documentation

[RFC 2/4] dma-buf/fence: kerneldoc: remove spurious section header

Commit e941759c74a44d6ac2eed21bb0a38b21fe4559e2 ("fence: dma-buf cross-device synchronization (v18)") had a spurious kerneldoc section header that caused Sphinx to complain. Fix it. Fixes: e941759c74a4 ("fence: dma-buf cross-device synchronization (v18)") Signed-

[RFC 1/4] dma-buf/fence: kerneldoc: remove unused struct members

Commit 0431b9065f28ecf6c320fefebe0241620049984f ("staging/android: bring struct sync_pt back") removed child_list and active_list from struct fence, but left it in kernel doc. Delete them. Fixes: 0431b9065f28 ("staging/android: bring struct sync_pt back") Signed-

[RFC 0/4] doc: dma-buf: sphinx conversion and cleanup

Convert dma-buf documentation over to sphinx; also cleanup to address sphinx warnings. While at that, convert dma-buf-sharing.txt as well, and make it the dma-buf API guide. There is no content change yet; only format conversion and creation of some hyperlinks. Sumit Semwal (4): dma-buf/fence

[RFC 0/4] doc: dma-buf: sphinx conversion and cleanup

Convert dma-buf documentation over to sphinx; also cleanup to address sphinx warnings. While at that, convert dma-buf-sharing.txt as well, and make it the dma-buf API guide. There is no content change yet; only format conversion and creation of some hyperlinks. Sumit Semwal (4): dma-buf/fence

[PATCH v4 2/5] dma-buf/sync_file: refactor fence storage in struct sync_file

Hi Greg, On 19 July 2016 at 17:51, Sumit Semwal wrote: > (Adding Greg KH) > > Hi Greg, > > On 19 July 2016 at 17:45, Sumit Semwal wrote: >> Hi Greg, >> >> >> On 12 July 2016 at 23:38, Gustavo Padovan wrote: >>> From: Gustavo Padovan >

[PATCH v4 2/5] dma-buf/sync_file: refactor fence storage in struct sync_file

(Adding Greg KH) Hi Greg, On 19 July 2016 at 17:45, Sumit Semwal wrote: > Hi Greg, > > > On 12 July 2016 at 23:38, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Create sync_file->fence to abstract the type of fence we are using for >> each syn

[PATCH v4 2/5] dma-buf/sync_file: refactor fence storage in struct sync_file

FIG_DEBUG_FS > struct list_headsync_file_list; > #endif > - int num_fences; > > wait_queue_head_t wq; > - atomic_tstatus; > > - struct sync_file_cb cbs[]; > + struct fence*fence; > + struct fence_cb cb; > }; > > struct sync_file *sync_file_create(struct fence *fence); > -- > 2.5.5 > BR, ~Sumit. -- Thanks and regards, Sumit Semwal Linaro Mobile Group - Kernel Team Lead Linaro.org │ Open source software for ARM SoCs

[PATCH] dma-buf: Release module reference on creation failure

Signed-off-by: Chris Wilson >> Reviewed-by: Joonas Lahtinen >> Cc: Joonas Lahtinen >> Cc: Sumit Semwal >> Cc: Daniel Vetter >> Cc: linux-media at vger.kernel.org >> Cc: dri-devel at lists.freedesktop.org >> Cc: linaro-mm-sig at lists.linaro.org >> --

[RFC] dma-buf: Rename struct fence to dma_fence

>> - * ops is used in fence_init for get_driver_name, so needs to be >> + * ops is used in dma_fence_init for get_driver_name, so needs to be >> * initialized first >> */ >> fence->ops = ops; >> - fence_init(>base, _fence_ops, lock, context, seqno); >> + dma_fence_init(>base, _fence_ops, lock, context, seqno); >> get_dma_buf(sync_buf); >> fence->sync_buf = sync_buf; >> fence->seqno_ofs = seqno_ofs; >> diff --git a/include/linux/sync_file.h b/include/linux/sync_file.h >> index c6ffe8b0725c..6aae242b26de 100644 >> --- a/include/linux/sync_file.h >> +++ b/include/linux/sync_file.h >> @@ -18,11 +18,11 @@ >> #include >> #include >> #include >> -#include >> +#include >> >> struct sync_file_cb { >> - struct fence_cb cb; >> - struct fence *fence; >> + struct dma_fence_cb cb; >> + struct dma_fence *fence; >> struct sync_file *sync_file; >> }; >> >> @@ -52,6 +52,6 @@ struct sync_file { >> struct sync_file_cb cbs[]; >> }; >> >> -struct sync_file *sync_file_create(struct fence *fence); >> +struct sync_file *sync_file_create(struct dma_fence *fence); >> >> #endif /* _LINUX_SYNC_H */ >> diff --git a/include/trace/events/dma-fence.h >> b/include/trace/events/dma-fence.h >> new file mode 100644 >> index ..9d6e9434e53c >> --- /dev/null >> +++ b/include/trace/events/dma-fence.h >> @@ -0,0 +1,128 @@ >> +#undef TRACE_SYSTEM >> +#define TRACE_SYSTEM dma-fence >> + >> +#if !defined(_TRACE_FENCE_H) || defined(TRACE_HEADER_MULTI_READ) >> +#define _TRACE_DMA_FENCE_H >> + >> +#include >> + >> +struct dma_fence; >> + >> +TRACE_EVENT(dma_fence_annotate_wait_on, >> + >> + /* fence: the fence waiting on f1, f1: the fence to be waited on. */ >> + TP_PROTO(struct dma_fence *fence, struct dma_fence *f1), >> + >> + TP_ARGS(fence, f1), >> + >> + TP_STRUCT__entry( >> + __string(driver, fence->ops->get_driver_name(fence)) >> + __string(timeline, fence->ops->get_timeline_name(fence)) >> + __field(unsigned int, context) >> + __field(unsigned int, seqno) >> + >> + __string(waiting_driver, f1->ops->get_driver_name(f1)) >> + __string(waiting_timeline, f1->ops->get_timeline_name(f1)) >> + __field(unsigned int, waiting_context) >> + __field(unsigned int, waiting_seqno) >> + ), >> + >> + TP_fast_assign( >> + __assign_str(driver, fence->ops->get_driver_name(fence)) >> + __assign_str(timeline, fence->ops->get_timeline_name(fence)) >> + __entry->context = fence->context; >> + __entry->seqno = fence->seqno; >> + >> + __assign_str(waiting_driver, f1->ops->get_driver_name(f1)) >> + __assign_str(waiting_timeline, f1->ops->get_timeline_name(f1)) >> + __entry->waiting_context = f1->context; >> + __entry->waiting_seqno = f1->seqno; >> + >> + ), >> + >> + TP_printk("driver=%s timeline=%s context=%u seqno=%u " \ >> + "waits on driver=%s timeline=%s context=%u seqno=%u", >> + __get_str(driver), __get_str(timeline), __entry->context, >> + __entry->seqno, >> + __get_str(waiting_driver), __get_str(waiting_timeline), >> + __entry->waiting_context, __entry->waiting_seqno) >> +); >> + >> +DECLARE_EVENT_CLASS(dma_fence, >> + >> + TP_PROTO(struct dma_fence *fence), >> + >> + TP_ARGS(fence), >> + >> + TP_STRUCT__entry( >> + __string(driver, fence->ops->get_driver_name(fence)) >> + __string(timeline, fence->ops->get_timeline_name(fence)) >> + __field(unsigned int, context) >> + __field(unsigned int, seqno) >> + ), >> + >> + TP_fast_assign( >> + __assign_str(driver, fence->ops->get_driver_name(fence)) >> + __assign_str(timeline, fence->ops->get_timeline_name(fence)) >> + __entry->context = fence->context; >> + __entry->seqno = fence->seqno; >> + ), >> + >> + TP_printk("driver=%s timeline=%s context=%u seqno=%u", >> + __get_str(driver), __get_str(timeline), __entry->context, >> + __entry->seqno) >> +); >> + >> +DEFINE_EVENT(dma_fence, dma_fence_emit, >> + >> + TP_PROTO(struct dma_fence *fence), >> + >> + TP_ARGS(fence) >> +); >> + >> +DEFINE_EVENT(dma_fence, dma_fence_init, >> + >> + TP_PROTO(struct dma_fence *fence), >> + >> + TP_ARGS(fence) >> +); >> + >> +DEFINE_EVENT(dma_fence, dma_fence_destroy, >> + >> + TP_PROTO(struct dma_fence *fence), >> + >> + TP_ARGS(fence) >> +); >> + >> +DEFINE_EVENT(dma_fence, dma_fence_enable_signal, >> + >> + TP_PROTO(struct dma_fence *fence), >> + >> + TP_ARGS(fence) >> +); >> + >> +DEFINE_EVENT(dma_fence, dma_fence_signaled, >> + >> + TP_PROTO(struct dma_fence *fence), >> + >> + TP_ARGS(fence) >> +); >> + >> +DEFINE_EVENT(dma_fence, dma_fence_wait_start, >> + >> + TP_PROTO(struct dma_fence *fence), >> + >> + TP_ARGS(fence) >> +); >> + >> +DEFINE_EVENT(dma_fence, dma_fence_wait_end, >> + >> + TP_PROTO(struct dma_fence *fence), >> + >> + TP_ARGS(fence) >> +); >> + >> +#endif /* _TRACE_DMA_FENCE_H */ >> + >> +/* This part must be outside protection */ >> +#include >> -- >> 2.8.1 >> >> ___ >> dri-devel mailing list >> dri-devel at lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Thanks and regards, Sumit Semwal Linaro Mobile Group - Kernel Team Lead Linaro.org │ Open source software for ARM SoCs

[PATCH 0/3] dma-buf: debugfs fixes

-- > 2 files changed, 14 insertions(+), 32 deletions(-) > > -- > 1.7.10.4 > -- Thanks and regards, Sumit Semwal Linaro Mobile Group - Kernel Team Lead Linaro.org │ Open source software for ARM SoCs

<    1   2   3   4   >