Re: [PATCH] MAINTAINERS: Update email of Andrzej Hajda

2021-11-24 Thread Sylwester Nawrocki
49,15 @@ F: > Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml > F: drivers/nfc/s3fwrn5 > SAMSUNG S5C73M3 CAMERA DRIVER > -M: Andrzej Hajda > +M: Sylwester Nawrocki > +M: Andrzej Hajda > L: linux-me...@vger.kernel.org > S: Supported > F:

Re: [PATCH v9 0/5] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-13 Thread Sylwester Nawrocki
Hi Georgi, Chanwoo, On 13.11.2020 10:07, Chanwoo Choi wrote: > On 11/13/20 5:48 PM, Georgi Djakov wrote: >> On 11/12/20 16:09, Sylwester Nawrocki wrote: [...] >> >> Good work Sylwester! Thank you and all the reviewers! What would be the merge >> path fo

[PATCH v9 1/5] dt-bindings: devfreq: Add documentation for the interconnect properties

2020-11-12 Thread Sylwester Nawrocki
. Acked-by: Krzysztof Kozlowski Acked-by: Chanwoo Choi Tested-by: Chanwoo Choi Acked-by: Rob Herring Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v9: - added Ack tags Changes for v8: - updated description of the interconnects property, - fixed typo in samsung

[PATCH v9 4/5] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-11-12 Thread Sylwester Nawrocki
. Acked-by: Krzysztof Kozlowski Acked-by: Chanwoo Choi Signed-off-by: Sylwester Nawrocki --- Changes for v9: - whitespace (indentation) corrections. Changes for v8...v6: - none. Changes for v5: - new patch. --- drivers/devfreq/exynos-bus.c | 17 + 1 file changed, 17

[PATCH v9 2/5] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-12 Thread Sylwester Nawrocki
before its children. Reviewed-by: Chanwoo Choi Tested-by: Chanwoo Choi Acked-by: Krzysztof Kozlowski Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v9: - Makefile and Kconfig fixes/improvements. Changes for v8: - renamed drivers/interconnect/exynos to drivers/in

[PATCH v9 3/5] MAINTAINERS: Add entry for Samsung interconnect drivers

2020-11-12 Thread Sylwester Nawrocki
Add maintainers entry for the Samsung SoC interconnect drivers, this currently includes the Exynos generic interconnect driver. Reviewed-by: Chanwoo Choi Signed-off-by: Sylwester Nawrocki --- Changes for v9: - add linux-samsung-soc ML, - fixed Artur's last name spelling, - whole entry moved

[PATCH v9 5/5] drm: exynos: mixer: Add interconnect support

2020-11-12 Thread Sylwester Nawrocki
-by: Chanwoo Choi Tested-by: Chanwoo Choi Co-developed-by: Artur Świgoń Signed-off-by: Artur Świgoń Co-developed-by: Marek Szyprowski Signed-off-by: Marek Szyprowski Signed-off-by: Sylwester Nawrocki --- Changes for v9: - whitespace cleanup, - Co-developed-by/Signed-off-by tags corrections

[PATCH v9 0/5] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-12 Thread Sylwester Nawrocki
https://patchwork.kernel.org/cover/11152595/ (v2 of this RFC) Sylwester Nawrocki (5): dt-bindings: devfreq: Add documentation for the interconnect properties interconnect: Add generic interconnect driver for Exynos SoCs MAINTAINERS: Add entry for Samsung interconnect drivers PM / de

Re: [PATCH v8 3/7] MAINTAINERS: Add entry for Samsung interconnect drivers

2020-11-04 Thread Sylwester Nawrocki
On 04.11.2020 13:27, Krzysztof Kozlowski wrote: > On Wed, Nov 04, 2020 at 11:36:53AM +0100, Sylwester Nawrocki wrote: >> Add maintainers entry for the Samsung interconnect drivers, this currently >> includes Exynos SoC generic interconnect driver. >> >> Signed-off-by: S

Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-04 Thread Sylwester Nawrocki
On 04.11.2020 13:37, Krzysztof Kozlowski wrote: > On Wed, Nov 04, 2020 at 11:36:52AM +0100, Sylwester Nawrocki wrote: >> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile >> index d203520..c2f9e9d 100644 >> --- a/drivers/interconnect/Makefile >>

[PATCH v8 7/7] drm: exynos: mixer: Add interconnect support

2020-11-04 Thread Sylwester Nawrocki
-by: Artur Świgoń Signed-off-by: Marek Szyprowski Signed-off-by: Sylwester Nawrocki --- Changes for v8: - updated comment in mixer_probe() Changes for v7: - fixed incorrect setting of the ICC bandwidth when the mixer is disabled, now the bandwidth is set explicitly to 0 in such case. Changes

[PATCH v8 0/7] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-04 Thread Sylwester Nawrocki
1054417/ (v1 of this RFC) [6] https://patchwork.kernel.org/cover/11152595/ (v2 of this RFC) Artur Świgoń (1): ARM: dts: exynos: Add interconnects to Exynos4412 mixer Sylwester Nawrocki (6): dt-bindings: devfreq: Add documentation for the interconnect properties interconnect: Add generic

[PATCH v8 4/7] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-11-04 Thread Sylwester Nawrocki
. Acked-by: Krzysztof Kozlowski Acked-by: Chanwoo Choi Signed-off-by: Sylwester Nawrocki --- Changes for v8, v7, v6: - none. Changes for v5: - new patch. --- drivers/devfreq/exynos-bus.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/devfreq/exynos-bus.c b

[PATCH v8 3/7] MAINTAINERS: Add entry for Samsung interconnect drivers

2020-11-04 Thread Sylwester Nawrocki
Add maintainers entry for the Samsung interconnect drivers, this currently includes Exynos SoC generic interconnect driver. Signed-off-by: Sylwester Nawrocki --- Changes since v7: - new patch. --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH v8 5/7] ARM: dts: exynos: Add interconnect properties to Exynos4412 bus nodes

2020-11-04 Thread Sylwester Nawrocki
to specify minimum data clock frequency corresponding to requested bandwidth for each bus. Note that #interconnect-cells is always zero and node IDs are not hardcoded anywhere. Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v8: - none. Changes for v7

[PATCH v8 1/7] dt-bindings: devfreq: Add documentation for the interconnect properties

2020-11-04 Thread Sylwester Nawrocki
. Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v8: - updated description of the interconnects property, - fixed typo in samsung,data-clk-ratio property description. Changes for v7: - bus-width property replaced with samsung,data-clock-ratio, - the interconnect

[PATCH v8 6/7] ARM: dts: exynos: Add interconnects to Exynos4412 mixer

2020-11-04 Thread Sylwester Nawrocki
() with a NULL name simply returns the right path. Reviewed-by: Chanwoo Choi Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v8...v5: - none. --- arch/arm/boot/dts/exynos4412.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch

[PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-04 Thread Sylwester Nawrocki
before its children. Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v8: - renamed drivers/interconnect/exynos to drivers/interconnect/samsung, - added missing driver sync_state callback assignment. Changes for v7: - adjusted to the DT property changes: "interco

Re: [PATCH v7 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-03 Thread Sylwester Nawrocki
On 03.11.2020 15:12, Chanwoo Choi wrote: >>> I have a question about exynos_icc_get_parent(). >>> As I checked, this function returns the only one icc_node >>> as parent node. But, bus_display dt node in the exynos4412.dtsi >>> specifies the two interconnect node as following with bus_leftbus,

Re: [PATCH v7 3/6] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-11-03 Thread Sylwester Nawrocki
Hi Chanwoo, On 03.11.2020 11:45, Chanwoo Choi wrote: > On 10/30/20 9:51 PM, Sylwester Nawrocki wrote: >> This patch adds registration of a child platform device for the exynos >> interconnect driver. It is assumed that the interconnect provider will >> only be needed whe

Re: [PATCH v7 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-03 Thread Sylwester Nawrocki
On 03.11.2020 10:37, Chanwoo Choi wrote: > On 10/30/20 9:51 PM, Sylwester Nawrocki wrote: >> This patch adds a generic interconnect driver for Exynos SoCs in order >> to provide interconnect functionality for each "samsung,exynos-bus" >> compatible device. &g

Re: [PATCH v7 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-03 Thread Sylwester Nawrocki
Hi Chanwoo, Georgi On 03.11.2020 09:53, Chanwoo Choi wrote: > On 11/3/20 5:29 PM, Georgi Djakov wrote: >> On 11/3/20 09:54, Chanwoo Choi wrote: >>> When I tested this patchset on Odroid-U3, >>> After setting 0 bps by interconnect[1][2], >>> the frequency of devfreq devs sustain the high

Re: [PATCH v7 6/6] drm: exynos: mixer: Add interconnect support

2020-11-02 Thread Sylwester Nawrocki
On 31.10.2020 13:47, Krzysztof Kozlowski wrote: >> @@ -1223,19 +1330,33 @@ static int mixer_probe(struct platform_device *pdev) >> struct device *dev = >dev; >> const struct mixer_drv_data *drv; >> struct mixer_context *ctx; >> +struct icc_path *path; >> int ret; >> >> +

Re: [PATCH v7 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-02 Thread Sylwester Nawrocki
On 31.10.2020 13:17, Krzysztof Kozlowski wrote: > On Fri, Oct 30, 2020 at 01:51:45PM +0100, Sylwester Nawrocki wrote: >> This patch adds a generic interconnect driver for Exynos SoCs in order >> to provide interconnect functionality for each "samsung,exynos-bus" >>

[PATCH v7 5/6] ARM: dts: exynos: Add interconnects to Exynos4412 mixer

2020-10-30 Thread Sylwester Nawrocki
From: Artur Świgoń This patch adds an 'interconnects' property to Exynos4412 DTS in order to declare the interconnect path used by the mixer. Please note that the 'interconnect-names' property is not needed when there is only one path in 'interconnects', in which case calling of_icc_get() with a

[PATCH v7 6/6] drm: exynos: mixer: Add interconnect support

2020-10-30 Thread Sylwester Nawrocki
-by: Marek Szyprowski Signed-off-by: Sylwester Nawrocki --- Changes for v7: - fixed incorrect setting of the ICC bandwidth when the mixer is disabled, now the bandwidth is set explicitly to 0 in such case. Changes for v6: - the icc_set_bw() call is now only done when calculated value

[PATCH v7 3/6] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-10-30 Thread Sylwester Nawrocki
. Signed-off-by: Sylwester Nawrocki --- Changes for v7, v6: - none. Changes for v5: - new patch. --- drivers/devfreq/exynos-bus.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 1e684a4..ee300ee 100644

[PATCH v7 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-10-30 Thread Sylwester Nawrocki
C) [6] https://patchwork.kernel.org/cover/11152595/ (v2 of this RFC) Artur Świgoń (1): ARM: dts: exynos: Add interconnects to Exynos4412 mixer Sylwester Nawrocki (5): dt-bindings: devfreq: Add documentation for the interconnect properties interconnect: Add generic interconnect driver for Exy

[PATCH v7 4/6] ARM: dts: exynos: Add interconnect properties to Exynos4412 bus nodes

2020-10-30 Thread Sylwester Nawrocki
to specify minimum data clock frequency corresponding to requested bandwidth for each bus. Note that #interconnect-cells is always zero and node IDs are not hardcoded anywhere. Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v7: - adjusted to the DT property

[PATCH v7 1/6] dt-bindings: devfreq: Add documentation for the interconnect properties

2020-10-30 Thread Sylwester Nawrocki
. Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v7: - bus-width property replaced with samsung,data-clock-ratio, - the interconnect consumer bindings used instead of vendor specific properties Changes for v6: - added dts example of bus hierarchy definition

[PATCH v7 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-10-30 Thread Sylwester Nawrocki
lease note that it is not an error when CONFIG_INTERCONNECT is 'n', in which case all interconnect API functions are no-op. The bus-width DT property is to determine the interconnect data width and traslate requested bandwidth to clock frequency for each bus. Signed-off-by: Artur Świgoń Signed-off-by: Sylweste

Re: [PATCH RFC v6 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-10-30 Thread Sylwester Nawrocki
Hi Georgi, On 15.09.2020 23:40, Georgi Djakov wrote: > On 9/9/20 17:47, Sylwester Nawrocki wrote: >> On 09.09.2020 11:07, Georgi Djakov wrote: >>> On 8/28/20 17:49, Sylwester Nawrocki wrote: >>>> On 30.07.2020 14:28, Sylwester Nawrocki wrote: >>>&g

Re: [PATCH RFC v6 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-09-09 Thread Sylwester Nawrocki
Hi Georgi, On 09.09.2020 11:07, Georgi Djakov wrote: > On 8/28/20 17:49, Sylwester Nawrocki wrote: >> On 30.07.2020 14:28, Sylwester Nawrocki wrote: >>> On 09.07.2020 23:04, Rob Herring wrote: >>>> On Thu, Jul 02, 2020 at 06:37:19PM +0200, Sylwester Nawrocki wrote: &

Re: [PATCH 08/10] arm64: dts: exynos: Add compatibles to sysreg nodes

2020-08-31 Thread Sylwester Nawrocki
valid under any of the given schemas > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Sylwester Nawrocki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 07/10] arm64: dts: exynos: Replace deprecated "gpios" i2c-gpio property in Exynos5433

2020-08-31 Thread Sylwester Nawrocki
ot/dts/exynos/exynos5433-tm2.dt.yaml: i2c-gpio-0: 'scl-gpios' > is a required property > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Sylwester Nawrocki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 06/10] dt-bindings: sound: samsung-i2s: Use unevaluatedProperties

2020-08-31 Thread Sylwester Nawrocki
are not allowed ('power-domains', '#address-cells', > 'interrupts', '#size-cells' were unexpected) > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Sylwester Nawrocki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists

Re: [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles

2020-08-31 Thread Sylwester Nawrocki
- samsung,exynos5-sysreg > + - samsung,exynos5433-sysreg Reviewed-by: Sylwester Nawrocki Do you also have a patch updating Documentation/devicetree/ bindings/arm/samsung/sysreg.yaml with new compatibles? -- Regards, Sylwester _

Re: [PATCH 02/10] dt-bindings: gpu: arm,mali-midgard: Use unevaluatedProperties

2020-08-31 Thread Sylwester Nawrocki
'opp_table' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Sylwester Nawrocki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 03/10] dt-bindings: timer: exynos4210-mct: Use unevaluatedProperties

2020-08-31 Thread Sylwester Nawrocki
o not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Sylwester Nawrocki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 01/10] dt-bindings: arm: samsung: pmu: Use unevaluatedProperties

2020-08-31 Thread Sylwester Nawrocki
'assigned-clock-parents', 'assigned-clocks' do not match any of the > regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Sylwester Nawrocki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freed

Re: [PATCH RFC v6 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-08-28 Thread Sylwester Nawrocki
On 30.07.2020 14:28, Sylwester Nawrocki wrote: > On 09.07.2020 23:04, Rob Herring wrote: >> On Thu, Jul 02, 2020 at 06:37:19PM +0200, Sylwester Nawrocki wrote: >>> Add documentation for new optional properties in the exynos bus nodes: >>> samsung,interconnect-parent, #in

Re: [PATCH RFC v6 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-07-30 Thread Sylwester Nawrocki
On 09.07.2020 23:04, Rob Herring wrote: > On Thu, Jul 02, 2020 at 06:37:19PM +0200, Sylwester Nawrocki wrote: >> Add documentation for new optional properties in the exynos bus nodes: >> samsung,interconnect-parent, #interconnect-cells, bus-width. >> These properties all

[PATCH RFC v6 3/6] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-07-02 Thread Sylwester Nawrocki
. Signed-off-by: Sylwester Nawrocki Acked-by: Chanwoo Choi --- Changes for v6: - none. Changes for v5: - new patch. --- drivers/devfreq/exynos-bus.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 8fa8eb5

[PATCH RFC v6 6/6] drm: exynos: mixer: Add interconnect support

2020-07-02 Thread Sylwester Nawrocki
-by: Marek Szyprowski Signed-off-by: Sylwester Nawrocki --- Changes for v6: - the icc_set_bw() call is now only done when calculated value for a crtc changes, this avoids unnecessary calls per each video frame - added synchronization of the interconnect bandwidth setting with the mixer VSYNC

[PATCH RFC v6 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-07-02 Thread Sylwester Nawrocki
lease note that it is not an error when CONFIG_INTERCONNECT is 'n', in which case all interconnect API functions are no-op. The bus-width DT property is to determine the interconnect data width and traslate requested bandwidth to clock frequency for each bus. Signed-off-by: Artur Świgoń Signed-off-by: Sylweste

[PATCH RFC v6 5/6] ARM: dts: exynos: Add interconnects to Exynos4412 mixer

2020-07-02 Thread Sylwester Nawrocki
From: Artur Świgoń This patch adds an 'interconnects' property to Exynos4412 DTS in order to declare the interconnect path used by the mixer. Please note that the 'interconnect-names' property is not needed when there is only one path in 'interconnects', in which case calling of_icc_get() with a

[PATCH RFC v6 4/6] ARM: dts: exynos: Add interconnect properties to Exynos4412 bus nodes

2020-07-02 Thread Sylwester Nawrocki
width in bits, required to properly derive minimum bus clock frequency from requested bandwidth for each bus. Note that #interconnect-cells is always zero and node IDs are not hardcoded anywhere. Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki Reviewed-by: Chanwoo Choi

[PATCH RFC v6 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-07-02 Thread Sylwester Nawrocki
. Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v6: - added dts example of bus hierarchy definition and the interconnect consumer, - added new bus-width property. Changes for v5: - exynos,interconnect-parent-node renamed to samsung,interconnect-parent

[PATCH RFC v6 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-07-02 Thread Sylwester Nawrocki
RFC) Artur Świgoń (1): ARM: dts: exynos: Add interconnects to Exynos4412 mixer Sylwester Nawrocki (5): dt-bindings: exynos-bus: Add documentation for interconnect properties interconnect: Add generic interconnect driver for Exynos SoCs PM / devfreq: exynos-bus: Add registration of interconnect

Re: [RFC PATCH v5 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-07-02 Thread Sylwester Nawrocki
On 02.07.2020 14:33, Georgi Djakov wrote: > On 7/2/20 15:01, Sylwester Nawrocki wrote: >> On 01.07.2020 14:50, Georgi Djakov wrote: >>> On 5/29/20 19:31, Sylwester Nawrocki wrote: >>>> +static int exynos_generic_icc_remove(struct platform_device *pdev) >>>&g

Re: [RFC PATCH v5 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-07-02 Thread Sylwester Nawrocki
Hi Georgi, On 01.07.2020 14:50, Georgi Djakov wrote: > Thanks for the patch and apologies for the delayed reply. Thanks, no problem. It's actually just in time as I put that patchset aside for a while and was just about to post an update. > On 5/29/20 19:31, Sylwester Nawrocki

Re: [RFC PATCH v5 6/6] drm: exynos: mixer: Add interconnect support

2020-06-03 Thread Sylwester Nawrocki
Hi Chanwoo, On 01.06.2020 09:58, Chanwoo Choi wrote: > On 5/30/20 1:32 AM, Sylwester Nawrocki wrote: >> From: Marek Szyprowski >> >> This patch adds interconnect support to exynos-mixer. The mixer works >> the same as before when CONFIG_INTERCONNECT is 'n'.

Re: [RFC PATCH v5 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-06-03 Thread Sylwester Nawrocki
On 02.06.2020 10:21, Krzysztof Kozlowski wrote: >> +static struct icc_node *exynos_icc_get_parent(struct device_node *np) >> +{ >> +struct of_phandle_args args; >> +int num, ret; >> + >> +num = of_count_phandle_with_args(np, "samsung,interconnect-parent", >> +

Re: [RFC PATCH v5 3/6] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-06-01 Thread Sylwester Nawrocki
Cc: Rob, devicetree ML On 31.05.2020 01:57, Chanwoo Choi wrote: > On Sat, May 30, 2020 at 1:33 AM Sylwester Nawrocki > wrote: >> >> This patch adds registration of a child platform device for the exynos >> interconnect driver. It is assumed that the interconnect provide

Re: [RFC PATCH v5 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-06-01 Thread Sylwester Nawrocki
Cc: Rob, devicetree ML On 31.05.2020 02:13, Chanwoo Choi wrote: > On Sat, May 30, 2020 at 1:34 AM Sylwester Nawrocki > wrote: >> >> This patch adds a generic interconnect driver for Exynos SoCs in order >> to provide interconnect functionality for each "samsung,exy

Re: [RFC PATCH v5 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-06-01 Thread Sylwester Nawrocki
Hi Chanwoo, On 31.05.2020 02:01, Chanwoo Choi wrote: > On Sat, May 30, 2020 at 1:32 AM Sylwester Nawrocki > wrote: >> >> Add documentation for new optional properties in the exynos bus nodes: >> samsung,interconnect-parent, #interconnect-cells. >> These prope

Re: [RFC PATCH v5 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-06-01 Thread Sylwester Nawrocki
Cc: Rob, devicetree ML On 29.05.2020 18:31, Sylwester Nawrocki wrote: > Add documentation for new optional properties in the exynos bus nodes: > samsung,interconnect-parent, #interconnect-cells. > These properties allow to specify the SoC interconnect structure which >

Re: [RFC PATCH v5 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-06-01 Thread Sylwester Nawrocki
Cc: Rob, devicetree ML On 29.05.2020 18:31, Sylwester Nawrocki wrote: > This patchset adds interconnect API support for the Exynos SoC "samsung, > exynos-bus" compatible devices, which already have their corresponding > exynos-bus driver in the devfreq subsystem. Comple

[RFC PATCH v5 4/6] ARM: dts: exynos: Add interconnect properties to Exynos4412 bus nodes

2020-05-29 Thread Sylwester Nawrocki
-cells is always zero and node IDs are not hardcoded anywhere. Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v5: - adjust to renamed exynos,interconnect-parent-node property, - add properties in common exynos4412.dtsi file rather than in Odroid specific

[RFC PATCH v5 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-05-29 Thread Sylwester Nawrocki
-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki --- Changes for v5: - exynos,interconnect-parent-node renamed to samsung,interconnect-parent --- Documentation/devicetree/bindings/devfreq/exynos-bus.txt | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git

[RFC PATCH v5 5/6] ARM: dts: exynos: Add interconnects to Exynos4412 mixer

2020-05-29 Thread Sylwester Nawrocki
From: Artur Świgoń This patch adds an 'interconnects' property to Exynos4412 DTS in order to declare the interconnect path used by the mixer. Please note that the 'interconnect-names' property is not needed when there is only one path in 'interconnects', in which case calling of_icc_get() with a

[RFC PATCH v5 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-05-29 Thread Sylwester Nawrocki
lease note that it is not an error when CONFIG_INTERCONNECT is 'n', in which case all interconnect API functions are no-op. Signed-off-by: Artur Świgoń Signed-off-by: Sylwester Nawrocki Changes for v5: - adjust to renamed exynos,interconnect-parent-node property, - use automatically generated platform

[RFC PATCH v5 3/6] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-05-29 Thread Sylwester Nawrocki
. Signed-off-by: Sylwester Nawrocki Changes for v5: - new patch. --- drivers/devfreq/exynos-bus.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 8fa8eb5..856e37d 100644 --- a/drivers/devfreq/exynos-bus.c

[RFC PATCH v5 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-05-29 Thread Sylwester Nawrocki
ń (1): ARM: dts: exynos: Add interconnects to Exynos4412 mixer Marek Szyprowski (1): drm: exynos: mixer: Add interconnect support Sylwester Nawrocki (4): dt-bindings: exynos-bus: Add documentation for interconnect properties interconnect: Add generic interconnect driver for Exynos SoCs PM / devfreq

[RFC PATCH v5 6/6] drm: exynos: mixer: Add interconnect support

2020-05-29 Thread Sylwester Nawrocki
, height, refresh rate and pixel format. Co-developed-by: Artur Świgoń Signed-off-by: Marek Szyprowski [s.nawrocki: renamed soc_path variable to icc_path, edited commit desc.] Signed-off-by: Sylwester Nawrocki --- Changes for v5: - renamed soc_path variable to icc_path --- drivers/gpu/drm

Re: [PATCH v7 9/9] drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register

2019-08-28 Thread Sylwester Nawrocki
hys address before > deregistering the notifier, > - use cec_notifier_phys_addr_invalidate instead of setting > invalid address on a notifier. > > Signed-off-by: Dariusz Marcinkiewicz > Tested-by: Hans Verkuil Reviewed-by: Sylwester Nawrocki > diff --git a/dr

Re: [RFT 02/10] clk: samsung: Add bus clock for GPU/G3D on Exynos4412

2019-06-19 Thread Sylwester Nawrocki
On 6/18/19 21:05, Krzysztof Kozlowski wrote: > Add ID and gate for bus clock for GPU (Mali 400) on Exynos4412. Patch applied to clk/samsung tree, thanks.

[PATCH v2] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-09 Thread Sylwester Nawrocki
The #sound-dai-cells DT property is required to describe link between the HDMI IP block and the SoC's audio subsystem. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v2: - the property has been moved to "Required properties" paragraph, I didn't ad

Re: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-09 Thread Sylwester Nawrocki
On 03/09/2018 03:35 AM, Inki Dae wrote: > 2018년 03월 08일 20:22에 Sylwester Nawrocki 이(가) 쓴 글: >> On 03/08/2018 09:15 AM, Inki Dae wrote: [...] >>> Is there a possibility for other boards based on Exynos4210/4212/5420/5433 >>> SoC to use this property later? >> &

Re: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-08 Thread Sylwester Nawrocki
Hi Inki, Cc: alsa-de...@alsa-project.org On 03/08/2018 09:15 AM, Inki Dae wrote: > By the way, it seems 'sound-dai-cells' property never affect Exynos4210/4212> > 5420/5433. It seems that even through ALSA TM2 audio driver(tm2_wm5110.c) > exists the driver never check the property. > >

[PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-07 Thread Sylwester Nawrocki
The #sound-dai-cells DT property is required to describe link between the HDMI IP block and the SoC's audio subsystem. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt | 3 +++ 1 file changed, 3 insertions(+)

[PATCH v2] drm: exynos: Use proper macro definition for HDMI_I2S_PIN_SEL_1

2018-02-14 Thread Sylwester Nawrocki
-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 7 +-- drivers/gpu/drm/exynos/regs-hdmi.h | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c

Re: [PATCH] drm: exynos: Use proper macro definition for HDMI_I2S_PIN_SEL_1

2018-02-14 Thread Sylwester Nawrocki
Hi Inki, On 02/14/2018 06:57 AM, Inki Dae wrote: >> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c >> b/drivers/gpu/drm/exynos/exynos_hdmi.c >> index a4b75a46f946..abd84cbcf1c2 100644 >> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c >> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c >> @@ -1068,10

[PATCH] drm: exynos: Use proper macro definition for HDMI_I2S_PIN_SEL_1

2018-02-05 Thread Sylwester Nawrocki
Bit field [2:0] of HDMI_I2S_PIN_SEL_1 corresponds to SDATA_0, not SDATA_2. This patch removes redefinition of HDMI_I2S_SEL_DATA2 constant and adds missing HDMI_I2S_SEL_DATA0. There is no functional change. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/gpu/drm/

[PATCH] drm/bridge: analogix: Remove unreachable code from analogic_dp_core.c

2017-12-12 Thread Sylwester Nawrocki
at this program point the variable retval is always equal to 0 at drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:786 Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-)

[PATCH v4] drm: exynos: Add driver for HDMI audio interface

2017-10-23 Thread Sylwester Nawrocki
with the HDMI audio transmitter's input I2S interface. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> --- Changes since v3: - removed unregister_audio_device() function, added missing audio platform device unregistrat

Re: [PATCH v3] drm: exynos: Add driver for HDMI audio interface

2017-10-23 Thread Sylwester Nawrocki
On 10/23/2017 03:27 AM, Inki Dae wrote: >> +static int hdmi_audio_digital_mute(struct device *dev, void *data, bool >> mute) >> +{ >> +struct hdmi_context *hdata = dev_get_drvdata(dev); >> + >> +mutex_lock(>mutex); >> + >> +hdata->audio.enable = !mute; > > Wouldn't it be better to

Re: [PATCH v3] drm: exynos: Add driver for HDMI audio interface

2017-10-12 Thread Sylwester Nawrocki
On 09/26/2017 04:17 PM, Sylwester Nawrocki wrote: > The hdmi-codec interface added in this patch is required to properly > support HDMI audio. Currently the audio part of the SoC internal > HDMI transmitter is configured with fixed values, which makes HDMI > audio working by chance, on

Re: [PATCH v2 8/9] drivers: clk: samsung: Fix m2m scaler clock on Exynos542x

2017-09-29 Thread Sylwester Nawrocki
On 09/29/2017 09:32 AM, Marek Szyprowski wrote: > From: Andrzej Pietrasiewicz > > TOP "aclk400_mscl" clock should be kept enabled all the time to allow > proper access to power management control for MSC power domain and > devices that are a part of it. This change is

[PATCH v3] drm: exynos: Add driver for HDMI audio interface

2017-09-26 Thread Sylwester Nawrocki
with the HDMI audio transmitter's input I2S interface. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> --- Tested on Odroid XU3 and Odroid XU4 with Ubuntu 14.04. Changes since v2: - u8 replaced with bool type, - the HDMI code

Re: [PATCH v2] drm: exynos: Add driver for HDMI audio interface

2017-09-19 Thread Sylwester Nawrocki
On 09/19/2017 10:30 AM, Andrzej Hajda wrote: On 18.09.2017 18:19, Sylwester Nawrocki wrote: diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 214fa5e..dc254b7 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos

[PATCH v2] drm: exynos: Add driver for HDMI audio interface

2017-09-18 Thread Sylwester Nawrocki
with the HDMI audio transmitter's input I2S interface. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Patch tested on Odroid XU3 and Odroid XU4 with Ubuntu 14.04. Changes since v1: - rebased onto v4.14-rc1 and adapted locking Changes since RFC version: - fixed hdmi-codec l

Re: [PATCH v4 0/4] Exynos-gsc: Support the hardware rotation limits

2017-09-13 Thread Sylwester Nawrocki
On 09/13/2017 01:41 PM, Hoegeun Kwon wrote: Hoegeun Kwon (4): [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version ARM: dts: exynos: Add clean name of compatible. drm/exynos/gsc: Add hardware rotation limits [media] exynos-gsc: Add hardware rotation

Re: [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits

2017-09-13 Thread Sylwester Nawrocki
On 09/13/2017 01:41 PM, Hoegeun Kwon wrote: @@ -1004,11 +1088,33 @@ static irqreturn_t gsc_irq_handler(int irq, void *priv) .num_clocks = 1, }; +static struct gsc_driverdata gsc_v_5250_drvdata = { + .variant = { + [0] = _v_5250_variant, + [1] =

Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

2017-09-13 Thread Sylwester Nawrocki
Hi Hoegeun, On 09/13/2017 04:33 AM, Hoegeun Kwon wrote: >>> @@ -1017,8 +1083,12 @@ static irqreturn_t gsc_irq_handler(int irq, >>> void *priv) >>> static const struct of_device_id exynos_gsc_match[] = { >>>{ >>> -.compatible = "samsung,exynos5-gsc", >>> -.data =

Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

2017-09-11 Thread Sylwester Nawrocki
On 09/08/2017 08:02 AM, Hoegeun Kwon wrote: The hardware rotation limits of gsc depends on SOC (Exynos 5250/5420/5433). Distinguish them and add them to the driver data. Signed-off-by: Hoegeun Kwon --- drivers/media/platform/exynos-gsc/gsc-core.c | 96

[PATCH] drm: exynos: Add driver for HDMI audio interface

2017-08-03 Thread Sylwester Nawrocki
with the HDMI audio transmitter I2S input interface. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since RFC version: - fixed hdmi-codec locking issue - added a comment documenting struct hdmi_contex::mutex --- drivers/gpu/drm/exynos/Kconfig | 1 + drive

Re: [PATCH 2/2] dt-bindings: media/s5p-cec.txt, media/stih-cec.txt: refer to cec.txt

2017-06-12 Thread Sylwester Nawrocki
off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Thanks, Sylwester ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] dt-bindings: add media/cec.txt

2017-06-12 Thread Sylwester Nawrocki
On 06/09/2017 07:54 PM, Hans Verkuil wrote: From: Hans Verkuil <hans.verk...@cisco.com> Document common HDMI CEC bindings. Add this to the MAINTAINERS file as well. Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki <s.nawro

Re: [PATCH 8/9] s5p_cec: set the CEC_CAP_NEEDS_HPD flag if needed

2017-06-12 Thread Sylwester Nawrocki
On 06/07/2017 04:46 PM, Hans Verkuil wrote: From: Hans Verkuil <hans.verk...@cisco.com> Use the needs-hpd DT property to determine if the CEC_CAP_NEEDS_HPD should be set. Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Sylwester Nawrocki <s.nawro

Re: [PATCH RFC 5/7] ASoC: Add Odroid sound DT bindings documentation

2017-06-09 Thread Sylwester Nawrocki
On 04/28/2017 07:03 PM, Rob Herring wrote: On Fri, Apr 21, 2017 at 07:19:49PM +0200, Sylwester Nawrocki wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/sound/samsung,odroid.txt @@ -0,0 +1,57 @@ +Samsung Exynos Odroid XU3/XU4 audio complex with MAX98090 codec + +Required

Re: [PATCH RFC 1/7] clk: samsung: Add enable/disable operation for PLL36XX clocks

2017-04-24 Thread Sylwester Nawrocki
On 04/22/2017 05:22 PM, Krzysztof Kozlowski wrote: [...] +static void samsung_pll3xxx_disable(struct clk_hw *hw) +{ + struct samsung_clk_pll *pll = to_clk_pll(hw); + u32 tmp; + + tmp = readl_relaxed(pll->con_reg); + tmp |= BIT(pll->enable_offs); I think you meant here:

Re: [PATCH RFC 1/7] clk: samsung: Add enable/disable operation for PLL36XX clocks

2017-04-24 Thread Sylwester Nawrocki
On 04/22/2017 04:51 AM, Stephen Boyd wrote: +static int samsung_pll3xxx_enable(struct clk_hw *hw) +{ + struct samsung_clk_pll *pll = to_clk_pll(hw); + u32 tmp; + + tmp = readl_relaxed(pll->con_reg); + tmp |= BIT(pll->enable_offs); + writel_relaxed(tmp,

[PATCH RFC 7/7] ARM: dts: samsung: Switch to dedicated Odroid sound card binding

2017-04-21 Thread Sylwester Nawrocki
The new sound card DT binding is used for Odroid XU3 in order to properly support the HDMI audio path. Clocks configuration is changed so the I2S controller is now the bit and the frame clock master with EPLL as the root clock source. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.

[PATCH RFC 6/7] ASoC: samsung: Add Odroid ASoC machine driver

2017-04-21 Thread Sylwester Nawrocki
This dedicated driver allows to support SoC specific clock settings and helps to ensure proper number of channels gets negotiated in multicodec system configurations. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- sound/soc/samsung/Kconfig | 8 ++ sound/soc/samsung/Ma

[PATCH RFC 2/7] clk: samsung: Add definitions of some audio related clocks

2017-04-21 Thread Sylwester Nawrocki
This patch adds missing definitions of mux clocks required for using EPLL as the audio subsystem root clock on exynos5420/exynos5422 SoCs. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/clk/samsung/clk-exynos5420.c | 13 - include/dt-bindings

[PATCH RFC 3/7] clk: samsung: exynos542x: Add EPLL rate table

2017-04-21 Thread Sylwester Nawrocki
A specific clock rate table is added for EPLL so it is possible to set frequency of the EPLL output clock as multiple of various audio sampling rates. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/clk/samsung/clk-exynos5420.c | 20 ++-- 1 file chang

[PATCH RFC 5/7] ASoC: Add Odroid sound DT bindings documentation

2017-04-21 Thread Sylwester Nawrocki
This patch adds DT binding documentation for Odroid XU3/4 sound subsystem. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- .../devicetree/bindings/sound/samsung,odroid.txt | 57 ++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devi

[PATCH RFC 0/7] HDMI audio support for Exynos Odroid boards

2017-04-21 Thread Sylwester Nawrocki
specific clock settings (EPLL and the I2S root clock adjusted to audio sample rates) and to ensure proper number of audio channels gets negotiated in multicodec system configuration. This series is based on v4.11-rc6, has been tested on Odroid XU3. Sylwester Nawrocki (7): clk: samsung: Add

[PATCH RFC 4/7] drm: exynos: Add driver for HDMI audio interface

2017-04-21 Thread Sylwester Nawrocki
with the HDMI audio transmitter I2S input interface. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- drivers/gpu/drm/exynos/Kconfig | 1 + drivers/gpu/drm/exynos/exynos_hdmi.c | 220 +-- 2 files changed, 188 insertions(+), 33 del

  1   2   3   >