Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec

2021-05-25 Thread Takashi Iwai
On Tue, 25 May 2021 11:23:53 +0200, Maxime Ripard wrote: > > Hi Takashi, > > On Tue, May 25, 2021 at 10:35:14AM +0200, Takashi Iwai wrote: > > On Mon, 24 May 2021 15:39:04 +0200, > > Maxime Ripard wrote: > > > > > > Hi, > > > > > > O

Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec

2021-05-25 Thread Takashi Iwai
On Mon, 24 May 2021 15:39:04 +0200, Maxime Ripard wrote: > > Hi, > > On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > > Hi, > > > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in > > place, > > it's missing a few controls to be able to provide HBR

Re: [PATCH 01/11] snd: iec958: split status creation and fill

2021-05-25 Thread Takashi Iwai
On Fri, 07 May 2021 16:03:24 +0200, Maxime Ripard wrote: > > In some situations, like a codec probe, we need to provide an IEC status > default but don't have access to the sampling rate and width yet since > no stream has been configured yet. > > Each and every driver has its own default,

[5.12 regression] ttm->pages NULL dereference with radeon driver

2021-05-07 Thread Takashi Iwai
Hi, we've received a regression report showing NULL dereference Oops with radeon driver on 5.12 kernel: https://bugzilla.opensuse.org/show_bug.cgi?id=1185516 It turned out that the recent TTM cleanup / refactoring via commit 0575ff3d33cd ("drm/radeon: stop using pages with

Re: [PATCH v2] drm/bochs: Add screen blanking support

2021-04-27 Thread Takashi Iwai
On Mon, 26 Apr 2021 20:44:55 +0200, Thomas Zimmermann wrote: > > Hi > > Am 21.04.21 um 10:08 schrieb Takashi Iwai: > > On bochs DRM driver, the execution of "setterm --blank force" results > > in a frozen screen instead of a blank screen. It's due to the lack

[PATCH] drm/ast: Fix missing conversions to managed API

2021-04-21 Thread Takashi Iwai
ver unbind. Let's fix them. Fixes: 7cbb93d89838 ("drm/ast: Use managed pci functions") Signed-off-by: Takashi Iwai --- drivers/gpu/drm/ast/ast_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.

[PATCH v2] drm/bochs: Add screen blanking support

2021-04-21 Thread Takashi Iwai
/vga.h for VGA register definitions * move the blank/unblank code to bochs_hw_blank() Signed-off-by: Takashi Iwai --- drivers/gpu/drm/bochs/bochs.h | 1 + drivers/gpu/drm/bochs/bochs_hw.c | 25 - drivers/gpu/drm/bochs/bochs_kms.c | 8 3 files changed, 33 in

Re: [PATCH] drm/bochs: Add screen blanking support

2021-04-21 Thread Takashi Iwai
On Wed, 21 Apr 2021 09:19:42 +0200, Gerd Hoffmann wrote: > > > > However, a tricky part is that the QEMU vga code does treat VGA_ATT_IW > > > register always as "flip-flop"; the first write is for index and the > > > second write is for the data like palette. Meanwhile, in the current > > >

Re: [PATCH] drm/bochs: Add screen blanking support

2021-04-21 Thread Takashi Iwai
On Tue, 20 Apr 2021 19:47:31 +0200, Thomas Zimmermann wrote: > > Hi > > Am 20.04.21 um 18:56 schrieb Takashi Iwai: > > On bochs DRM driver, the execution of "setterm --blank force" results > > in a frozen screen instead of a blank screen. It's due to the lack

[PATCH] drm/bochs: Add screen blanking support

2021-04-20 Thread Takashi Iwai
twice at each place as well. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/bochs/bochs_hw.c | 13 - drivers/gpu/drm/bochs/bochs_kms.c | 8 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.

Re: [PATCH] drm: Fix fbcon blank on QEMU graphics drivers

2021-04-20 Thread Takashi Iwai
On Fri, 16 Apr 2021 20:30:05 +0200, Daniel Vetter wrote: > > On Fri, Apr 16, 2021 at 2:53 PM Takashi Iwai wrote: > > > > Currently the DRM fbcon helper for console blank, > > drm_fb_helper_blank(), simply calls drm_fb_helper_dpms() and always > > returns zero

[PATCH] drm: Fix fbcon blank on QEMU graphics drivers

2021-04-16 Thread Takashi Iwai
.@suse.de/ BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1095700 Signed-off-by: Takashi Iwai --- Here I whip a dead horse again, revisiting the long-standing issue stated in the previous patch set in 2017: https://lore.kernel.org/dri-devel/20170726205636.19144-1-ti...@suse.de/ I thought t

Re: [PATCH v4] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-25 Thread Takashi Iwai
On Thu, 25 Feb 2021 08:57:14 +0100, Thomas Zimmermann wrote: > > Hi > > Am 24.02.21 um 16:21 schrieb Alan Stern: > > On Wed, Feb 24, 2021 at 10:23:04AM +0100, Thomas Zimmermann wrote: > >> USB devices cannot perform DMA and hence have no dma_mask set in their > >> device structure. Therefore

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Takashi Iwai
On Tue, 23 Feb 2021 17:00:54 +0100, Alan Stern wrote: > > On Tue, Feb 23, 2021 at 03:06:07PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 23.02.21 um 14:44 schrieb Takashi Iwai: > > > > Aside from the discussion whether this "workaround" is

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Takashi Iwai
On Tue, 23 Feb 2021 11:58:42 +0100, Thomas Zimmermann wrote: > > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Importing dmabuf into a USB-based driver fails, which > break joining and mirroring of display in X11. > > For USB devices, pick the

Re: [PATCH 1/2] drm/amd/display: Fix the brightness read via aux

2021-02-06 Thread Takashi Iwai
On Fri, 05 Feb 2021 17:36:44 +0100, Alex Deucher wrote: > > On Wed, Feb 3, 2021 at 7:42 AM Takashi Iwai wrote: > > > > The current code tries to read the brightness value via > > dc_link_get_backlight_level() no matter whether it's controlled via > > aux or not, and

Re: [PATCH 2/2] drm/amd/display: Add aux_backlight module option

2021-02-06 Thread Takashi Iwai
On Fri, 05 Feb 2021 17:34:36 +0100, Alex Deucher wrote: > > On Wed, Feb 3, 2021 at 7:42 AM Takashi Iwai wrote: > > > > There seem devices that don't work with the aux channel backlight > > control. For allowing such users to test with the other backlight > > contro

[PATCH 0/2] drm/amd/display: some backlight fixes

2021-02-03 Thread Takashi Iwai
control. It's no direct solution for the bug we've hit, but it gives at least a workaround. BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1180749 BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1438 thanks, Takashi === Takashi Iwai (2): drm/amd/display: Fix the brightness

[PATCH 2/2] drm/amd/display: Add aux_backlight module option

2021-02-03 Thread Takashi Iwai
is detected by the hardware capability. BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1180749 BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1438 Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

[PATCH 1/2] drm/amd/display: Fix the brightness read via aux

2021-02-03 Thread Takashi Iwai
://bugzilla.opensuse.org/show_bug.cgi?id=1180749 BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1438 Signed-off-by: Takashi Iwai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

Re: [PATCH v3 4/5] amba: Make the remove callback return void

2021-01-26 Thread Takashi Iwai
al/amba-pl011.c| 3 +-- > drivers/vfio/platform/vfio_amba.c | 3 +-- > drivers/video/fbdev/amba-clcd.c| 4 +--- > drivers/watchdog/sp805_wdt.c | 4 +--- > include/linux/amba/bus.h

Re: [PATCH] drm/vc4: Unify PCM card's driver_name

2021-01-16 Thread Takashi Iwai
t; In order to avoid this, set "card->driver_name" to "vc4-hdmi" > unanimously. > > Signed-off-by: Nicolas Saenz Julienne > Fixes: f437bc1ec731 ("drm/vc4: drv: Support BCM2711") Looks good to me. Reviewed-by: Takashi Iwai thanks, Takashi > --- >

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-12-02 Thread Takashi Iwai
On Wed, 02 Dec 2020 13:14:06 +0100, Michael Ellerman wrote: > > Uwe Kleine-König writes: > > Hello Michael, > > > > On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote: > >> On Thu, 26 Nov 2020 17:59:50 +0100, > >> Uwe Kleine-König wro

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-11-28 Thread Takashi Iwai
; accordingly. > > Signed-off-by: Uwe Kleine-König For the sound bit: Acked-by: Takashi Iwai thanks, Takashi > --- > arch/powerpc/include/asm/ps3.h | 4 ++-- > arch/powerpc/platforms/ps3/system-bus.c | 5 ++--- > drivers/block/ps3disk.c

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

2020-11-28 Thread Takashi Iwai
On Thu, 26 Nov 2020 17:59:49 +0100, Uwe Kleine-König wrote: > > The remove callback is only called for devices that were probed > successfully before. As the matching probe function cannot complete > without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to > check this here. > >

Re: [PATCH 2/8] ALSA: pcm: use krealloc_array()

2020-10-27 Thread Takashi Iwai
On Tue, 27 Oct 2020 13:17:19 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Use the helper that checks for overflows internally instead of manually > calculating the size of the new array. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: T

Re: [PATCH] drm/vc4: hdmi: Avoid sleeping in atomic context

2020-10-27 Thread Takashi Iwai
ixes: bb7d78568814 ("drm/vc4: Add HDMI audio support") > Suggested-by: Mark Brown > Signed-off-by: Maxime Ripard Reviewed-by: Takashi Iwai thanks, Takashi > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

[PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint

2020-10-23 Thread Takashi Iwai
Hi, the amdgpu driver's ASSERT_CRITICAL() macro calls the kgdb_breakpoing() even if no debug option is set, and this leads to a kernel panic on distro kernels. The first two patches are the oneliner fixes for those, while the last one is the cleanup of those debug macros. Takashi === Takashi

[PATCH 3/3] drm/amd/display: Clean up debug macros

2020-10-23 Thread Takashi Iwai
. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/display/Kconfig | 1 + drivers/gpu/drm/amd/display/dc/os_types.h | 33 +++ 2 files changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display

[PATCH 2/3] drm/amd/display: Don't invoke kgdb_breakpoint() unconditionally

2020-10-23 Thread Takashi Iwai
, make the kgdb_breakpoint() call only when CONFIG_DEBUG_KERNEL_DC is set. https://bugzilla.opensuse.org/show_bug.cgi?id=1177973 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/display/dc/os_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd

[PATCH 1/3] drm/amd/display: Fix kernel panic by dal_gpio_open() error

2020-10-23 Thread Takashi Iwai
(), for allowing the debugging, instead. BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1177973 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio

Re: [PATCH] ALSA: hda/i915 - fix list corruption with concurrent probes

2020-10-09 Thread Takashi Iwai
On Tue, 06 Oct 2020 18:17:22 +0200, Kai Vehmanen wrote: > > From: Takashi Iwai > > Current hdac_i915 uses a static completion instance to wait > for i915 driver to complete the component bind. > > This design is not safe if multiple HDA controllers are active and > comm

Re: [PATCH trivial 5/6] ALSA: Fix misspellings of "Analog Devices"

2020-04-17 Thread Takashi Iwai
On Thu, 16 Apr 2020 12:30:57 +0200, Geert Uytterhoeven wrote: > > According to https://www.analog.com/, the company name is spelled > "Analog Devices". > > Signed-off-by: Geert Uytterhoeven Applied this patch to sound git tree for-next branch. thanks, Takashi > --- >

[PATCH] drm/nouveau: Fix regression by audio component transition

2020-04-16 Thread Takashi Iwai
udio regression. Fixes: 742db30c4ee6 ("drm/nouveau: Add HD-audio component notifier support") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207223 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 16 ++-- 1 file changed, 10 insertions(+), 6 delet

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Takashi Iwai
On Wed, 01 Apr 2020 12:35:16 +0200, Michael Ellerman wrote: > > Michal Simek writes: > > On 01. 04. 20 4:07, Michael Ellerman wrote: > >> Michal Simek writes: > >>> Hi, > >>> > >>> recently we wanted to update xilinx intc driver and we found that function > >>> which we wanted to remove is

Re: [PATCH 0/3] video: Use scnprintf() for avoiding potential buffer overflow

2020-03-27 Thread Takashi Iwai
On Fri, 20 Mar 2020 14:42:51 +0100, Bartlomiej Zolnierkiewicz wrote: > > > On 3/19/20 4:49 PM, Takashi Iwai wrote: > > On Wed, 11 Mar 2020 10:32:27 +0100, > > Takashi Iwai wrote: > >> > >> Hi, > >> > >> here is a series of trivial

Re: [PATCH] drm: sysfs: Use scnprintf() for avoiding potential buffer overflow

2020-03-11 Thread Takashi Iwai
On Wed, 11 Mar 2020 09:10:56 +0100, Thomas Zimmermann wrote: > > Hi Takashi > > Am 11.03.20 um 08:35 schrieb Takashi Iwai: > > Since snprintf() returns the would-be-output size instead of the > > actual output size, the succeeding calls may go beyond the give

Re: [PATCH] drm/ttm: Use scnprintf() for avoiding potential buffer overflow

2020-03-11 Thread Takashi Iwai
On Wed, 11 Mar 2020 08:56:11 +0100, Christian K6nig wrote: > > Am 11.03.20 um 08:52 schrieb Huang Rui: > > On Wed, Mar 11, 2020 at 03:34:52PM +0800, Takashi Iwai wrote: > >> Since snprintf() returns the would-be-output size instead of the > >> actual output siz

[PATCH] drm: sysfs: Use scnprintf() for avoiding potential buffer overflow

2020-03-11 Thread Takashi Iwai
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Signed-off-by: Takashi Iwai --- drivers/gpu/drm/drm_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] drm/ttm: Use scnprintf() for avoiding potential buffer overflow

2020-03-11 Thread Takashi Iwai
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Signed-off-by: Takashi Iwai --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 2 +- 1 file changed, 1 insertion

[PATCH RESEND] drm/nouveau: Add HD-audio component notifier support

2020-01-13 Thread Takashi Iwai
->index number is passed directly as the zero-based port number. The bind and unbind callbacks handle the device-link so that it assures the PM call order. Link: https://lore.kernel.org/r/20190722143815.7339-3-ti...@suse.de Reviewed-by: Lyude Paul Cc: Jaroslav Kysela Signed-off-by: Takashi I

Re: [PATCH for-5.6 0/2] drm/bridge: dw-hdmi: PCM API updates

2020-01-09 Thread Takashi Iwai
On Tue, 10 Dec 2019 16:45:34 +0100, Takashi Iwai wrote: > > Hi, > > this is a patch set for updating ALSA PCM API usages in dw-hdmi > driver. I already tried to "fix" the driver some time ago but it was > utterly wrong. So this is a combination of the revised patch

Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2020-01-04 Thread Takashi Iwai
, 2019-07-22 at 16:38 +0200, Takashi Iwai wrote: > > This patch adds the support for the notification of HD-audio hotplug > > via the already existing drm_audio_component framework. This allows > > us more reliable hotplug notification and ELD transfer without > > accessin

Re: [Regression drm-tip] Internal audio device missing

2019-12-26 Thread Takashi Iwai
On Thu, 26 Dec 2019 15:41:34 +0100, Paul Menzel wrote: > > Dear Takashi, > > > Am 26.12.19 um 11:03 schrieb Takashi Iwai: > > On Thu, 26 Dec 2019 10:47:18 +0100, Paul Menzel wrote: > > >> With > >> > >> $ git describe --tags dr

Re: [Regression drm-tip] Internal audio device missing

2019-12-26 Thread Takashi Iwai
ct of the recent protocol version bump in sound.git for-next branch. It seems that we can't change the minor version unless we really want to break something. Below is the fix patch. Please give it a try. thanks, Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: control: Fix

[PATCH for-5.6 2/2] drm/bridge: dw-hdmi: Drop superfluous ioctl PCM ops

2019-12-10 Thread Takashi Iwai
PCM core deals the empty ioctl field now as default. Let's kill the redundant lines. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm

[PATCH for-5.6 0/2] drm/bridge: dw-hdmi: PCM API updates

2019-12-10 Thread Takashi Iwai
The second one is a oneliner patch just to remove the superfluous PCM ops. Both need the ALSA PCM core changes in 5.5-rc1, so please apply them on top of 5.5-rc1 or later. Or, just let me know if I should apply them through sound git tree. thanks, Takashi === Takashi Iwai (2): drm/bridg

[PATCH for-5.6 1/2] drm/bridge: dw-hdmi: Follow the standard ALSA memalloc way

2019-12-10 Thread Takashi Iwai
the new snd_pcm_set_managed_buffer*() helper - The hw_params and hw_free callbacks are removed as they become superfluous with the new API Also the hw_constraint call is corrected to point to the right unit (bytes) instead of the frame size. Signed-off-by: Takashi Iwai --- .../gpu/drm

Re: Incorrect buffer handling in dw-hdmi bridge audio

2019-11-05 Thread Takashi Iwai
On Tue, 05 Nov 2019 18:02:03 +0100, Russell King - ARM Linux admin wrote: > > On Tue, Nov 05, 2019 at 05:44:26PM +0100, Takashi Iwai wrote: > > On Tue, 05 Nov 2019 17:33:44 +0100, > > Takashi Iwai wrote: > > > > > > On Tue, 05 Nov 2019 17:02:15 +0100, > &

Re: Incorrect buffer handling in dw-hdmi bridge audio

2019-11-05 Thread Takashi Iwai
On Tue, 05 Nov 2019 17:33:44 +0100, Takashi Iwai wrote: > > On Tue, 05 Nov 2019 17:02:15 +0100, > Russell King - ARM Linux admin wrote: > > > > On Tue, Nov 05, 2019 at 09:07:43AM +0100, Neil Armstrong wrote: > > > Hi, > > > > > > On

Re: Incorrect buffer handling in dw-hdmi bridge audio

2019-11-05 Thread Takashi Iwai
On Tue, 05 Nov 2019 17:02:15 +0100, Russell King - ARM Linux admin wrote: > > On Tue, Nov 05, 2019 at 09:07:43AM +0100, Neil Armstrong wrote: > > Hi, > > > > On 05/11/2019 08:55, Takashi Iwai wrote: > > > Hi, > > > > > > while recently

Incorrect buffer handling in dw-hdmi bridge audio

2019-11-04 Thread Takashi Iwai
and this is involved, I'd like to take the fix through my tree once after it's confirmed (and get ACK if possible). Thanks! Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] drm/bridge: dw-hdmi: Fix the incorrect buffer allocations The driver sets up the buffer preallocat

Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-08-27 Thread Takashi Iwai
On Mon, 22 Jul 2019 16:38:15 +0200, Takashi Iwai wrote: > > This patch adds the support for the notification of HD-audio hotplug > via the already existing drm_audio_component framework. This allows > us more reliable hotplug notification and ELD transfer without > accessing HD-

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Takashi Iwai
On Thu, 15 Aug 2019 18:19:52 +0200, wrote: > > > -Original Message- > > From: Takashi Iwai > > Sent: Thursday, August 15, 2019 9:57 AM > > To: Alex Deucher > > Cc: Karol Herbst; Limonciello, Mario; nouveau; Rafael J . Wysocki; LKML; > > dri-devel;

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Takashi Iwai
On Thu, 15 Aug 2019 16:37:05 +0200, Alex Deucher wrote: > > On Thu, Aug 15, 2019 at 10:25 AM Karol Herbst wrote: > > > > On Thu, Aug 15, 2019 at 4:20 PM wrote: > > > > > > > > There are definitely going to be regressions on machines in the field > > > > > with the > > > > > in tree drivers by

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 17:38:36 +0200, Koenig, Christian wrote: > > Am 22.07.19 um 17:21 schrieb Takashi Iwai: > > On Mon, 22 Jul 2019 17:07:09 +0200, > > Koenig, Christian wrote: > >> Am 22.07.19 um 16:53 schrieb Takashi Iwai: > >>> On Mon, 22 Jul 2019 16:44:

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 17:35:09 +0200, Alex Deucher wrote: > > On Mon, Jul 22, 2019 at 11:21 AM Takashi Iwai wrote: > > > > On Mon, 22 Jul 2019 17:07:09 +0200, > > Koenig, Christian wrote: > > > > > > Am 22.07.19 um 16:53 schrieb Takashi Iwai:

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 17:07:09 +0200, Koenig, Christian wrote: > > Am 22.07.19 um 16:53 schrieb Takashi Iwai: > > On Mon, 22 Jul 2019 16:44:06 +0200, > > Koenig, Christian wrote: > >> Am 22.07.19 um 16:38 schrieb Takashi Iwai: > >>> This patch adds the s

Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 17:00:15 +0200, Ilia Mirkin wrote: > > On Mon, Jul 22, 2019 at 10:38 AM Takashi Iwai wrote: > > +static void > > +nv50_audio_component_init(struct nouveau_drm *drm) > > +{ > > + if (!component_add(drm->dev->dev, _audio_componen

Re: [PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 16:44:06 +0200, Koenig, Christian wrote: > > Am 22.07.19 um 16:38 schrieb Takashi Iwai: > > This patch adds the support for the notification of HD-audio hotplug > > via the already existing drm_audio_component framework to radeon > > driver. This

[PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
->index number is passed directly as the zero-based port number. The bind and unbind callbacks handle the device-link so that it assures the PM call order. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/nouveau/Kconfig | 1 + drivers/gpu/drm/nouveau/dispnv50/disp.c |

[PATCH 0/2] Audio component support for radeon and nouveau

2019-07-22 Thread Takashi Iwai
:) thanks, Takashi === Takashi Iwai (2): drm/radeon: Add HD-audio component notifier support drm/nouveau: Add HD-audio component notifier support drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/nouveau/Kconfig | 1 + drivers/gpu/drm/nouveau/dispnv50/disp.c | 111

[PATCH 1/2] drm/radeon: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
ack, and the corresponding connector is looked through the encoder list in the get_eld callback in turn. The bind and unbind callbacks handle the device-link so that it assures the PM call order. Acked-by: Jim Qu Signed-off-by: Takashi Iwai --- drivers/gpu/drm/Kconfig | 1 + driv

Re: [alsa-devel] Linking ALSA playback devices and DRM connectors

2019-06-11 Thread Takashi Iwai
On Tue, 04 Jun 2019 18:25:53 +0200, Ville Syrjälä wrote: > > On Tue, Jun 04, 2019 at 05:24:35PM +0200, Daniel Vetter wrote: > > On Tue, Jun 4, 2019 at 5:15 PM Christian König > > wrote: > > > > > > Am 04.06.19 um 17:05 schrieb Ser, Simon: > > > > Hi, > > > > > > > > I'm trying to link ALSA

Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data

2019-03-13 Thread Takashi Iwai
On Tue, 05 Mar 2019 20:36:38 +0100, Ville Syrjälä wrote: > > On Tue, Mar 05, 2019 at 02:21:04PM -0500, Alex Deucher wrote: > > On Tue, Mar 5, 2019 at 2:15 PM Ville Syrjälä > > wrote: > > > > > > On Tue, Mar 05, 2019 at 05:24:13PM +0200, Ville Syrjälä wrote: > > > > On Tue, Mar 05, 2019 at

Re: [PULL] topic/component-typed

2019-02-11 Thread Takashi Iwai
On Mon, 11 Feb 2019 19:25:12 +0100, Sam Ravnborg wrote: > > Hi Daniel. > > On Mon, Feb 11, 2019 at 06:15:20PM +0100, Daniel Vetter wrote: > > Hi all, > > > > Here's the typed component topic branch. > > > > drm-intel maintainers: Please pull, I need this for the mei hdcp work from > > Ram. >

Re: [PATCH v10 02/40] i915/snd_hdac: I915 subcomponent for the snd_hdac

2019-02-04 Thread Takashi Iwai
Daniel Vetter > > Signed-off-by: Ramalingam C > > cc: Greg Kroah-Hartman > > cc: Russell King > > cc: Rafael J. Wysocki > > cc: Jaroslav Kysela > > cc: Takashi Iwai > > cc: Rodrigo Vivi > > cc: Jani Nikula > > Takashi, can you pls take

Re: [alsa-devel] [Xen-devel][PATCH v2 3/3] ALSA: xen-front: Use Xen common shared buffer implementation

2018-12-03 Thread Takashi Iwai
ound bits, Reviewed-by: Takashi Iwai I suppose the whole patchset will be taken through xen or other tree? thanks, Takashi ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [alsa-devel] [Xen-devel][PATCH 3/3] ALSA: xen-front: Use Xen common shared buffer implementation

2018-11-22 Thread Takashi Iwai
On Thu, 22 Nov 2018 11:02:30 +0100, Oleksandr Andrushchenko wrote: > > @@ -214,12 +221,19 @@ static void stream_clear(struct > xen_snd_front_pcm_stream_info *stream) > stream->out_frames = 0; > atomic_set(>hw_ptr, 0); > xen_snd_front_evtchnl_pair_clear(stream->evt_pair); > -

[PATCH] drm/amdgpu: Add missing firmware entry for HAINAN

2018-11-19 Thread Takashi Iwai
Due to lack of MODULE_FIRMWARE() with hainan_mc.bin, the driver doesn't work properly in initrd. Let's add it. Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1116239 Fixes: 8eaf2b1faaf4 ("drm/amdgpu: switch firmware path for SI parts") Cc: Signed-off-by: Takashi Iwai --- drive

Re: [Nouveau] [PATCH] drm/nouveau: Don't disable polling in fallback mode

2018-11-14 Thread Takashi Iwai
On Fri, 14 Sep 2018 13:59:25 +0200, Martin Peres wrote: > > On 14/09/2018 10:28, Ben Skeggs wrote: > > On Wed, 12 Sep 2018 at 20:59, Takashi Iwai wrote: > >> > >> When a fan is controlled via linear fallback without cstate, we > >> shouldn't stop polling

Re: Performance regression in ast drm driver

2018-11-12 Thread Takashi Iwai
On Mon, 12 Nov 2018 15:36:07 +0100, Jean Delvare wrote: > > Hi David, > > On Fri, 2018-11-09 at 10:04 +1000, David Airlie wrote: > > On Thu, Nov 8, 2018 at 10:05 PM Jean Delvare wrote: > > > > > > On Thu, 1 Nov 2018 16:27:07 +0100, Jean Delvare wrote: > > > > Hi David, > > > > > > > > The

Re: [PATCH] vga_switcheroo: Fix missing gpu_bound call at audio client registration

2018-11-05 Thread Takashi Iwai
On Mon, 05 Nov 2018 14:38:42 +0100, Lukas Wunner wrote: > > On Mon, Nov 05, 2018 at 02:11:06PM +0100, Takashi Iwai wrote: > > On Mon, 05 Nov 2018 13:59:37 +0100, Lukas Wunner wrote: > > > On Mon, Nov 05, 2018 at 01:51:23PM +0100, Takashi Iwai wrote: > > > > O

Re: [PATCH] vga_switcheroo: Fix missing gpu_bound call at audio client registration

2018-11-05 Thread Takashi Iwai
On Mon, 05 Nov 2018 13:59:37 +0100, Lukas Wunner wrote: > > On Mon, Nov 05, 2018 at 01:51:23PM +0100, Takashi Iwai wrote: > > On Mon, 05 Nov 2018 12:55:17 +0100, Lukas Wunner wrote: > > > On Mon, Nov 05, 2018 at 12:02:53PM +0100, Takashi Iwai wrote: > > >

Re: [PATCH] vga_switcheroo: Fix missing gpu_bound call at audio client registration

2018-11-05 Thread Takashi Iwai
On Mon, 05 Nov 2018 12:55:17 +0100, Lukas Wunner wrote: > > On Mon, Nov 05, 2018 at 12:02:53PM +0100, Takashi Iwai wrote: > > The commit 37a3a98ef601 ("ALSA: hda - Enable runtime PM only for > > discrete GPU") added a new ops gpu_bound to be called when GPU gets >

[PATCH] vga_switcheroo: Fix missing gpu_bound call at audio client registration

2018-11-05 Thread Takashi Iwai
bug.cgi?id=201615 Fixes: 37a3a98ef601 ("ALSA: hda - Enable runtime PM only for discrete GPU") Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/vga/vga_switcheroo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga/vga_switcheroo.

Re: [alsa-devel] [PATCH 4/8] sound: hpios: don't pass GFP_DMA32 to dma_alloc_coherent

2018-10-13 Thread Takashi Iwai
On Sat, 13 Oct 2018 18:35:40 +0200, Christoph Hellwig wrote: > > On Sat, Oct 13, 2018 at 06:18:28PM +0200, Takashi Iwai wrote: > > On Sat, 13 Oct 2018 17:17:03 +0200, > > Christoph Hellwig wrote: > > > > > > The DMA API does its own zone deci

Re: [alsa-devel] [PATCH 5/8] sound: intel/sst: don't pass GFP_DMA32 to dma_alloc_coherent

2018-10-13 Thread Takashi Iwai
On Sat, 13 Oct 2018 17:17:04 +0200, Christoph Hellwig wrote: > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > Signed-off-by: Christoph Hellwig Reviewed-by: Takashi Iwai thanks, Takashi > --- > sound/soc/intel/common/sst-firmware.c | 2 +-

Re: [alsa-devel] [PATCH 4/8] sound: hpios: don't pass GFP_DMA32 to dma_alloc_coherent

2018-10-13 Thread Takashi Iwai
On Sat, 13 Oct 2018 17:17:03 +0200, Christoph Hellwig wrote: > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > Signed-off-by: Christoph Hellwig Reviewed-by: Takashi Iwai Would you like to take this as a series, or shall I take individually throug

Re: i915, HDMI/DP audio with multiple monitors

2018-09-13 Thread Takashi Iwai
On Thu, 13 Sep 2018 09:25:37 +0200, Bruno Prémont wrote: > > On Wed, 12 Sep 2018 20:06:43 +0200 Takashi Iwai wrote: > > On Wed, 12 Sep 2018 19:46:58 +0200, > > Ville Syrjälä wrote: > > > > > > On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote:

Re: [PATCH v2] ALSA: hda - Enable runtime PM only for discrete GPU

2018-09-13 Thread Takashi Iwai
On Thu, 13 Sep 2018 15:58:13 +0200, Lukas Wunner wrote: > > On Thu, Sep 13, 2018 at 03:35:36PM +0200, Takashi Iwai wrote: > > On Thu, 13 Sep 2018 15:27:16 +0200, Jian-Hong Pan wrote: > > > 2018-09-13 14:56 GMT+08:00 Takashi Iwai : > > > > The recent change of vga_

Re: i915, HDMI/DP audio with multiple monitors

2018-09-12 Thread Takashi Iwai
On Wed, 12 Sep 2018 19:46:58 +0200, Ville Syrjälä wrote: > > On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote: > > Hi, > > > > I have a system with multiple monitors and would like to send > > notification sounds to the monitor on which corresponding > > window is visible. > > > >

[PATCH] drm/nouveau: Don't disable polling in fallback mode

2018-09-12 Thread Takashi Iwai
lla: https://bugzilla.suse.com/show_bug.cgi?id=1103356 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107447 Reported-by: Thomas Blume Signed-off-by: Takashi Iwai --- drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: y4T�TCH 4/4] drm/amdgpu: Add audio component support

2018-07-25 Thread Takashi Iwai
On Wed, 25 Jul 2018 10:02:34 +0200, jimqu wrote: > > > > On 2018年07月25日 13:46, Takashi Iwai wrote: > > On Wed, 25 Jul 2018 07:38:37 +0200, > > Qu, Jim wrote: > >> Jim: Just like Alex said, we want driver can get eld info when hotplug in > >> new devi

Re: 答复: [PATCH 4/4] drm/amdgpu: Add audio component support

2018-07-24 Thread Takashi Iwai
On Wed, 25 Jul 2018 07:38:37 +0200, Qu, Jim wrote: > > Jim: Just like Alex said, we want driver can get eld info when hotplug in new > device. amdgpu driver is a bit difference from radeon driver, it is not a > suitable place to call notify() function in *_audio_enable() , since they are > not

Re: 答复: [PATCH 3/4] drm/radeon: Add audio component support

2018-07-24 Thread Takashi Iwai
On Wed, 25 Jul 2018 05:32:52 +0200, Qu, Jim wrote: > @@ -269,6 +271,10 @@ static void radeon_audio_enable(struct radeon_device > *rdev, > > if (rdev->audio.funcs->enable) > rdev->audio.funcs->enable(rdev, pin, enable_mask); > + > + if (acomp && acomp->audio_ops &&

Re: [PATCH 0/4] drm_audio_component support for AMD/ATI HDMI codecs

2018-07-23 Thread Takashi Iwai
On Mon, 23 Jul 2018 22:53:08 +0200, Alex Deucher wrote: > > On Mon, Jul 23, 2018 at 10:50 AM, Takashi Iwai wrote: > > Hi, > > > > this is a patch set to add the support of drm_audio_component for > > AMD/ATI HDMI codecs. With the drm_audio_component, the HDMI/DP

[PATCH 3/4] drm/radeon: Add audio component support

2018-07-23 Thread Takashi Iwai
->eld contents. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/radeon/radeon.h | 3 + drivers/gpu/drm/radeon/radeon_audio.c | 79 +++ 3 files changed, 83 insertions(+) diff --git a/drivers/gpu/drm/Kconfig b/drivers/

[PATCH 1/4] ALSA: hda/hdmi: Use single mutex unlock in error paths

2018-07-23 Thread Takashi Iwai
for further changes. Signed-off-by: Takashi Iwai --- sound/pci/hda/patch_hdmi.c | 67 +++--- 1 file changed, 33 insertions(+), 34 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 1de5491fb9bf..6750318d1c82 100644 --- a/sound/pci/hda

[PATCH 4/4] drm/amdgpu: Add audio component support

2018-07-23 Thread Takashi Iwai
the connector->eld contents. This patch currently doesn't contain the component support for the new DC codes yet. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + driv

[PATCH 0/4] drm_audio_component support for AMD/ATI HDMI codecs

2018-07-23 Thread Takashi Iwai
=== Takashi Iwai (4): ALSA: hda/hdmi: Use single mutex unlock in error paths ALSA: hda/hdmi: Allow audio component for AMD/ATI HDMI drm/radeon: Add audio component support drm/amdgpu: Add audio component support drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/amd/amdgpu

[PATCH 2/4] ALSA: hda/hdmi: Allow audio component for AMD/ATI HDMI

2018-07-23 Thread Takashi Iwai
component in radeon and amdgpu DRM driver sides isn't implemented yet, so this change won't give any benefit alone. By the following changes in DRM sides, the mission will be completed. Signed-off-by: Takashi Iwai --- sound/pci/hda/patch_hdmi.c | 142 + 1 file

[PATCH] ALSA: hda/i915: Allow delayed i915 audio component binding

2018-07-22 Thread Takashi Iwai
registration. For addressing it, implement a completion to be synced with the master binding. The timeout is set to 10 seconds which should be long enough and hopefully be not too annoying if anyone boots up a debugging session with i915 KMS turned off. Signed-off-by: Takashi Iwai --- This is applied

Re: [alsa-devel] [PATCH v2 0/3] Make the audio component binding more generic

2018-07-19 Thread Takashi Iwai
On Thu, 19 Jul 2018 15:05:45 +0200, Pierre-Louis Bossart wrote: > > On 7/19/18 12:50 AM, Takashi Iwai wrote: > > On Wed, 18 Jul 2018 22:54:35 +0200, > > Pierre-Louis Bossart wrote: > >> > >> > >> > >> On 07/17/2018 04:26 AM, Takashi Iwai wro

Re: [alsa-devel] [PATCH v2 0/3] Make the audio component binding more generic

2018-07-18 Thread Takashi Iwai
On Wed, 18 Jul 2018 22:54:35 +0200, Pierre-Louis Bossart wrote: > > > > On 07/17/2018 04:26 AM, Takashi Iwai wrote: > > Hi, > > > > this is a preliminiary patch set to convert the existing i915 / > > HD-audio component binding to be applicable to ot

[PATCH v2 0/3] Make the audio component binding more generic

2018-07-17 Thread Takashi Iwai
know if anyone has concerns. Thanks! Takashi === v1->v2: * Change to SPDX for the new drm_audio_component.h * Fix remaining i915 word in drm_audio_component.h comments * Fix NULL dereference in master_bind / _unbind ops === Takashi Iwai (3): drm/i915: Split audio component to a gene

[PATCH v2 3/3] ALSA: hda: Make audio component support more generic

2018-07-17 Thread Takashi Iwai
;v2: Fix missing NULL check in master_bind/unbind Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/Kconfig | 1 + include/drm/drm_audio_component.h | 23 ++ include/sound/hda_component.h | 61 ++ include/sound/hda_i915.h | 39 +--- sound/hda/Kconfig |

[PATCH v2 2/3] ALSA: hda/i915: Associate audio component with devres

2018-07-17 Thread Takashi Iwai
, the corresponding code is removed by passing hdac_bus object to the function, too. Signed-off-by: Takashi Iwai --- include/sound/hda_i915.h | 6 -- sound/hda/hdac_i915.c| 34 +- sound/pci/hda/patch_hdmi.c | 5 +++-- sound/soc/codecs/hdac_hdmi.c | 2 +- 4

[PATCH v2 1/3] drm/i915: Split audio component to a generic type

2018-07-17 Thread Takashi Iwai
915 argument in drm_audio_component.h Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_audio.c | 22 +++ include/drm/drm_audio_component.h | 95 ++ include/drm/i915_component.h | 85 ++ include/sound/hda_i915.h |

Re: [V3] vga_switcheroo: set audio client id according to bound GPU id

2018-07-17 Thread Takashi Iwai
On Tue, 17 Jul 2018 10:56:37 +0200, jimqu wrote: > > > > On 2018年07月17日 16:52, Takashi Iwai wrote: > > On Tue, 17 Jul 2018 10:38:58 +0200, > > Lukas Wunner wrote: > >> On Tue, Jul 17, 2018 at 04:20:50PM +0800, Jim Qu wrote: > >>> On modern laptop,

<    1   2   3   4   5   6   7   >