[PATCH 15/86] drm/ili9163: Run DRM default client setup

Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/ili9163.c | 4 +++- 1 file changed, 3 insertions(+), 1 del

[PATCH 06/86] drm/arcgpu: Run DRM default client setup

Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Alexey Brodkin --- drivers/gpu/drm/tiny/arcpgu.c | 4 +++- 1 file chang

[PATCH 00/86] drm: Provide client setup helper and convert drivers

devel/20240801100640.462606-4-jfale...@redhat.com/ [2] https://lists.freedesktop.org/archives/dri-devel/2019-March/212113.html Thomas Zimmermann (86): drm/fbdev-helper: Move color-mode lookup into 4CC format helper drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info drm/fbdev: Add m

[PATCH 04/86] drm: Add client-agnostic setup helper

on is currently supported. Later versions can add support for DRM-based logging, a boot logo or even a console. Some drivers handle the color mode for clients internally. Provide the helper drm_client_setup_with_color_mode() for them. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Mak

[PATCH 05/86] drm/fbdev-dma: Support struct drm_driver.fbdev_probe

- based DRM drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_dma.c | 60 - include/drm/drm_fbdev_dma.h | 12 +++ 2 files changed, 48 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm

[PATCH 03/86] drm/fbdev: Add memory-agnostic fbdev client

drm_fb_helper_funcs, which does the same. To use the new client, DRM drivers set fbdev_probe in their struct drm_driver instance and call drm_fbdev_client_setup(). Probing and creating the fbdev surface buffer is now independent from the other operations in struct drm_fb_helper. Signed-off-by: Thomas Zimmermann

[PATCH 08/86] drm/arm/hdlcd: Run DRM default client setup

t out entirely. Signed-off-by: Thomas Zimmermann Cc: Liviu Dudau --- drivers/gpu/drm/arm/hdlcd_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index 32be9e370049..f5d358f3893b 100644 --- a/drivers/gpu/dr

[PATCH 02/86] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info

the same as the one stored in struct drm_client and struct drm_fb_helper, so there is no difference in behavior. Some NULL-pointer checks are being removed, where those pointers cannot be NULL. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 15 +++ 1 file changed

[PATCH 01/86] drm/fbdev-helper: Move color-mode lookup into 4CC format helper

The color mode specified on the kernel command line gives the user's preferred color depth and number of bits per pixel. Move the color-mode-to-format conversion form fbdev helpers into a 4CC helper, so that is can be shared among DRM clients. Signed-off-by: Thomas Zimmermann --- driver

[PULL] drm-misc-next

tartek-kd070fhfid015: transition to mipi_dsi wrapped functions Thomas Zimmermann (18): Merge drm/drm-next into drm-misc-next drm: Do delayed switcheroo in drm_lastclose() drm/amdgpu: Do not set struct drm_driver.lastclose drm/nouveau: Do not set struct drm_driver.lastclose

Re: [PATCH 0/9] fbdev: Use backlight power constants

Ping for review Am 31.07.24 um 14:33 schrieb Thomas Zimmermann: Commit a1cacb8a8e70 ("backlight: Add BACKLIGHT_POWER_ constants for power states") introduced dedicated constants for backlight power states. Convert fbdev drivers to the new constants. The new constants replace

[PATCH v3 10/11] drm/ast: vga: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. v3: - use struct ast_connector.physical_status to handle BMC Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_vga.c | 27 +-- 1 file c

[PATCH v3 08/11] drm/ast: dp501: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. v3: - use struct ast_connector.physical_status to handle BMC Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_dp501.c | 33 + 1 file c

[PATCH v3 07/11] drm/ast: dp501: Use struct drm_edid and helpers

Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_dp501.c | 59 - 1 file changed, 22 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_dp501.c b/drivers/gpu/drm/ast/ast_dp501.c index 3904f98ef846

[PATCH v3 05/11] drm/ast: astdp: Simplify power management when detecting display

Remove the CRTC handling in the ASTDP detect_ctx helper and enable power while the detecting the display. Unconditionally wait a few milliseconds after switching power. Simplifies the code and makes it more robust. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp.c | 19

[PATCH v3 06/11] drm/ast: astdp: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. v3: - use struct ast_connector.physical_status to handle BMC Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_dp.c | 43 ++-- 1 file c

[PATCH v3 00/11] drm/ast: Transparently handle BMC in outputs

https://patchwork.freedesktop.org/series/136885/ Thomas Zimmermann (11): drm/ast: Move code for physical outputs into separate files drm/ast: Add struct ast_connector drm/ast: astdp: Move locking into EDID helper drm/ast: astdp: Use struct drm_edid and helpers drm/ast: astdp: Simplify

[PATCH v3 01/11] drm/ast: Move code for physical outputs into separate files

Move the modesetting code for the various transmitter chips into their own source files before adding BMC support. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/Makefile | 4 +- drivers/gpu/drm/ast/ast_dp.c | 214

[PATCH v3 11/11] drm/ast: Remove BMC output

handle BMC support internally. Hence, remove the driver's code and the BMC output entirely. v3: - remove struct ast_bmc_connector Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.h | 19 -- drivers/gpu/drm/ast/a

[PATCH v3 03/11] drm/ast: astdp: Move locking into EDID helper

The modeset mutex protects EDID retrival from concurrent modeset operations. Acquire the lock in ast_astdp_read_edid(). Prepares the code for conversion to struct drm_edid. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_dp.c | 24

[PATCH v3 09/11] drm/ast: sil164: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. v3: - use struct ast_connector.physical_status to handle BMC Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_sil164.c | 27 +-- 1 file c

[PATCH v3 04/11] drm/ast: astdp: Use struct drm_edid and helpers

multiple of 4 Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_dp.c | 55 +++- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_dp.c b/drivers/gpu/drm/ast/ast_dp.c index c2b08a414ae4

[PATCH v3 02/11] drm/ast: Add struct ast_connector

Add struct ast_connector to track a connector's physical status. With the upcoming BMC support, the physical status can be different from the reported status. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp.c | 7 ++- drivers/gpu/drm/ast/ast_dp501.c

[PULL] drm-misc-fixes

dmi.c | 4 +--- drivers/gpu/drm/v3d/v3d_sched.c| 14 +++--- 4 files changed, 30 insertions(+), 12 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo

Re: [PATCH 9/9] drm/tilcdc: Use backlight power constants

Am 15.08.24 um 10:07 schrieb Tomi Valkeinen: Hi, On 15/08/2024 10:59, Thomas Zimmermann wrote: Ping. This patch still needs an ack. Am 31.07.24 um 14:17 schrieb Thomas Zimmermann: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical

Re: [PATCH 9/9] drm/tilcdc: Use backlight power constants

Ping. This patch still needs an ack. Am 31.07.24 um 14:17 schrieb Thomas Zimmermann: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Jyri

Re: [PATCH] drm/hisilicon: Remove unused delarations

Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h index 207aa3f660b0..6b566f3aeecb 100644 --- a/drivers/gpu/drm/

Re: [PATCH v2 9/9] drm/ast: Remove BMC output

Hi Am 13.08.24 um 15:20 schrieb Jocelyn Falempe: On 12/08/2024 11:30, Thomas Zimmermann wrote: Ast's BMC connector tracks the status of an underlying physical connector and updates the BMC status accordingly. This functionality works around GNOME's settings app, which cannot handl

Re: [PATCH v2 5/9] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()

Hi Am 12.08.24 um 14:17 schrieb Danilo Krummrich: On 8/12/24 10:28 AM, Thomas Zimmermann wrote: Replace the call to drm_fb_helper_output_poll_changed() with a call to drm_client_dev_hotplug(). It is equivalent in functionality, but uses the DRM client infrastructure. v2: - fix commit

Re: [PATCH] video/aperture: match the pci device when calling sysfb_disable()

reen_info' csky-linux-ld: aperture.c:(.text+0x2c4): undefined reference to `screen_info_pci_dev' -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)

Re: [PATCH v3] drm/ast: astdp: fix loop timeout check

at the loop to count forwards instead of backwards. Fixes: 2281475168d2 ("drm/ast: astdp: Perform link training during atomic_enable") Signed-off-by: Dan Carpenter Reviewed-by: Thomas Zimmermann Thanks a lot for the fix. I'll merge it during the week if no other comments come in.

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

Hi Am 12.08.24 um 12:18 schrieb Daniel Vetter: On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from their lastclose callbacks. Call it from

[PATCH v2 9/9] drm/ast: Remove BMC output

handle BMC support internally. Hence, remove the driver's code and the BMC output entirely. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 4 -- drivers/gpu/drm/ast/ast_mode.c | 107 - 2 files changed, 111 deletions(-) diff --git a/

[PATCH v2 8/9] drm/ast: vga: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_vga.c | 40 +-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_vga.c b/drive

[PATCH v2 6/9] drm/ast: dp501: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp501.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_dp501.c b/drivers/g

[PATCH v2 4/9] drm/ast: astdp: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_dp.c b/drivers/gpu/drm/ast/ast_

[PATCH v2 0/9] drm/ast: Transparently handle BMC in outputs

been taken for mgag200. [1] Here a server's display hardware also contains an internal BMC that needs to display even without the presence of a physical display. v2: - fix reading EDID data on ASTDP and DP501 chips (Jocelyn) [1] https://patchwork.freedesktop.org/series/136885/ Thomas Zimmerma

[PATCH v2 3/9] drm/ast: astdp: Use struct drm_edid and helpers

multiple of 4 Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp.c | 55 +++- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_dp.c b/drivers/gpu/drm/ast/ast_dp.c index 217c155f0874..22c4f2a126e9 100644 --- a/drivers

[PATCH v2 5/9] drm/ast: dp501: Use struct drm_edid and helpers

Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp501.c | 59 - 1 file changed, 22 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_dp501.c b/drivers/gpu/drm/ast/ast_dp501.c index 478efa226170..0dc37b65e1d7 100644 --- a/drivers/gpu/drm

[PATCH v2 2/9] drm/ast: astdp: Move locking into EDID helper

The modeset mutex protects EDID retrival from concurrent modeset operations. Acquire the lock in ast_astdp_read_edid(). Prepares the code for conversion to struct drm_edid. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_dp.c | 24

[PATCH v2 1/9] drm/ast: Move code for physical outputs into separate files

Move the modesetting code for the various transmitter chips into their own source files before adding BMC support. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/Makefile | 4 +- drivers/gpu/drm/ast/ast_dp.c | 214

[PATCH v2 7/9] drm/ast: sil164: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_sil164.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_sil164.c b/d

[PATCH v2 9/9] drm: Remove struct drm_mode_config_funcs.output_poll_changed

The output_poll_changed hook in struct drm_mode_config_funcs is unused. Remove it. The helper drm_client_dev_hotplug() implements the callback's functionality. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_probe_helper.c | 10 +- includ

[PATCH v2 4/9] drm/nouveau: Do not set struct drm_mode_config_funcs.output_poll_changed

The output_poll_changed hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The client code handles display hotplugging internally. v2: - fix commit description Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/nouveau/dispnv50

[PATCH v2 3/9] drm/nouveau: Do not set struct drm_driver.lastclose

Remove the implementation of struct drm_driver.lastclose. The hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The code in nouveau_vga_lastclose() is performed by drm_lastclose(). v2: - update commit description Signed-off-by: Thomas Zimmermann --- drivers/gpu

[PATCH v2 7/9] drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed()

The function is unused. Remove it. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 15 --- include/drm/drm_fb_helper.h | 6 -- 2 files changed, 21 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index

[PATCH v2 8/9] drm: Remove struct drm_driver.lastclose

The lastclose callback in struct drm_driver is unused. Remove it. Also update documentation. v2: - update to use drm_lastclose() - fix typo in documentation Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_file.c | 28

[PATCH v2 5/9] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()

Replace the call to drm_fb_helper_output_poll_changed() with a call to drm_client_dev_hotplug(). It is equivalent in functionality, but uses the DRM client infrastructure. v2: - fix commit description Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/nouveau

[PATCH v2 6/9] drm/fbdev-helper: Update documentation on obsolete callbacks

The old callbacks lastclose and output_poll_changed are deprecated and unused. Remove them from the documentation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose

Remove the implementation of struct drm_driver.lastclose. The hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The code in amdgpu_driver_lastclose_kms() is performed by drm_lastclose(). v2: - update commit message Signed-off-by: Thomas Zimmermann --- drivers

[PATCH v2 0/9] drm/{amdgpu,nouveau}: Remove old fbdev hooks

call vga_switcheroo_process_delayed_switch() from drm_lastclose() (Sima) - documentation updates Thomas Zimmermann (9): drm: Do delayed switcheroo in drm_lastclose() drm/amdgpu: Do not set struct drm_driver.lastclose drm/nouveau: Do not set struct drm_driver.lastclose drm/nouveau: Do not set s

[PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

: - move change to drm_lastclose() (Sima) - update docs for vga_switcheroo_process_delayed_switch() Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_file.c | 4 drivers/gpu/vga/vga_switcheroo.c | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH v2] drm/ast: astdp: fix loop timeout check

Hi Am 12.08.24 um 08:54 schrieb Dan Carpenter: On Mon, Aug 12, 2024 at 08:48:16AM +0200, Thomas Zimmermann wrote: Hi Am 12.08.24 um 08:42 schrieb Dan Carpenter: This code has an issue because it loops until "i" is set to UINT_MAX but the test for failure assumes that "i"

Re: [PATCH v2] drm/ast: astdp: fix loop timeout check

quot;Link training failed\n"); + drm_err(dev, "Link training failed\n"); } void ast_dp_set_on_off(struct drm_device *dev, bool on) -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF:

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

Hi Am 09.08.24 um 19:06 schrieb Dan Carpenter: On Fri, Aug 09, 2024 at 04:43:51PM +0300, Jani Nikula wrote: On Fri, 09 Aug 2024, Thomas Zimmermann wrote: Hi, thanks a lot for the bugfix. Am 09.08.24 um 14:33 schrieb Dan Carpenter: The test for "Link training failed" expect t

Re: [PATCH] drm/ast: astdp: fix pre-op vs post-op bug

c = ast_get_index_reg(ast, AST_IO_VGACRI, 0xdc); if (vgacrdc & AST_IO_VGACRDC_LINK_SUCCESS) -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)

Re: [PATCH 3/9] drm/ast: astdp: Use struct drm_edid and helpers

Hi Am 06.08.24 um 14:51 schrieb Thomas Zimmermann: Convert ASTDP support to struct drm_edid and its helpers. Simplifies and modernizes the EDID handling. The driver reads 4 bytes at once, but the overall read length is now variable. Therefore update the EDID read loop to never return more than

Re: [PATCH 5/9] drm/ast: dp501: Use struct drm_edid and helpers

Hi Am 09.08.24 um 13:36 schrieb Jocelyn Falempe: On 06/08/2024 14:52, Thomas Zimmermann wrote: Convert DP501 support to struct drm_edid and its helpers. Simplifies and modernizes the EDID handling. The driver reads 4 bytes at once, but the overall read length is now variable. Therefore

Re: [PATCH 1/8] drm/fbdev-helper: Do delayed switcheroo in lastclose helper

Hi Am 09.08.24 um 10:44 schrieb Daniel Vetter: On Wed, Aug 07, 2024 at 10:41:33AM +0200, Thomas Zimmermann wrote: Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from their lastclose callbacks. Call it from the fbdev lastclose helper, so that the driver functions can finally be

[PULL] drm-misc-next

_node() Terry Hsiao (1): drm/panel-edp: Fix HKC MB116AN01 name Thomas Zimmermann (5): drm/mgag200: Add VGA-BMC output drm/mgag200: vga-bmc: Transparently handle BMC drm/mgag200: vga-bmc: Control CRTC VIDRST flag from encoder drm/mgag200: vga-bmc: Control BMC scanout fro

Re: [PATCH 1/9] drm/amdgpu: Use backlight power constants

Hi Am 07.08.24 um 21:47 schrieb Alex Deucher: On Tue, Aug 6, 2024 at 3:06 AM Thomas Zimmermann wrote: Hi Am 05.08.24 um 21:00 schrieb Deucher, Alexander: [Public] -Original Message- From: Thomas Zimmermann Sent: Wednesday, July 31, 2024 8:17 AM To: maarten.lankho

Re: [PATCH 0/5] drm/panic: Cleanup and add panic description

; in panic message drm/panic: Remove useless export symbols drm/panic: Move drm_panic_register prototype to drm_crtc_internal.h drm/panic: Move copyright notice to the top drm/panic: Add panic description For the whole series: Reviewed-by: Thomas Zimmermann drive

Re: [PATCH 2/2] drm/ast: Request PCI BAR with devres

a BAR. Replace pcim_iomap() with pcim_iomap_region(). Suggested-by: Thomas Zimmermann Signed-off-by: Philipp Stanner Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ast

[PATCH 6/8] drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed()

The function is unused. Remove it. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 15 --- include/drm/drm_fb_helper.h | 6 -- 2 files changed, 21 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index

[PATCH 8/8] drm: Remove struct drm_mode_config_funcs.output_poll_changed

The output_poll_changed hook in struct drm_mode_config_funcs is unused. Remove it. The helper drm_client_dev_hotplug() implements the callback's functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_probe_helper.c | 10 +- include/drm/drm_mode_config.h

[PATCH 7/8] drm: Remove struct drm_driver.lastclose

The lastclose callback in struct drm_driver is unused. Remove it. Also inline the now trivial drm_lastclose() and update documentation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_drv.c | 5 ++--- drivers/gpu/drm/drm_fb_helper.c | 18 + drivers/gpu/drm

[PATCH 4/8] drm/nouveau: Do not set struct drm_mode_config_funcs.output_poll_changed

The output_poll_changed hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The client code handles display otplugging internally. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 - drivers/gpu/drm/nouveau/nouveau_display.c | 1

[PATCH 2/8] drm/amdgpu: Do not set struct drm_driver.lastclose

Remove the implementation of struct drm_driver.lastclose. The hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The code within amdgpu_driver_lastclose_kms() is performed elsewhere in the DRM fbdev emulation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm

[PATCH 3/8] drm/nouveau: Do not set struct drm_driver.lastclose

Remove the implementation of struct drm_driver.lastclose. The hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The code within nouveau_vga_lastclose() is performed elsewhere in the DRM fbdev emulation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm

[PATCH 5/8] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()

Replace the callto drm_fb_helper_output_poll_changed() with a call to drm_client_dev_hotplug(). It's equivalent in functionality, but use the DRM client infrastructure. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nouveau_vga.c | 3 ++- 1 file changed, 2 insertions(

[PATCH 0/8] drm/{amdgpu,nouveau}: Remove old fbdev hooks

After switching all drivers' fbdev emulation to DRM client, the old fbdev hooks are now obsolete. Only amgdpu and nouveau still use them in a several places. Remove the hooks from the drivers and the DRM core. The series would ideally be merged at once via drm-misc-next. Thomas Zimmerma

[PATCH 1/8] drm/fbdev-helper: Do delayed switcheroo in lastclose helper

with enabled switcheroo do the delayed switching. The call has no effect on other drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 3f7da78849e4

[PATCH 5/9] drm/ast: dp501: Use struct drm_edid and helpers

Convert DP501 support to struct drm_edid and its helpers. Simplifies and modernizes the EDID handling. The driver reads 4 bytes at once, but the overall read length is now variable. Therefore update the EDID read loop to never return more than the requested bytes. Signed-off-by: Thomas

[PATCH 4/9] drm/ast: astdp: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_dp.c b/drivers/gpu/drm/ast/ast_

[PATCH 0/9] drm/ast: Transparently handle BMC in outputs

been taken for mgag200. [1] Here a server's display hardware also contains an internal BMC that needs to display even without the presence of a physical display. [1] https://patchwork.freedesktop.org/series/136885/ Thomas Zimmermann (9): drm/ast: Move code for physical outputs into separate

[PATCH 9/9] drm/ast: Remove BMC output

handle BMC support internally. Hence, remove the driver's code and the BMC output entirely. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 4 -- drivers/gpu/drm/ast/ast_mode.c | 107 - 2 files changed, 111 deletions(-) diff --git a/

[PATCH 7/9] drm/ast: sil164: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_sil164.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_sil164.c b/d

[PATCH 8/9] drm/ast: vga: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_vga.c | 40 +-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_vga.c b/drive

[PATCH 6/9] drm/ast: dp501: Transparently handle BMC support

will then reconfigure their output to a mode appropriate for either physical display or BMC. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp501.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_dp501.c b/drivers/g

[PATCH 3/9] drm/ast: astdp: Use struct drm_edid and helpers

support EDID extensions, as the driver actively clears any such information from the main EDID header. As the new interface allows for reading extension blocks for EDID, make sure that the block is always 0 (i.e., the main header). A later update might fix that. Signed-off-by: Thomas Zimmermann

[PATCH 2/9] drm/ast: astdp: Move locking into EDID helper

The modeset mutex protects EDID retrival from concurrent modeset operations. Acquire the lock in ast_astdp_read_edid(). Prepares the code for conversion to struct drm_edid. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp.c | 24 ++-- 1 file changed, 10

[PATCH 1/9] drm/ast: Move code for physical outputs into separate files

Move the modesetting code for the various transmitter chips into their own source files before adding BMC support. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/Makefile | 4 +- drivers/gpu/drm/ast/ast_dp.c | 214 +- drivers/gpu/drm/ast

Re: [PATCH 1/9] drm/amdgpu: Use backlight power constants

Hi Am 05.08.24 um 21:00 schrieb Deucher, Alexander: [Public] -Original Message- From: Thomas Zimmermann Sent: Wednesday, July 31, 2024 8:17 AM To: maarten.lankho...@linux.intel.com; mrip...@kernel.org; airl...@gmail.com; dan...@ffwll.ch Cc: amd-...@lists.freedesktop.org; dri-devel

[PATCH 4/5] drm/mgag200: vga-bmc: Control BMC scanout from encoder

ps scanning out the VGA signal if modeset disables the VGA encoder, and starts scanning out if the modeset enables the VGA encoder. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_g200er.c | 3 --- drivers/gpu/drm/mgag200/mgag200_g200ev.c | 3 --- drivers/

[PATCH 0/5] drm/mgag200: Handle BMC in dedicated VGA output

series also picks up an idea from an older series, [2] where BMC support is entirely transparent to the CRTC. [1] https://patchwork.freedesktop.org/series/136084/ [2] https://patchwork.freedesktop.org/series/135931/ Thomas Zimmermann (5): drm/mgag200: Add VGA-BMC output drm/mgag200: vga-bmc

[PATCH 5/5] drm/mgag200: Remove BMC output

andles BMC support internally. Hence, remove the driver's code and the BMC output entirely. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_bmc.c | 102 -- drivers/gpu/drm/mgag200/mgag200_drv.h | 10 --- drivers/gpu/drm/mgag200/mgag200_

[PATCH 3/5] drm/mgag200: vga-bmc: Control CRTC VIDRST flag from encoder

, but depends on the presence of the clock source. This is the case for some BMCs, so control the pin from the VGA-BMC output. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c| 3 --- drivers/gpu/drm/mgag200/mgag200_vga_bmc.c | 18 ++ 2 files change

[PATCH 2/5] drm/mgag200: vga-bmc: Transparently handle BMC

's display modes either come from the VGA monitor's EDID or from an internal list of BMC-compatible modes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_vga_bmc.c | 50 ++- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH 1/5] drm/mgag200: Add VGA-BMC output

Duplicate VGA output to VGA-BMC output and update all code for Matrox server chips. The new output represents a VGA output that has a BMC attached to it. No functional changes so far. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/Makefile | 1 + drivers/gpu/drm/mgag200

Re: [PATCH v2 1/1] drm/fb-helper: Don't schedule_work() to flush frame buffer during panic()

Hi Am 05.08.24 um 10:10 schrieb Zhuo, Qiuxu: Hi Thomas, From: Thomas Zimmermann Sent: Monday, August 5, 2024 3:31 PM [...] Hi Maarten and maintainers, A gentle ping :-). Could you please help push this v2 fix upstream? If you have any concerns, please let me know. I already acked this

Re: [PATCH v2 1/1] drm/fb-helper: Don't schedule_work() to flush frame buffer during panic()

...@intel.com, yudong.w...@intel.com Subject: [PATCH v2 1/1] drm/fb-helper: Don't schedule_work() to flush frame buffer during panic() [...] Acked-by: Thomas Zimmermann Reported-by: Yudong Wang Tested-by: Yudong Wang Signed-off-by: Qiuxu Zhuo Hi Maarten and maintainers, A gentle ping :-). Coul

Re: [PATCH] drm/client: Use common display mode for cloned outputs

Hi Am 02.08.24 um 10:03 schrieb Jani Nikula: On Thu, 01 Aug 2024, Thomas Zimmermann wrote: For cloned outputs, don't pick a default resolution of 1024x768 as most hardware can do better. Instead look through the modes of all connectors to find a common mode for all of them. Signed-o

Re: [PATCH v4 RESEND] drm/client: fix null pointer dereference in drm_client_modeset_probe

drm_connector_get(connector); modeset->connectors[modeset->num_connectors++] = connector; modeset->x = offset->x; -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF

Re: [PATCH v4 RESEND] drm/client: fix null pointer dereference in drm_client_modeset_probe

xes: cf13909aee05 ("drm/fb-helper: Move out modeset config code") Signed-off-by: Ma Ke Reviewed-by: Thomas Zimmermann --- Changes in v4: - modified patch, set ret and break to handle error rightly. Changes in v3: - modified patch as suggestions, returned error directly when failing t

[PATCH] drm/client: Use common display mode for cloned outputs

For cloned outputs, don't pick a default resolution of 1024x768 as most hardware can do better. Instead look through the modes of all connectors to find a common mode for all of them. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client_modeset.c | 54 +-

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

zero doesn't really work. Once KWin sets the property to zero, changing the power saving level "works" but the screen blanks for a moment (might just be a single frame) and reading from the file returns zero again, with the visuals and backlight level unchanged as well. -- -- Thomas Z

[PULL] drm-misc-next

m/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves drm/ttm: Provide a generic LRU walker helper drm/ttm: Use the LRU walker helper for swapping drm/ttm: Use the LRU walker for eviction Thomas Zimmermann (16): drm/mgag200: Only set VIDRST bits in CRTC modesett

Re: [PATCH v15 01/29] drm/connector: Introduce an HDMI connector initialization function

register(struct drm_connector *connector); void drm_connector_unregister(struct drm_connector *connector); int drm_connector_attach_encoder(struct drm_connector *connector, struct drm_encoder *encoder); -- -- Thomas Zimmermann Graphics Driver Develope

[PATCH 2/2] staging: olpc_dcon: Use backlight power constants

Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Jens Frederich Cc: Jon Nettleton Cc: Greg Kroah-Hartman --- drivers/staging/olpc

[PATCH 0/2] staging: Use backlight power constants

stems more independent from fbdev code and headers. Thomas Zimmermann (2): staging: fbtft: Use backlight power constants staging: olpc_dcon: Use backlight power constants drivers/staging/fbtft/fb_ssd1351.c| 2 +- drivers/staging/fbtft/fbtft-core.c| 6 +++--- drivers/staging

<    1   2   3   4   5   6   7   8   9   10   >