Hi,
On 03/05/2024 16:45, Ulf Hansson wrote:
+ Abel, Saravanna, Stephen
On Mon, 15 Apr 2024 at 19:17, Tomi Valkeinen
wrote:
On 15/04/2024 19:00, Tomi Valkeinen wrote:
Add a new flag, TI_SCI_PD_KEEP_BOOT_STATE, which can be set in the dts
when referring to power domains. When this flag
Hi,
On 04/05/2024 00:54, Sean Anderson wrote:
Hi,
I have discovered a bug in the displayport driver on drm-misc-next. To
trigger it, run
echo fd4a.display > /sys/bus/platform/drivers/zynqmp-dpsub/unbind
The system will become unresponsive and (after a bit) splat with a hard
LOCKUP. One
On 03/05/2024 19:27, Nathan Chancellor wrote:
Hi Tomi,
On Sat, Apr 27, 2024 at 10:48:16AM +0300, Tomi Valkeinen wrote:
On 26/04/2024 22:27, Anatoliy Klymenko wrote:
Fix number of CI reported W=1 build issues.
Patch 1/2: Fix function arguments description.
Closes:
https://lore.kernel.org/oe
On 26/04/2024 22:27, Anatoliy Klymenko wrote:
Fix number of CI reported W=1 build issues.
Patch 1/2: Fix function arguments description.
Closes:
https://lore.kernel.org/oe-kbuild-all/202404260616.kfgdpcdn-...@intel.com/
Patch 2/2: Fix clang compilation error.
Closes:
On 26/04/2024 12:30, Laurent Pinchart wrote:
On Fri, Mar 22, 2024 at 08:01:44AM +0200, Tomi Valkeinen wrote:
On 08/03/2024 22:47, Sean Anderson wrote:
We must always register the DRM bridge, since zynqmp_dp_hpd_work_func
calls drm_bridge_hpd_notify, which in turn expects hpd_mutex
On 25/04/2024 18:17, Sean Anderson wrote:
On 4/24/24 14:54, Tomi Valkeinen wrote:
Hi Sean,
On 23/04/2024 20:18, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help
On 26/04/2024 04:46, Anatoliy Klymenko wrote:
Fix W=1 clang 19 compilation error in zynqmp_disp_layer_drm_formats().
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202404260946.4ozxvhd2-...@intel.com/
---
This is missing your signed-off-by.
Tomi
Hi Sean,
On 23/04/2024 20:18, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help debug signal-integrity issues.
Last time I discussed converting the HPD work(s) to
Ripard
To: Thomas Zimmermann
To: David Airlie
To: Daniel Vetter
To: Michal Simek
To: Andrzej Hajda
To: Neil Armstrong
To: Robert Foss
To: Jonas Karlman
To: Jernej Skrabec
To: Rob Herring
To: Krzysztof Kozlowski
To: Conor Dooley
To: Mauro Carvalho Chehab
Cc: Tomi Valkeinen
Cc: dri
On 23/04/2024 20:18, Sean Anderson wrote:
Instead of polling the status register for the AUX status, just enable
the IRQs and signal a completion.
Signed-off-by: Sean Anderson
---
This one seems to cause a hang when I unload the modules. I didn't debug
it further yet, but most likely we
On 23/04/2024 23:50, Sean Anderson wrote:
Hi,
On 3/22/24 02:01, Tomi Valkeinen wrote:
Hi,
On 08/03/2024 22:47, Sean Anderson wrote:
We must always register the DRM bridge, since zynqmp_dp_hpd_work_func
calls drm_bridge_hpd_notify, which in turn expects hpd_mutex to be
initialized. We do
On 23/04/2024 17:59, Sean Anderson wrote:
On 4/23/24 09:33, Tomi Valkeinen wrote:
Hi Sean,
On 22/04/2024 21:45, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help
Hi Sean,
On 22/04/2024 21:45, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help debug signal-integrity issues.
Last time I discussed converting the HPD work(s) to
On 22/04/2024 21:45, Sean Anderson wrote:
We always call scheduled_delayed_work with no delay, so just use a
non-delayed work_struct instead.
Signed-off-by: Sean Anderson
---
Reviewed-by: Tomi Valkeinen
Tomi
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 13
On 22/04/2024 21:45, Sean Anderson wrote:
Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed
members.
Signed-off-by: Sean Anderson
---
Reviewed-by: Tomi Valkeinen
Tomi
Changes in v3:
- Split off documentation for base pointers to previous commit
Changes in v2
to, e.g., "blend_base", but it doesn't
really matter as they are accessed only in a couple of places.
Reviewed-by: Tomi Valkeinen
Tomi
drivers/gpu/drm/xlnx/zynqmp_disp.c | 44 +-
1 file changed, 19 insertions(+), 25 deletions(-)
diff --git a/drivers/gp
insertions(+), 17 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c
b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 8cdd74a9b772..13157da0089e 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -436,19 +436,29
/zynqmp_dp.c | 31 +++
3 files changed, 139 insertions(+), 4 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c
b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 891577475349..24f1f367b1d3 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b
BIT(8)
#define ZYNQMP_DISP_AV_BUF_PALETTE_MEMORY 0x400
Reviewed-by: Tomi Valkeinen
Tomi
On 15/04/2024 19:00, Tomi Valkeinen wrote:
Add a new flag, TI_SCI_PD_KEEP_BOOT_STATE, which can be set in the dts
when referring to power domains. When this flag is set, the ti-sci
driver will check if the PD is currently enabled in the HW, and if so,
set the GENPD_FLAG_ALWAYS_ON flag so
The first patch here is a fix for ti_sci_pm_domains to handle the case
where the dts has two nodes which refer to the same PD.
The second is the interesting one, and very much an RFC.
Tomi
Signed-off-by: Tomi Valkeinen
---
Tomi Valkeinen (2):
pmdomain: ti-sci: Fix duplicate PD referrals
this checking if a PD with the ID has already been created, and only
create a PD for new IDs.
Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds
instead of one")
Signed-off-by: Tomi Valkeinen
---
drivers/pmdomain/ti/ti_sci_pm_domains.c | 20 ++
ybe
adding TI_SCI_PD_KEEP_BOOT_STATE flag this way is not fine.
Signed-off-by: Tomi Valkeinen
---
drivers/pmdomain/ti/ti_sci_pm_domains.c| 27 +--
include/dt-bindings/soc/ti,sci_pm_domain.h | 1 +
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers/p
On 10/04/2024 20:04, Ville Syrjälä wrote:
On Wed, Apr 10, 2024 at 06:25:17PM +0300, Ville Syrjälä wrote:
On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote:
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
__iowmb() isn't available on most architectures. Make
its
On 10/04/2024 18:25, Ville Syrjälä wrote:
On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote:
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
__iowmb() isn't available on most architectures. Make
its use optional so that the driver can be built on
other
On 22/09/2023 10:37, Wolfram Sang wrote:
Since commit ab78029ecc34 ("drivers/pinctrl: grab default handles from
device core"), we can rely on device core for setting the default pins.
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 --
1 file changed, 6
On 30/03/2024 22:28, Krzysztof Kozlowski wrote:
Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().
Signed-off-by: Krzysztof Kozlowski
---
On 04/04/2024 10:32, Dan Carpenter wrote:
Free "dp" before returning.
Fixes: be318d01a903 ("drm: xlnx: dp: Reset DisplayPort IP")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
Allow omapdrm to be built with COMPILE_TEST=y for greater
coverage.
FIXME: Still borked due to ?
Cc: Tomi Valkeinen
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/omapdrm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
phys_to_page() is not available on most architectures.
Just open code it like msm does. Allows COMPILE_TEST=y
builds of omapdrm on other architectures.
Cc: Tomi Valkeinen
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/omapdrm
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
Allow tilcdc to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/tilcdc/Kconfig | 2 +-
1 file changed
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
__iowmb() isn't available on most architectures. Make
its use optional so that the driver can be built on
other architectures with COMPILE_TEST=y.
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Signed-off-by: Ville Syrjälä
---
drivers/gpu
On 21/03/2024 22:43, Anatoliy Klymenko wrote:
Program live video input format according to selected media bus format.
In the bridge mode of operation, DPSUB is connected to FPGA CRTC which
almost certainly supports a single media bus format as its output. Expect
this to be delivered via the new
a(struct zynqmp_disp *disp,
unsigned int i;
int ret;
- if (!disp->dpsub->dma_enabled)
- return 0;
-
for (i = 0; i < layer->info->num_channels; i++) {
struct zynqmp_disp_layer_dma *dma = >dmas[i];
char dma_channel_name[16];
Reviewed-by: Tomi Valkeinen
Tomi
On 21/03/2024 22:43, Anatoliy Klymenko wrote:
DPSUB in bridge mode supports multiple input media bus formats.
Announce the list of supported input media bus formats via
drm_bridge.atomic_get_input_bus_fmts callback.
Introduce a set of live input formats, supported by DPSUB.
Rename
On 21/03/2024 22:43, Anatoliy Klymenko wrote:
Set layer mode of operation (live or dma-based) during layer creation.
Each DPSUB layer mode of operation is defined by corresponding DT node port
connection, so it is possible to assign it during layer object creation.
Previously it was set in
,
* DISP Configuration
*/
+/**
+ * zynqmp_dp_disp_connected_live_layer - Return the first connected live layer
+ * @dp: DisplayPort IP core structure
+ *
+ * Return: The first connected live display layer or NULL if none of the live
+ * layer is connected.
"layers"
Reviewe
On 21/03/2024 22:43, Anatoliy Klymenko wrote:
Update live format defines to match DPSUB AV_BUF_LIVE_VID_CONFIG register
layout.
I think this description needs a bit more. Mention that the defines are
not currently used, so we can change them like this without any other
change.
Tomi
/zynqmp_disp.h | 13 +
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
drivers/gpu/drm/xlnx/zynqmp_kms.c | 2 +-
4 files changed, 19 insertions(+), 18 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c
b/drivers/gpu/drm/xlnx/zynqmp_disp.c
Add myself as a co-maintainer for Xilinx DRM drivers to help Laurent.
Signed-off-by: Tomi Valkeinen
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1aabf1c15bb3..79ef5a6bf21b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7306,6 +7306,7 @@ F
On 22/03/2024 23:22, Sean Anderson wrote:
On 3/22/24 14:09, Tomi Valkeinen wrote:
On 22/03/2024 18:18, Sean Anderson wrote:
On 3/22/24 01:32, Tomi Valkeinen wrote:
On 21/03/2024 21:17, Sean Anderson wrote:
On 3/21/24 15:08, Tomi Valkeinen wrote:
On 21/03/2024 20:01, Sean Anderson wrote
On 22/03/2024 18:18, Sean Anderson wrote:
On 3/22/24 01:32, Tomi Valkeinen wrote:
On 21/03/2024 21:17, Sean Anderson wrote:
On 3/21/24 15:08, Tomi Valkeinen wrote:
On 21/03/2024 20:01, Sean Anderson wrote:
On 3/21/24 13:25, Tomi Valkeinen wrote:
On 21/03/2024 17:52, Sean Anderson wrote
t I also wonder if there might be some risks in adding the bridge
early (before zynqmp_disp_probe()), although I can't see any issue right
away...
In any case, as this works for me too:
Reviewed-by: Tomi Valkeinen
Tomi
On 21/03/2024 17:33, Sean Anderson wrote:
On 3/20/24 02:05, Randy Dunlap wrote:
On 3/19/24 22:42, Tomi Valkeinen wrote:
On 20/03/2024 00:51, Sean Anderson wrote:
Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed
members.
Signed-off-by: Sean Anderson
---
Changes
On 21/03/2024 21:17, Sean Anderson wrote:
On 3/21/24 15:08, Tomi Valkeinen wrote:
On 21/03/2024 20:01, Sean Anderson wrote:
On 3/21/24 13:25, Tomi Valkeinen wrote:
On 21/03/2024 17:52, Sean Anderson wrote:
On 3/20/24 02:53, Tomi Valkeinen wrote:
On 20/03/2024 00:51, Sean Anderson wrote
On 21/03/2024 20:01, Sean Anderson wrote:
On 3/21/24 13:25, Tomi Valkeinen wrote:
On 21/03/2024 17:52, Sean Anderson wrote:
On 3/20/24 02:53, Tomi Valkeinen wrote:
On 20/03/2024 00:51, Sean Anderson wrote:
Retraining the link can take a while, and might involve waiting for
DPCD reads/writes
On 21/03/2024 17:52, Sean Anderson wrote:
On 3/20/24 02:53, Tomi Valkeinen wrote:
On 20/03/2024 00:51, Sean Anderson wrote:
Retraining the link can take a while, and might involve waiting for
DPCD reads/writes to complete. This is inappropriate for an IRQ handler.
Just schedule this work
On 21/03/2024 18:08, Sean Anderson wrote:
On 3/20/24 03:49, Tomi Valkeinen wrote:
On 20/03/2024 00:51, Sean Anderson wrote:
+/**
+ * enum test_pattern - Test patterns for test testing
"for test testing"? =)
@@ -1655,6 +2321,9 @@ static void zynqmp_dp_hpd_irq_work_func(struct
w
On 20/03/2024 17:37, Rob Herring wrote:
On Tue, Mar 19, 2024 at 10:22:37AM +0200, Tomi Valkeinen wrote:
The DP subsystem for ZynqMP support audio via two channels, and the DP
DMA has dma-engines for those channels. For some reason the DT binding
has not specified those channels, even
On 20/03/2024 00:51, Sean Anderson wrote:
+/**
+ * enum test_pattern - Test patterns for test testing
"for test testing"? =)
@@ -1655,6 +2321,9 @@ static void zynqmp_dp_hpd_irq_work_func(struct
work_struct *work)
u8 status[DP_LINK_STATUS_SIZE + 2];
int err;
+ if
++--
1 file changed, 34 insertions(+), 15 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
On 20/03/2024 00:51, Sean Anderson wrote:
Retraining the link can take a while, and might involve waiting for
DPCD reads/writes to complete. This is inappropriate for an IRQ handler.
Just schedule this work for later completion. This is racy, but will be
fixed in the next commit.
You should
On 20/03/2024 00:51, Sean Anderson wrote:
Sort the members of struct zynqmp_dp to reduce padding necessary for
alignment.
Signed-off-by: Sean Anderson
---
Changes in v2:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 28 ++--
1 file changed, 14 insertions(+), 14
set[i] = voltage | preemphasis;
Reviewed-by: Tomi Valkeinen
Tomi
is fine too (or even dropping the print totally), so:
Reviewed-by: Tomi Valkeinen
Tomi
On 20/03/2024 00:51, Sean Anderson wrote:
Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed
members.
Signed-off-by: Sean Anderson
---
Changes in v2:
- New
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 +
.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/xlnx/Kconfig| 9 +
drivers/gpu/drm/xlnx/Makefile | 1 +
drivers/gpu/drm/xlnx/zynqmp_disp.c | 50
drivers/gpu/drm/xlnx/zynqmp_disp_regs.h | 7 +-
drivers/gpu/drm/xlnx/zynqmp_dp.c| 54 ++--
drivers/gpu
Add the two DMA channels used for the DisplayPort audio to the
zynqmp_dpsub node.
Signed-off-by: Tomi Valkeinen
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
b/arch/arm64/boot/dts
he binding.
Signed-off-by: Tomi Valkeinen
---
.../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml| 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
b/Documentation/devicetree/bindings/display
the device.
Signed-off-by: Tomi Valkeinen
---
include/sound/dmaengine_pcm.h | 2 ++
sound/soc/soc-core.c | 8 +---
sound/soc/soc-generic-dmaengine-pcm.c | 3 +++
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/include/sound/dmaengine_pcm.h b/include/sound
includes an improvement to the
soc-generic-dmaengine-pcm.c, required to support two dmaengine_pcms.
Signed-off-by: Tomi Valkeinen
---
Changes in v2:
- Fix a missing double-quote in the DT binding
- Link to v1:
https://lore.kernel.org/r/20240312-xilinx-dp-audio-v1-0-696c79fac...@ideasonboard.com
Hi,
On 28/02/2024 08:35, Tony Lindgren wrote:
Here are two fixes for omapdrm for missing drm_framebuffer_funcs.dirty
that needs to be paired with omap_framebuffer_dirty(), and to add
FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS so things behave as earlier with
drm_fb_helper_sys_write(). Without these
.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/xlnx/Kconfig| 9 +
drivers/gpu/drm/xlnx/Makefile | 1 +
drivers/gpu/drm/xlnx/zynqmp_disp.c | 50
drivers/gpu/drm/xlnx/zynqmp_disp_regs.h | 7 +-
drivers/gpu/drm/xlnx/zynqmp_dp.c| 54 ++--
drivers/gpu
Add the two DMA channels used for the DisplayPort audio to the
zynqmp_dpsub node.
Signed-off-by: Tomi Valkeinen
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
b/arch/arm64/boot/dts
he binding.
Signed-off-by: Tomi Valkeinen
---
.../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml| 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
b/Documentation/devicetree/bindings/display
the device.
Signed-off-by: Tomi Valkeinen
---
include/sound/dmaengine_pcm.h | 2 ++
sound/soc/soc-core.c | 8 +---
sound/soc/soc-generic-dmaengine-pcm.c | 3 +++
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/include/sound/dmaengine_pcm.h b/include/sound
includes an improvement to the
soc-generic-dmaengine-pcm.c, required to support two dmaengine_pcms.
Signed-off-by: Tomi Valkeinen
---
Tomi Valkeinen (4):
ASoC: dmaengine_pcm: Allow passing component name via config
dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs
arm64: dts
aged
correctly.
Signed-off-by: Tomi Valkeinen
Fixes: 561671612394 ("drm: xlnx: zynqmp_dpsub: Add support for live video
input")
---
drivers/gpu/drm/xlnx/zynqmp_dp.c| 4
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git
On 29/02/2024 11:05, Laurent Pinchart wrote:
Tomi, could you push this through drm-misc ?
On Wed, Feb 28, 2024 at 06:22:25PM +0200, Laurent Pinchart wrote:
Hello Rohit,
Thank you for the patch.
On Fri, Feb 16, 2024 at 04:40:43AM -0800, Rohit Visavalia wrote:
Assert DisplayPort reset signal
On 26/02/2024 10:26, Tomi Valkeinen wrote:
Hi Tony,
On 25/02/2024 08:46, Tony Lindgren wrote:
Here are two fixes for omapdrm console.
How is it broken? I don't usually use the console (or fbdev) but
enabling it now, it seems to work fine for me, on DRA76 EVM with HDMI
output.
After
Hi Tony,
On 25/02/2024 08:46, Tony Lindgren wrote:
Here are two fixes for omapdrm console.
How is it broken? I don't usually use the console (or fbdev) but
enabling it now, it seems to work fine for me, on DRA76 EVM with HDMI
output.
Tomi
Regards,
Tony
Changes since v1:
- Add
On 15/02/2024 11:03, Alexander Stein wrote:
Hi everyone,
Am Donnerstag, 15. Februar 2024, 09:53:54 CET schrieb Jan Kiszka:
On 11.12.23 09:07, Aradhya Bhatia wrote:
On 06/12/23 17:41, Tomi Valkeinen wrote:
Hi,
On 08/11/2023 14:45, Alexander Stein wrote:
Hi Tomi,
Am Mittwoch, 8. November
Hi,
On 13/02/2024 13:39, Daniel Stone wrote:
Hi,
On Tue, 13 Feb 2024 at 10:18, Marius Vlad wrote:
On Tue, Feb 13, 2024 at 11:57:59AM +0200, Tomi Valkeinen wrote:
I haven't. I'm quite unfamiliar with Weston, and Randolph from TI (cc'd) has
been working on the Weston side of things. I also
, 14 insertions(+), 8 deletions(-)
For the series:
Reviewed-by: Tomi Valkeinen
Tomi
On 14/02/2024 11:10, Tomi Valkeinen wrote:
Hi,
On 15/01/2024 14:57, Devarsh Thakkar wrote:
TI keystone display subsystem present in AM65 and other SoCs such as AM62
support two separate register spaces namely "common" and "common1" which
can be used by two separate hosts to
Hi,
On 15/01/2024 14:57, Devarsh Thakkar wrote:
TI keystone display subsystem present in AM65 and other SoCs such as AM62
support two separate register spaces namely "common" and "common1" which
can be used by two separate hosts to program the display controller as
described in respective
Hi,
On 13/02/2024 11:04, Pekka Paalanen wrote:
On Tue, 13 Feb 2024 10:16:36 +0200
Tomi Valkeinen wrote:
When the driver sets up the zpos property it sets the default zpos value
to the HW id of the plane. That is fine as such, but as on many DSS
versions the driver arranges the DRM planes
, related to J721e
erratum i2097 ("DSS: Disabling a Layer Connected to Overlay May Result
in Synclost During the Next Frame"). Experimentation also shows that the
OVR's CHANNELIN field has similar issue. So we may need to revisit this
when we find out more about the core issue.
Signed-of
to zpos 0. On a two display system this would give us plane zpos values
of 0, 0, 1, 2. The end result and behavior would be very similar in this
option, and I'm not aware that this would actually help us in any way.
So, to keep the code simple, I opted for the 0, 1, 2, 3 values.
Signed-off-by: Tomi
Two fixes for tidss: The first one helps Weston deal with the planes,
the second fixes a possible sync-lost issue with multiple displays.
Signed-off-by: Tomi Valkeinen
---
Tomi Valkeinen (2):
drm/tidss: Fix initial plane zpos values
drm/tidss: Fix sync-lost issue with two displays
On 24/01/2024 04:53, Anatoliy Klymenko wrote:
Add few missing pieces to support ZynqMP DPSUB live video in mode.
ZynqMP DPSUB supports 2 modes of operations in regard to video data
input.
In the first mode, DPSUB uses DMA engine to pull video data from memory
buffers. To support this the
On 19/01/2024 07:54, Klymenko, Anatoliy wrote:
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h
b/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h
index f92a006d5070..926e07c255bb 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h
@@ -165,10 +165,10 @@
(!status)
return IRQ_NONE;
/* dbg for diagnostic, but not much that the driver can do */
Reviewed-by: Tomi Valkeinen
Tomi
- zynqmp_dp_write(dp, ZYNQMP_DP_INT_STATUS, status);
-
if (status & ZYNQMP_DP_INT_VBLANK_START)
zynqmp_dpsub_drm_handle_vblank(dp->dpsub);
Reviewed-by: Tomi Valkeinen
Tomi
Hi,
On 16/01/2024 15:41, Devarsh Thakkar wrote:
This overlay needs to be used with display sharing supported device
manager firmware only.
Remote core running this firmware has write access to "common" register
space, VIDL pipeline, OVR1 overlay and VP1 videoport.
The processing core running
Hi,
On 16/01/2024 15:41, Devarsh Thakkar wrote:
Display subsystem present in TI Keystone family of devices supports sharing
of display between multiple hosts as it provides separate register space
(common* region) for each host to programming display controller and also a
unique interrupt line
Hi Anatoliy,
On 13/01/2024 01:42, Anatoliy Klymenko wrote:
Live video input format is expected to be set as
"bus-format" property in connected remote endpoint.
Program live video input format DPSUB registers.
Set display layer mode in layer creation context.
Some comments inline below. But
On 13/01/2024 01:42, Anatoliy Klymenko wrote:
Filter out status register against interrupts' mask.
Some events are being reported via DP status register, even if
corresponding interrupts have been disabled. Avoid processing
of such events in interrupt handler context.
The subject talks about
gt;vid_clk_from_ps);
zynqmp_disp_avbuf_enable_channels(disp);
zynqmp_disp_avbuf_enable_audio(disp);
Reviewed-by: Tomi Valkeinen
Tomi
On 13/01/2024 01:42, Anatoliy Klymenko wrote:
Assign device of node to bridge prior registering it. This will
make said bridge discoverable by separate crtc driver.
I think a few words on why this is needed (and why it wasn't needed
before) would be nice.
Other than that:
Reviewed-by: Tomi
The driver never unregisters the audio codec platform device, which can
lead to a crash on module reloading, nor does it handle the return value
from sii902x_audio_codec_init().
Signed-off-by: Tomi Valkeinen
Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support")
Cc:
the i2c part yet, leading
to the crash.
Fix this by moving the drm_bridge_add() to the end of the
sii902x_init(), which is also at the very end of sii902x_probe().
Signed-off-by: Tomi Valkeinen
Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")
---
drivers/gpu/drm/bridge
Two small fixes to sii902x for crashes.
Signed-off-by: Tomi Valkeinen
---
Tomi Valkeinen (2):
drm/bridge: sii902x: Fix probing race issue
drm/bridge: sii902x: Fix audio codec unregistration
drivers/gpu/drm/bridge/sii902x.c | 42 +++-
1 file
On 15/12/2023 15:33, Jan Kiszka wrote:
On 31.10.23 14:26, Tomi Valkeinen wrote:
These two patches are needed to make tc358767 work in the
DRM_BRIDGE_ATTACH_NO_CONNECTOR case, at least when using a DP connector.
The first patch, "drm/bridge: tc358767: Support input format negotiation
Hi all,
On 03/11/2023 15:14, Tomi Valkeinen wrote:
Fix cases where smatch reports a use of an uninitialized variable, and
one where the variable is initialized but contains wrong value.
Tomi
Signed-off-by: Tomi Valkeinen
---
Changes in v2:
- Added two more fixes
- Link to v1:
https
Hi mipi dsi maintainers (I'm not sure who that is =),
On 21/09/2023 13:50, Tomi Valkeinen wrote:
It's been reported that DSI host driver's detach can be called without
the attach ever happening:
https://lore.kernel.org/all/20230412073954.20601-1-t...@atomide.com/
After reading the code, I
Hi,
On 08/11/2023 14:45, Alexander Stein wrote:
Hi Tomi,
Am Mittwoch, 8. November 2023, 12:27:21 CET schrieb Tomi Valkeinen:
These two patches are needed to make tc358767 work in the
DRM_BRIDGE_ATTACH_NO_CONNECTOR case, at least when using a DP connector.
I have tested this with TI AM654 EVM
On 08/11/2023 19:16, Aradhya Bhatia wrote:
This patch series adds a new compatible for the Display SubSystem (DSS)
controller on TI's AM62A7 SoC. It further adds the required support, for
the same, in the tidss driver.
The DSS controller is similar to the recently added AM625 DSS, with the
key
On 13/11/2023 22:55, Andrew Davis wrote:
While a scatter-gather table having only 1 entry does imply it is
contiguous, it is a logic error to assume the inverse. Tables can have
more than 1 entry and still be contiguous. Use a proper check here.
Signed-off-by: Andrew Davis
---
Thanks, I'll
idss/tidss_drv.c | 1 +
4 files changed, 77 insertions(+)
base-commit: 2220f68f4504aa1ccce0fac721ccdb301e9da32f
For the series:
Reviewed-by: Tomi Valkeinen
Tomi
1 - 100 of 3370 matches
Mail list logo
