[PATCH v4 09/80] drm/omap: dsi: simplify write function

2020-11-24 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the write related messages handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/Kconfig | 1 + drivers/gpu/drm

[PATCH v4 12/80] drm/omap: dsi: introduce mipi_dsi_host

2020-11-24 Thread Tomi Valkeinen
: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 121 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 53 ++-- drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 - 3 files changed, 102 insertions

[PATCH v4 03/80] drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_*

2020-11-24 Thread Tomi Valkeinen
From: Sebastian Reichel This replaces OMAP specific enum for pixel format with common implementation. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 2 +- drivers/gpu/drm/omapdrm/dss/dsi.c

[PATCH v4 02/80] drm/omap: drop unused dsi.configure_pins

2020-11-24 Thread Tomi Valkeinen
From: Sebastian Reichel The panel-dsi-cm's ddata->pin_config is always NULL, so this callback is never called. Instead the DSI encoder gets the pin configuration directly from DT. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- dri

[PATCH v4 06/80] drm/omap: panel-dsi-cm: convert to transfer API

2020-11-24 Thread Tomi Valkeinen
From: Sebastian Reichel This converts the panel-dsi-cm driver to use the transfer API instead of specific functions, so that the specific functions can be unexported and squashed into the generic transfer function. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Acked-by

[PATCH v4 07/80] drm/omap: dsi: unexport specific data transfer functions

2020-11-24 Thread Tomi Valkeinen
From: Sebastian Reichel After converting all DSI drivers, unexport the specific transfer functions. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dsi.c | 12 drivers/gpu/drm/omapdrm/dss/omapdss.h

[PATCH v4 04/80] drm/omap: constify write buffers

2020-11-24 Thread Tomi Valkeinen
From: Sebastian Reichel The write buffers are not modified, so they can be constant. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dsi.c | 24 drivers/gpu/drm/omapdrm/dss/omapdss.h

[PATCH v4 01/80] Revert "drm/omap: dss: Remove unused omap_dss_device operations"

2020-11-24 Thread Tomi Valkeinen
From: Sebastian Reichel This reverts commit e086558ae923 ("drm/omap: dss: Remove unused omap_dss_device operations") This is still needed by DSI. E.g. unloading modules without this will cause a crash. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Reviewed-b

[PATCH v4 00/80] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-24 Thread Tomi Valkeinen
efconfig: Update for moved DSI command mode panel Tomi Valkeinen (31): drm/omap: squash omapdrm sub-modules into one drm/omap: remove unused display.c drm/omap: drop unused owner field drm/omap: remove dispc_ops drm/omap: remove dss_mgr_ops drm/panel: panel-dsi-cm: use MIPI_DCS_GET_

[PATCH RESEND v3 0/2] drm: add DisplayPort connector

2020-11-24 Thread Tomi Valkeinen
Hi, This series adds the DT bindings and a driver for DisplayPort connector. This is a resend of https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg326794.html with no changes (rebased on top of latest drm-misc). Tomi Tomi Valkeinen (2): dt-bindings: dp-connector: add binding

[PATCH RESEND v3 2/2] drm/bridge: display-connector: add DP support

2020-11-24 Thread Tomi Valkeinen
as possible. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/display-connector.c | 46 +- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c index 4d278573cdb9..04362

[PATCH RESEND v3 1/2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-11-24 Thread Tomi Valkeinen
even if there is, I don't want to guess what it could look like, and could it be part of the dp-connector binding. * No DP++. I'm not familiar with DP++. DP++ might need an i2c bus added to the bindings. Signed-off-by: Tomi Valkeinen Cc: Rob Herring --- .../displa

Re: [PATCH v3 6/6] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable

2020-11-23 Thread Tomi Valkeinen
quired in other places. > > Signed-off-by: Nikhil Devshatwar > Reviewed-by: Swapnil Jakhade Reviewed-by: Tomi Valkeinen I think this is fine as a fix for this issue, but at some point the irq management needs some work. E.g. we call cdns_mhdp_bridge_hpd_enable when attaching/enabling t

Re: [PATCH v1 0/4] Add bus format negotiation support for Cadence MHDP8546 driver

2020-11-16 Thread Tomi Valkeinen
Hi, On 13/11/2020 11:46, Yuti Amonkar wrote: > This patch series add bus format negotiation support for Cadence MHDP8546 > bridge > driver. > > The patch series has four patches in the below sequence: > 1. drm: bridge: cdns-mhdp8546: Add output bus format negotiation > Add minimal output bus for

Re: [PATCH v3 30/56] drm/omap: dsi: move panel refresh function to host

2020-11-12 Thread Tomi Valkeinen
On 11/11/2020 17:58, Laurent Pinchart wrote: diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c index 030a8fa140db..1582960f9e90 100644 --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c +++ b/drivers/gpu/drm/

Re: [PATCH v3 33/56] drm/omap: dsi: convert to drm_panel

2020-11-11 Thread Tomi Valkeinen
On 09/11/2020 12:39, Laurent Pinchart wrote: > On Thu, Nov 05, 2020 at 02:03:10PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> This converts the DSI module to expect common drm_panel display >> drivers instead of dssdev based ones. >> &g

Re: [PATCH v3 30/56] drm/omap: dsi: move panel refresh function to host

2020-11-11 Thread Tomi Valkeinen
On 09/11/2020 12:10, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:03:07PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> This moves the panel refresh/update function from the panel &

Re: [PATCH v3 29/56] drm/omap: dsi: do ULPS in host driver

2020-11-11 Thread Tomi Valkeinen
On 09/11/2020 12:03, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:03:06PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> Move ULPS handling into the DSI host controller, so that we &

Re: [PATCH v3 28/56] drm/omap: dsi: untangle ulps ops from enable/disable

2020-11-11 Thread Tomi Valkeinen
On 09/11/2020 11:57, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:03:05PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> Create a custom function pointer for ULPS and use it ins

Re: [PATCH v3 27/56] drm/omap: dsi: do bus locking in host driver

2020-11-11 Thread Tomi Valkeinen
On 09/11/2020 15:27, Sebastian Reichel wrote: > Hi, > > On Mon, Nov 09, 2020 at 12:08:33PM +0200, Tomi Valkeinen wrote: >> On 09/11/2020 11:52, Laurent Pinchart wrote: >>> Hi Tomi, >>> >>> Thank you for the patch. >>> >>> On Thu, Nov 0

Re: [PATCH v3 25/56] drm/omap: dsi: move TE GPIO handling into core

2020-11-11 Thread Tomi Valkeinen
On 09/11/2020 11:19, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:03:02PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> In preparation for removing custom DSS calls from the DSI &g

Re: [PATCH v3 35/56] drm/omap: dsi: implement check timings

2020-11-11 Thread Tomi Valkeinen
On 09/11/2020 12:47, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:03:12PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> Implement check timings, which will check if its possible to

Re: [PATCH v3 50/56] drm/omap: dsi: simplify pin config

2020-11-11 Thread Tomi Valkeinen
On 09/11/2020 13:09, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:03:27PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> Simplify DSI pin config, which always originates from DT >&

Re: [PATCH v3 37/56] drm/omap: panel-dsi-cm: support unbinding

2020-11-11 Thread Tomi Valkeinen
On 09/11/2020 12:49, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > On Thu, Nov 05, 2020 at 02:03:14PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> Now, that the driver implements the common DRM panel API >> the unbind no longer needs to b

Re: [PATCH v2 5/6] drm/tidss: Move to newer connector model

2020-11-11 Thread Tomi Valkeinen
to > create the connector and attach bridges with flag > DRM_BRIDGE_ATTACH_NO_CONNECTOR > > Signed-off-by: Nikhil Devshatwar > --- > drivers/gpu/drm/tidss/tidss_drv.h | 3 +++ > drivers/gpu/drm/tidss/tidss_kms.c | 19 ++- > 2 files changed, 21 insertions(

Re: [PATCH v2 4/6] drm/tidss: Set bus_format correctly from bridge/connector

2020-11-11 Thread Tomi Valkeinen
On 09/11/2020 19:05, Nikhil Devshatwar wrote: > When there is a chain of bridges attached to the encoder, > the bus_format should be ideally set from the input format of the > first bridge in the chain. > > Use the bridge state to get the negotiated bus_format. > If the bridge does not support for

Re: [PATCH v2 3/6] drm/bridge: mhdp8546: Add minimal format negotiation

2020-11-11 Thread Tomi Valkeinen
cdns_mhdp_bridge_atomic_duplicate_state, > .atomic_destroy_state = cdns_mhdp_bridge_atomic_destroy_state, > .atomic_reset = cdns_mhdp_bridge_atomic_reset, > + .atomic_get_input_bus_fmts = cdns_mhdp_get_input_bus_fmts, > .detect = cdns_mhdp_bridge_detect, > .get_edid = cdns_mhdp_brid

Re: [PATCH v2 2/6] drm/bridge: tfp410: Support format negotiation hooks

2020-11-11 Thread Tomi Valkeinen
10 *dvi = drm_bridge_to_tfp410(bridge); > + u32 *input_fmts; > + > + *num_input_fmts = 0; > + > + /* > + * Output of tfp410 is DVI, which is TMDS. > + * There is no media format defined for this > + * Using MEDIA_BUS_FMT_FIXED for now > + */ Please fix the missing

Re: [PATCH v2 1/6] drm: bridge: Propagate the bus flags from bridge->timings

2020-11-11 Thread Tomi Valkeinen
ould be more clear. Maybe something like: If legacy bus flags are provided in bridge->timings, use those as input flags instead of propagating the output flags. Other than that: Reviewed-by: Tomi Valkeinen Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Busin

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-11 Thread Tomi Valkeinen
On 11/11/2020 09:48, H. Nikolaus Schaller wrote: > >> Am 11.11.2020 um 07:40 schrieb Tomi Valkeinen : >> >> On 10/11/2020 23:04, H. Nikolaus Schaller wrote: >>> >>>> Am 10.11.2020 um 17:52 schrieb Tomi Valkeinen : >>>> >>>> On 1

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-11 Thread Tomi Valkeinen
On 10/11/2020 23:04, H. Nikolaus Schaller wrote: > >> Am 10.11.2020 um 17:52 schrieb Tomi Valkeinen : >> >> On 10/11/2020 18:49, H. Nikolaus Schaller wrote: >> >> I guess you have the same issue. It goes to dsi_bridge_mode_valid, then >> __dsi_calc_config,

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-10 Thread Tomi Valkeinen
On 10/11/2020 18:49, H. Nikolaus Schaller wrote: > >> Am 10.11.2020 um 14:49 schrieb H. Nikolaus Schaller : >> >> Hi Tomi, >> >>> Am 09.11.2020 um 12:33 schrieb Tomi Valkeinen : >>> >>> On 09/11/2020 13:09, H. Nikolaus Schaller wrote: >>

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-10 Thread Tomi Valkeinen
On 10/11/2020 15:49, H. Nikolaus Schaller wrote: > I did now some tests based on v5.10-rc3 by adding mre and more printk() and > dump_stack(). > And I did blacklist the panel driver so that I could boot and after > modprobing it manually > I could trigger a re-probe by inserting some USB memory

Re: [PATCH 0/4] drm/omap: fix reference leak in runtime get ops

2020-11-10 Thread Tomi Valkeinen
Hi, On 10/11/2020 14:51, Zhang Qilong wrote: > This series of patches fixed several usage counter leaks refer to > pm_runtime_get_sync. Many callers forget to call pm_runtime_put_noidle > when pm_runtime_get_sync failed, and we fixed it. > > Zhang Qilong (4): > drm: omapdrm: dsi: fix-reference-

Re: [PATCH] [v2] drm/omap: Fix runtime PM imbalance on error

2020-11-10 Thread Tomi Valkeinen
On 22/08/2020 09:57, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter > even when it returns an error code. However, users of its > direct wrappers in omapdrm assume that PM usage counter will > not change on error. Thus a pairing decrement is needed on > the error

Re: [PATCH] drm: omapdrm: Replace HTTP links with HTTPS ones

2020-11-10 Thread Tomi Valkeinen
On 13/07/2020 15:28, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b

Re: [PATCH -next] drm/tidss: use devm_platform_ioremap_resource_byname

2020-11-10 Thread Tomi Valkeinen
On 17/09/2020 09:29, Wang Xiaojun wrote: > Use the devm_platform_ioremap_resource_byname() helper instead of > calling platform_get_resource_byname() and devm_ioremap_resource() > separately. > > Signed-off-by: Wang Xiaojun > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 9 + > 1 file chan

Re: [PATCH v2 6/6] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable

2020-11-10 Thread Tomi Valkeinen
On 10/11/2020 12:27, Nikhil Devshatwar wrote: > On 11:21-20201110, Tomi Valkeinen wrote: >> On 09/11/2020 19:06, Nikhil Devshatwar wrote: >>> When removing the tidss driver, there is a warning reported by >>> kernel about an unhandled interrupt for mhdp driver. &g

Re: [PATCH 08/19] drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions

2020-11-10 Thread Tomi Valkeinen
gem.c:593: warning: Excess function parameter > 'drm_file' description in 'omap_gem_dumb_create' > drivers/gpu/drm/omapdrm/omap_gem.c:619: warning: Function parameter or > member 'offset' not described in 'omap_gem_dumb_map_offset' > > Cc: Tomi Valk

Re: [PATCH v2 6/6] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable

2020-11-10 Thread Tomi Valkeinen
On 09/11/2020 19:06, Nikhil Devshatwar wrote: > When removing the tidss driver, there is a warning reported by > kernel about an unhandled interrupt for mhdp driver. > > [ 43.238895] irq 31: nobody cared (try booting with the "irqpoll" option) > ... [snipped backtrace] > [ 43.330735] handlers:

Re: [PATCH v2 0/6] drm/tidss: Use new connector model for tidss

2020-11-10 Thread Tomi Valkeinen
Hi Nikhil, On 09/11/2020 19:05, Nikhil Devshatwar wrote: > This series moves the tidss to using new connectoe model, where the > SoC driver (tidss) creates the connector and all the bridges are > attached with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR > > Since the bridges do not create the conne

Re: [PATCH v3 27/56] drm/omap: dsi: do bus locking in host driver

2020-11-09 Thread Tomi Valkeinen
On 09/11/2020 15:27, Sebastian Reichel wrote: > Hi, > > On Mon, Nov 09, 2020 at 12:08:33PM +0200, Tomi Valkeinen wrote: >> On 09/11/2020 11:52, Laurent Pinchart wrote: >>> Hi Tomi, >>> >>> Thank you for the patch. >>> >>> On Thu, Nov 0

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-09 Thread Tomi Valkeinen
On 09/11/2020 13:09, H. Nikolaus Schaller wrote: >>> I see. >>> Anyways there is missing some simple thing which makes the driver not >>> prepared/enabled. >>> Or is this related to VC? >> >> No, that's not related to the VC. > > Ok, then it is worth searching for that independently. Any idea/hi

Re: [PATCH v3 15/56] drm/omap: dsi: request VC via mipi_dsi_attach

2020-11-09 Thread Tomi Valkeinen
On 09/11/2020 10:42, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:02:52PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> Drop custom request_vc/release_vc callbacks by usi

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-09 Thread Tomi Valkeinen
On 09/11/2020 12:31, H. Nikolaus Schaller wrote: > >> Am 09.11.2020 um 11:22 schrieb Tomi Valkeinen : >> >> On 09/11/2020 11:30, H. Nikolaus Schaller wrote: >>> >>>> Am 09.11.2020 um 09:04 schrieb Tomi Valkeinen : >>>> >>>> On 07/1

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-09 Thread Tomi Valkeinen
On 09/11/2020 11:30, H. Nikolaus Schaller wrote: > >> Am 09.11.2020 um 09:04 schrieb Tomi Valkeinen : >> >> On 07/11/2020 14:19, H. Nikolaus Schaller wrote: >> >>> I have set up based on our complete letux-5.10-rc2 tree and maybe using our >>> pri

Re: [PATCH v3 27/56] drm/omap: dsi: do bus locking in host driver

2020-11-09 Thread Tomi Valkeinen
On 09/11/2020 11:52, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:03:04PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> This moves the bus locking into the host driver and unexports >> the

Re: [PATCH v3 19/56] drm/omap: dsi: drop unused get_te()

2020-11-09 Thread Tomi Valkeinen
On 09/11/2020 10:45, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:02:56PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> The get_te() callback is not used, so we can drop the &

Re: [PATCH v3 22/56] drm/omap: dsi: use pixel-format and mode from attach

2020-11-09 Thread Tomi Valkeinen
On 09/11/2020 10:49, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:02:59PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> In order to reduce the amount of custom functionality, this

Re: [PATCH v3 09/56] drm/omap: dsi: drop virtual channel logic

2020-11-09 Thread Tomi Valkeinen
On 09/11/2020 10:14, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:02:46PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> This drops the virtual channel logic. Afterwards DSI client

Re: [PATCH v3 09/56] drm/omap: dsi: drop virtual channel logic

2020-11-09 Thread Tomi Valkeinen
On 05/11/2020 14:02, Tomi Valkeinen wrote: > From: Sebastian Reichel > > This drops the virtual channel logic. Afterwards DSI clients > request their channel number and get the virtual channel with > the same number or -EBUSY if already in use. > > Signed-off-by: Sebastian

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-09 Thread Tomi Valkeinen
On 07/11/2020 14:19, H. Nikolaus Schaller wrote: > I have set up based on our complete letux-5.10-rc2 tree and maybe using our > private config makes > the difference. Anyways, the driver is now probed and I can see the call to > w677l_get_modes(). > > I have still no image and no calls to prep

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-06 Thread Tomi Valkeinen
On 06/11/2020 16:37, Tomi Valkeinen wrote: > On 05/11/2020 20:56, H. Nikolaus Schaller wrote: >> >>> Am 05.11.2020 um 19:28 schrieb Tomi Valkeinen : >>> >>> On 05/11/2020 20:14, H. Nikolaus Schaller wrote: >>>> >>>>> Am 05.11.2020 um 1

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-06 Thread Tomi Valkeinen
On 05/11/2020 20:56, H. Nikolaus Schaller wrote: > >> Am 05.11.2020 um 19:28 schrieb Tomi Valkeinen : >> >> On 05/11/2020 20:14, H. Nikolaus Schaller wrote: >>> >>>> Am 05.11.2020 um 18:36 schrieb Tomi Valkeinen : >>>> >>>

Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables

2020-11-06 Thread Tomi Valkeinen
On 05/11/2020 20:07, Lee Jones wrote: > On Thu, 05 Nov 2020, Tomi Valkeinen wrote: > >> On 05/11/2020 16:45, Lee Jones wrote: >>> Fixes the following W=1 kernel build warning(s): >>> >>> drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_st

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-05 Thread Tomi Valkeinen
On 05/11/2020 20:14, H. Nikolaus Schaller wrote: > >> Am 05.11.2020 um 18:36 schrieb Tomi Valkeinen : >> >> Hi, >> >> On 05/11/2020 19:15, H. Nikolaus Schaller wrote: >> >>> Next, I migrated my long waiting mipi_dsi/drm_panel driver conversion for

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-05 Thread Tomi Valkeinen
Hi, On 05/11/2020 19:15, H. Nikolaus Schaller wrote: > Next, I migrated my long waiting mipi_dsi/drm_panel driver conversion for > the panel of the Pyra handheld (omap 5 based) to compile on 5.10-rc2. And > I followed the latest existing panel-orisetech-otm8009a.c which uses a > similar video mod

Re: [PATCH 04/19] gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues

2020-11-05 Thread Tomi Valkeinen
ion in 'omap_irq_disable_vblank' > drivers/gpu/drm/omapdrm/omap_irq.c:142: warning: Excess function parameter > 'pipe' description in 'omap_irq_disable_vblank' > > Cc: Tomi Valkeinen > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rob Clark > C

Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables

2020-11-05 Thread Tomi Valkeinen
deletions(-) I'd use "drm/omap: dsi: " subject prefix, the current one is fine too: Reviewed-by: Tomi Valkeinen Should I pick this up or do you want to keep the series intact? Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 001

Re: [PATCH v3 40/56] drm/panel: Move OMAP's DSI command mode panel driver

2020-11-05 Thread Tomi Valkeinen
On 05/11/2020 14:03, Tomi Valkeinen wrote: > From: Sebastian Reichel > > The panel driver is no longer using any OMAP specific APIs, so > let's move it into the generic panel directory. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen >

[PATCH v3 51/56] ARM: omap2plus_defconfig: Update for moved DSI command mode panel

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The DSI command mode panel is no longer specific to OMAP and thus the config option has been renamed slightly. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Cc: Tony Lindgren --- arch/arm/configs/omap2plus_defconfig | 2 +- 1 file changed, 1

[PATCH v3 55/56] drm/omap: remove dispc_ops

2020-11-05 Thread Tomi Valkeinen
dispc_ops was created to help with the multi-module architecture and giving us the possibility of multiple dispc implementations. Neither of these is valid anymore, and we can remove dispc_ops and use direct calls to dispc. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c

[PATCH v3 54/56] drm/omap: drop unused owner field

2020-11-05 Thread Tomi Valkeinen
dssdev->owner is set, but never used. We can drop the field. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dpi.c | 1 - drivers/gpu/drm/omapdrm/dss/dsi.c | 1 - drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 - drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 - drivers/gpu/

[PATCH v3 56/56] drm/omap: remove dss_mgr_ops

2020-11-05 Thread Tomi Valkeinen
dss_mgr_ops was needed with the multi-module architecture, but is no longer needed. We can thus remove it and use direct calls. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dss.h | 1 - drivers/gpu/drm/omapdrm/dss/omapdss.h | 42 +++ drivers/gpu/drm

[PATCH v3 53/56] drm/omap: remove unused display.c

2020-11-05 Thread Tomi Valkeinen
The functions in display.c are not used, so drop the file. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/Makefile | 2 +- drivers/gpu/drm/omapdrm/dss/display.c | 58 --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 -- 3 files changed, 1 insertion(+), 63

[PATCH v3 35/56] drm/omap: dsi: implement check timings

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Implement check timings, which will check if its possible to configure the clocks for the provided mode using the same code as the set_config() hook. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 70

[PATCH v3 30/56] drm/omap: dsi: move panel refresh function to host

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This moves the panel refresh/update function from the panel driver into the DSI host driver to prepare for common drm_panel support. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 68

[PATCH v3 27/56] drm/omap: dsi: do bus locking in host driver

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This moves the bus locking into the host driver and unexports the custom API in preparation for drm_panel support. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 46 +-- drivers/gpu

[PATCH v3 49/56] drm/omap: simplify DSI manual update code

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Move dsi_ops into the main structure, since all other ops are gone. Instead of checking the device type we can simply check if dsi_ops are set. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 10

[PATCH v3 40/56] drm/panel: Move OMAP's DSI command mode panel driver

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The panel driver is no longer using any OMAP specific APIs, so let's move it into the generic panel directory. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/omapdrm/Kc

[PATCH v3 29/56] drm/omap: dsi: do ULPS in host driver

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Move ULPS handling into the DSI host controller, so that we no longer need a custom API for the DSI client. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 273 +- drivers/gpu/drm

[PATCH v3 28/56] drm/omap: dsi: untangle ulps ops from enable/disable

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Create a custom function pointer for ULPS and use it instead of reusing disable/enable functions for ULPS mode switch. This allows us to use the common disable/enable functions pointers for DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen

[PATCH v3 26/56] drm/omap: dsi: drop custom enable_te() API

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Instead of using the custon enable_te() API, this automatically enables/disables TE core support when a matching packet is send to the panel. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3

[PATCH v3 33/56] drm/omap: dsi: convert to drm_panel

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This converts the DSI module to expect common drm_panel display drivers instead of dssdev based ones. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 204 +++--- drivers/gpu/drm/omapdrm/dss

[PATCH v3 44/56] drm/omap: simplify omap_display_id

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel We no longer need to check for the DSS API, since all encoders, panels and connectors have been converted to the bridge API. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_drv.c | 9 + 1 file changed, 1

[PATCH v3 50/56] drm/omap: dsi: simplify pin config

2020-11-05 Thread Tomi Valkeinen
conversion and means the pins can be configured earlier. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 33 +-- drivers/gpu/drm/omapdrm/dss/omapdss.h | 15 2 files changed, 11 insertions(+), 37

[PATCH v3 32/56] drm/omap: dsi: drop custom panel capability support

2020-11-05 Thread Tomi Valkeinen
ities. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 --- drivers/gpu/drm/omapdrm/dss/dsi.c | 8 drivers/gpu/drm/omapdrm/dss/omapdss.h | 8 +--- drivers/gpu/drm/omapdrm/omap_c

[PATCH v3 37/56] drm/omap: panel-dsi-cm: support unbinding

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Now, that the driver implements the common DRM panel API the unbind no longer needs to be suppressed. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH v3 36/56] drm/omap: panel-dsi-cm: use DEVICE_ATTR_RO

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 8 1 file changed, 4 insertions

[PATCH v3 47/56] drm/omap: drop DSS ops_flags

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The omapdss device's ops_flags field is no longer used and can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 - drivers/gpu/drm/omapdrm/dss/venc.c| 1 - 2 files change

[PATCH v3 45/56] drm/omap: drop unused DSS next pointer

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Since all encoders and panels are using the bridge API now, we next pointer is no longer useful and can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c | 2 +- drivers/gpu/drm/omapdrm/dss/omapdss.h

[PATCH v3 34/56] drm/omap: drop omapdss-boot-init

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel The table of compatible values needed to be prefixed with "omapdss," is empty, so all of this code is doing nothing now. Let's drop it. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/Kconfig |

[PATCH v3 46/56] drm/omap: drop empty omap_encoder helper functions

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Cleanup empty functions for encoder enable, disable and atomic check. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_encoder.c | 28 -- 1 file changed, 28 deletions(-) diff --git a/drivers/gpu

[PATCH v3 52/56] drm/omap: squash omapdrm sub-modules into one

2020-11-05 Thread Tomi Valkeinen
;dss = NULL; } -EXPORT_SYMBOL_GPL(omapdss_device_disconnect); /* - * Components Handling @@ -290,7 +275,6 @@ void omapdss_gather_components(struct device *dev) for_each_available_child_of_node(dev->of_node, ch

[PATCH v3 41/56] drm/omap: dsi: Register a drm_bridge

2020-11-05 Thread Tomi Valkeinen
Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 134 -- 1 file changed, 89 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index f643321434e9..bbcdb62e1571 100644 --- a

[PATCH v3 38/56] drm/omap: panel-dsi-cm: fix remove()

2020-11-05 Thread Tomi Valkeinen
-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c index 086c7d71fe17..795db22d148d 100644 --- a/drivers/gpu/drm/omapdrm

[PATCH v3 48/56] drm/omap: drop dssdev display field

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel All displays are using drm_panel instead off dssdev now, so this field is always 0 and can be dropped. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c| 2 +- drivers/gpu/drm/omapdrm/dss/omapdss.h | 6 -- 2

[PATCH v3 42/56] drm/omap: remove legacy DSS device operations

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel All DSS devices have been converted to bridge API, so the device operations are always NULL. This removes the device ops function pointers and all code using it. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c

[PATCH v3 43/56] drm/omap: remove unused omap_connector

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Remove unused code. Connectors are now created via drm_bridge_connector_init() and no longer OMAP specific. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/Makefile | 1 - drivers/gpu/drm/omapdrm/omap_connector.c

[PATCH v3 39/56] drm/omap: remove global dss_device variable

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel We can simply provide the device to the omapdrm driver via pdata. omapdss_is_initialized() is no longer required (even before this patch), since omapdrm device is only registered after the pointer is initialized. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi

[PATCH v3 31/56] drm/omap: dsi: Reverse direction of the DSS device enable/disable operations

2020-11-05 Thread Tomi Valkeinen
nel driver moving it a bit further to a standard drm_panel driver. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 74 +-- drivers/gpu/drm/omapdrm/omap_encoder.c| 24 ++ 2 files changed, 45 inserti

[PATCH v3 10/56] drm/omap: dsi: simplify write function

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the write related messages handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/Kconfig | 1 + drivers/gpu/drm/omapdrm/dss/dsi.c | 146

[PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

2020-11-05 Thread Tomi Valkeinen
fy omap_display_id drm/omap: drop unused DSS next pointer drm/omap: drop empty omap_encoder helper functions drm/omap: drop DSS ops_flags drm/omap: drop dssdev display field drm/omap: simplify DSI manual update code drm/omap: dsi: simplify pin config ARM: omap2plus_defconfig: Update

[PATCH v3 24/56] drm/omap: dsi: lp/hs switching support for transfer()

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Integrate low-power / high-speed bus switching into transfer function and drop the omapdrm specific enable_hs() callback. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 6 +++--- drivers/gpu/drm

[PATCH v3 06/56] drm/omap: dsi: add generic transfer function

2020-11-05 Thread Tomi Valkeinen
patches. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 54 +++ drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ++ 2 files changed, 57 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm

[PATCH v3 08/56] drm/omap: dsi: unexport specific data transfer functions

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel After converting all DSI drivers, unexport the specific transfer functions. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 12 drivers/gpu/drm/omapdrm/dss/omapdss.h | 20 2

[PATCH v3 07/56] drm/omap: panel-dsi-cm: convert to transfer API

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This converts the panel-dsi-cm driver to use the transfer API instead of specific functions, so that the specific functions can be unexported and squashed into the generic transfer function. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu

[PATCH v3 11/56] drm/omap: dsi: simplify read functions

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Simplify the read related message handling by using the functionality provided by CONFIG_DRM_MIPI_DSI. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/dsi.c | 110 +- 1 file changed, 34

[PATCH v3 16/56] drm/omap: panel-dsi-cm: drop hardcoded VC

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel Use dsi->channel everywhere, which originates from DT. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 20 +++ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/

[PATCH v3 02/56] Revert "drm/omap: dss: Remove unused omap_dss_device operations"

2020-11-05 Thread Tomi Valkeinen
From: Sebastian Reichel This reverts commit 4ff8e98879e6eeae9d125dfcf3b642075d00089d. This is still needed by DSI. E.g. unloading modules without this will cause a crash. Signed-off-by: Sebastian Reichel Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/base.c | 26

<    5   6   7   8   9   10   11   12   13   14   >