Re: [PATCH v3 1/2] drm/rockchip: vop: clear DMA stop bit upon vblank on RK3066

On Mon, May 27 2024 at 20:11:49 -03:00:00, Val Packett wrote: The RK3066 VOP sets a dma_stop bit when it's done scanning out a frame and needs the driver to acknowledge that by clearing the bit. So unless we clear it "between" frames, the RGB output only shows noise instead of t

[PATCH v3 2/2] drm/rockchip: vop: enable VOP_FEATURE_INTERNAL_RGB on RK3066

The RK3066 does have RGB display output, so it should be marked as such. Fixes: f4a6de8 ("drm: rockchip: vop: add rk3066 vop definitions") Cc: sta...@vger.kernel.org Signed-off-by: Val Packett --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v3 1/2] drm/rockchip: vop: clear DMA stop bit upon vblank on RK3066

it, since it indicates exactly that: that the hardware is done with the frame. This seems to be a redundant synchronization mechanism that was removed in later iterations of the VOP hardware block. Fixes: f4a6de8 ("drm: rockchip: vop: add rk3066 vop definitions") Cc: sta...@vger.kernel.or

Re: [PATCH v2 1/2] drm/rockchip: vop: clear DMA stop bit upon vblank on RK3066

On Mon, May 27 2024 at 22:43:18 +02:00:00, Heiko Stübner wrote: Hi Val, Am Montag, 27. Mai 2024, 09:16:33 CEST schrieb Val Packett: On the RK3066, there is a bit that must be cleared, otherwise the picture does not show up on the display (at least for RGB). Fixes: f4a6de8 (&quo

[PATCH v2 2/2] drm/rockchip: vop: enable VOP_FEATURE_INTERNAL_RGB on RK3066

The RK3066 does have RGB display output, so it should be marked as such. Fixes: f4a6de8 ("drm: rockchip: vop: add rk3066 vop definitions") Cc: sta...@vger.kernel.org Signed-off-by: Val Packett --- v2: expanded commit message --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + 1 fi

[PATCH v2 1/2] drm/rockchip: vop: clear DMA stop bit upon vblank on RK3066

On the RK3066, there is a bit that must be cleared, otherwise the picture does not show up on the display (at least for RGB). Fixes: f4a6de8 ("drm: rockchip: vop: add rk3066 vop definitions") Cc: sta...@vger.kernel.org Signed-off-by: Val Packett --- v2: doing this on vblank makes

Re: [PATCH v4 2/3] drm/lima: Fix dma_resv deadlock at drm object pin time

hip RK3066 tablet, and it did fix the problem :) Thank you. Tested-by: Val Packett

Re: [PATCH 1/2] drm/rockchip: vop: clear DMA stop bit on flush on RK3066

On Sun, May 19 2024 at 09:59:47 +02:00:00, Greg KH wrote: On Sun, May 19, 2024 at 04:31:31AM -0300, Val Packett wrote: On the RK3066, there is a bit that must be cleared on flush, otherwise we do not get display output (at least for RGB). What commit id does this fix? I guess

[PATCH 1/2] drm/rockchip: vop: clear DMA stop bit on flush on RK3066

On the RK3066, there is a bit that must be cleared on flush, otherwise we do not get display output (at least for RGB). Signed-off-by: Val Packett Cc: sta...@vger.kernel.org --- Hi! This was required to get display working on an old RK3066 tablet, along with the next tiny patch in the series

[PATCH 2/2] drm/rockchip: vop: enable VOP_FEATURE_INTERNAL_RGB on RK3066

Signed-off-by: Val Packett Cc: sta...@vger.kernel.org --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c index 9bcb40a64..e2c6ba26f 100644 --- a/drivers/gpu