RE: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-10-24 Thread Zhang, Hawking
...@linux.intel.com; ogab...@kernel.org; tta...@habana.ai; Zhang, Hawking ; Kasiviswanathan, Harish ; Kuehling, Felix ; Tuikov, Luben ; michael.j.r...@intel.com Subject: Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem On Fri, Oct 20, 2023 at 7:42 PM Aravind

RE: [PATCH] fix a memory leak in amdgpu_ras_feature_enable

2023-09-14 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Cong Liu Sent: Thursday, September 14, 2023 17:46 To: Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Daniel Vetter ; Yang, Stanley ; Zhang, Hawking Cc: Cong

RE: [PATCH] nbio_v7_4: Add pointer check

2022-11-11 Thread Zhang, Hawking
[AMD Official Use Only - General] Hey, The patch does the right thing from coding principal perspective, but it is really redundant check in RAS context. The function is a hardware interrupt handler which is only triggered for specific RAS event. When software receives the interrupt, the

RE: [PATCH libdrm 2/2] tests/amdgpu: add memcpy dispatch test

2019-02-28 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Cui, Flora Sent: 2019年2月28日 13:44 To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH libdrm 2/2] tests/amdgpu: add memcpy dispatch test add memcpy

RE: [PATCH libdrm] tests/amdgpu: add dispatch test

2019-02-18 Thread Zhang, Hawking
Although the shader is simple enough, please work with CQE to test it on all gfx9 ASICs before push it. The patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Cui, Flora Sent: 2019年2月18日 12:56 To: amd-...@lists.freedesktop.org;

RE: [radeon-alex:amd-staging-drm-next 12/15] drivers/gpu//drm/amd/amdgpu/amdgpu_xgmi.c:117:1: warning: the frame size of 1040 bytes is larger than 1024 bytes

2018-11-06 Thread Zhang, Hawking
Fixed and pushed. Thanks. Regards, Hawking -Original Message- From: kbuild test robot Sent: 2018年11月7日 5:20 To: Zhang, Hawking Cc: kbuild-...@01.org; dri-devel@lists.freedesktop.org; Deucher, Alexander ; Liu, Shaoyun Subject: [radeon-alex:amd-staging-drm-next 12/15] drivers/gpu

[PATCH 1/2] drm/ttm: remove unused placement flags

2016-09-09 Thread Zhang, Hawking
Hi Chris, Removing the flag will make ttm_mem_type_from_place skip counting the corresponding placement and thus have impact on mem region create and bo movement. There is no guarantee that amdgpu would never introduce new memory domain in future. In such case, I'd like to vote for keeping

[PATCH 1/2] drm/ttm: remove unused placement flags

2016-09-09 Thread Zhang, Hawking
Hi Chris, Removing the flag will make ttm_mem_type_from_place skip counting the corresponding placement and thus have impact on mem region create and bo movement. There is no guarantee that amdgpu would never introduce new memory domain in future. In such case, I'd like to vote for keeping