Re: [virtio-dev] Re: [PATCH 1/2] virtio: add dma-buf support for exported objects

2020-02-26 Thread David Stevens
On Tue, Feb 25, 2020 at 3:10 PM Gerd Hoffmann wrote: > > On Wed, Feb 19, 2020 at 05:06:36PM +0900, David Stevens wrote: > > This change adds a new flavor of dma-bufs that can be used by virtio > > drivers to share exported objects. A virtio dma-buf can be queried by > >

[PATCH 2/2] drm/virtio: Support virtgpu exported resources

2020-02-19 Thread David Stevens
Add support for exported resources to virtgpu. This includes adding support for the new virtgpu command as well as well as switching from regular prime dma-bufs to virtio dma-bufs. Signed-off-by: David Stevens --- drivers/gpu/drm/virtio/virtgpu_drv.c | 3 + drivers/gpu/drm/virtio

[PATCH 0/2] Support virtio cross-device resources

2020-02-19 Thread David Stevens
/p5d3k566srtdtute David Stevens (2): virtio: add dma-buf support for exported objects drm/virtio: Support virtgpu exported resources drivers/gpu/drm/virtio/virtgpu_drv.c | 3 + drivers/gpu/drm/virtio/virtgpu_drv.h | 21 + drivers/gpu/drm/virtio/virtgpu_kms.c | 4 + drivers/gpu/drm/virtio

[PATCH 1/2] virtio: add dma-buf support for exported objects

2020-02-19 Thread David Stevens
This change adds a new flavor of dma-bufs that can be used by virtio drivers to share exported objects. A virtio dma-buf can be queried by virtio drivers to obtain the UUID which identifies the underlying exported object. Signed-off-by: David Stevens --- drivers/virtio/Makefile | 2

drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c:33:33: error: Buffer is accessed out of bounds

2020-02-10 Thread David Binderman
five bytes long. Suggest code rework. Regards David Binderman ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-5.6-rc1/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8411:45: error: Division by zero.

2020-02-10 Thread David Binderman
. Regards David Binderman ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 1/4] drm/tiny/repaper: Make driver OF-independent

2020-02-05 Thread David Lechner
On 2/5/20 3:31 PM, Sam Ravnborg wrote: Hi David. Are you planning to pick this series and apply it? Unless I get any other info I plan to process it tomorrow. Sam I won't be able to do it before then, so please go ahead. ___ dri-

RE: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

2020-01-24 Thread David Laight
re between 800MHz and 4GHz depending on the whim of the hardware (probable at the low end). Considerably faster, and enough that calling cond_resched() every 4k is probably noticable. So every 128 pages is probably a reasonable compromise. David > Reported-by: David Laight > Sign

Re: [PATCH v1 2/4] drm/tiny/repaper: No need to set ->owner for spi_register_driver()

2020-01-22 Thread David Lechner
On 1/22/20 4:54 AM, Andy Shevchenko wrote: The spi_register_driver() will set the ->owner member to THIS_MODULE. Signed-off-by: Andy Shevchenko --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org ht

Re: [PATCH v1 4/4] drm/tiny/st7735r: No need to set ->owner for spi_register_driver()

2020-01-22 Thread David Lechner
On 1/22/20 4:54 AM, Andy Shevchenko wrote: The spi_register_driver() will set the ->owner member to THIS_MODULE. Signed-off-by: Andy Shevchenko --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org ht

Re: [PATCH v1 3/4] drm/tiny/st7735r: Make driver OF-independent

2020-01-22 Thread David Lechner
On 1/22/20 4:54 AM, Andy Shevchenko wrote: There is one OF call in the driver that limits its area of use. Replace it to generic device_get_match_data() and get rid of OF dependency. Signed-off-by: Andy Shevchenko --- Acked-by: David Lechner

Re: [PATCH v2 1/5] dt-bindings: display: sitronix, st7735r: Convert to DT schema

2020-01-20 Thread David Lechner
e.org/meta-schemas/core.yaml# + +title: Sitronix ST7735R Display Panels Device Tree Bindings + +maintainers: + - David Lechner + +description: + This binding is for display panels using a Sitronix ST7735R controller in + SPI mode. + +allOf: + - $ref: panel/panel-common.yaml# not all of these propertie

RE: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

2020-01-17 Thread David Laight
-- Without the cond_sched I suspect more of them are 3.0ms. Not really a significant difference. I guess the longer times are the scheduler looking for work? I don't understand the extra traces - I'm guessing they are process switch related. David - Registered Address Lakesid

RE: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

2020-01-17 Thread David Laight
flushing large objects takes a demonstrable amount to time > > > to flush all the cachelines, clflush is still preferred over a > > > system-wide wbinvd as the latter has unpredictable latencies affecting > > > the whole system not just the local task. > > >

RE: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

2020-01-17 Thread David Laight
From: Chris Wilson > Sent: 16 January 2020 12:29 > > Quoting David Laight (2020-01-16 12:26:45) > > However there is a call from __i915_gem_objet_set_pages() that > > is preceded by a lockdep_assert_held() check - so mustn't sleep. > > That is a mutex; it

RE: [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg()

2020-01-17 Thread David Laight
From: David Laight > Sent: 16 January 2020 14:41 > > I'll do some measurements later this afternoon. > > This is an Ivy bridge cpu, so clflush (not clflushopt). > With a cond_resched for every page I get: > (Note these calls are every 10 seconds) For comparison

RE: drm_cflush_sg() loops for over 3ms - scheduler not running tasks.

2020-01-14 Thread David Laight
From: David Laight > Sent: 13 January 2020 14:35 > > I've been looking at why some RT processes don't get scheduled promptly. > In my test the RT process's affinity ties it to a single cpu (this may not be > such > a good idea as it seems). > > What I&#

drm_cflush_sg() loops for over 3ms

2020-01-14 Thread David Laight
ftrace scheduler events (and schedviz)) to the actual work item name. (Oh, after I'd written a program to tidy up the raw ftrace output so schedviz didn't barf on a trace that had wrapped.) Is there anything in /proc (etc) that shows all the work queues and their current work? Da

RE: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-09 Thread David Laight
the desired effect without adding extra instructions. (You might think 'volatile' would mean that - but it doesn't.) David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) ___

Re: [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T

2020-01-06 Thread David Lechner
On 1/6/20 3:28 AM, Geert Uytterhoeven wrote: Hi Sam, On Sun, Jan 5, 2020 at 10:13 AM Sam Ravnborg wrote: Good to see we add more functionality to the smallest driver in DRM. The patch triggered a few comments - see below. Some comments relates to the original driver - and not your changes. T

Re: [PATCH 1/3] dt-bindings: display: sitronix, st7735r: Add Okaya rh128128t

2020-01-06 Thread David Lechner
On 1/2/20 8:46 AM, Sam Ravnborg wrote: Hi Geert. On Thu, Jan 02, 2020 at 03:12:44PM +0100, Geert Uytterhoeven wrote: Document support for the Okaya RH128128T display, which is a 128x128 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver. ST7715R and ST7735R are very similar.

powernv build issue

2019-12-16 Thread David Hildenbrand
trick ) -- Thanks, David / dhildenb ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2] drm: add dp helper to initialize remote aux channel.

2019-12-06 Thread David (Dingchen) Zhang
is helper in DP MST port initialization. This, plus David Francis' patch [1], fix the issue of MST remote aux DPCD CRCs read. [1] https://patchwork.kernel.org/patch/11217941/ Cc: Leo Li Cc: Harry Wentland Signed-off-by: David (Dingchen) Zhang --- drivers/gpu/drm/drm_dp

Re: [PATCH 3/4] drm/mgag200: Add workaround for HW that does not support 'startadd'

2019-12-05 Thread David Airlie
On Fri, Dec 6, 2019 at 4:14 PM Thomas Zimmermann wrote: > > Hi > > Am 04.12.19 um 10:36 schrieb Dave Airlie: > > On Wed, 4 Dec 2019 at 17:30, Thomas Zimmermann wrote: > >> > >> Hi John > >> > >> Am 03.12.19 um 18:55 schrieb John Donnelly: > >>> Hi , > >>> > >>> See below , > >>> > >>> > On N

[PATCH 1/2] drm: add dp helper to initialize remote aux channel.

2019-12-05 Thread David (Dingchen) Zhang
is helper in DP MST port initialization. Cc: Leo Li Cc: Harry Wentland Signed-off-by: David (Dingchen) Zhang --- drivers/gpu/drm/drm_dp_helper.c | 13 + drivers/gpu/drm/drm_dp_mst_topology.c | 3 +++ include/drm/drm_dp_helper.h | 1 + 3 files changed, 17 insertions

Re: [PATCH] drm/tilcdc: Switch to using GPIO descriptors

2019-12-03 Thread David Lechner
Jyri Sarha Cc: Tomi Valkeinen Cc: David Lechner Signed-off-by: Linus Walleij --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 05/18] mm/gup: introduce pin_user_pages*() and FOLL_PIN

2019-11-04 Thread David Rientjes
On Sun, 3 Nov 2019, John Hubbard wrote: > Introduce pin_user_pages*() variations of get_user_pages*() calls, > and also pin_longterm_pages*() variations. > > These variants all set FOLL_PIN, which is also introduced, and > thoroughly documented. > > The pin_longterm*() variants also set FOLL_L

Re: [PATCH] drm/ttm: use the parent resv for ghost objects v2

2019-10-24 Thread Zhou, David(ChunMing)
dma_resv_add_excl_fence(ghost_obj->base.resv, fence); >> +    dma_resv_add_excl_fence(&ghost_obj->base._resv, fence); >>     /** >>    * If we're not moving to fixed memory, the TTM object >> @@ -724,7 +726,7 @@ int ttm_bo_move_accel_cleanup(s

Re: [PATCH 4/5] drm/dsi: rename MIPI_DCS_SET_PARTIAL_AREA to MIPI_DCS_SET_PARTIAL_ROWS

2019-10-22 Thread David Lechner
On 10/22/19 5:09 AM, Jani Nikula wrote: The DCS command has been named SET_PARTIAL_ROWS in the DCS spec since v1.02, for more than a decade. Rename the enumeration to match the spec. Cc: David Lechner Cc: Vandita Kulkarni Signed-off-by: Jani Nikula --- I guess all of my documents are old

linux-5.4-rc2/drivers/video/fbdev/amifb.c:1875: bad expression ?

2019-10-08 Thread David Binderman
ter code: datawords = (*(lspr + delta) << 16) | (*lspr); ++lspr; Regards David Binderman ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/1] drm/syncobj: add sideband payload

2019-09-17 Thread Zhou, David(ChunMing)
Hi Lionel, The update looks good to me. I tried your signal-order test, seems it isn't ready to run, not sure if I can reproduce your this issue. -David From: Lionel Landwerlin Sent: Tuesday, September 17, 2019 7:03 PM To: dri-devel@lists.freedesktop.or

[PATCH] drm/virtio: Fix warning in virtio_gpu_queue_fenced_ctrl_buffer.

2019-09-12 Thread David Riley
Fix warning introduced with commit e1218b8c0cc1 ("drm/virtio: Use vmalloc for command buffer allocations.") from drm-misc-next. Signed-off-by: David Riley --- drivers/gpu/drm/virtio/virtgpu_vq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/

[PATCH v4 2/2] drm/virtio: Use vmalloc for command buffer allocations.

2019-09-11 Thread David Riley
Userspace requested command buffer allocations could be too large to make as a contiguous allocation. Use vmalloc if necessary to satisfy those allocations. Signed-off-by: David Riley --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +- drivers/gpu/drm/virtio/virtgpu_vq.c| 78

[PATCH v4 1/2] drm/virtio: Rewrite virtio_gpu_queue_ctrl_buffer using fenced version.

2019-09-11 Thread David Riley
Factor function in preparation to generating scatterlist prior to locking. Signed-off-by: David Riley --- drivers/gpu/drm/virtio/virtgpu_vq.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio

[PATCH v4 0/2] drm/virtio: Use vmalloc for command buffer alllocations.

2019-09-11 Thread David Riley
s. v4: Rebase onto drm-misc-next. David Riley (2): drm/virtio: Rewrite virtio_gpu_queue_ctrl_buffer using fenced version. drm/virtio: Use vmalloc for command buffer allocations. drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +- drivers/gpu/drm/virtio/virtgpu_vq.c| 98

Re: [PATCH v3 1/2] drm/virtio: Rewrite virtio_gpu_queue_ctrl_buffer using fenced version.

2019-09-11 Thread David Riley
They were based off of Linus' https://github.com/torvalds/linux master from yesterday. I can rebase onto drm-misc-next. On Tue, Sep 10, 2019 at 10:12 PM Gerd Hoffmann wrote: > > On Tue, Sep 10, 2019 at 01:06:50PM -0700, David Riley wrote: > > Factor function in preparat

[PATCH v3 2/2] drm/virtio: Use vmalloc for command buffer allocations.

2019-09-10 Thread David Riley
Userspace requested command buffer allocations could be too large to make as a contiguous allocation. Use vmalloc if necessary to satisfy those allocations. Signed-off-by: David Riley --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +- drivers/gpu/drm/virtio/virtgpu_vq.c| 79

[PATCH v3 1/2] drm/virtio: Rewrite virtio_gpu_queue_ctrl_buffer using fenced version.

2019-09-10 Thread David Riley
Factor function in preparation to generating scatterlist prior to locking. Signed-off-by: David Riley --- drivers/gpu/drm/virtio/virtgpu_vq.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio

Re: [PATCH v2] drm/virtio: Use vmalloc for command buffer allocations.

2019-09-09 Thread David Riley
if (!sgt) > > + return -ENOMEM; > > + vout = sgt->sgl; > > + } else { > > + sg_init_one(&sg, vbuf->data_buf, vbuf->data_size); > > + vout = &sg; > > + outcnt = 1; > > outcnt must be set in both cases. outcnt is set by vmalloc_to_sgt. > > > +static int virtio_gpu_queue_ctrl_buffer(struct virtio_gpu_device *vgdev, > > + struct virtio_gpu_vbuffer *vbuf) > > +{ > > + return virtio_gpu_queue_fenced_ctrl_buffer(vgdev, vbuf, NULL, NULL); > > +} > > Changing virtio_gpu_queue_ctrl_buffer to call > virtio_gpu_queue_fenced_ctrl_buffer should be done in a separate patch. Will do. Thanks, David

Re: [PATCH] mm, notifier: Fix early return case for new lockdep annotations

2019-09-09 Thread David Hildenbrand
_start_map); > if (mm_has_notifiers(range->mm)) { > range->flags &= ~MMU_NOTIFIER_RANGE_BLOCKABLE; > - return __mmu_notifier_invalidate_range_start(range); > + ret = __mmu_notifier_invalidate_range_start(range); > } > lock_map_release(&

[PATCH v2] drm/virtio: Use vmalloc for command buffer allocations.

2019-09-05 Thread David Riley
Userspace requested command buffer allocations could be too large to make as a contiguous allocation. Use vmalloc if necessary to satisfy those allocations. Signed-off-by: David Riley --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +- drivers/gpu/drm/virtio/virtgpu_vq.c| 114

Re: [PATCH] drm/virtio: Use vmalloc for command buffer allocations.

2019-09-03 Thread David Riley
On Sun, Sep 1, 2019 at 10:28 PM Gerd Hoffmann wrote: > > On Fri, Aug 30, 2019 at 10:49:25AM -0700, David Riley wrote: > > Hi Gerd, > > > > On Fri, Aug 30, 2019 at 4:16 AM Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > > >

Re: [PATCH] drm/virtio: Use vmalloc for command buffer allocations.

2019-08-30 Thread David Riley
Hi Gerd, On Fri, Aug 30, 2019 at 4:16 AM Gerd Hoffmann wrote: > > Hi, > > > > > - kfree(vbuf->data_buf); > > > > + kvfree(vbuf->data_buf); > > > > > > if (is_vmalloc_addr(vbuf->data_buf)) ... > > > > > > needed here I gues? > > > > > > > kvfree() handles vmalloc/kmalloc/kvmalloc interna

Re: [PATCH] drm/virtio: Use vmalloc for command buffer allocations.

2019-08-29 Thread David Riley
On Thu, Aug 29, 2019 at 11:09 PM Gerd Hoffmann wrote: > Hi, > > > { > > if (vbuf->resp_size > MAX_INLINE_RESP_SIZE) > > kfree(vbuf->resp_buf); > > - kfree(vbuf->data_buf); > > + kvfree(vbuf->data_buf); > > if (is_vmalloc_addr(vbuf->data_buf)) ... > > needed here I g

[PATCH] drm/virtio: Use vmalloc for command buffer allocations.

2019-08-29 Thread David Riley
Userspace requested command buffer allocations could be too large to make as a contiguous allocation. Use vmalloc if necessary to satisfy those allocations. Signed-off-by: David Riley --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 +- drivers/gpu/drm/virtio/virtgpu_vq.c| 74

Re: [PATCH v9 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

2019-08-27 Thread Francis, David
t;> Cc: Lyude Paul >> Cc: Jani Nikula >> Cc: Harry Wentland >> Reviewed-by: Wenjing Liu >> Signed-off-by: David Francis >> --- >> drivers/gpu/drm/drm_dp_mst_topology.c | 153 ++ >> include/drm/drm_dp_mst_helper.h | 2 + >

[PATCH v9 4/6] drm/dp_mst: Fill branch->num_ports

2019-08-27 Thread David Francis
to 0 Signed-off-by: David Francis Reviewed-by: Lyude Paul Reviewed-by: Harry Wentland --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 9f3604355705..502923c24450 1

[PATCH v9 3/6] drm/dp_mst: Add MST support to DP DPCD R/W functions

2019-08-27 Thread David Francis
Reviewed-by: Harry Wentland Signed-off-by: David Francis --- drivers/gpu/drm/drm_dp_aux_dev.c | 12 ++-- drivers/gpu/drm/drm_dp_helper.c | 30 -- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_aux_dev.c b/drivers/gpu/drm

[PATCH v9 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

2019-08-27 Thread David Francis
is a DP feature new in DP v1.4, which exposes certain DPCD registers on virtual ports. v2: Remember to unlock mutex on all paths v3: Refactor to match coding style and increase brevity Cc: Lyude Paul Cc: Jani Nikula Cc: Harry Wentland Reviewed-by: Wenjing Liu Signed-off-by: David Francis ---

[PATCH v9 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

2019-08-27 Thread David Francis
Wentland Reviewed-by: Wenjing Liu Signed-off-by: David Francis --- drivers/gpu/drm/drm_dp_helper.c | 2 ++ include/drm/drm_dp_helper.h | 7 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 2cc21eff4cf3..fc39323e7d52

[PATCH v9 1/6] drm/dp_mst: Add PBN calculation for DSC modes

2019-08-27 Thread David Francis
s Cc: amd-...@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Cc: intel-...@lists.freedesktop.org Reviewed-by: Manasi Navare Reviewed-by: Lyude Paul Reviewed-by: Harry Wentland Signed-off-by: David Francis --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 2 +- drivers/gp

[PATCH v9 2/6] drm/dp_mst: Parse FEC capability on MST ports

2019-08-27 Thread David Francis
Store it on drm_dp_mst_port Signed-off-by: David Francis Reviewed-by: Lyude Paul Reviewed-by: Harry Wentland --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ include/drm/drm_dp_mst_helper.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b

[PATCH v9 0/6] DSC MST support in DRM

2019-08-27 Thread David Francis
v6: Fix typo, split last patch in two v7: Fix compilation warnings v8: Fix a missing mutex_unlock v9: Refactor last patch David Francis (6): drm/dp_mst: Add PBN calculation for DSC modes drm/dp_mst: Parse FEC capability on MST ports drm/dp_mst: Add MST support to DP DPCD R/W functions drm

Re: [PATCH v8 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

2019-08-26 Thread Francis, David
Received offline review from AMD MST DSC (Non-Linux) expert Wenjing Liu, giving me permission to mark this patch Reviewed-by: Wenjing Liu From: David Francis Sent: August 26, 2019 2:05 PM To: dri-devel@lists.freedesktop.org Cc: Francis, David; Lyude

Re: [PATCH v8 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

2019-08-26 Thread Francis, David
On 2019-08-26 2:05 p.m., David Francis wrote: >> Synaptics DP1.4 hubs (BRANCH_ID 0x90CC24) do not >> support virtual DPCD registers, but do support DSC. >> The DSC caps can be read from the physical aux, >> like in SST DSC. These hubs have many different >> DEVICE_I

[PATCH v8 3/6] drm/dp_mst: Add MST support to DP DPCD R/W functions

2019-08-26 Thread David Francis
-off-by: David Francis --- drivers/gpu/drm/drm_dp_aux_dev.c | 12 ++-- drivers/gpu/drm/drm_dp_helper.c | 30 -- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_aux_dev.c b/drivers/gpu/drm/drm_dp_aux_dev.c index

[PATCH v8 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

2019-08-26 Thread David Francis
is a DP feature new in DP v1.4, which exposes certain DPCD registers on virtual ports. v2: Remember to unlock mutex on all paths Cc: Lyude Paul Cc: Jani Nikula Signed-off-by: David Francis --- drivers/gpu/drm/drm_dp_mst_topology.c | 152 ++ include/drm/drm_dp_mst_helpe

[PATCH v8 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

2019-08-26 Thread David Francis
: David Francis --- drivers/gpu/drm/drm_dp_helper.c | 2 ++ include/drm/drm_dp_helper.h | 7 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 2cc21eff4cf3..fc39323e7d52 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b

[PATCH v8 1/6] drm/dp_mst: Add PBN calculation for DSC modes

2019-08-26 Thread David Francis
s Cc: amd-...@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Cc: intel-...@lists.freedesktop.org Reviewed-by: Manasi Navare Reviewed-by: Lyude Paul Signed-off-by: David Francis --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 2 +- drivers/gpu/drm/drm_dp_mst_topol

[PATCH v8 4/6] drm/dp_mst: Fill branch->num_ports

2019-08-26 Thread David Francis
to 0 Signed-off-by: David Francis Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 9f3604355705..502923c24450 100644 --- a/drivers/gp

[PATCH v8 0/6] DSC MST support in DRM

2019-08-26 Thread David Francis
Add necessary support for MST DSC. (Display Stream Compression over Multi-Stream Transport) v4: Split patchset and rebase onto drm-tip v5: Clean up formatting, make new quirk v6: Fix typo, split last patch in two v7: Fix compilation warnings v8: Fix a missing mutex_unlock David Francis (6

[PATCH v8 2/6] drm/dp_mst: Parse FEC capability on MST ports

2019-08-26 Thread David Francis
Store it on drm_dp_mst_port Signed-off-by: David Francis Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ include/drm/drm_dp_mst_helper.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm

[PATCH v7 0/6] DSC MST support in DRM

2019-08-26 Thread David Francis
Add necessary support for MST DSC. (Display Stream Compression over Multi-Stream Transport) v4: Split patchset and rebase onto drm-tip v5: Clean up formatting, make new quirk v6: Fix typo, split last patch in two v7: Fix compilation warnings David Francis (6): drm/dp_mst: Add PBN calculation

[PATCH v7 4/6] drm/dp_mst: Fill branch->num_ports

2019-08-26 Thread David Francis
to 0 Signed-off-by: David Francis Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 9f3604355705..502923c24450 100644 --- a/drivers/gp

[PATCH v7 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

2019-08-26 Thread David Francis
is a DP feature new in DP v1.4, which exposes certain DPCD registers on virtual ports. Cc: Lyude Paul Cc: Jani Nikula Signed-off-by: David Francis --- drivers/gpu/drm/drm_dp_mst_topology.c | 150 ++ include/drm/drm_dp_mst_helper.h | 2 + 2 files changed, 152 inse

[PATCH v7 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

2019-08-26 Thread David Francis
: David Francis --- drivers/gpu/drm/drm_dp_helper.c | 2 ++ include/drm/drm_dp_helper.h | 7 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 2cc21eff4cf3..fc39323e7d52 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b

[PATCH v7 2/6] drm/dp_mst: Parse FEC capability on MST ports

2019-08-26 Thread David Francis
Store it on drm_dp_mst_port Signed-off-by: David Francis Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ include/drm/drm_dp_mst_helper.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm

[PATCH v7 3/6] drm/dp_mst: Add MST support to DP DPCD R/W functions

2019-08-26 Thread David Francis
-off-by: David Francis --- drivers/gpu/drm/drm_dp_aux_dev.c | 12 ++-- drivers/gpu/drm/drm_dp_helper.c | 30 -- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_aux_dev.c b/drivers/gpu/drm/drm_dp_aux_dev.c index

[PATCH v7 1/6] drm/dp_mst: Add PBN calculation for DSC modes

2019-08-26 Thread David Francis
s Cc: amd-...@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Cc: intel-...@lists.freedesktop.org Reviewed-by: Manasi Navare Reviewed-by: Lyude Paul Signed-off-by: David Francis --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 2 +- drivers/gpu/drm/drm_dp_mst_topol

[PATCH v6 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

2019-08-26 Thread David Francis
: David Francis --- drivers/gpu/drm/drm_dp_helper.c | 2 ++ include/drm/drm_dp_helper.h | 7 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 2cc21eff4cf3..fc39323e7d52 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b

[PATCH v6 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

2019-08-26 Thread David Francis
is a DP feature new in DP v1.4, which exposes certain DPCD registers on virtual ports. Cc: Lyude Paul Cc: Jani Nikula Signed-off-by: David Francis --- drivers/gpu/drm/drm_dp_mst_topology.c | 148 ++ include/drm/drm_dp_mst_helper.h | 2 + 2 files changed, 150 inse

[PATCH v6 2/6] drm/dp_mst: Parse FEC capability on MST ports

2019-08-26 Thread David Francis
Store it on drm_dp_mst_port Signed-off-by: David Francis Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ include/drm/drm_dp_mst_helper.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm

[PATCH v6 1/6] drm/dp_mst: Add PBN calculation for DSC modes

2019-08-26 Thread David Francis
s Cc: amd-...@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Cc: intel-...@lists.freedesktop.org Reviewed-by: Manasi Navare Reviewed-by: Lyude Paul Signed-off-by: David Francis --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 2 +- drivers/gpu/drm/drm_dp_mst_topol

[PATCH v6 4/6] drm/dp_mst: Fill branch->num_ports

2019-08-26 Thread David Francis
to 0 Signed-off-by: David Francis Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 9f3604355705..502923c24450 100644 --- a/drivers/gp

[PATCH v6 3/6] drm/dp_mst: Add MST support to DP DPCD R/W functions

2019-08-26 Thread David Francis
-off-by: David Francis --- drivers/gpu/drm/drm_dp_aux_dev.c | 12 ++-- drivers/gpu/drm/drm_dp_helper.c | 30 -- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_aux_dev.c b/drivers/gpu/drm/drm_dp_aux_dev.c index

[PATCH v6 0/6] DSC MST support in DRM

2019-08-26 Thread David Francis
Add necessary support for MST DSC. (Display Stream Compression over Multi-Stream Transport) v4: Split patchset and rebase onto drm-tip v5: Clean up formatting, make new quirk v6: Fix typo, split last patch in two David Francis (6): drm/dp_mst: Add PBN calculation for DSC modes drm/dp_mst

[PATCH v5 5/5] drm/dp_mst: Add helper for finding right aux to enable/query DSC

2019-08-23 Thread David Francis
is a DP feature new in DP v1.4, which exposes certain DPCD registers on virtual ports. ALso add a new quirk for Synatics MST hubs that support DSC despite not supporting virtual DPCD. Cc: Lyude Paul Cc: Wenjing Liu Cc: Nikola Cornij Signed-off-by: David Francis --- drivers/gpu/drm/drm_dp_helpe

[PATCH v5 4/5] drm/dp_mst: Fill branch->num_ports

2019-08-23 Thread David Francis
to 0 Signed-off-by: David Francis Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 11b02f6b9e8a..a39e42c7d868 100644 --- a/drivers/gp

[PATCH v5 2/5] drm/dp_mst: Parse FEC capability on MST ports

2019-08-23 Thread David Francis
Store it on drm_dp_mst_port Signed-off-by: David Francis Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ include/drm/drm_dp_mst_helper.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm

[PATCH v5 0/5] DSC MST support in DRM

2019-08-23 Thread David Francis
Add necessary support for MST DSC. (Display Stream Compression over Multi-Stream Transport) v4: Split patchset and rebase onto drm-tip v5: Clean up formatting, make new quirk David Francis (5): drm/dp_mst: Add PBN calculation for DSC modes drm/dp_mst: Parse FEC capability on MST ports drm

[PATCH v5 1/5] drm/dp_mst: Add PBN calculation for DSC modes

2019-08-23 Thread David Francis
s Cc: Lyude Paul Signed-off-by: David Francis --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 2 +- drivers/gpu/drm/drm_dp_mst_topology.c| 16 drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/disp.c

[PATCH v5 3/5] drm/dp_mst: Add MST support to DP DPCD R/W functions

2019-08-23 Thread David Francis
-off-by: David Francis --- drivers/gpu/drm/drm_dp_aux_dev.c | 12 ++-- drivers/gpu/drm/drm_dp_helper.c | 30 -- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_aux_dev.c b/drivers/gpu/drm/drm_dp_aux_dev.c index

Re: [PATCH v4 0/5] MST DSC support in drm-mst

2019-08-23 Thread Francis, David
s going to be a major rewrite. MST DSC hardware is already on the market. It would be expedient to merge the patches we need for Navi support sooner and update drm_dp_mst_atomic_check when we're able to test it. David Francis From: Lyude Paul Sent: Au

[PATCH v4 5/5] drm/dp-mst: Add helpers for querying and enabling MST DSC

2019-08-22 Thread David Francis
k branch_dev_id = 0x90CC24 (Synaptix) - There is exactly one branch device between the link and output In this case, DSC can be attempted, but only using the *link* aux device's caps. This is a quirk. Cc: Lyude Paul Cc: Wenjing Liu Cc: Nikola Cornij Signed-off-by: David Francis

[PATCH v4 4/5] drm/dp-mst: Fill branch->num_ports

2019-08-22 Thread David Francis
This field on drm_dp_mst_branch was never filled Initialize it to zero when the list of ports is created. When a port is added to the list, increment num_ports, and when a port is removed from the list, decrement num_ports. v2: remember to decrement on port removal Signed-off-by: David Francis

[PATCH v4 2/5] drm/dp-mst: Parse FEC capability on MST ports

2019-08-22 Thread David Francis
Store it on drm_dp_mst_port Signed-off-by: David Francis Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ include/drm/drm_dp_mst_helper.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm

[PATCH v4 3/5] drm/dp-mst: Add MST support to DP DPCD R/W functions

2019-08-22 Thread David Francis
Instead of having drm_dp_dpcd_read/write and drm_dp_mst_dpcd_read/write as entry points into the aux code, have drm_dp_dpcd_read/write handle both. This means that DRM drivers can make MST DPCD read/writes. v2: Fix spacing Cc: Leo Li Cc: Lyude Paul Signed-off-by: David Francis --- drivers

[PATCH v4 1/5] drm/dp-mst: Add PBN calculation for DSC modes

2019-08-22 Thread David Francis
With DSC, bpp can be a multiple of 1/16, so drm_dp_calc_pbn_mode is insufficient. Add drm_dp_calc_pbn_mode_dsc, a function which is the same as drm_dp_calc_pbn_mode, but the bpp is in units of 1/16. Reviewed-by: Lyude Paul Signed-off-by: David Francis --- drivers/gpu/drm/drm_dp_mst_topology.c

[PATCH v4 0/5] MST DSC support in drm-mst

2019-08-22 Thread David Francis
Add necessary support for MST DSC. (Display Stream COmpression over Multi-Stream Transport) v4: Split patchset and rebase onto drm-tip David Francis (5): drm/dp-mst: Add PBN calculation for DSC modes drm/dp-mst: Parse FEC capability on MST ports drm/dp-mst: Add MST support to DP DPCD R/W

Re: [PATCH v3 00/16] Display Stream Compression (DSC) for AMD Navi

2019-08-22 Thread Francis, David
I was building against amd-staging-drm-next (commit e4a67e6cf14c). v4 will contain just the drm-mst patches and will apply on latest drm-tip/drm-tip (commit 018886de4726) From: Lyude Paul Sent: August 21, 2019 5:20 PM To: Francis, David; dri-devel

Re: [PATCH v3 13/16] drm/amd/display: Validate DSC caps on MST endpoints

2019-08-22 Thread Francis, David
Whoops, left in a test print. Ignore this patch From: David Francis Sent: August 21, 2019 4:01 PM To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Francis, David; Liu, Wenjing; Cornij, Nikola Subject: [PATCH v3 13/16] drm/amd

Re: [PATCH v2] drm/qxl: get vga ioports

2019-08-22 Thread David Airlie
Reviewed-by: Dave Airlie On Thu, Aug 22, 2019 at 4:59 PM Gerd Hoffmann wrote: > > On Mon, Aug 05, 2019 at 12:54:01PM +0200, Gerd Hoffmann wrote: > > qxl has two modes: "native" (used by the drm driver) and "vga" (vga > > compatibility mode, typically used for boot display and firmware > > frameb

Re: [PATCH v3 16/16] drm/amd/display: Trigger modesets on MST DSC connectors

2019-08-21 Thread Francis, David
is clear what functionality is common between drivers From: dri-devel on behalf of David Francis Sent: August 21, 2019 4:01 PM To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Li, Sun peng (Leo); Francis, David; Kazlauskas

[PATCH v3 12/16] drm/dp-mst: Add helpers for querying and enabling MST DSC

2019-08-21 Thread David Francis
k branch_dev_id = 0x90CC24 (Synaptix) - There is exactly one branch device between the link and output In this case, DSC can be attempted, but only using the *link* aux device's caps. This is a quirk. Cc: Lyude Paul Cc: Wenjing Liu Cc: Nikola Cornij Signed-off-by: David Francis

[PATCH v3 15/16] drm/amd/display: MST DSC compute fair share

2019-08-21 Thread David Francis
end of amdgpu atomic check. If it fails, fail check; This combination of timings cannot be supported. Cc: Wenjing Liu Cc: Nikola Cornij Signed-off-by: David Francis --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 + .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 375

[PATCH v3 14/16] drm/amd/display: Write DSC enable to MST DPCD

2019-08-21 Thread David Francis
Rework the dm_helpers_write_dsc_enable callback to handle the MST case. Use the drm_dp_mst_dsc_enable helper. Cc: Wenjing Liu Cc: Nikola Cornij Signed-off-by: David Francis --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 16 +++- 1 file changed, 15 insertions(+), 1

[PATCH v3 13/16] drm/amd/display: Validate DSC caps on MST endpoints

2019-08-21 Thread David Francis
During MST mode enumeration, if a new dc_sink is created, populate it with dsc caps as appropriate. Use drm_dp_mst_dsc_caps_for_port to get the raw caps, then parse them onto dc_sink with dc_dsc_parse_dsc_dpcd. Cc: Wenjing Liu Cc: Nikola Cornij Signed-off-by: David Francis --- .../display

[PATCH v3 16/16] drm/amd/display: Trigger modesets on MST DSC connectors

2019-08-21 Thread David Francis
before adding connectors and planes on modesetting crtcs Cc: Leo Li Cc: Nicholas Kazlauskas Cc: Lyude Paul Signed-off-by: David Francis --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 77 +++ 1 file changed, 77 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH v3 11/16] drm/dp-mst: Fill branch->num_ports

2019-08-21 Thread David Francis
This field on drm_dp_mst_branch was never filled Initialize it to zero when the list of ports is created. When a port is added to the list, increment num_ports, and when a port is removed from the list, decrement num_ports. v2: remember to decrement on port removal Signed-off-by: David Francis

[PATCH v3 09/16] drm/dp-mst: Parse FEC capability on MST ports

2019-08-21 Thread David Francis
Store it on drm_dp_mst_port Signed-off-by: David Francis Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ include/drm/drm_dp_mst_helper.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm

<    3   4   5   6   7   8   9   10   11   12   >