[PATCH v5 09/12] drm/rockchip: analogix_dp: Disable clock when unbinding

The clock is enabled when binding cdn dp. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

Hi Sean, On 04/06/2017 12:28 AM, Sean Paul wrote: On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote: After unbinding drm, the userspace may still has a chance to access gem buf. Add a sanity check for a NULL dev_private to prevent that from happening. I still don't understand how

[PATCH v5 00/12] drm: rockchip: Fix rockchip drm unbind crash error

;'s comments. Update commit message. Address Sean Paul <seanp...@chromium.org>'s comments. Update commit message. Address Daniel Vetter <dan...@ffwll.ch>'s comments. Update commit message. Changes in v2: Fix some commit messages. Jeffy Chen (12): drm: bridge: analogix: Detach panel

Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

Hi Daniel, On 04/06/2017 04:26 PM, Daniel Vetter wrote: On Wed, Apr 05, 2017 at 12:28:40PM -0400, Sean Paul wrote: On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote: After unbinding drm, the userspace may still has a chance to access gem buf. Add a sanity check for a NULL

[PATCH v5 04/12] drm: bridge: analogix: Destroy connector & encoder when unbinding

. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: None Changes in v4: Address Andrzej Hajda <a.ha...@samsung.com>'s comments. Changes in v3: None Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered

After unbinding drm, the user space may still owns the drm dev fd, and may still be able to call drm ioctl. Add a sanity check here to prevent that from happening. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes

Re: [PATCH v3 3/9] drm: bridge: analogix: Destroy connector when unbinding

Hi Andrzej, On 04/06/2017 03:19 PM, Andrzej Hajda wrote: On 05.04.2017 10:29, Jeffy Chen wrote: Normally we do this in drm_mode_config_cleanup. But analogix dp's connector is allocated in bind, and freed after unbind. So we need to destroy it in unbind to avoid further access. Signed-off

[PATCH v5 02/12] drm: bridge: analogix: Unregister dp aux when unbinding

The dp aux is registered when binding analogix dp. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_d

[PATCH v5 05/12] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-cor

Re: [PATCH v3 2/9] drm: bridge: analogix: Unregister dp aux when unbinding

Hi Andrzej, On 04/06/2017 03:11 PM, Andrzej Hajda wrote: On 05.04.2017 10:29, Jeffy Chen wrote: The dp aux is registered when binding analogix dp. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Btw, if you are wor

[PATCH v3 0/9] drm: rockchip: Fix rockchip drm unbind crash error

<dan...@ffwll.ch>'s comments. Update commit message. Address Daniel Vetter <dan...@ffwll.ch>'s comments. Update commit message. Update commit message. Changes in v2: Fix some commit messages. Jeffy Chen (9): drm: bridge: analogix: Detach panel when unbinding analogix dp drm: bri

[PATCH v3 2/9] drm: bridge: analogix: Unregister dp aux when unbinding

The dp aux is registered when binding analogix dp. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: None Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/an

Re: [PATCH v2 5/9] drm/rockchip: vop: Enable pm domain when resetting vop

Hi Sean, On 04/05/2017 03:42 AM, Sean Paul wrote: On Sat, Apr 01, 2017 at 07:35:25PM +0800, Jeffy Chen wrote: Hi Jeffy, Could you please add commit messages describing *why* you're making the change? It might be obvious to you (and maybe me), but others will benefit from better descriptions

[PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

After unbinding drm, the userspace may still has a chance to access gem buf. Add a sanity check for a NULL dev_private to prevent that from happening. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: Address Daniel Vetter <dan...@ffwll.ch>'s comments. U

[PATCH v3 9/9] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding

After snd_soc_unregister_codec, the dai link would remain bound to the invalid codec. That would cause crashes after unbind dp driver. Let's unregister audio codec when removing dp driver to prevent that. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: Update

[PATCH v3 7/9] drm/rockchip: Shutdown all crtcs when unbinding drm

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: Address Daniel Vetter <dan...@ffwll.ch>'s comments. Update commit message. Changes in v2: None drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/

[PATCH v3 5/9] drm/rockchip: vop: Enable pm domain before vop_initial

to the end of vop_bind for eaiser error handling. 2/ correct the err_put_pm_runtime of vop_enable. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: Address Sean Paul <seanp...@chromium.org>'s comments. Update commit message. Changes in v2: None drivers/gpu/

[PATCH v3 3/9] drm: bridge: analogix: Destroy connector when unbinding

Normally we do this in drm_mode_config_cleanup. But analogix dp's connector is allocated in bind, and freed after unbind. So we need to destroy it in unbind to avoid further access. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: None Changes in v2: None drive

[PATCH v3 4/9] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: None Changes in v2: None drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c

Re: [PATCH v2 7/9] drm/rockchip: Force disable all crtc when unload

Hi Daniel, On 04/03/2017 03:58 PM, Daniel Vetter wrote: On Sat, Apr 1, 2017 at 1:35 PM, Jeffy Chen <jeffy.c...@rock-chips.com> wrote: diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index a5d83cb..5dbf011 100644 --- a/drivers/g

Re: [PATCH v2 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered

Hi Daniel, On 04/03/2017 03:41 PM, Daniel Vetter wrote: On Sat, Apr 01, 2017 at 07:35:28PM +0800, Jeffy Chen wrote: Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None Wut? How is this even possible? If you haven't registered the driver yet, there's

Re: [PATCH v2 6/9] drm/rockchip: Reoder unload sequence

Hi Sean, On 04/05/2017 03:44 AM, Sean Paul wrote: On Sat, Apr 01, 2017 at 07:35:26PM +0800, Jeffy Chen wrote: We should not cleanup iommu before cleanup other resources. Reorder unload sequence, follow exynos drm. This doesn't match the cleanup sequence in rockchip_drm_bind. Also make sure

[PATCH v3 6/9] drm/rockchip: Reoder drm bind/unbind sequence

Current drm bind/unbind sequence would cause some memory issues. For example we should not cleanup iommu before cleanup mode config. Reorder bind/unbind sequence, follow exynos drm. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: Address Sean Paul <seanp...@chr

[PATCH v3 1/9] drm: bridge: analogix: Detach panel when unbinding analogix dp

The panel is attached when binding analogix dp. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: None Changes in v2: Fix some commit messages. drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/

[PATCH 1/9] drm: bridge: analogix: Detach panel when unbinding analogix dp

The panel is attached when binding analogix dp. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/

[PATCH 4/9] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index fd79a70..a97f3f4 100644 --- a/drive

[PATCH v2 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index df9e570..2

[PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error

Verified on rk3399 chromebook kevin: 1/ stop ui && pkill -9 frecon 2/ unbind/bind drm Jeffy Chen (9): drm: bridge: analogix: Detach panel when unbinding analogix dp drm: bridge: analogix: Unregister dp aux when unbinding drm: bridge: analogix: Destroy connector when unbindi

[PATCH v2 5/9] drm/rockchip: vop: Enable pm domain when resetting vop

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 31 +++-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/ro

[PATCH 7/9] drm/rockchip: Force disable all crtc when unload

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index a5d83cb..5dbf011 100644 --- a/drivers/g

[PATCH v2 2/9] drm: bridge: analogix: Unregister dp aux when unbinding

The dp aux is registered when binding analogix dp. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/d

[PATCH 3/9] drm: bridge: analogix: Destroy connector when unbinding

Normally we do this in drm_mode_config_cleanup. But analogix dp's connector is allocated when binding, and would be freed after unbind. So we need to destroy it when unbinding, to avoid further access. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/bridge/an

[PATCH 9/9] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding

In current sound framework, there's no way to unbind dai link after unregister codec. So don't unregister the codec when unbinding for now. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH v2 7/9] drm/rockchip: Force disable all crtc when unload

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index a5d83cb..5dbf011

[PATCH 5/9] drm/rockchip: vop: Enable pm domain when resetting vop

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 31 +++-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm

[PATCH v2 0/9] drm: rockchip: Fix rockchip drm unbind crash error

Verified on rk3399 chromebook kevin: 1/ stop ui && pkill -9 frecon 2/ unbind/bind drm Changes in v2: Fix some commit messages. Jeffy Chen (9): drm: bridge: analogix: Detach panel when unbinding analogix dp drm: bridge: analogix: Unregister dp aux when unbinding drm: bridge:

[PATCH v2 3/9] drm: bridge: analogix: Destroy connector when unbinding

Normally we do this in drm_mode_config_cleanup. But analogix dp's connector is allocated in bind, and freed after unbind. So we need to destroy it in unbind to avoid further access. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None drivers/gpu/drm/bridge/an

[PATCH 2/9] drm: bridge: analogix: Unregister dp aux when unbinding

The dp aux is registered when binding analogix dp. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/

[PATCH v2 1/9] drm: bridge: analogix: Detach panel when unbinding analogix dp

The panel is attached when binding analogix dp. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: Fix some commit messages. drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/bridge/an

[PATCH v2 9/9] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding

In current sound framework, there's no way to unbind dai link after unregister codec. So move unregister codec to driver remove for now. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None drivers/gpu/drm/rockchip/cdn-dp-core.c | 6 +++--- 1 file chan

[PATCH 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index df9e570..19679b2 100644 --- a/d

[PATCH 6/9] drm/rockchip: Reoder unload sequence

We should don't cleanup iommu before cleanup other resources. Reorder unload sequence, follow exynos drm. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH v2 4/9] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded

Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index fd79a70..a

[PATCH v2 6/9] drm/rockchip: Reoder unload sequence

We should not cleanup iommu before cleanup other resources. Reorder unload sequence, follow exynos drm. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [PATCH] drm/rockchip: fix Kconfig dependencies

Hi Arnd, Tested-by: Jeffy Chen <jeffy.c...@rock-chips.com> Thanx for fixing this :) On 03/29/2017 12:37 AM, Guenter Roeck wrote: On Tue, Mar 28, 2017 at 3:16 AM, Arnd Bergmann <a...@arndb.de> wrote: A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m, the rockchi

Re: [PATCH v7] drm/rockchip: Refactor the component match logic.

Hi Sean, On 03/22/2017 03:55 AM, Sean Paul wrote: On Tue, Mar 21, 2017 at 02:42:11PM +0800, Jeffy Chen wrote: Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow exynos drm

[PATCH v8] drm/rockchip: Refactor the component match logic.

Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow exynos drm. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.c

[PATCH v7] drm/rockchip: Refactor the component match logic.

Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow exynos drm. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.c

[PATCH v6] drm/rockchip: Refactor the component match logic.

Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow exynos drm. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.c

Re: [PATCH v4] drm/rockchip: Refactor the component match logic.

Hi Heiko, On 03/16/2017 04:20 PM, Heiko Stuebner wrote: Hi Jeffy, Am Donnerstag, 16. März 2017, 10:05:56 CET schrieb Jeffy Chen: Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic

Re: [PATCH v3] drm/rockchip: Refactor the component match logic.

Hi Heiko, On 03/16/2017 01:00 AM, Heiko Stuebner wrote: Am Mittwoch, 15. März 2017, 18:20:47 CET schrieb Jeffy Chen: Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow

[PATCH v4] drm/rockchip: Refactor the component match logic.

Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow exynos drm. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@sa

[PATCH v3] drm/rockchip: Refactor the component match logic.

Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow exynos drm. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Andrzej Hajda <a.ha...@sa

Re: [PATCH v2] drm/rockchip: Refactor the component match logic.

Hi Andrzej, On 03/14/2017 08:05 PM, Andrzej Hajda wrote: Hi Jeffy, On 14.03.2017 11:45, Jeffy Chen wrote: Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow exynos drm

[PATCH v2] drm/rockchip: Refactor the component match logic.

Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow exynos drm. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/rockchip/K

Re: [PATCH] drm/rockchip: Refactor the component match logic.

Hi Sean, On 03/14/2017 05:06 AM, Sean Paul wrote: On Wed, Mar 08, 2017 at 01:58:14PM +0800, Jeffy Chen wrote: Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow exynos drm

[PATCH] drm/rockchip: Refactor the component match logic.

Currently we are adding all components from the dts, if one of their drivers been disabled, we would not be able to bring up others. Refactor component match logic, follow exynos drm. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/gpu/drm/rockchip/K

<    1   2