Re: [PATCH] drm: An uninitialized return value is returned.

2012-06-04 Thread richard -rw- weinberger
On Sun, Jun 3, 2012 at 2:26 PM, bing deng deng8b...@gmail.com wrote: Hi All,    Why not modify int ret; to int ret = 0;? Below is the benefit:    1. return the constant 0 as wish.    2. The variable ret can be used if we want. Why? ret is in vain and wastes memory... -- Thanks, //richard

[PATCH] drm: An uninitialized return value is returned.

2012-06-03 Thread richard -rw- weinberger
On Sun, Jun 3, 2012 at 2:26 PM, bing deng wrote: > Hi All, > > ? ?Why not modify "int ret;" to "int ret = 0;"? Below is the benefit: > ? ?1. return the constant 0 as wish. > ? ?2. The variable ret can be used if we want. Why? ret is in vain and wastes memory... -- Thanks, //richard

[git pull] drm intel hibernation fix

2012-03-29 Thread richard -rw- weinberger
On Thu, Mar 29, 2012 at 9:34 AM, Keith Packard wrote: > <#part sign=pgpmime> > On Thu, 29 Mar 2012 08:14:08 +0100 (IST), Dave Airlie > wrote: > >> Dave Airlie (1): >> ? ? ? drm/i915: suspend fbdev device around suspend/hibernate > I've reported the issue one year ago and kept the discussion

Re: [git pull] drm intel hibernation fix

2012-03-29 Thread richard -rw- weinberger
On Thu, Mar 29, 2012 at 9:34 AM, Keith Packard kei...@keithp.com wrote: #part sign=pgpmime On Thu, 29 Mar 2012 08:14:08 +0100 (IST), Dave Airlie airl...@linux.ie wrote: Dave Airlie (1):       drm/i915: suspend fbdev device around suspend/hibernate I've reported the issue one year ago and