Reviewed-by: Tian Tao
-邮件原件-
发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
发送时间: 2021年7月21日 21:17
收件人: xinliang@linaro.org; tiantao (H) ;
john.stu...@linaro.org; kongxinwei (A) ;
Chenfeng (puck) ; airl...@linux.ie; dan...@ffwll.ch;
max...@cerno.tech; s...@ravnborg.org
抄送
在 2021/7/6 15:54, Thomas Zimmermann 写道:
Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's
IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers
don't benefit from using it.
Reviewed-by:Tian Tao
Signed-off-by: Thomas Zimmermann
---
...@arm.com;
maarten.lankho...@linux.intel.com; mrip...@kernel.org; inki@samsung.com;
jy0922.s...@samsung.com; sw0312@samsung.com; kyungmin.p...@samsung.com;
krzysztof.kozlow...@canonical.com; xinliang@linaro.org; tiantao (H)
; john.stu...@linaro.org; kongxinwei (A)
; Chenfeng (puck
在 2021/5/24 20:05, Inki Dae 写道:
21. 5. 22. 오전 12:31에 Daniel Vetter 이(가) 쓴 글:
On Fri, May 21, 2021 at 05:06:06PM +0800, Tian Tao wrote:
use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
pm_runtime_put_noidle.
It would be good to explain why: Apparently get_sync increments
在 2021/5/21 17:09, Daniel Vetter 写道:
Like we have for the shadow helpers too, and roll it out to drivers.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Thomas Zimmermann
Cc: Hans de Goede
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: David Airlie
Cc: Daniel Vetter
Cc: Tian Tao
Cc:
在 2021/3/30 14:43, fanghao (A) 写道:
s/Hisilicon/HiSilicon/g.
It should use capital S, according to
https://www.hisilicon.com/en/terms-of-use.
Acked-by: Tian Tao
Signed-off-by: Hao Fang
---
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c| 2 +-
在 2021/3/15 14:35, Inki Dae 写道:
Hi Tian Tao,
21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글:
remove the legacy GPIO headers but what it really
uses is since only gpio_desc structs are ever
referenced.
This driver doesn't reference even linux/gpio/consumer.h so could you drop only
of_gpio.h
在 2021/3/15 14:35, Inki Dae 写道:
Hi Tian Tao,
21. 3. 2. 오후 12:03에 Tian Tao 이(가) 쓴 글:
remove the legacy GPIO headers but what it really
uses is since only gpio_desc structs are ever
referenced.
This driver doesn't reference even linux/gpio/consumer.h so could you drop only
of_gpio.h
在 2021/1/15 16:42, Thomas Zimmermann 写道:
ping for review
Am 13.01.21 um 12:31 schrieb Thomas Zimmermann:
The file is not in use. It got re-added by a rebased patch. Removing
it.
Reviewed-by Tian Tao
Signed-off-by: Thomas Zimmermann
Fixes: 4d4dad21cc7b ("drm/hibmc: Remove references to
在 2020/12/22 16:27, Daniel Vetter 写道:
On Tue, Dec 22, 2020 at 1:38 AM tiantao (H) wrote:
在 2020/12/22 6:02, Daniel Vetter 写道:
On Mon, Dec 21, 2020 at 08:45:22AM +0800, Tian Tao wrote:
Using the managed function simplifies the error handling. After
unloading the driver, the PCI device
在 2020/12/22 6:02, Daniel Vetter 写道:
On Mon, Dec 21, 2020 at 08:45:22AM +0800, Tian Tao wrote:
Using the managed function simplifies the error handling. After
unloading the driver, the PCI device should now get disabled as
well.
Signed-off-by: Tian Tao
---
在 2020/12/15 20:01, Daniel Vetter 写道:
On Tue, Dec 15, 2020 at 12:59:53PM +0100, Daniel Vetter wrote:
On Tue, Dec 15, 2020 at 11:01:39AM +0800, Tian Tao wrote:
drm_irq_uninstall should be called before pci_disable_msi, if use
devm_drm_irq_install to register the interrupt, the system will
call
在 2020/12/7 17:22, Thomas Zimmermann 写道:
Hi
Am 07.12.20 um 10:05 schrieb Tian Tao:
Using drmm_mode_config_init() sets up managed release of modesetting
resources.
Individual patches usually contain a changelog to highlight the
difference to previous versions. Please add one before
Hi
在 2020/12/2 17:02, Thomas Zimmermann 写道:
Am 02.12.20 um 09:47 schrieb Tian Tao:
Use the devm_drm_dev_alloc provided by the drm framework to alloc
a structure hibmc_drm_private.
Signed-off-by: Tian Tao
This looks good now. Thanks for sticking to it.
Thank you for your continued
在 2020/12/1 21:44, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 14:05 schrieb tiantao (H):
在 2020/12/1 20:36, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 13:26 schrieb tiantao (H):
在 2020/12/1 20:17, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 12:55 schrieb Tian Tao:
Assign local variable
在 2020/12/1 18:35, Thomas Zimmermann 写道:
Using struct drm_device.pdev is deprecated. Convert hibmc to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Acked-by: Sam Ravnborg
Cc: Xinliang Liu
Cc: Tian Tao
Cc: John Stultz
Cc: Xinwei Kong
Cc: Chen Feng
---
在 2020/12/2 10:06, tiantao (H) 写道:
在 2020/12/1 21:44, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 14:05 schrieb tiantao (H):
在 2020/12/1 20:36, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 13:26 schrieb tiantao (H):
在 2020/12/1 20:17, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 12:55 schrieb
在 2020/12/1 20:36, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 13:26 schrieb tiantao (H):
在 2020/12/1 20:17, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 12:55 schrieb Tian Tao:
Assign local variable to struct drm_device *dev because they are
used multiple times within a function.
Signed-off
在 2020/12/1 20:17, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 12:55 schrieb Tian Tao:
Assign local variable to struct drm_device *dev because they are
used multiple times within a function.
Signed-off-by: Tian Tao
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 +-
在 2020/11/3 15:56, Thomas Zimmermann 写道:
Hi
Thanks, the code looks good already. There just are a few nits below.
Thanks for the help with the review code.
Add the new api devm_drm_irq_install and himbc use the new interface as
one patch or two?
Am 03.11.20 um 03:10 schrieb Tian Tao:
在 2020/11/2 20:09, Thomas Zimmermann 写道:
Hi
Am 02.11.20 um 12:19 schrieb Tian Tao:
Add the detection of false for irq, so that the EINVAL is not
returned when dev->irq_enabled is false.
Signed-off-by: Tian Tao
---
drivers/gpu/drm/drm_irq.c | 3 +++
1 file changed, 3 insertions(+)
diff
在 2020/11/2 17:03, Thomas Zimmermann 写道:
Hi
Am 02.11.20 um 09:46 schrieb tiantao (H):
在 2020/11/2 16:32, Thomas Zimmermann 写道:
Hi
Am 30.10.20 um 10:27 schrieb Tian Tao:
drm_irq_uninstall can handle the case where dev->irq_enable is false,
so Remove redundant null check.
Signed-
在 2020/11/2 16:32, Thomas Zimmermann 写道:
Hi
Am 30.10.20 um 10:27 schrieb Tian Tao:
drm_irq_uninstall can handle the case where dev->irq_enable is false,
so Remove redundant null check.
Signed-off-by: Tian Tao
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 +++---
1 file
在 2020/9/29 15:24, Thomas Zimmermann 写道:
Am 29.09.20 um 02:45 schrieb Tian Tao:
The macro PADDING is no longer used. Delete it.
Signed-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
Thanks a lot for the timely help with the review code!
---
在 2020/9/25 15:26, Thomas Zimmermann 写道:
Hi
Am 25.09.20 um 09:02 schrieb Thomas Zimmermann:
Hi,
just a few nits.
Am 25.09.20 um 08:49 schrieb Tian Tao:
drm_framebuffer.h contains drm/drm_device.h and struct drm_device is
contains -> includes
already declared in this file, so there is
Hi :
I alwaygs used scripts/get_maintainers.pl to get the recipient list.I
don't know why miss maintainers for a given piece of code.
tiantao@ubuntu:~$ git send-email -to e...@anholt.net -to
airl...@linux.ie -to dan...@ffwll.ch -to sumit.sem...@linaro.org -to
christian.koe...@amd.com -to
Hi Thomas:
在 2020/9/11 15:47, Thomas Zimmermann 写道:
Hi
Am 09.09.20 um 09:33 schrieb Tian Tao:
Fixes the following W=1 kernel build warning(s):
vc4_plane.c: In function ‘vc4_plane_init’:
vc4_plane.c:1340:6: warning: variable ‘ret’ set but not
used [-Wunused-but-set-variable]
Signed-off-by:
在 2020/8/12 15:04, Thomas Zimmermann 写道:
Hi
Am 03.08.20 um 02:38 schrieb Tian Tao:
patch #1 and #3 is clean up, patch #2 is for code refactoring
Sorry for all my reviews taking so long. Please merge patch #3 into
patch #2 and then the series is
thanks,I will send v3 to fix this.
Hi Thomas:
Thank you very much .
Best
-邮件原件-
发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
发送时间: 2020年7月29日 16:35
收件人: tiantao (H) ; airl...@linux.ie; dan...@ffwll.ch;
kra...@redhat.com; alexander.deuc...@amd.com; t...@linutronix.de;
dri-devel@lists.freedesktop.org
Hi:
I am sorry for misunderstood you suggests. I will send v3 to fixed this.
Best
-邮件原件-
发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
发送时间: 2020年7月2日 15:20
收件人: tiantao (H) ; Chenfeng (puck)
; airl...@linux.ie; dan...@ffwll.ch;
kra...@redhat.com; alexander.deuc...@amd.com; t
Hi：
Thanks for the help with the review code. I will send v2 to fixed this.
Best
-邮件原件-
发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
发送时间: 2020年7月2日 14:43
收件人: tiantao (H) ; Chenfeng (puck)
; airl...@linux.ie; dan...@ffwll.ch;
kra...@redhat.com; alexander.deuc
Thank you, your suggestion is accepted and I will issue v2
在 2020/4/11 11:43, Joe Perches 写道:
On Sat, 2020-04-11 at 10:49 +0800, Tian Tao wrote:
code refactoring for hibmc_drv_vdac.c, no actual function changes.
Seems sensible.
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
Hi All：
Sorry，please ignore this patch.
Best
-邮件原件-
发件人: Linuxarm [mailto:linuxarm-boun...@huawei.com] 代表 Tian Tao
发送时间: 2020年3月6日 11:43
收件人: Chenfeng (puck) ; airl...@linux.ie;
dan...@ffwll.ch; tzimmerm...@suse.de; kra...@redhat.com;
alexander.deuc...@amd.com;
Hi All：
Sorry，please ignore this patch.
Best
-邮件原件-
发件人: Linuxarm [mailto:linuxarm-boun...@huawei.com] 代表 Tian Tao
发送时间: 2020年3月6日 11:43
收件人: Chenfeng (puck) ; airl...@linux.ie;
dan...@ffwll.ch; tzimmerm...@suse.de; kra...@redhat.com;
alexander.deuc...@amd.com;
Hi All：
Sorry，please ignore this patch.
Best
-邮件原件-
发件人: Linuxarm [mailto:linuxarm-boun...@huawei.com] 代表 Tian Tao
发送时间: 2020年3月6日 11:43
收件人: Chenfeng (puck) ; airl...@linux.ie;
dan...@ffwll.ch; tzimmerm...@suse.de; kra...@redhat.com;
alexander.deuc...@amd.com;
Sorry,my mistake. I sent the wrong patch, please ignore the patch below
在 2020/2/21 16:52, Thomas Zimmermann 写道:
Hi
Am 21.02.20 um 08:06 schrieb Xinliang Liu:
Hi tao,
Are you sending a wrong patch?
Function hibmc_remove_framebuffers is added by your prior reviewing patch.
Please send patch
Hi Thomas Zimmermann:
I will modify this patch and send v2 as you suggested.
Thank you very much.
Best
-邮件原件-
发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
发送时间: 2020年1月8日 16:49
收件人: tiantao (H) ; Chenfeng (puck)
; airl...@linux.ie; dan...@ffwll.ch;
kra
Hi Daniel:
Thanks you very much ,I will follow your suggestion to split this to
three patches.
Best
在 2019/12/30 18:23, Daniel Stone 写道:
Hi Tian,
On Sat, 28 Dec 2019 at 01:14, Tian Tao wrote:
@@ -118,11 +119,9 @@ static void hibmc_plane_atomic_update(struct drm_plane
*plane,
38 matches
Mail list logo
