[BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Arnd Bergmann
On Monday 18 October 2010 22:30:17 Arnd Bergmann wrote: > I don't think the code path you patch here actually gets used, since > intel_lvds_init gets called by intel_setup_outputs only for mobile devices. FWIW, the patch below does work. Arnd --- a/drivers/gpu/drm/i915/intel_display.c +

[BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Arnd Bergmann
On Monday 18 October 2010 22:15:23 Jesse Barnes wrote: > On Mon, 18 Oct 2010 21:57:05 +0200 Arnd Bergmann wrote: > > i915 is a module with kms enabled, the blur seems to show up on the > > text console the moment that the module gets loaded during boot. > > Before that, the console is in VGA text

[BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Arnd Bergmann
On Monday 18 October 2010 21:28:01 Jesse Barnes wrote: > > On Mon, 18 Oct 2010 21:13:59 +0200 > Arnd Bergmann wrote: > > > On Monday 18 October 2010 20:56:48 Jesse Barnes wrote: > > > Hm, the LVDS code should take care of panel fitting in > > > the !HAS_PCH_SPLIT case. Does this patch achieve t

[BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Arnd Bergmann
On Monday 18 October 2010 20:56:48 Jesse Barnes wrote: > Hm, the LVDS code should take care of panel fitting in > the !HAS_PCH_SPLIT case. Does this patch achieve the same thing as > yours? Maybe we were leaving a stale PFIT value in place... No, your patch doesn't have any effect for me.

Re: [BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Jesse Barnes
On Mon, 18 Oct 2010 22:37:43 +0200 Arnd Bergmann wrote: > On Monday 18 October 2010 22:30:17 Arnd Bergmann wrote: > > > I don't think the code path you patch here actually gets used, since > > intel_lvds_init gets called by intel_setup_outputs only for mobile devices. > > FWIW, the patch below

[BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Jesse Barnes
On Mon, 18 Oct 2010 22:37:43 +0200 Arnd Bergmann wrote: > On Monday 18 October 2010 22:30:17 Arnd Bergmann wrote: > > > I don't think the code path you patch here actually gets used, since > > intel_lvds_init gets called by intel_setup_outputs only for mobile devices. > > FWIW, the patch below

Re: [BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Arnd Bergmann
On Monday 18 October 2010 22:30:17 Arnd Bergmann wrote: > I don't think the code path you patch here actually gets used, since > intel_lvds_init gets called by intel_setup_outputs only for mobile devices. FWIW, the patch below does work. Arnd --- a/drivers/gpu/drm/i915/intel_display.c +

Re: [BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Arnd Bergmann
On Monday 18 October 2010 22:15:23 Jesse Barnes wrote: > On Mon, 18 Oct 2010 21:57:05 +0200 Arnd Bergmann wrote: > > i915 is a module with kms enabled, the blur seems to show up on the > > text console the moment that the module gets loaded during boot. > > Before that, the console is in VGA text

Re: [BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Jesse Barnes
On Mon, 18 Oct 2010 21:57:05 +0200 Arnd Bergmann wrote: > On Monday 18 October 2010 21:28:01 Jesse Barnes wrote: > > > > On Mon, 18 Oct 2010 21:13:59 +0200 > > Arnd Bergmann wrote: > > > > > On Monday 18 October 2010 20:56:48 Jesse Barnes wrote: > > > > Hm, the LVDS code should take care of pa

[BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Jesse Barnes
On Mon, 18 Oct 2010 21:57:05 +0200 Arnd Bergmann wrote: > On Monday 18 October 2010 21:28:01 Jesse Barnes wrote: > > > > On Mon, 18 Oct 2010 21:13:59 +0200 > > Arnd Bergmann wrote: > > > > > On Monday 18 October 2010 20:56:48 Jesse Barnes wrote: > > > > Hm, the LVDS code should take care of pa

Re: [BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Arnd Bergmann
On Monday 18 October 2010 21:28:01 Jesse Barnes wrote: > > On Mon, 18 Oct 2010 21:13:59 +0200 > Arnd Bergmann wrote: > > > On Monday 18 October 2010 20:56:48 Jesse Barnes wrote: > > > Hm, the LVDS code should take care of panel fitting in > > > the !HAS_PCH_SPLIT case. Does this patch achieve t

Re: [BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Jesse Barnes
On Mon, 18 Oct 2010 21:13:59 +0200 Arnd Bergmann wrote: > On Monday 18 October 2010 20:56:48 Jesse Barnes wrote: > > Hm, the LVDS code should take care of panel fitting in > > the !HAS_PCH_SPLIT case. Does this patch achieve the same thing as > > yours? Maybe we were leaving a stale PFIT value

[BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Jesse Barnes
On Mon, 18 Oct 2010 21:13:59 +0200 Arnd Bergmann wrote: > On Monday 18 October 2010 20:56:48 Jesse Barnes wrote: > > Hm, the LVDS code should take care of panel fitting in > > the !HAS_PCH_SPLIT case. Does this patch achieve the same thing as > > yours? Maybe we were leaving a stale PFIT value

Re: [BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Arnd Bergmann
On Monday 18 October 2010 20:56:48 Jesse Barnes wrote: > Hm, the LVDS code should take care of panel fitting in > the !HAS_PCH_SPLIT case. Does this patch achieve the same thing as > yours? Maybe we were leaving a stale PFIT value in place... No, your patch doesn't have any effect for me.

Re: [BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Jesse Barnes
On Sun, 17 Oct 2010 19:37:13 +0200 Arnd Bergmann wrote: > Commit e9e331a8ab "drm/i915/lvds: Ensure panel is unlocked for Ironlake or > the panel fitter" broke my HDMI output on GMA4500HD, it seemed to be driving > the output with the wrong resolution, while still showing the native panel > resolu

[BISECTED, -next] drm/i915: blurred HDMI output

2010-10-18 Thread Jesse Barnes
On Sun, 17 Oct 2010 19:37:13 +0200 Arnd Bergmann wrote: > Commit e9e331a8ab "drm/i915/lvds: Ensure panel is unlocked for Ironlake or > the panel fitter" broke my HDMI output on GMA4500HD, it seemed to be driving > the output with the wrong resolution, while still showing the native panel > resolu

[BISECTED, -next] drm/i915: blurred HDMI output

2010-10-17 Thread Arnd Bergmann
Commit e9e331a8ab "drm/i915/lvds: Ensure panel is unlocked for Ironlake or the panel fitter" broke my HDMI output on GMA4500HD, it seemed to be driving the output with the wrong resolution, while still showing the native panel resolution of 1680x1050 being in use. This caused a very irritating blur

[BISECTED, -next] drm/i915: blurred HDMI output

2010-10-17 Thread Arnd Bergmann
Commit e9e331a8ab "drm/i915/lvds: Ensure panel is unlocked for Ironlake or the panel fitter" broke my HDMI output on GMA4500HD, it seemed to be driving the output with the wrong resolution, while still showing the native panel resolution of 1680x1050 being in use. This caused a very irritating blur