Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-10 Thread Abhinav Kumar
On 6/8/2022 11:08 PM, Dmitry Baryshkov wrote: On Thu, 9 Jun 2022 at 02:37, Abhinav Kumar wrote: On 6/8/2022 3:46 PM, Dmitry Baryshkov wrote: On 09/06/2022 01:42, Abhinav Kumar wrote: On 6/8/2022 3:38 PM, Dmitry Baryshkov wrote: On 09/06/2022 01:35, Abhinav Kumar wrote: On 6/8/2022

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-08 Thread Dmitry Baryshkov
On Thu, 9 Jun 2022 at 02:37, Abhinav Kumar wrote: > > > > On 6/8/2022 3:46 PM, Dmitry Baryshkov wrote: > > On 09/06/2022 01:42, Abhinav Kumar wrote: > >> > >> > >> On 6/8/2022 3:38 PM, Dmitry Baryshkov wrote: > >>> On 09/06/2022 01:35, Abhinav Kumar wrote: > > > On 6/8/2022 3:30 PM,

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-08 Thread Abhinav Kumar
On 6/8/2022 3:46 PM, Dmitry Baryshkov wrote: On 09/06/2022 01:42, Abhinav Kumar wrote: On 6/8/2022 3:38 PM, Dmitry Baryshkov wrote: On 09/06/2022 01:35, Abhinav Kumar wrote: On 6/8/2022 3:30 PM, Dmitry Baryshkov wrote: On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar wrote: On 6/2/2022

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-08 Thread Dmitry Baryshkov
On 09/06/2022 01:42, Abhinav Kumar wrote: On 6/8/2022 3:38 PM, Dmitry Baryshkov wrote: On 09/06/2022 01:35, Abhinav Kumar wrote: On 6/8/2022 3:30 PM, Dmitry Baryshkov wrote: On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar wrote: On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote: On Thu, 2 Jun 20

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-08 Thread Abhinav Kumar
On 6/8/2022 3:38 PM, Dmitry Baryshkov wrote: On 09/06/2022 01:35, Abhinav Kumar wrote: On 6/8/2022 3:30 PM, Dmitry Baryshkov wrote: On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar wrote: On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote: On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar wrote: On

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-08 Thread Dmitry Baryshkov
On 09/06/2022 01:35, Abhinav Kumar wrote: On 6/8/2022 3:30 PM, Dmitry Baryshkov wrote: On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar wrote: On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote: On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar wrote: On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote: On Wed

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-08 Thread Abhinav Kumar
On 6/8/2022 3:30 PM, Dmitry Baryshkov wrote: On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar wrote: On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote: On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar wrote: On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote: On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar wro

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-08 Thread Dmitry Baryshkov
On Wed, 8 Jun 2022 at 22:29, Abhinav Kumar wrote: > > > > On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote: > > On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote: > >>> On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar > >>> wrote: >

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-08 Thread Abhinav Kumar
On 6/2/2022 1:13 PM, Dmitry Baryshkov wrote: On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar wrote: On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote: On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar wrote: On 6/1/2022 2:46 AM, Dmitry Baryshkov wrote: On Wed, 1 Jun 2022 at 01:01, Abhinav Kumar wro

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-02 Thread Dmitry Baryshkov
On Thu, 2 Jun 2022 at 21:18, Abhinav Kumar wrote: > > > > On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote: > > On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 6/1/2022 2:46 AM, Dmitry Baryshkov wrote: > >>> On Wed, 1 Jun 2022 at 01:01, Abhinav Kumar > >>> wrote: >

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-02 Thread Abhinav Kumar
On 6/1/2022 1:04 PM, Dmitry Baryshkov wrote: On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar wrote: On 6/1/2022 2:46 AM, Dmitry Baryshkov wrote: On Wed, 1 Jun 2022 at 01:01, Abhinav Kumar wrote: On 5/31/2022 5:18 AM, Dmitry Baryshkov wrote: Replace magic register writes in msm_mdss_enable(

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-01 Thread Dmitry Baryshkov
On Wed, 1 Jun 2022 at 20:38, Abhinav Kumar wrote: > > > > On 6/1/2022 2:46 AM, Dmitry Baryshkov wrote: > > On Wed, 1 Jun 2022 at 01:01, Abhinav Kumar > > wrote: > >> On 5/31/2022 5:18 AM, Dmitry Baryshkov wrote: > >>> Replace magic register writes in msm_mdss_enable() with version that > >>> con

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-01 Thread Abhinav Kumar
On 6/1/2022 2:46 AM, Dmitry Baryshkov wrote: On Wed, 1 Jun 2022 at 01:01, Abhinav Kumar wrote: On 5/31/2022 5:18 AM, Dmitry Baryshkov wrote: Replace magic register writes in msm_mdss_enable() with version that contains less magic and more variable names that can be traced back to the dpu_hw