Re: [Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2023-01-13 Thread Juha-Pekka Heikkila
On 12.1.2023 20.28, Ville Syrjälä wrote: On Mon, Dec 26, 2022 at 10:53:24PM -0700, Drew Davenport wrote: The error message suggests that the height of the src rect must be at least 1. Reject source with height of 0. Signed-off-by: Drew Davenport --- I was investigating some divide-by-zero

Re: [Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2023-01-11 Thread Drew Davenport
On Tue, Dec 27, 2022 at 05:55:17PM +, Teres Alexis, Alan Previn wrote: > Is there a better place for this check higher up the intel specific > atomic-check? (so the check won't be skl specific - i notice that > intel_adjusted_rate is also called by > ilk_foo as well and non-backend-specific

Re: [Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2022-12-27 Thread Teres Alexis, Alan Previn
Is there a better place for this check higher up the intel specific atomic-check? (so the check won't be skl specific - i notice that intel_adjusted_rate is also called by ilk_foo as well and non-backend-specific functions). Else, perhaps intel_adjusted_rate should add a check + WARN? (if we