[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-10-01 Thread Vincent ABRIOU
On 09/22/2015 05:21 PM, Tvrtko Ursulin wrote: > > On 09/22/2015 03:53 PM, David Herrmann wrote: >> Hi >> >> On Thu, Sep 10, 2015 at 12:15 PM, Tvrtko Ursulin >> wrote: >>> On 09/10/2015 10:56 AM, Daniel Vetter wrote: That's not different from the compositor just freezing instead of cras

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-22 Thread David Herrmann
Hi On Thu, Sep 10, 2015 at 12:15 PM, Tvrtko Ursulin wrote: > On 09/10/2015 10:56 AM, Daniel Vetter wrote: >> That's not different from the compositor just freezing instead of >> crashing: Screen contents stays on and nothing happens. Imo this really is >> all just broken userspace, and the kernel

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-22 Thread Tvrtko Ursulin
On 09/22/2015 03:53 PM, David Herrmann wrote: > Hi > > On Thu, Sep 10, 2015 at 12:15 PM, Tvrtko Ursulin > wrote: >> On 09/10/2015 10:56 AM, Daniel Vetter wrote: >>> That's not different from the compositor just freezing instead of >>> crashing: Screen contents stays on and nothing happens. Imo th

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-10 Thread Daniel Vetter
On Thu, Sep 10, 2015 at 10:07:41AM +0100, Tvrtko Ursulin wrote: > > On 09/09/2015 08:06 PM, Daniel Vetter wrote: > >On Wed, Sep 9, 2015 at 6:36 PM, Tvrtko Ursulin > > wrote: > >>I am not even going that far, just talking about last frame stuck on screen. > >>For me making that easier is a regressi

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-10 Thread Tvrtko Ursulin
On 09/10/2015 10:56 AM, Daniel Vetter wrote: > On Thu, Sep 10, 2015 at 10:07:41AM +0100, Tvrtko Ursulin wrote: >> >> On 09/09/2015 08:06 PM, Daniel Vetter wrote: >>> On Wed, Sep 9, 2015 at 6:36 PM, Tvrtko Ursulin >>> wrote: I am not even going that far, just talking about last frame stuck on

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-10 Thread Tvrtko Ursulin
On 09/09/2015 08:06 PM, Daniel Vetter wrote: > On Wed, Sep 9, 2015 at 6:36 PM, Tvrtko Ursulin > wrote: >> I am not even going that far, just talking about last frame stuck on screen. >> For me making that easier is a regression. > > So let's look at various systems: > - super-modern fbdev less sy

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Daniel Vetter
On Wed, Sep 9, 2015 at 6:36 PM, Tvrtko Ursulin wrote: > I am not even going that far, just talking about last frame stuck on screen. > For me making that easier is a regression. So let's look at various systems: - super-modern fbdev less system: logind keeps a dup of every master-capabel drm fd.

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Maarten Lankhorst
Op 09-09-15 om 18:15 schreef Tvrtko Ursulin: > > On 09/09/2015 05:07 PM, Daniel Vetter wrote: >> On Wed, Sep 9, 2015 at 6:03 PM, Tvrtko Ursulin >> wrote: >>> It was just an example of a class of vulnerabilities which would be possible >>> with these changes. If they, as you said, will preserve the

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Daniel Vetter
On Wed, Sep 9, 2015 at 6:03 PM, Tvrtko Ursulin wrote: > It was just an example of a class of vulnerabilities which would be possible > with these changes. If they, as you said, will preserve the last frame on > screen when the compositor crashes. If your compositor crashes something should take o

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Daniel Vetter
On Wed, Sep 09, 2015 at 04:47:08PM +0100, Tvrtko Ursulin wrote: > > On 09/09/2015 04:29 PM, Daniel Vetter wrote: > >On Wed, Sep 09, 2015 at 04:18:02PM +0100, Tvrtko Ursulin wrote: > >> > >>On 09/09/2015 04:04 PM, Daniel Vetter wrote: > >>>On Wed, Sep 09, 2015 at 03:51:50PM +0100, Tvrtko Ursulin wr

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Tvrtko Ursulin
On 09/09/2015 05:26 PM, Maarten Lankhorst wrote: > Op 09-09-15 om 18:15 schreef Tvrtko Ursulin: >> >> On 09/09/2015 05:07 PM, Daniel Vetter wrote: >>> On Wed, Sep 9, 2015 at 6:03 PM, Tvrtko Ursulin >>> wrote: It was just an example of a class of vulnerabilities which would be possible

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Daniel Vetter
On Wed, Sep 09, 2015 at 04:18:02PM +0100, Tvrtko Ursulin wrote: > > On 09/09/2015 04:04 PM, Daniel Vetter wrote: > >On Wed, Sep 09, 2015 at 03:51:50PM +0100, Tvrtko Ursulin wrote: > >> > >>Hi, > >> > >>On 09/09/2015 03:40 PM, Maarten Lankhorst wrote: > >>>Previously RMFB and fd close chose to disa

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Tvrtko Ursulin
On 09/09/2015 05:07 PM, Daniel Vetter wrote: > On Wed, Sep 9, 2015 at 6:03 PM, Tvrtko Ursulin > wrote: >> It was just an example of a class of vulnerabilities which would be possible >> with these changes. If they, as you said, will preserve the last frame on >> screen when the compositor crashes

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Daniel Vetter
On Wed, Sep 09, 2015 at 03:51:50PM +0100, Tvrtko Ursulin wrote: > > Hi, > > On 09/09/2015 03:40 PM, Maarten Lankhorst wrote: > >Previously RMFB and fd close chose to disable any plane that had > >an active framebuffer from this file. If it was a primary plane the > >crtc was disabled. However the

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Tvrtko Ursulin
On 09/09/2015 04:56 PM, Daniel Vetter wrote: > On Wed, Sep 09, 2015 at 04:47:08PM +0100, Tvrtko Ursulin wrote: >> >> On 09/09/2015 04:29 PM, Daniel Vetter wrote: >>> On Wed, Sep 09, 2015 at 04:18:02PM +0100, Tvrtko Ursulin wrote: On 09/09/2015 04:04 PM, Daniel Vetter wrote: > On Wed,

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Tvrtko Ursulin
On 09/09/2015 04:29 PM, Daniel Vetter wrote: > On Wed, Sep 09, 2015 at 04:18:02PM +0100, Tvrtko Ursulin wrote: >> >> On 09/09/2015 04:04 PM, Daniel Vetter wrote: >>> On Wed, Sep 09, 2015 at 03:51:50PM +0100, Tvrtko Ursulin wrote: Hi, On 09/09/2015 03:40 PM, Maarten Lankhorst wr

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Tvrtko Ursulin
On 09/09/2015 04:04 PM, Daniel Vetter wrote: > On Wed, Sep 09, 2015 at 03:51:50PM +0100, Tvrtko Ursulin wrote: >> >> Hi, >> >> On 09/09/2015 03:40 PM, Maarten Lankhorst wrote: >>> Previously RMFB and fd close chose to disable any plane that had >>> an active framebuffer from this file. If it was a

[Intel-gfx] [PATCH 1/2] drm/core: Preserve the framebuffer after removing it.

2015-09-09 Thread Tvrtko Ursulin
Hi, On 09/09/2015 03:40 PM, Maarten Lankhorst wrote: > Previously RMFB and fd close chose to disable any plane that had > an active framebuffer from this file. If it was a primary plane the > crtc was disabled. However the fbdev code or any system compositor > should restore the planes anyway so