Re: [Intel-gfx] [PATCH 13/21] drm/i915/gem: Add an intermediate proto_context struct

2021-04-29 Thread Jason Ekstrand
On Thu, Apr 29, 2021 at 8:02 AM Daniel Vetter wrote: > > The commit introducing a new data structure really should have a solid > intro in the commit message about. Please cover > > - that ctx really should be immutable, safe for exceptions like priority > > - that unfortunately we butchered the

Re: [Intel-gfx] [PATCH 13/21] drm/i915/gem: Add an intermediate proto_context struct

2021-04-29 Thread Daniel Vetter
The commit introducing a new data structure really should have a solid intro in the commit message about. Please cover - that ctx really should be immutable, safe for exceptions like priority - that unfortunately we butchered the uapi with setparam and sharing setparams between create_ext and