[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 13:24:12 -0700 Keith Packard wrote: > On Mon, 8 Aug 2011 13:01:28 -0700, Jesse Barnes > wrote: > > On Mon, 08 Aug 2011 12:53:31 -0700 > > Keith Packard wrote: > > > > > On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes > > virtuousgeek.org> wrote: > > > > > > > Yep, it's

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 13:01:28 -0700, Jesse Barnes wrote: > On Mon, 08 Aug 2011 12:53:31 -0700 > Keith Packard wrote: > > > On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes > virtuousgeek.org> wrote: > > > > > Yep, it's safe and possible to do on pre-PCH as well. For panel > > > fitting we do

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 12:53:31 -0700 Keith Packard wrote: > On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes > wrote: > > > Yep, it's safe and possible to do on pre-PCH as well. For panel > > fitting we do need to do an actual power cycle when going from > > non-native back to native iirc, but

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes wrote: > Yep, it's safe and possible to do on pre-PCH as well. For panel > fitting we do need to do an actual power cycle when going from > non-native back to native iirc, but we can still leave them unlocked so > we don't have to worry about the

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 11:42:56 -0700 Keith Packard wrote: > On Mon, 8 Aug 2011 09:30:10 -0700, Jesse Barnes > wrote: > > > Yep, looks fine. The only think we might want to sprinkle about are > > checks for panel off so we can avoid visible corruption if we whack > > timing or fb stuff while

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 09:30:10 -0700, Jesse Barnes wrote: > Yep, looks fine. The only think we might want to sprinkle about are > checks for panel off so we can avoid visible corruption if we whack > timing or fb stuff while the panel is on. So, I'd like to know if we could unlock the panel

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 09:30:10 -0700, Jesse Barnes wrote: > Yep, looks fine. The only think we might want to sprinkle about are > checks for panel off so we can avoid visible corruption if we whack > timing or fb stuff while the panel is on. Yeah, could do. Would be nice to somehow get the LVDS

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Sat, 6 Aug 2011 10:54:06 -0700 Keith Packard wrote: > There's no reason to relock them; it just makes operations more > complex. This fixes DPMS where the panel registers were locked making > the disable not work. > > Signed-off-by: Keith Packard Yep, looks fine. The only think we might

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Sat, 6 Aug 2011 10:54:06 -0700 Keith Packard kei...@keithp.com wrote: There's no reason to relock them; it just makes operations more complex. This fixes DPMS where the panel registers were locked making the disable not work. Signed-off-by: Keith Packard kei...@keithp.com Yep, looks

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 09:30:10 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Yep, looks fine. The only think we might want to sprinkle about are checks for panel off so we can avoid visible corruption if we whack timing or fb stuff while the panel is on. Yeah, could do. Would be nice to

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Yep, it's safe and possible to do on pre-PCH as well. For panel fitting we do need to do an actual power cycle when going from non-native back to native iirc, but we can still leave them unlocked so we don't

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 12:53:31 -0700 Keith Packard kei...@keithp.com wrote: On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Yep, it's safe and possible to do on pre-PCH as well. For panel fitting we do need to do an actual power cycle when going from

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Keith Packard
On Mon, 8 Aug 2011 13:01:28 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Mon, 08 Aug 2011 12:53:31 -0700 Keith Packard kei...@keithp.com wrote: On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Yep, it's safe and possible to do on pre-PCH as

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 13:24:12 -0700 Keith Packard kei...@keithp.com wrote: On Mon, 8 Aug 2011 13:01:28 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Mon, 08 Aug 2011 12:53:31 -0700 Keith Packard kei...@keithp.com wrote: On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes