[Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-23 Thread Jesse Barnes
On Tue, 20 Sep 2011 21:45:54 -0700 Keith Packard wrote: > On Wed, 21 Sep 2011 09:20:01 +0530, Jesse Barnes > wrote: > > > This one mixes up lots of cleanups plus the EDID read with the power > > changes. > > I think the cleanups are; > > 1) edp checks inside vdd_on and vdd_off to make the

[Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-22 Thread Keith Packard
On Fri, 23 Sep 2011 08:25:13 +0530, Jesse Barnes wrote: > Yeah that sounds good. (2) and (3) are ok cleanups, but it would be > best if they were a separate patch just in case the subtle timing > change breaks the panel power sequencing state machine. Ok, I'll split things up into tiny

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-22 Thread Jesse Barnes
On Tue, 20 Sep 2011 21:45:54 -0700 Keith Packard kei...@keithp.com wrote: On Wed, 21 Sep 2011 09:20:01 +0530, Jesse Barnes jbar...@virtuousgeek.org wrote: This one mixes up lots of cleanups plus the EDID read with the power changes. I think the cleanups are; 1) edp checks inside

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-22 Thread Keith Packard
On Fri, 23 Sep 2011 08:25:13 +0530, Jesse Barnes jbar...@virtuousgeek.org wrote: Yeah that sounds good. (2) and (3) are ok cleanups, but it would be best if they were a separate patch just in case the subtle timing change breaks the panel power sequencing state machine. Ok, I'll split

[Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-21 Thread Jesse Barnes
On Mon, 19 Sep 2011 15:22:00 -0700 Keith Packard wrote: > The eDP panel may not be able to respond to aux channel communications > unless it has power supplied. During mode setting, power may be > cut-off during panel power sequencing. Make sure that any aux channel > communications will work by

[Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-20 Thread Keith Packard
On Wed, 21 Sep 2011 09:20:01 +0530, Jesse Barnes wrote: > This one mixes up lots of cleanups plus the EDID read with the power > changes. I think the cleanups are; 1) edp checks inside vdd_on and vdd_off to make the other code a bit easier to read. 2) Hold VDD on until the end of

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-20 Thread Jesse Barnes
On Mon, 19 Sep 2011 15:22:00 -0700 Keith Packard kei...@keithp.com wrote: The eDP panel may not be able to respond to aux channel communications unless it has power supplied. During mode setting, power may be cut-off during panel power sequencing. Make sure that any aux channel communications

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-20 Thread Keith Packard
On Wed, 21 Sep 2011 09:20:01 +0530, Jesse Barnes jbar...@virtuousgeek.org wrote: This one mixes up lots of cleanups plus the EDID read with the power changes. I think the cleanups are; 1) edp checks inside vdd_on and vdd_off to make the other code a bit easier to read. 2) Hold VDD on