[Intel-gfx] PCH reference clock cleanups

2011-10-03 Thread Keith Packard
On Mon, 3 Oct 2011 16:21:08 -0700, Jesse Barnes wrote: > Agreed; fortunately shutting everything off when no outputs are > active should be simpler than trying flip the bits on & off every mode > set. :) We'd have to track when outputs are shut off; just tracking per clock doesn't seem any

[Intel-gfx] PCH reference clock cleanups

2011-10-03 Thread Jesse Barnes
On Mon, 03 Oct 2011 16:18:48 -0700 Keith Packard wrote: > On Mon, 3 Oct 2011 14:14:23 -0700, Jesse Barnes > wrote: > > > Now... is keeping the various refclks enabled costing us any power? > > IOW, should we be trying to disable them when everything has been > > DPMS'd off too? > > That's

[Intel-gfx] PCH reference clock cleanups

2011-10-03 Thread Keith Packard
On Mon, 3 Oct 2011 14:14:23 -0700, Jesse Barnes wrote: > Now... is keeping the various refclks enabled costing us any power? > IOW, should we be trying to disable them when everything has been > DPMS'd off too? That's the same as tracking usage and enabling/disabling on the fly as modes are

[Intel-gfx] PCH reference clock cleanups

2011-10-03 Thread Jesse Barnes
On Wed, 28 Sep 2011 15:22:48 -0300 Paulo Zanoni wrote: > 2011/9/27 Keith Packard : > > Here's a patch sequence which cleans up a bunch of PCH refclk related > > bits. > > For the series: Tested-by: Paulo Zanoni > > Tested all the patches on Ironlake (LVDS + VGA). Fixes fd.o bug #38750 for me.

Re: [Intel-gfx] PCH reference clock cleanups

2011-10-03 Thread Keith Packard
On Mon, 3 Oct 2011 14:14:23 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Now... is keeping the various refclks enabled costing us any power? IOW, should we be trying to disable them when everything has been DPMS'd off too? That's the same as tracking usage and enabling/disabling on

[Intel-gfx] PCH reference clock cleanups

2011-09-28 Thread Paulo Zanoni
2011/9/27 Keith Packard : > Here's a patch sequence which cleans up a bunch of PCH refclk related > bits. For the series: Tested-by: Paulo Zanoni Tested all the patches on Ironlake (LVDS + VGA). Fixes fd.o bug #38750 for me. I also tested the patch you sent today 1 hour ago (inline in one of

[Intel-gfx] PCH reference clock cleanups

2011-09-28 Thread Keith Packard
On Wed, 28 Sep 2011 15:22:48 -0300, Paulo Zanoni wrote: > I also tested the patch you sent today 1 hour ago (inline in one of > the emails) and things still work with it. I'll keep using these > patches since they fix my laptop. Any problem will be reported. Thanks. I think we're failing to

Re: [Intel-gfx] PCH reference clock cleanups

2011-09-28 Thread Paulo Zanoni
2011/9/27 Keith Packard kei...@keithp.com: Here's a patch sequence which cleans up a bunch of PCH refclk related bits. For the series: Tested-by: Paulo Zanoni paulo.r.zan...@intel.com Tested all the patches on Ironlake (LVDS + VGA). Fixes fd.o bug #38750 for me. I also tested the patch you

Re: [Intel-gfx] PCH reference clock cleanups

2011-09-28 Thread Keith Packard
On Wed, 28 Sep 2011 15:22:48 -0300, Paulo Zanoni przan...@gmail.com wrote: I also tested the patch you sent today 1 hour ago (inline in one of the emails) and things still work with it. I'll keep using these patches since they fix my laptop. Any problem will be reported. Thanks. I think we're