Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

2020-03-31 Thread John B. Wyatt IV
On Mon, 2020-03-30 at 19:40 +0200, Stefano Brivio wrote: > On Sun, 29 Mar 2020 12:37:18 +0200 (CEST) > Julia Lawall wrote: > > > On Sun, 29 Mar 2020, Soumyajit Deb wrote: > > > > > I had the same doubt the other day about the replacement of > > > udelay() with > > > usleep_range(). The

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

2020-03-30 Thread Stefano Brivio
On Mon, 30 Mar 2020 15:03:55 -0700 "John B. Wyatt IV" wrote: > On Mon, 2020-03-30 at 19:40 +0200, Stefano Brivio wrote: > > On Sun, 29 Mar 2020 12:37:18 +0200 (CEST) > > Julia Lawall wrote: > > > > > On Sun, 29 Mar 2020, Soumyajit Deb wrote: > > > > > > > I had the same doubt the other

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

2020-03-30 Thread Stefano Brivio
On Sun, 29 Mar 2020 12:37:18 +0200 (CEST) Julia Lawall wrote: > On Sun, 29 Mar 2020, Soumyajit Deb wrote: > > > I had the same doubt the other day about the replacement of udelay() with > > usleep_range(). The corresponding range for the single argument value of > > udelay() is quite confusing

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

2020-03-30 Thread Julia Lawall
On Sun, 29 Mar 2020, Soumyajit Deb wrote: > I had the same doubt the other day about the replacement of udelay() with > usleep_range(). The corresponding range for the single argument value of > udelay() is quite confusing as I couldn't decide the range. But as much as I > noticed checkpatch.pl

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

2020-03-30 Thread Julia Lawall
On Sun, 29 Mar 2020, John Wyatt wrote: > On Sun, 2020-03-29 at 11:28 +0200, Julia Lawall wrote: > > > > On Sun, 29 Mar 2020, John B. Wyatt IV wrote: > > > > > Fix style issue with usleep_range being reported as preferred over > > > udelay. > > > > > > Issue reported by checkpatch. > > > > > >

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

2020-03-30 Thread Julia Lawall
On Sun, 29 Mar 2020, John B. Wyatt IV wrote: > Fix style issue with usleep_range being reported as preferred over > udelay. > > Issue reported by checkpatch. > > Please review. > > As written in Documentation/timers/timers-howto.rst udelay is the > generally preferred API. hrtimers, as noted

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

2020-03-30 Thread John Wyatt
On Sun, 2020-03-29 at 11:28 +0200, Julia Lawall wrote: > > On Sun, 29 Mar 2020, John B. Wyatt IV wrote: > > > Fix style issue with usleep_range being reported as preferred over > > udelay. > > > > Issue reported by checkpatch. > > > > Please review. > > > > As written in

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

2020-03-30 Thread Soumyajit Deb
I had the same doubt the other day about the replacement of udelay() with usleep_range(). The corresponding range for the single argument value of udelay() is quite confusing as I couldn't decide the range. But as much as I noticed checkpatch.pl gives warning for replacing udelay() with

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

2020-03-30 Thread Sam Muhammed
On Sun, 2020-03-29 at 12:37 +0200, Julia Lawall wrote: > > On Sun, 29 Mar 2020, Soumyajit Deb wrote: > > > I had the same doubt the other day about the replacement of udelay() with > > usleep_range(). The corresponding range for the single argument value of > > udelay() is quite confusing as I

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

2020-03-29 Thread Andy Shevchenko
On Sun, Mar 29, 2020 at 2:23 PM Sam Muhammed wrote: > On Sun, 2020-03-29 at 12:37 +0200, Julia Lawall wrote: > > On Sun, 29 Mar 2020, Soumyajit Deb wrote: > > First of all, let's stop topposting. > > > I had the same doubt the other day about the replacement of udelay() with > > >