Using the managed variant to allocate the resource makes the code simpler
and less error-prone.

Tested-by: Darren Etheridge <detheridge at ti.com>
Signed-off-by: Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c 
b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 4b36e68..c716c12 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -354,7 +354,7 @@ static int panel_probe(struct platform_device *pdev)
                return -ENXIO;
        }

-       panel_mod = kzalloc(sizeof(*panel_mod), GFP_KERNEL);
+       panel_mod = devm_kzalloc(&pdev->dev, sizeof(*panel_mod), GFP_KERNEL);
        if (!panel_mod)
                return -ENOMEM;

@@ -391,7 +391,6 @@ fail_timings:
        display_timings_release(panel_mod->timings);

 fail_free:
-       kfree(panel_mod);
        tilcdc_module_cleanup(mod);
        return ret;
 }
@@ -405,7 +404,6 @@ static int panel_remove(struct platform_device *pdev)

        tilcdc_module_cleanup(mod);
        kfree(panel_mod->info);
-       kfree(panel_mod);

        return 0;
 }
-- 
2.0.1

Reply via email to