Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-18 Thread Doug Anderson
Hi, On Mon, Jun 17, 2024 at 7:22 AM Daniel Vetter wrote: > > > I'm really not convinced that hacking with device links in order to > > get the shutdown notification in the right order is correct, though. > > The idea is that after we're confident that all DRM modeset drivers > > are calling

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-18 Thread Doug Anderson
Hi, On Mon, Jun 17, 2024 at 7:17 AM Daniel Vetter wrote: > > > That all being said, I'm also totally OK with any of the following: > > > > 1. Dropping my patch and just accepting that we will have warnings > > printed out for all DRM drivers that do things correct

[PATCH v2 10/10] nova: add initial driver stub

2024-06-18 Thread Danilo Krummrich
Add the initial driver stub of Nova, a Rust-based GSP-only driver for Nvidia GPUs. Nova, in the long term, is intended to serve as the successor of Nouveau for GSP-firmware-based GPUs. [1] As a stub driver Nova's focus is to make use of the most basic device / driver infrastructure required to

[PATCH v2 8/8] nova: add initial driver stub

2024-06-18 Thread Danilo Krummrich
Add the initial driver stub of Nova, a Rust-based GSP-only driver for Nvidia GPUs. Nova, in the long term, is intended to serve as the successor of Nouveau for GSP-firmware-based GPUs. [1] As a stub driver Nova's focus is to make use of the most basic device / driver infrastructure required to

[PATCH v2 7/8] rust: drm: gem: Add GEM object abstraction

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina The DRM GEM subsystem is the DRM memory management subsystem used by most modern drivers. Add a Rust abstraction to allow Rust DRM driver implementations to use it. Signed-off-by: Asahi Lina Co-developed-by: Danilo Krummrich Signed-off-by: Danilo Krummrich ---

[PATCH v2 6/8] rust: drm: file: Add File abstraction

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina A DRM File is the DRM counterpart to a kernel file structure, representing an open DRM file descriptor. Add a Rust abstraction to allow drivers to implement their own File types that implement the DriverFile trait. Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich ---

[PATCH v2 5/8] rust: drm: add DRM driver registration

2024-06-18 Thread Danilo Krummrich
Implement the DRM driver `Registration`. The `Registration` structure is responsible to register and unregister a DRM driver. It makes use of the `Devres` container in order to allow the `Registration` to be owned by devres, such that it is automatically dropped (and the DRM driver unregistered)

[PATCH v2 4/8] rust: drm: add device abstraction

2024-06-18 Thread Danilo Krummrich
Implement the abstraction for a `struct drm_device`. A `drm::device::Device` creates a static const `struct drm_driver` filled with the data from the `drm::drv::Driver` trait implementation of the actual driver creating the `drm::device::Device`. Co-developed-by: Asahi Lina Signed-off-by: Asahi

[PATCH v2 2/8] rust: Add a Sealed trait

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina Some traits exposed by the kernel crate may not be intended to be implemented by downstream modules. Add a Sealed trait to allow avoiding this using the sealed trait pattern. Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich --- rust/kernel/lib.rs | 5 + 1 file

[PATCH v2 3/8] rust: drm: add driver abstractions

2024-06-18 Thread Danilo Krummrich
Implement the DRM driver abstractions. The `Driver` trait provides the interface to the actual driver to fill in the driver specific data, such as the `DriverInfo`, driver features and IOCTLs. Co-developed-by: Asahi Lina Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich ---

[PATCH v2 1/8] rust: drm: ioctl: Add DRM ioctl abstraction

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina DRM drivers need to be able to declare which driver-specific ioctls they support. Add an abstraction implementing the required types and a helper macro to generate the ioctl definition inside the DRM driver. Note that this macro is not usable until further bits of the

[PATCH v2 0/8] DRM Rust abstractions and Nova

2024-06-18 Thread Danilo Krummrich
This patch series implements some basic DRM Rust abstractions and a stub implementation of the Nova GPU driver. Nova is intended to be developed upstream, starting out with just a stub driver to lift some initial required infrastructure upstream. A more detailed explanation can be found in [1

Re: [PATCH v2 05/14] drm/msm/hdmi: drop clock frequency assignment

2024-06-18 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: The only clock which has frequency being set through hpd_freqs is the "core" aka MDSS_HDMI_CLK clock. It always has the specified frequency, so we can drop corresponding clk_set_rate() call together with the hpd_freq infrastructure.

Re: [PATCH v3 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-06-18 Thread Abhinav Kumar
. Signed-off-by: Dmitry Baryshkov ---   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 +++   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c  |  9 ++---   2 files changed, 17 insertions(+), 7 deletions(-) Did anything change in this patch from v2 that the R-b was dropped? Here it is again

Re: [PATCH v3 8/9] drm/msm/dpu: merge MAX_IMG_WIDTH/HEIGHT with DPU_MAX_IMG_WIDTH/HEIGHT

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these constants to remove duplication. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v3 7/9] drm/msm/dpu: drop _dpu_crtc_check_and_setup_lm_bounds from atomic_begin

2024-06-18 Thread Abhinav Kumar
if that works for you. Otherwise I will have to spend a little more time on this patch and why chrome compositor does not like this for the animation screen.

Re: [PATCH v3 6/9] drm/msm/dpu: check for the plane pitch overflow

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Check that the plane pitch doesn't overflow the maximum pitch size allowed by the hardware. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++

Re: [PATCH v3 5/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-18 Thread Abhinav Kumar
On 6/14/2024 3:34 AM, Dmitry Baryshkov wrote: On Thu, Jun 13, 2024 at 04:19:07PM GMT, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as

Re: [PATCH v3 4/9] drm/msm/dpu: split dpu_format_populate_layout

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Split dpu_format_populate_layout() into addess-related and pitch/format-related parts. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 8 +++-

Re: [PATCH v3 3/9] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layout in the plane state and drop this call from dpu_plane_sspp_update(). Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v3 2/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 4:14 PM, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov ---   drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43

Re: [PATCH v3 1/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 4:13 PM, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Make _dpu_crtc_setup_lm_bounds() check that CRTC width is not overflowing LM requirements. Rename the function accordingly. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by:

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-18 Thread Leo Li
On 2024-06-05 22:04, Mario Limonciello wrote: When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy` property is set to bit mask

Re: [PATCH v5 05/12] drm/ttm: Provide a generic LRU walker helper

2024-06-18 Thread Matthew Brost
On Tue, Jun 18, 2024 at 09:18:13AM +0200, Thomas Hellström wrote: Replying to correct version... > Provide a generic LRU walker in TTM, in the spirit of drm_gem_lru_scan() > but building on the restartable TTM LRU functionality. > > The LRU walker optionally supports locking objects as part of

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Alex Deucher
eucher > > > Cc: Christian König > > > Cc: Xinhui Pan > > > Signed-off-by: Douglas Anderson > > > --- > > > This commit is only compile-time tested. > > > > > > ...and further, I'd say that this patch is more of a plea for help > > >

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Doug Anderson
he kernel doc "driver > > instance overview" in drm_drv.c. > > > > Suggested-by: Maxime Ripard > > Cc: Alex Deucher > > Cc: Christian König > > Cc: Xinhui Pan > > Signed-off-by: Douglas Anderson > > --- > > This commit is only compile-tim

Re: [PATCH] drm/amd/display: Disable CONFIG_DRM_AMD_DC_FP for RISC-V with clang

2024-06-18 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Jun 18, 2024 at 10:17 AM Harry Wentland wrote: > > > > On 2024-06-14 15:54, Nathan Chancellor wrote: > > Commit 77acc6b55ae4 ("riscv: add support for kernel-mode FPU") and > > commit a28e4b672f04 ("drm/amd/display: use ARCH_HAS_KERNEL_FPU_SUPPORT") > > enabled

Re: [PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-06-18 Thread Mario Limonciello
On 6/18/2024 15:20, Leo Li wrote: On 2024-05-22 18:08, Mario Limonciello wrote: Verify that the property has disabled PSR ---   tests/amdgpu/amd_psr.c | 74 ++   1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c

Re: [PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-06-18 Thread Mario Limonciello
On 6/18/2024 15:20, Leo Li wrote: Thanks for the tests! FYI IGT patches should also cc igt-...@lists.freedesktop.org Some comments inline: On 2024-05-22 18:08, Mario Limonciello wrote: From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread André Almeida
Em 18/06/2024 14:43, Dmitry Baryshkov escreveu: On Tue, Jun 18, 2024 at 01:18:10PM GMT, André Almeida wrote: Em 18/06/2024 07:07, Dmitry Baryshkov escreveu: On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote: On Tue, 18 Jun 2024, André Almeida wrote: Drivers have different capabilities on

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 01:48, Joe Damato wrote: > [You don't often get email from jdam...@fastly.com. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:22:02AM +0300, Omer Shpigelman wrote: >> This ethernet driver is initialized via auxiliary bus

Re: [PATCH 04/15] net: hbl_cn: QP state machine

2024-06-18 Thread Omer Shpigelman
On 6/18/24 10:08, Leon Romanovsky wrote: > On Tue, Jun 18, 2024 at 05:50:15AM +, Omer Shpigelman wrote: >> On 6/17/24 16:18, Leon Romanovsky wrote: >>> [Some people who received this message don't often get email from >>> l...@kernel.org. Learn why this is important at >>>

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-18 Thread Omer Shpigelman
.../ethernet/intel/hbl_cn/common/hbl_cn_drv.c | 220 + >>>> .../intel/hbl_cn/common/hbl_cn_memory.c | 40 + >>>> .../ethernet/intel/hbl_cn/common/hbl_cn_phy.c | 33 + >>>> .../ethernet/intel/hbl_cn/common/hbl_cn_qp.c | 13 + >>>> include/lin

[PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread TaoJiang
From: Ming Qian When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't know whether the dma buffer is coherent or synchronized. The videobuf2-core will skip cache syncs as it think the DMA exporter should take care of cache syncs But in fact it's likely that the client doesn't

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread ming qian
the cache syncs. Signed-off-by: Ming Qian Signed-off-by: TaoJiang --- .../media/common/videobuf2/videobuf2-core.c | 22 +++ 1 file changed, 22 insertions(+) Sorry, that patch is incorrect. I believe you're misunderstanding the way DMA-buf buffers should be managed

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 13:55, Zhu Yanjun wrote: > [You don't often get email from yanjun@linux.dev. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > 在 2024/6/13 16:22, Omer Shpigelman 写道: >> + >> +/* This function should be called after ctrl_lock was taken */ > >

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 03:16, Stephen Hemminger wrote: > [You don't often get email from step...@networkplumber.org. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > >> + >> +/* get the src IP as it is done in devinet_ioctl() */ >> +static int hbl_en_get_src_ip(struct

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 18:02, Andrew Lunn wrote: > [Some people who received this message don't often get email from > and...@lunn.ch. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 04:05:57PM +0200, Markus Elfring wrote: >> … >>> +++

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 22:04, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 05:43:49PM +, Omer Shpigelman wrote: >> On 6/13/24

Re: [PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-06-18 Thread Leo Li
On 2024-05-22 18:08, Mario Limonciello wrote: Verify that the property has disabled PSR --- tests/amdgpu/amd_psr.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c index 9da161a09..a9f4a6aa5

Re: [PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-06-18 Thread Leo Li
Thanks for the tests! FYI IGT patches should also cc igt-...@lists.freedesktop.org Some comments inline: On 2024-05-22 18:08, Mario Limonciello wrote: From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to

Re: [PATCH v2 1/2] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-06-18 Thread Rodrigo Vivi
ncr_ms: Successive frame duration increase > > * @duration_decr_ms: Successive frame duration decrease > > + * @target_rr_divider: Target refresh rate divider > > Maarten, Maxime, or Thomas, > the patch introducing this target_rr_divider is in drm-intel-next. > Ack on adding t

RE: [PATCH v2 0/2] Sparse errors on the i915_gem_stolen

2024-06-18 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Monday, June 17, 2024 11:43 AM To: intel-gfx ; dri-devel Cc: Andi Shyti ; Cavitt, Jonathan ; De Marchi, Lucas Subject: [PATCH v2 0/2] Sparse errors on the i915_gem_stolen > > Hi Jonathan, > > Commit 05da7d9f717b ("drm/i9

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-18 Thread Dragan Simic
e lines containing MODULE_SOFTDEP() at the very end of fs/btrfs/super.c. [2] If a filesystem driver can rely on the abuse of softdeps, which admittedly are a bit fragile, I think we can follow the same approach, at least for now. With all that in mind, I think that accepting this patch, as w

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Konrad Dybcio
On 6/18/24 20:55, Dmitry Baryshkov wrote: On Tue, Jun 18, 2024 at 08:50:52PM GMT, Konrad Dybcio wrote: On 6/18/24 19:50, Dmitry Baryshkov wrote: On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sankouski wrote: sdm845 has "General Purpose" clocks that can be muxed to SoC pins. Those

Re: [PATCH v4 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

2024-06-18 Thread Konrad Dybcio
max); + BUILD_BUG_ON(a650_protect.count > a650_protect.count_max); + BUILD_BUG_ON(a660_protect.count > a660_protect.count_max); + BUILD_BUG_ON(a690_protect.count > a690_protect.count_max); + BUILD_BUG_ON(a730_protect.count > a730_protect.count_max); +} + patch:394:

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 08:50:52PM GMT, Konrad Dybcio wrote: > > > On 6/18/24 19:50, Dmitry Baryshkov wrote: > > On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sankouski wrote: > > > sdm845 has "General Purpose" clocks that can be muxed to > > > SoC pins. > > > > > > Those clocks may be used

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Konrad Dybcio
On 6/18/24 19:50, Dmitry Baryshkov wrote: On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sankouski wrote: sdm845 has "General Purpose" clocks that can be muxed to SoC pins. Those clocks may be used as e.g. PWM sources for external peripherals. Add more frequencies to the table for those

Re: [PATCH v3 11/23] drm/panel: Add support for S6E3HA8 panel driver

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 04:59:45PM GMT, Dzmitry Sankouski wrote: > Add support for MIPI-DSI based S6E3HA8 AMOLED panel > driver. This panel has 1440x2960 resolution, 5.8-inch physical > size, and can be found in starqltechn device. > Brightness regulation is not yet supported. > > Signed-off-by:

Re: [PATCH] drm: bridge: simple-bridge: use devm_drm_bridge_add in probe

2024-06-18 Thread Dmitry Baryshkov
device release, and the remove() > callback is no longer required. > > Signed-off-by: Marc Gonzalez > --- > This patch was proposed in an abandoned patch series, > but it makes sense by itself. Submit now. > https://lore.kernel.org/r/20240617-tdp158-v1-0-df98ef7de...@freebo

Re: [PATCH 2/3] drm/vc4: Add monochrome mode to the VEC.

2024-06-18 Thread Dave Stevenson
Hi Maxime On Tue, 18 Jun 2024 at 10:28, Maxime Ripard wrote: > > Hi, > > On Fri, Feb 16, 2024 at 06:48:56PM GMT, Dave Stevenson wrote: > > The VEC supports not producing colour bursts for monochrome output. > > It also has an option for disabling the chroma input to remove > > chroma from the

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sankouski wrote: > sdm845 has "General Purpose" clocks that can be muxed to > SoC pins. > > Those clocks may be used as e.g. PWM sources for external peripherals. > Add more frequencies to the table for those clocks so it's possible > for arbitrary

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:18:10PM GMT, André Almeida wrote: > Em 18/06/2024 07:07, Dmitry Baryshkov escreveu: > > On Tue, 18 Jun 2024 at 12:38, Jani Nikula > > wrote: > > > > > > On Tue, 18 Jun 2024, André Almeida wrote: > > > > Drivers have different capabilities on what plane types they can

Re: [PATCH v3 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 09:33:48AM GMT, Rob Clark wrote: > On Tue, Jun 18, 2024 at 1:30 AM Dmitry Baryshkov > wrote: > > > > On Mon, Jun 17, 2024 at 03:51:14PM GMT, Rob Clark wrote: > > > From: Rob Clark > > > > > > Introduce a6xx_info where we can stash gen specific stuff without > > >

Re: [PATCH 4/4] drm: bridge: simple-bridge: add tdp158 support

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:48:48PM GMT, Marc Gonzalez wrote: > On 18/06/2024 00:33, Dmitry Baryshkov wrote: > > > On Mon, Jun 17, 2024 at 06:03:02PM GMT, Marc Gonzalez wrote: > > > >> + if (sbridge->vcc) { > >> + ret = regulator_enable(sbridge->vcc); > >> + msleep(100); > > >

Re: [PATCH 3/4] drm: bridge: simple-bridge: use only devm* in probe

2024-06-18 Thread Dmitry Baryshkov
r needed, since devm unwind will free all resources. > > Is that better? Yes. Or something like: The only call in remove() is drm_bridge_remove(). Use devm_bridge_add(), removing the need to call drm_bridge_remove() manually and drop the driver's remove callback completely. > > NB: t

Re: [PATCH v9 16/21] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-18 Thread 林睿祥

Re: [PATCH v3 07/23] dt-bindings: power: supply: add maxim,max77705

2024-06-18 Thread Rob Herring (Arm)
t; My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: pmic@66: fuelgauge: 'monitored-battery', 'power-supplies' do not m

Re: [PATCH v3 09/23] dt-bindings: mfd: add samsung,s2dos05

2024-06-18 Thread Rob Herring (Arm)
| 1 + > 2 files changed, 90 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/mfd/samsung,s2dos05.example.dtb: /example-0/i2c/pmic@60:

Re: [PATCH v3 04/23] dt-bindings: mfd: add maxim,max77705

2024-06-18 Thread Rob Herring (Arm)
+++ > MAINTAINERS| 1 + > 2 files changed, 113 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dt

[PATCH v4 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

2024-06-18 Thread Rob Clark
From: Rob Clark Move the CP_PROTECT settings into the hw catalog. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 248 + drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 257 +-

[PATCH v4 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2024-06-18 Thread Rob Clark
From: Rob Clark Introduce a6xx_info where we can stash gen specific stuff without polluting the toplevel adreno_info struct. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 65 +--

[PATCH v4 3/5] drm/msm/adreno: Move hwcg regs to a6xx hw catalog

2024-06-18 Thread Rob Clark
From: Rob Clark Move the hwcg tables into the hw catalog. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 619 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 617 -

[PATCH v4 2/5] drm/msm/adreno: Split catalog into separate files

2024-06-18 Thread Rob Clark
From: Rob Clark Split each gen's gpu table into it's own file. Only code-motion, no functional change. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/Makefile | 5 + drivers/gpu/drm/msm/adreno/a2xx_catalog.c | 52

[PATCH v4 1/5] drm/msm/adreno: Split up giant device table

2024-06-18 Thread Rob Clark
From: Rob Clark Split into a separate table per generation, in preparation to move each gen's device table to it's own file. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_device.c | 67 +-

[PATCH v4 0/5] drm/msm/adreno: Introduce/rework device hw catalog

2024-06-18 Thread Rob Clark
From: Rob Clark Split the single flat gpulist table into per-gen tables that exist in their own per-gen files, and start moving more info into the device table. This at least gets all the big tables of register settings out of the heart of the a6xx_gpu code. Probably more could be moved, to

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-18 Thread Akhil P Oommen
On Tue, Jun 04, 2024 at 07:35:04PM +0200, Konrad Dybcio wrote: > > > On 5/14/24 20:38, Akhil P Oommen wrote: > > On Wed, May 08, 2024 at 07:46:31PM +0200, Konrad Dybcio wrote: > > > Memory barriers help ensure instruction ordering, NOT time and order > > > of actual write arrival at other

Re: [PATCH v3 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2024-06-18 Thread Rob Clark
On Tue, Jun 18, 2024 at 1:30 AM Dmitry Baryshkov wrote: > > On Mon, Jun 17, 2024 at 03:51:14PM GMT, Rob Clark wrote: > > From: Rob Clark > > > > Introduce a6xx_info where we can stash gen specific stuff without > > polluting the toplevel adreno_info struct. > > > > Signed-off-by: Rob Clark > >

[PATCH] drm: bridge: simple-bridge: use devm_drm_bridge_add in probe

2024-06-18 Thread Marc Gonzalez
Gonzalez --- This patch was proposed in an abandoned patch series, but it makes sense by itself. Submit now. https://lore.kernel.org/r/20240617-tdp158-v1-0-df98ef7de...@freebox.fr --- drivers/gpu/drm/bridge/simple-bridge.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread Nicolas Dufresne
d-off-by: TaoJiang > > --- > > .../media/common/videobuf2/videobuf2-core.c | 22 +++ > > 1 file changed, 22 insertions(+) > > > > Sorry, that patch is incorrect. I believe you're misunderstanding the > way DMA-buf buffers should be managed in

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread André Almeida
Em 18/06/2024 07:07, Dmitry Baryshkov escreveu: On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote: On Tue, 18 Jun 2024, André Almeida wrote: Drivers have different capabilities on what plane types they can or cannot perform async flips. Create a plane::async_flip field so each driver can

Re: [PATCH 0/4] Basic support for TI TDP158

2024-06-18 Thread Marc Gonzalez
On 18/06/2024 16:36, Maxime Ripard wrote: > On Tue, Jun 18, 2024 at 03:07:16PM GMT, Marc Gonzalez wrote: > >> On 17/06/2024 18:02, Marc Gonzalez wrote: >> >>> Marc Gonzalez (4): >>> dt-bindings: display: simple-bridge: add ti,tdp158 >>> drm: bridge: simple-bridge: use dev pointer in

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-18 Thread Akhil P Oommen
On Tue, Jun 04, 2024 at 03:40:56PM +0100, Will Deacon wrote: > On Thu, May 16, 2024 at 01:55:26PM -0500, Andrew Halaney wrote: > > On Thu, May 16, 2024 at 08:20:05PM GMT, Akhil P Oommen wrote: > > > On Thu, May 16, 2024 at 08:15:34AM -0500, Andrew Halaney wrote: > > > > If I understand correctly,

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-18 Thread Przemek Kitszel
On 6/18/24 13:08, Omer Shpigelman wrote: On 6/17/24 22:04, Leon Romanovsky wrote: [Some people who received this message don't often get email from l...@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] On Mon, Jun 17, 2024 at 05:43:49PM +, Omer

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-18 Thread Will Deacon
On Thu, Jun 06, 2024 at 02:03:24PM +0200, Konrad Dybcio wrote: > On 4.06.2024 4:40 PM, Will Deacon wrote: > > On Thu, May 16, 2024 at 01:55:26PM -0500, Andrew Halaney wrote: > >> On Thu, May 16, 2024 at 08:20:05PM GMT, Akhil P Oommen wrote: > >>> On Thu, May 16, 2024 at 08:15:34AM -0500, Andrew

Re: [PATCH] drm/panic: depends on !VT_CONSOLE

2024-06-18 Thread Jocelyn Falempe
ppen due the VT not being a system console for the kernel to print messages ? Yes, but when writing the patch, I thought that if you have VT_CONSOLE=y and FRAMEBUFFER_CONSOLE=n, then there won't be any race condition, and drm_panic can be enabled safely. I don't know if that really matters, and if V

[PATCH v3 23/23] arm64: dts: qcom: starqltechn: add new features

2024-06-18 Thread Dzmitry Sankouski
Add support for new features: - sound (headphones and mics only) - gpu - panel - buttons - MAX77705 MFD:    - charger    - fuelgauge    - haptic    - led Signed-off-by: Dzmitry Sankouski --- .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 593 - 1 file changed, 592

[PATCH v3 18/23] regulator: add s2dos05 regulator support

2024-06-18 Thread Dzmitry Sankouski
S2dos05 has 1 buck and 4 LDO regulators, used for powering panel/touchscreen. Signed-off-by: Dzmitry Sankouski --- MAINTAINERS | 1 + drivers/regulator/Kconfig | 8 + drivers/regulator/Makefile| 1 + drivers/regulator/s2dos05-regulator.c |

Re: [PATCH RESEND v5 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-06-18 Thread Mark Brown
On Mon, Jun 17, 2024 at 10:05:37AM +0200, Alexandre Mergnat wrote: > On 14/06/2024 11:31, Mark Brown wrote: > > I seem to remember you had review comments that needed addressing from > > AngeloGioacchino, why resend without addressing those? > I don't see any comment: >

Re: [PATCH RESEND v5 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-06-18 Thread AngeloGioacchino Del Regno
Il 17/06/24 10:05, Alexandre Mergnat ha scritto: On 14/06/2024 11:31, Mark Brown wrote: On Fri, Jun 14, 2024 at 09:27:43AM +0200, Alexandre Mergnat wrote: This serie aim to add the following audio support for the Genio 350-evk: - Playback    - 2ch Headset Jack (Earphone)    - 1ch Line-out

[PATCH v3 08/23] dt-bindings: led: add maxim,max77705-leds

2024-06-18 Thread Dzmitry Sankouski
add maxim,max77705 leds binding part Signed-off-by: Dzmitry Sankouski --- .../devicetree/bindings/leds/maxim,max77705.yaml | 45 ++ 1 file changed, 45 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/maxim,max77705.yaml

Re: [PATCH 0/4] Basic support for TI TDP158

2024-06-18 Thread Maxime Ripard
On Tue, Jun 18, 2024 at 03:07:16PM GMT, Marc Gonzalez wrote: > On 17/06/2024 18:02, Marc Gonzalez wrote: > > > Marc Gonzalez (4): > > dt-bindings: display: simple-bridge: add ti,tdp158 > > drm: bridge: simple-bridge: use dev pointer in probe > > drm: bridge: simple-bridge: use

Re: [PATCH v3 22/23] arm64: dts: qcom: starqltechn: fix usb regulator mistake

2024-06-18 Thread Dzmitry Sankouski
вт, 18 июн. 2024 г. в 17:08, Konrad Dybcio : > > > > On 6/18/24 15:59, Dzmitry Sankouski wrote: > > Usb regulator was wrongly pointed to vreg_l1a_0p875. > > However, on starqltechn it's powered from vreg_l5a_0p8. > > > > Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device > >

[PATCH v3 04/23] dt-bindings: mfd: add maxim,max77705

2024-06-18 Thread Dzmitry Sankouski
maxim,max77705 is MAX77705 pmic binding part Signed-off-by: Dzmitry Sankouski --- .../devicetree/bindings/mfd/maxim,max77705.yaml| 112 + MAINTAINERS| 1 + 2 files changed, 113 insertions(+) diff --git

[PATCH v3 22/23] arm64: dts: qcom: starqltechn: fix usb regulator mistake

2024-06-18 Thread Dzmitry Sankouski
Usb regulator was wrongly pointed to vreg_l1a_0p875. However, on starqltechn it's powered from vreg_l5a_0p8. Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn") Signed-off-by: Dzmitry Sankouski ---

[PATCH v3 21/23] arm64: dts: qcom: starqltechn: remove framebuffer

2024-06-18 Thread Dzmitry Sankouski
Remove framebuffer because a panel driver introduced. Signed-off-by: Dzmitry Sankouski --- arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts

[PATCH v3 20/23] arm64: dts: qcom: starqltechn: remove wifi

2024-06-18 Thread Dzmitry Sankouski
Starqltechn has broadcom chip for wifi, so sdm845 wifi part can be disabled. Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn") Signed-off-by: Dzmitry Sankouski --- arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 8 1 file

[PATCH v3 19/23] power: supply: s2dos05: Add fuel gauge driver for s2dos05

2024-06-18 Thread Dzmitry Sankouski
Add fuel gauge driver for s2dos05 PMIC. It uses adc to measure power on each power output s2dos05 provides, including regulator outputs and AVDD, ELVSS, ELVDD lines. Driver registers power supply for each corresponding power line. Adc can be disabled and enabled via sysfs. Signed-off-by: Dzmitry

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Andrew Lunn
> >> +static u32 hbl_en_get_mtu(struct hbl_aux_dev *aux_dev, u32 port_idx) > >> +{ > >> + struct hbl_en_port *port = HBL_EN_PORT(aux_dev, port_idx); > >> + struct net_device *ndev = port->ndev; > >> + u32 mtu; > >> + > >> + if (atomic_cmpxchg(>in_reset, 0, 1)) { > >> +

[PATCH v3 17/23] mfd: add s2dos series core driver

2024-06-18 Thread Dzmitry Sankouski
S2DOS05 is a panel/touchscreen PMIC, often found in Samsung phones. We define 2 sub-devices for which drivers will be added in subsequent patches. Signed-off-by: Dzmitry Sankouski --- MAINTAINERS| 1 + drivers/mfd/Kconfig| 13 +++

[PATCH v3 16/23] leds: max77705: Add LEDs support

2024-06-18 Thread Dzmitry Sankouski
This adds basic support for LEDs for the max77705 PMIC. Signed-off-by: Dzmitry Sankouski --- MAINTAINERS | 1 + drivers/leds/Kconfig | 6 ++ drivers/leds/Makefile| 1 + drivers/leds/leds-max77705.c | 166 +++ 4 files

[PATCH v3 15/23] power: supply: max77705: Add fuel gauge driver for Maxim 77705

2024-06-18 Thread Dzmitry Sankouski
Add driver for Maxim 77705 fuel gauge (part of max77705 MFD driver) providing power supply class information to userspace. The driver is configured through DTS (battery and system related settings). Signed-off-by: Dzmitry Sankouski --- drivers/power/supply/Kconfig | 7 +

[PATCH v3 14/23] power: supply: max77705: Add charger driver for Maxim 77705

2024-06-18 Thread Dzmitry Sankouski
Add driver for Maxim 77705 switch-mode charger (part of max77705 MFD driver) providing power supply class information to userspace. The driver is configured through DTS (battery and system related settings). Also, POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE property is writable, which allows to

[PATCH v3 13/23] input: add max77705 haptic driver

2024-06-18 Thread Dzmitry Sankouski
Add support for haptic controller on MAX77705 Multifunction device. This driver supports external pwm and LRA (Linear Resonant Actuator) motor. User can control the haptic device via force feedback framework. Signed-off-by: Dzmitry Sankouski --- drivers/input/misc/Kconfig | 11 +

[PATCH v3 11/23] drm/panel: Add support for S6E3HA8 panel driver

2024-06-18 Thread Dzmitry Sankouski
Add support for MIPI-DSI based S6E3HA8 AMOLED panel driver. This panel has 1440x2960 resolution, 5.8-inch physical size, and can be found in starqltechn device. Brightness regulation is not yet supported. Signed-off-by: Dzmitry Sankouski --- MAINTAINERS | 1 +

[PATCH v3 12/23] mfd: Add new driver for MAX77705 PMIC

2024-06-18 Thread Dzmitry Sankouski
Add the core MFD driver for max77705 PMIC. We define five sub-devices for which the drivers will be added in subsequent patches. Signed-off-by: Dzmitry Sankouski Co-authored-by: Rose Hudson --- MAINTAINERS | 2 + drivers/mfd/Kconfig | 12 ++

[PATCH v3 10/23] dt-bindings: regulator: add samsung,s2dos05

2024-06-18 Thread Dzmitry Sankouski
add samsung,s2dos05 regulator binding part Signed-off-by: Dzmitry Sankouski --- .../bindings/regulator/samsung,s2dos05.yaml| 36 ++ MAINTAINERS| 1 + 2 files changed, 37 insertions(+) diff --git

[PATCH v3 09/23] dt-bindings: mfd: add samsung,s2dos05

2024-06-18 Thread Dzmitry Sankouski
add samsung,s2dos05 core MFD module binding Signed-off-by: Dzmitry Sankouski --- .../devicetree/bindings/mfd/samsung,s2dos05.yaml | 89 ++ MAINTAINERS| 1 + 2 files changed, 90 insertions(+) diff --git

[PATCH v3 07/23] dt-bindings: power: supply: add maxim,max77705

2024-06-18 Thread Dzmitry Sankouski
add maxim,max77705 fuel gauge binding part Signed-off-by: Dzmitry Sankouski --- .../bindings/power/supply/maxim,max77705-fg.yaml | 35 ++ 1 file changed, 35 insertions(+) diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max77705-fg.yaml

[PATCH v3 06/23] dt-bindings: power: supply: add maxim,max77705 charger

2024-06-18 Thread Dzmitry Sankouski
add maxim,max77705 charger binding part Signed-off-by: Dzmitry Sankouski --- .../power/supply/maxim,max77705-charger.yaml | 30 ++ 1 file changed, 30 insertions(+) diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max77705-charger.yaml

<    5   6   7   8   9   10   11   12   13   14   >