Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-04 Thread Joe Perches
On Fri, 2022-02-04 at 12:31 +, Russell King (Oracle) wrote: > On Fri, Feb 04, 2022 at 04:18:24AM -0800, Joe Perches wrote: > > On Fri, 2022-02-04 at 12:05 +, Russell King (Oracle) wrote: > > > On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawk...@hpe.com wrote: > > > > + if

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-04 Thread Andrew Lunn
> > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > It's normal to list all linux/ includes before asm/ includes. Please > rearrange. Hi Nick Since you are new to the kernel, please let me point out, you should consider Russell comments

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-04 Thread Russell King (Oracle)
On Fri, Feb 04, 2022 at 04:18:24AM -0800, Joe Perches wrote: > On Fri, 2022-02-04 at 12:05 +, Russell King (Oracle) wrote: > > On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawk...@hpe.com wrote: > > > + if (readb_relaxed(timer->control) & MASK_TCS_TC) { > > > +

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-04 Thread Joe Perches
On Fri, 2022-02-04 at 12:05 +, Russell King (Oracle) wrote: > On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawk...@hpe.com wrote: [] > > diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile [] > > +static irqreturn_t gxp_time_interrupt(int irq, void *dev_id) > > +{ > > +

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-04 Thread Russell King (Oracle)
Hi, On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawk...@hpe.com wrote: > diff --git a/arch/arm/mach-hpe/Makefile b/arch/arm/mach-hpe/Makefile > new file mode 100644 > index ..8b0a91234df4 > --- /dev/null > +++ b/arch/arm/mach-hpe/Makefile > @@ -0,0 +1 @@ >

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-04 Thread Krzysztof Kozlowski
On 03/02/2022 18:07, Verdun, Jean-Marie wrote: > >> Maybe it does not look like, but this is actually a v2. Nick was asked >> to change the naming for the nodes already in v1. Unfortunately it did >> not happen, so we have vuart, spifi, vic and more. > >> It is a waste of

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-03 Thread Verdun, Jean-Marie
> Maybe it does not look like, but this is actually a v2. Nick was asked > to change the naming for the nodes already in v1. Unfortunately it did > not happen, so we have vuart, spifi, vic and more. > It is a waste of reviewers' time to ask them to perform the same review > twice

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-03 Thread Krzysztof Kozlowski
On 03/02/2022 15:29, Rob Herring wrote: > On Wed, Feb 2, 2022 at 10:55 AM wrote: >> >> From: Nick Hawkins >> (...) >> + >> + vuart_a: vuart_a@80fd0200 { > > serial@... Maybe it does not look like, but this is actually a v2. Nick was asked to change the naming for the nodes already in

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-03 Thread Rob Herring
On Wed, Feb 2, 2022 at 10:55 AM wrote: > > From: Nick Hawkins > > GXP is the name of the HPE SoC. > This SoC is used to implement BMC features of HPE servers > (all ProLiant, Synergy, and many Apollo, and Superdome machines) > It does support many features including: > ARMv7

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-02 Thread Krzysztof Kozlowski
On 02/02/2022 17:52, nick.hawk...@hpe.com wrote: > From: Nick Hawkins > > GXP is the name of the HPE SoC. > This SoC is used to implement BMC features of HPE servers > (all ProLiant, Synergy, and many Apollo, and Superdome machines) > It does support many features including: > ARMv7

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-02 Thread Andrew Lunn
> .../bindings/display/hpe,gxp-thumbnail.txt| 21 + > .../devicetree/bindings/gpio/hpe,gxp-gpio.txt | 16 + > .../devicetree/bindings/i2c/hpe,gxp-i2c.txt | 19 + > .../bindings/ipmi/hpegxp-kcs-bmc-cfg.txt | 13 + > .../bindings/ipmi/hpegxp-kcs-bmc.txt | 21 + Hi Nick In

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-02 Thread Corey Minyard
On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawk...@hpe.com wrote: > From: Nick Hawkins > > GXP is the name of the HPE SoC. > This SoC is used to implement BMC features of HPE servers > (all ProLiant, Synergy, and many Apollo, and Superdome machines) > It does support many features including:

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-02 Thread Verdun, Jean-Marie
> This is far too big for a single patch. It needs to be broken into > functional chunks that can be reviewed individually. Each driver and > each device tree change along with it's accompanying code need to be > done in individual patches. The way it is it can't be reviewed in any > sane

Re: [Openipmi-developer] [PATCH] HPE BMC GXP SUPPORT

2022-02-02 Thread Corey Minyard
On Wed, Feb 02, 2022 at 06:14:57PM +, Verdun, Jean-Marie wrote: > > This is far too big for a single patch. It needs to be broken into > > functional chunks that can be reviewed individually. Each driver and > > each device tree change along with it's accompanying code need to be > > done in

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-02 Thread Arnd Bergmann
On Wed, Feb 2, 2022 at 7:14 PM Verdun, Jean-Marie wrote: > > > This is far too big for a single patch. It needs to be broken into > > functional chunks that can be reviewed individually. Each driver and > > each device tree change along with it's accompanying code need to be > > done in

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-02 Thread Sam Ravnborg
Hi Nick, good to see all this stuff coming mainline, On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawk...@hpe.com wrote: > From: Nick Hawkins > > GXP is the name of the HPE SoC. > This SoC is used to implement BMC features of HPE servers > (all ProLiant, Synergy, and many Apollo, and

[PATCH] HPE BMC GXP SUPPORT

2022-02-02 Thread nick . hawkins
From: Nick Hawkins GXP is the name of the HPE SoC. This SoC is used to implement BMC features of HPE servers (all ProLiant, Synergy, and many Apollo, and Superdome machines) It does support many features including: ARMv7 architecture, and it is based on a Cortex A9 core Use an