Re: [PATCH] Revert "drm/imx: don't destroy mode objects manually on driver unbind"

2018-10-17 Thread Stefan Agner
On 17.10.2018 13:25, Stefan Agner wrote: > On 16.10.2018 18:09, Stefan Agner wrote: >> This reverts commit 8e3b16e2117409625b89807de3912ff773aea354. >> >> Using the component framework requires all components to undo in >> ->unbind what ->bind does. Unfortunately that particular commit >> broke

Re: [PATCH] Revert "drm/imx: don't destroy mode objects manually on driver unbind"

2018-10-17 Thread Stefan Agner
On 16.10.2018 18:09, Stefan Agner wrote: > This reverts commit 8e3b16e2117409625b89807de3912ff773aea354. > > Using the component framework requires all components to undo in > ->unbind what ->bind does. Unfortunately that particular commit > broke this rule. In particular, this is an issue if a

Re: [PATCH] Revert "drm/imx: don't destroy mode objects manually on driver unbind"

2018-10-17 Thread Stefan Agner
On 16.10.2018 18:51, Lucas Stach wrote: > Am Dienstag, den 16.10.2018, 18:09 +0200 schrieb Stefan Agner: >> This reverts commit 8e3b16e2117409625b89807de3912ff773aea354. >> >> Using the component framework requires all components to undo in >> ->unbind what ->bind does. Unfortunately that

Re: [PATCH] Revert "drm/imx: don't destroy mode objects manually on driver unbind"

2018-10-16 Thread Lucas Stach
Am Dienstag, den 16.10.2018, 18:09 +0200 schrieb Stefan Agner: > This reverts commit 8e3b16e2117409625b89807de3912ff773aea354. > > Using the component framework requires all components to undo in > ->unbind what ->bind does. Unfortunately that particular commit > broke this rule. In particular,

Re: [PATCH] Revert "drm/imx: don't destroy mode objects manually on driver unbind"

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 06:09:23PM +0200, Stefan Agner wrote: > This reverts commit 8e3b16e2117409625b89807de3912ff773aea354. > > Using the component framework requires all components to undo in > ->unbind what ->bind does. Unfortunately that particular commit > broke this rule. In particular,

[PATCH] Revert "drm/imx: don't destroy mode objects manually on driver unbind"

2018-10-16 Thread Stefan Agner
This reverts commit 8e3b16e2117409625b89807de3912ff773aea354. Using the component framework requires all components to undo in ->unbind what ->bind does. Unfortunately that particular commit broke this rule. In particular, this is an issue if a single component during probe fails. In that case,