Re: [Spice-devel] [PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-29 Thread Daniel Vetter
On Mon, Apr 29, 2019 at 4:38 PM Gerd Hoffmann wrote: > > Hi, > > > > More useful would be some way to signal this self-reimport capability > > > to userspace somehow. See DRM_PRIME_CAP_LOCAL patch. > > > > Userspace is supposed to test whether import/export works for a > > specific combo, not b

Re: [Spice-devel] [PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-29 Thread Gerd Hoffmann
Hi, > > More useful would be some way to signal this self-reimport capability > > to userspace somehow. See DRM_PRIME_CAP_LOCAL patch. > > Userspace is supposed to test whether import/export works for a > specific combo, not blindly assume it does and then keel over. I think > we need to fix t

Re: [Spice-devel] [PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-29 Thread Gerd Hoffmann
On Fri, Apr 26, 2019 at 04:21:37PM +0200, Daniel Vetter wrote: > On Fri, Apr 26, 2019 at 7:33 AM Gerd Hoffmann wrote: > > > > This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. > > > > Simliar to commit a0cecc23cfcb Revert "drm/virtio: drop prime > > import/export callbacks". We have t

Re: [Spice-devel] [PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-29 Thread Daniel Vetter
On Mon, Apr 29, 2019 at 9:54 AM Gerd Hoffmann wrote: > > On Fri, Apr 26, 2019 at 04:21:37PM +0200, Daniel Vetter wrote: > > On Fri, Apr 26, 2019 at 7:33 AM Gerd Hoffmann wrote: > > > > > > This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. > > > > > > Simliar to commit a0cecc23cfcb Rev

Re: [PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-29 Thread Daniel Vetter
On Fri, Apr 26, 2019 at 05:42:23PM +0200, Thomas Hellstrom wrote: > On 4/26/19 4:21 PM, Daniel Vetter wrote: > > On Fri, Apr 26, 2019 at 7:33 AM Gerd Hoffmann wrote: > > > This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. > > > > > > Simliar to commit a0cecc23cfcb Revert "drm/virtio:

Re: [PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-26 Thread Thomas Hellstrom
On 4/26/19 4:21 PM, Daniel Vetter wrote: On Fri, Apr 26, 2019 at 7:33 AM Gerd Hoffmann wrote: This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. Simliar to commit a0cecc23cfcb Revert "drm/virtio: drop prime import/export callbacks". We have to do the same with qxl, for the same rea

Re: [PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-26 Thread Daniel Vetter
On Fri, Apr 26, 2019 at 7:33 AM Gerd Hoffmann wrote: > > This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. > > Simliar to commit a0cecc23cfcb Revert "drm/virtio: drop prime > import/export callbacks". We have to do the same with qxl, > for the same reasons (it breaks DRI3). > > Drop t

[PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-25 Thread Gerd Hoffmann
This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. Simliar to commit a0cecc23cfcb Revert "drm/virtio: drop prime import/export callbacks". We have to do the same with qxl, for the same reasons (it breaks DRI3). Drop the WARN_ON_ONCE(). Fixes: f4c34b1e2a37d5676180901fa6ff188bcb6371f8