Re: [PATCH] armada: no need to check return value of debugfs_create functions

2019-06-13 Thread Greg Kroah-Hartman
On Thu, Jun 13, 2019 at 05:15:59PM +0100, Russell King - ARM Linux admin wrote: > On Thu, Jun 13, 2019 at 06:01:14PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Jun 13, 2019 at 03:36:00PM +0100, Russell King - ARM Linux admin > > wrote: > > > On Thu, Jun 13, 2019 at 03:28:50PM +0200, Greg Kroah-H

Re: [PATCH] armada: no need to check return value of debugfs_create functions

2019-06-13 Thread Russell King - ARM Linux admin
On Thu, Jun 13, 2019 at 06:01:14PM +0200, Greg Kroah-Hartman wrote: > On Thu, Jun 13, 2019 at 03:36:00PM +0100, Russell King - ARM Linux admin > wrote: > > On Thu, Jun 13, 2019 at 03:28:50PM +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is no need to ever check the >

Re: [PATCH] armada: no need to check return value of debugfs_create functions

2019-06-13 Thread Greg Kroah-Hartman
On Thu, Jun 13, 2019 at 03:36:00PM +0100, Russell King - ARM Linux admin wrote: > On Thu, Jun 13, 2019 at 03:28:50PM +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > >

Re: [PATCH] armada: no need to check return value of debugfs_create functions

2019-06-13 Thread Russell King - ARM Linux admin
On Thu, Jun 13, 2019 at 03:28:50PM +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Please don't merge this patch - I have a c

[PATCH] armada: no need to check return value of debugfs_create functions

2019-06-13 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Russell King Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Greg Kroah