Re: [PATCH] dma-buf/reservation: should keep later one in add fence(v3)

2018-03-06 Thread Christian König
And still a NAK, the prerequisite for adding a shared fence is that it is later than any existing fence in that context. In other words reservation_object_add_shared_fence() is always called with a new fence, never with some old one. So the whole checking here is completely superfluous,

RE: [PATCH] dma-buf/reservation: should keep later one in add fence(v3)

2018-03-05 Thread Zhou, David(ChunMing)
o: dri-de...@freedesktop.org Cc: Liu, Monk <monk@amd.com> Subject: [PATCH] dma-buf/reservation: should keep later one in add fence(v3) v2: still check context first to avoid warning from dma_fence_is_later apply this fix in add_shared_replace as well v3: use a bool falg to indict if f

[PATCH] dma-buf/reservation: should keep later one in add fence(v3)

2018-03-05 Thread Monk Liu
v2: still check context first to avoid warning from dma_fence_is_later apply this fix in add_shared_replace as well v3: use a bool falg to indict if fence is need to insert to new slot and ignore it if it is an eld fence compared with the one with the same context in old->shared Change-Id: