Re: [Linaro-mm-sig] [PATCH] dma-buf: add some lockdep asserts to the reservation object implementation

2018-01-11 Thread Lucas Stach
Am Donnerstag, den 11.01.2018, 11:54 +0100 schrieb Christian König: > Yeah, somehow missed that one. > > The patch looks mostly good, except for reservation_object_get_excl(). > > For that one an RCU protection is usually sufficient, so annotating it  > with reservation_object_assert_held()

Re: [Linaro-mm-sig] [PATCH] dma-buf: add some lockdep asserts to the reservation object implementation

2018-01-11 Thread Christian König
Yeah, somehow missed that one. The patch looks mostly good, except for reservation_object_get_excl(). For that one an RCU protection is usually sufficient, so annotating it with reservation_object_assert_held() sounds incorrect to me. Regards, Christian. Am 11.01.2018 um 11:43 schrieb Lucas

Re: [Linaro-mm-sig] [PATCH] dma-buf: add some lockdep asserts to the reservation object implementation

2018-01-11 Thread Lucas Stach
Did this fall through the cracks over the holidays? It really has made my work much easier while reworking some of the reservation object handling in etnaviv and I think it might benefit others. Regards, Lucas Am Freitag, den 01.12.2017, 12:12 +0100 schrieb Lucas Stach: > This adds lockdep

[PATCH] dma-buf: add some lockdep asserts to the reservation object implementation

2017-12-01 Thread Lucas Stach
This adds lockdep asserts to the reservation functions which state in their documentation that obj->lock must be held. Allows builds with PROVE_LOCKING enabled to check that the locking requirements are met. Signed-off-by: Lucas Stach --- drivers/dma-buf/reservation.c |