Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2023-01-05 Thread Daniel Vetter
On Tue, Dec 13, 2022 at 07:17:41PM +0100, Christian König wrote: > Am 13.12.22 um 18:09 schrieb Daniel Vetter: > > On Sat, Dec 10, 2022 at 08:43:47AM +0530, Sumit Semwal wrote: > > > Hi Christian, > > > > > > On Fri, 9 Dec 2022 at 12:45, Christian König > > > wrote: > > > > The init order and

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-13 Thread Christian König
Am 13.12.22 um 18:09 schrieb Daniel Vetter: On Sat, Dec 10, 2022 at 08:43:47AM +0530, Sumit Semwal wrote: Hi Christian, On Fri, 9 Dec 2022 at 12:45, Christian König wrote: The init order and resulting error handling in dma_buf_export was pretty messy. Subordinate objects like the file and

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-13 Thread Daniel Vetter
On Sat, Dec 10, 2022 at 08:43:47AM +0530, Sumit Semwal wrote: > Hi Christian, > > On Fri, 9 Dec 2022 at 12:45, Christian König > wrote: > > > > The init order and resulting error handling in dma_buf_export > > was pretty messy. > > > > Subordinate objects like the file and the sysfs kernel

Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-09 Thread Sumit Semwal
Hi Christian, On Fri, 9 Dec 2022 at 12:45, Christian König wrote: > > The init order and resulting error handling in dma_buf_export > was pretty messy. > > Subordinate objects like the file and the sysfs kernel objects > were initializing and wiring itself up with the object in the > wrong order

Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-09 Thread T.J. Mercier
umit.sem...@linaro.org > >Cc: linaro-mm-...@lists.linaro.org; dri-devel@lists.freedesktop.org; linux- > >me...@vger.kernel.org > >Subject: [PATCH] dma-buf: fix dma_buf_export init order v2 > > > >The init order and resulting error handling in dma_buf_export > >was pretty m

RE: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-09 Thread Ruhl, Michael J
gt;me...@vger.kernel.org >Subject: [PATCH] dma-buf: fix dma_buf_export init order v2 > >The init order and resulting error handling in dma_buf_export >was pretty messy. > >Subordinate objects like the file and the sysfs kernel objects >were initializing and wiring itself up

[PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-08 Thread Christian König
The init order and resulting error handling in dma_buf_export was pretty messy. Subordinate objects like the file and the sysfs kernel objects were initializing and wiring itself up with the object in the wrong order resulting not only in complicating and partially incorrect error handling, but

Re: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread kernel test robot
-christian.koenig%40amd.com patch subject: [PATCH] dma-buf: fix dma_buf_export init order config: hexagon-randconfig-r022-20221206 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 6e4cea55f0d1104408b26ac574566a0e4de48036) reproduce (this is a W=1 build): wget https

Re: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread kernel test robot
-christian.koenig%40amd.com patch subject: [PATCH] dma-buf: fix dma_buf_export init order config: s390-randconfig-r044-20221206 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 6e4cea55f0d1104408b26ac574566a0e4de48036) reproduce (this is a W=1 build): wget https

Re: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread T.J. Mercier
On Tue, Dec 6, 2022 at 7:12 AM Christian König wrote: > > The init order and resulting error handling in dma_buf_export > was pretty messy. > > Subordinate objects like the file and the sysfs kernel objects > were initializing and wiring itself up with the object in the > wrong order resulting

Re: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread Christian König
; dri-devel@lists.freedesktop.org; linux- me...@vger.kernel.org Subject: [PATCH] dma-buf: fix dma_buf_export init order The init order and resulting error handling in dma_buf_export was pretty messy. Subordinate objects like the file and the sysfs kernel objects were initializing and wiring itself

Re: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread Charan Teja Kalla
Thanks Christian for this nice cleanup!! On 12/6/2022 8:42 PM, Christian König wrote: > @@ -638,10 +630,21 @@ struct dma_buf *dma_buf_export(const struct > dma_buf_export_info *exp_info) > if (!try_module_get(exp_info->owner)) > return ERR_PTR(-ENOENT); > > + file =

RE: [PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread Ruhl, Michael J
reedesktop.org; linux- >me...@vger.kernel.org >Subject: [PATCH] dma-buf: fix dma_buf_export init order > >The init order and resulting error handling in dma_buf_export >was pretty messy. > >Subordinate objects like the file and the sysfs kernel objects >were initializing and w

[PATCH] dma-buf: fix dma_buf_export init order

2022-12-06 Thread Christian König
The init order and resulting error handling in dma_buf_export was pretty messy. Subordinate objects like the file and the sysfs kernel objects were initializing and wiring itself up with the object in the wrong order resulting not only in complicating and partially incorrect error handling, but