Re: Re: [PATCH] drivers/video/fbdev/core/fbmem.c: add pointer judgment

2021-05-20 Thread Arnd Bergmann
> > On Wed, May 19, 2021 at 08:00:28PM +0800, songqiang wrote: > > Signed-off-by: songqiang > From: "Matthew Wilcox " > > You need to explain: > > > > - Why you think this patch is needed > > - Did you observe a problem at runtime? > > - Is this the output from some checking tool? > > - Why this

Re:Re:Re: [PATCH] drivers/video/fbdev/core/fbmem.c: add pointer judgment

2021-05-20 Thread 宋强
I find null pointer bug when I debug the kernel of loongson in mips,I think the function fb_set_suspend() adding pointer judgment will more friendly.[  101.409101] PM: hibernation entry               [  101.526365] PM: Syncing filesystems ... [  101.543008] PM: done.[  101.545287] Freezing user

Re:Re: [PATCH] drivers/video/fbdev/core/fbmem.c: add pointer judgment

2021-05-20 Thread 宋强
I find null pointer bug when I debug the kernel of loongson,I think the function fb_set_suspend() add pointer judgment will more friendly.[  101.409101] PM: hibernation entry               [  101.526365] PM: Syncing filesystems ... [  101.543008] PM: done.[  101.545287] Freezing user space

[PATCH] drivers/video/fbdev/core/fbmem.c: add pointer judgment

2021-05-19 Thread songqiang
Signed-off-by: songqiang --- drivers/video/fbdev/core/fbmem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 072780b0e570..6036ab849475 100644 --- a/drivers/video/fbdev/core/fbmem.c +++

Re: [PATCH] drivers/video/fbdev/core/fbmem.c: add pointer judgment

2021-05-19 Thread Matthew Wilcox
On Wed, May 19, 2021 at 08:00:28PM +0800, songqiang wrote: > Signed-off-by: songqiang > --- You need to explain: - Why you think this patch is needed - Did you observe a problem at runtime? - Is this the output from some checking tool? - Why this is the right way to address the problem