Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-20 Thread Chen Li
On Fri, 18 Dec 2020 16:10:12 +0800, Christian König wrote: > > Am 18.12.20 um 04:51 schrieb Chen Li: > > [SNIP] > If your ARM base board can't do that for some then you can't use the > hardware > with that board. > >>> Good to know, thanks! BTW, have you ever seen or heard boards

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-18 Thread Robin Murphy
On 2020-12-18 14:33, Christian König wrote: Am 18.12.20 um 15:17 schrieb Robin Murphy: On 2020-12-17 14:02, Christian König wrote: [SNIP] Do you have some background why some ARM boards fail with that? We had a couple of reports that memset/memcpy fail in userspace (usually system just

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-18 Thread Robin Murphy
On 2020-12-18 06:14, Chen Li wrote: [...] No, not performance. See standards like OpenGL, Vulkan as well as VA-API and VDPAU require that you can mmap() device memory and execute memset/memcpy on the memory from userspace. If your ARM base board can't do that for some then you can't use the

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-18 Thread Christian König
Am 18.12.20 um 15:17 schrieb Robin Murphy: On 2020-12-17 14:02, Christian König wrote: [SNIP] Do you have some background why some ARM boards fail with that? We had a couple of reports that memset/memcpy fail in userspace (usually system just spontaneously reboots or becomes unresponsive),

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-18 Thread Robin Murphy
On 2020-12-17 14:02, Christian König wrote: Am 17.12.20 um 14:45 schrieb Robin Murphy: On 2020-12-17 10:25, Christian König wrote: Am 17.12.20 um 02:07 schrieb Chen Li: On Wed, 16 Dec 2020 22:19:11 +0800, Christian König wrote: Am 16.12.20 um 14:48 schrieb Chen Li: On Wed, 16 Dec 2020

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-18 Thread Christian König
Am 18.12.20 um 09:52 schrieb Chen Li: On Fri, 18 Dec 2020 16:10:12 +0800, Christian König wrote: Am 18.12.20 um 04:51 schrieb Chen Li: [SNIP] If your ARM base board can't do that for some then you can't use the hardware with that board. Good to know, thanks! BTW, have you ever seen or heard

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-18 Thread Chen Li
On Thu, 17 Dec 2020 22:16:59 +0800, Christian König wrote: > > Am 17.12.20 um 14:37 schrieb Chen Li: > > On Thu, 17 Dec 2020 18:25:11 +0800, > > Christian König wrote: > >> Am 17.12.20 um 02:07 schrieb Chen Li: > >>> On Wed, 16 Dec 2020 22:19:11 +0800, > >>> Christian König wrote: > Am

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-18 Thread Chen Li
On Thu, 17 Dec 2020 21:45:06 +0800, Robin Murphy wrote: > > On 2020-12-17 10:25, Christian König wrote: > > Am 17.12.20 um 02:07 schrieb Chen Li: > >> On Wed, 16 Dec 2020 22:19:11 +0800, > >> Christian König wrote: > >>> Am 16.12.20 um 14:48 schrieb Chen Li: > On Wed, 16 Dec 2020 15:59:37

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-18 Thread Chen Li
On Thu, 17 Dec 2020 18:25:11 +0800, Christian König wrote: > > Am 17.12.20 um 02:07 schrieb Chen Li: > > On Wed, 16 Dec 2020 22:19:11 +0800, > > Christian König wrote: > >> Am 16.12.20 um 14:48 schrieb Chen Li: > >>> On Wed, 16 Dec 2020 15:59:37 +0800, > >>> Christian König wrote: > [SNIP] >

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-18 Thread Christian König
Am 18.12.20 um 04:51 schrieb Chen Li: [SNIP] If your ARM base board can't do that for some then you can't use the hardware with that board. Good to know, thanks! BTW, have you ever seen or heard boards like mine which cannot mmap device memory correctly from userspace correctly?

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-17 Thread Lucas Stach
Am Donnerstag, den 17.12.2020, 15:02 +0100 schrieb Christian König: > Am 17.12.20 um 14:45 schrieb Robin Murphy: > > On 2020-12-17 10:25, Christian König wrote: > > > Am 17.12.20 um 02:07 schrieb Chen Li: > > > > On Wed, 16 Dec 2020 22:19:11 +0800, > > > > Christian König wrote: > > > > > Am

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-17 Thread Christian König
Am 17.12.20 um 14:37 schrieb Chen Li: On Thu, 17 Dec 2020 18:25:11 +0800, Christian König wrote: Am 17.12.20 um 02:07 schrieb Chen Li: On Wed, 16 Dec 2020 22:19:11 +0800, Christian König wrote: Am 16.12.20 um 14:48 schrieb Chen Li: On Wed, 16 Dec 2020 15:59:37 +0800, Christian König wrote:

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-17 Thread Christian König
Am 17.12.20 um 14:45 schrieb Robin Murphy: On 2020-12-17 10:25, Christian König wrote: Am 17.12.20 um 02:07 schrieb Chen Li: On Wed, 16 Dec 2020 22:19:11 +0800, Christian König wrote: Am 16.12.20 um 14:48 schrieb Chen Li: On Wed, 16 Dec 2020 15:59:37 +0800, Christian König wrote: [SNIP] Hi,

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-17 Thread Robin Murphy
On 2020-12-17 10:25, Christian König wrote: Am 17.12.20 um 02:07 schrieb Chen Li: On Wed, 16 Dec 2020 22:19:11 +0800, Christian König wrote: Am 16.12.20 um 14:48 schrieb Chen Li: On Wed, 16 Dec 2020 15:59:37 +0800, Christian König wrote: [SNIP] Hi, Christian. I'm not sure why this change is

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-17 Thread Christian König
Am 17.12.20 um 02:07 schrieb Chen Li: On Wed, 16 Dec 2020 22:19:11 +0800, Christian König wrote: Am 16.12.20 um 14:48 schrieb Chen Li: On Wed, 16 Dec 2020 15:59:37 +0800, Christian König wrote: [SNIP] Hi, Christian. I'm not sure why this change is a hack here. I cannot see the problem and

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-17 Thread Chen Li
On Wed, 16 Dec 2020 15:59:37 +0800, Christian König wrote: > > Am 16.12.20 um 06:41 schrieb Chen Li: > > When using e8860(gcn1) on arm64, the kernel crashed on drm/radeon: > > > > [ 11.240414] pc : __memset+0x4c/0x188 > > [ 11.244101] lr : radeon_uvd_get_create_msg+0x114/0x1d0 [radeon] > > [

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-17 Thread Chen Li
On Wed, 16 Dec 2020 22:19:11 +0800, Christian König wrote: > > Am 16.12.20 um 14:48 schrieb Chen Li: > > On Wed, 16 Dec 2020 15:59:37 +0800, > > Christian König wrote: > >> Am 16.12.20 um 06:41 schrieb Chen Li: > >>> When using e8860(gcn1) on arm64, the kernel crashed on drm/radeon: > >>> [SNIP]

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-16 Thread Christian König
Am 16.12.20 um 14:48 schrieb Chen Li: On Wed, 16 Dec 2020 15:59:37 +0800, Christian König wrote: Am 16.12.20 um 06:41 schrieb Chen Li: When using e8860(gcn1) on arm64, the kernel crashed on drm/radeon: [SNIP] Obviously, the __memset call is generated by gcc(8.3.1). It optimizes this for loop

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-16 Thread kernel test robot
Hi Chen, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10 next-20201215] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

[kbuild] Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-16 Thread Dan Carpenter
Hi Chen, url: https://github.com/0day-ci/linux/commits/Chen-Li/drm-amdgpu-radeon-fix-memset-on-io-mem/20201216-165835 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d01e7f10dae29eba0f9ada82b65d24e035d5b2f9 config: x86_64-randconfig-m001-20201216 (attached as

[PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-16 Thread Chen Li
When using e8860(gcn1) on arm64, the kernel crashed on drm/radeon: [ 11.240414] pc : __memset+0x4c/0x188 [ 11.244101] lr : radeon_uvd_get_create_msg+0x114/0x1d0 [radeon] [ 11.249995] sp : 0d7eb700 [ 11.253295] x29: 0d7eb700 x28: 8001f632a868 [ 11.258585] x27:

Re: [PATCH] drm/[amdgpu|radeon]: fix memset on io mem

2020-12-15 Thread Christian König
Am 16.12.20 um 06:41 schrieb Chen Li: When using e8860(gcn1) on arm64, the kernel crashed on drm/radeon: [ 11.240414] pc : __memset+0x4c/0x188 [ 11.244101] lr : radeon_uvd_get_create_msg+0x114/0x1d0 [radeon] [ 11.249995] sp : 0d7eb700 [ 11.253295] x29: 0d7eb700 x28: