Re: [PATCH] drm/amd/pm: fix error handling

2022-02-07 Thread Alex Deucher
esktop.org; dri-devel@lists.freedesktop.org; linux- > > ker...@vger.kernel.org; l...@lists.linux.dev; Tom Rix > > Subject: [PATCH] drm/amd/pm: fix error handling > > > > From: Tom Rix > > > > clang static analysis reports this error > > amdgpu_smu.c:2

RE: [PATCH] drm/amd/pm: fix error handling

2022-02-06 Thread Quan, Evan
rnel.org; > ndesaulni...@google.com; Lazar, Lijo ; Powell, Darren > ; Chen, Guchun ; > Grodzovsky, Andrey > Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > ker...@vger.kernel.org; l...@lists.linux.dev; Tom Rix > Subject: [PATCH] drm/amd/pm: fix error

[PATCH] drm/amd/pm: fix error handling

2022-02-05 Thread trix
From: Tom Rix clang static analysis reports this error amdgpu_smu.c:2289:9: warning: Called function pointer is null (null dereference) return smu->ppt_funcs->emit_clk_levels( ^~~~ There is a logic error in the earlier check of