Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

2018-06-22 Thread Andrey Grodzovsky
On 06/22/2018 09:03 PM, Andrey Grodzovsky wrote: On 06/22/2018 02:56 PM, Lyude Paul wrote: On Fri, 2018-06-22 at 13:34 -0400, Andrey Grodzovsky wrote: On 06/21/2018 04:48 PM, Lyude Paul wrote: This fixes a regression I accidentally reduced that was picked up by kasan, where we were

Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

2018-06-22 Thread Andrey Grodzovsky
On 06/22/2018 02:56 PM, Lyude Paul wrote: On Fri, 2018-06-22 at 13:34 -0400, Andrey Grodzovsky wrote: On 06/21/2018 04:48 PM, Lyude Paul wrote: This fixes a regression I accidentally reduced that was picked up by kasan, where we were checking the CRTC atomic states after DRM's helpers had

Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

2018-06-22 Thread Lyude Paul
On Fri, 2018-06-22 at 13:34 -0400, Andrey Grodzovsky wrote: > > On 06/21/2018 04:48 PM, Lyude Paul wrote: > > This fixes a regression I accidentally reduced that was picked up by > > kasan, where we were checking the CRTC atomic states after DRM's helpers > > had already freed them. Example: > >

Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

2018-06-22 Thread Harry Wentland
On 2018-06-21 04:48 PM, Lyude Paul wrote: > This fixes a regression I accidentally reduced that was picked up by > kasan, where we were checking the CRTC atomic states after DRM's helpers > had already freed them. Example: > > == >

Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

2018-06-22 Thread Andrey Grodzovsky
On 06/21/2018 04:48 PM, Lyude Paul wrote: This fixes a regression I accidentally reduced that was picked up by kasan, where we were checking the CRTC atomic states after DRM's helpers had already freed them. Example: == BUG:

Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

2018-06-22 Thread Michel Dänzer
On 2018-06-21 10:48 PM, Lyude Paul wrote: > This fixes a regression I accidentally reduced that was picked up by > kasan, where we were checking the CRTC atomic states after DRM's helpers > had already freed them. Example: > > [...] > > So, we fix this by counting the number of CRTCs this atomic

[PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

2018-06-21 Thread Lyude Paul
This fixes a regression I accidentally reduced that was picked up by kasan, where we were checking the CRTC atomic states after DRM's helpers had already freed them. Example: == BUG: KASAN: use-after-free in