Re: [PATCH] drm/amdkfd: rework criu_restore_bos error handling

2022-02-20 Thread Christian König
Am 18.02.22 um 19:35 schrieb Felix Kuehling: Am 2022-02-18 um 12:39 schrieb t...@redhat.com: From: Tom Rix Clang static analysis reports this problem kfd_chardev.c:2327:2: warning: 1st function call argument    is an uninitialized value    kvfree(bo_privs);    ^~~~ If the

Re: [PATCH] drm/amdkfd: rework criu_restore_bos error handling

2022-02-18 Thread Felix Kuehling
Am 2022-02-18 um 21:34 schrieb Tom Rix: On 2/18/22 10:35 AM, Felix Kuehling wrote: Am 2022-02-18 um 12:39 schrieb t...@redhat.com: From: Tom Rix Clang static analysis reports this problem kfd_chardev.c:2327:2: warning: 1st function call argument    is an uninitialized value   

Re: [PATCH] drm/amdkfd: rework criu_restore_bos error handling

2022-02-18 Thread Tom Rix
On 2/18/22 10:35 AM, Felix Kuehling wrote: Am 2022-02-18 um 12:39 schrieb t...@redhat.com: From: Tom Rix Clang static analysis reports this problem kfd_chardev.c:2327:2: warning: 1st function call argument    is an uninitialized value    kvfree(bo_privs);    ^~~~ If the

Re: [PATCH] drm/amdkfd: rework criu_restore_bos error handling

2022-02-18 Thread Felix Kuehling
Am 2022-02-18 um 12:39 schrieb t...@redhat.com: From: Tom Rix Clang static analysis reports this problem kfd_chardev.c:2327:2: warning: 1st function call argument is an uninitialized value kvfree(bo_privs); ^~~~ If the copy_from_users(bo_buckets, ...) fails, there is a

[PATCH] drm/amdkfd: rework criu_restore_bos error handling

2022-02-18 Thread trix
From: Tom Rix Clang static analysis reports this problem kfd_chardev.c:2327:2: warning: 1st function call argument is an uninitialized value kvfree(bo_privs); ^~~~ If the copy_from_users(bo_buckets, ...) fails, there is a jump to the generic error handler at exit:. The