[PATCH] drm/ast: Remove useless drm_fb_get_bpp_depth() call

2016-06-08 Thread Laurent Pinchart
Hi Eric, On Tuesday 07 Jun 2016 17:49:20 Eric Engestrom wrote: > On Mon, Jun 06, 2016 at 09:14:12PM +0300, Laurent Pinchart wrote: > > The function has no side effect and its returned values are ignored, > > don't call it. > > > > Signed-off-by: Laurent Pinchart > > Good catch! Do you have a

[PATCH] drm/ast: Remove useless drm_fb_get_bpp_depth() call

2016-06-07 Thread Eric Engestrom
On Mon, Jun 06, 2016 at 09:14:12PM +0300, Laurent Pinchart wrote: > The function has no side effect and its returned values are ignored, > don't call it. > > Signed-off-by: Laurent Pinchart Good catch! Do you have a tool that detects this, or do you just have a really good eye? Reviewed-by:

[PATCH] drm/ast: Remove useless drm_fb_get_bpp_depth() call

2016-06-06 Thread Laurent Pinchart
The function has no side effect and its returned values are ignored, don't call it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/ast/ast_fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c index 5320f8c57884..c017a9330a18